From: Zhang Shurong <zhang_shurong@foxmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: oder_chiou@realtek.com, lgirdwood@gmail.com, perex@perex.cz,
tiwai@suse.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: rt5665: add missed regulator_bulk_disable
Date: Tue, 01 Aug 2023 23:46:36 +0800 [thread overview]
Message-ID: <tencent_5E8D53EDF5D61E189A478942372A8C44CA06@qq.com> (raw)
In-Reply-To: <ZL1DUWAeBbArQL1f@finisterre.sirena.org.uk>
在 2023年7月23日星期日 CST 下午11:12:17，Mark Brown 写道：
> On Sun, Jul 23, 2023 at 03:07:31PM +0800, Zhang Shurong wrote:
> > + ret = devm_add_action_or_reset(&i2c->dev,
rt5665_i2c_disable_regulators,
> > + rt5665);
> > + if (ret)
> > + return ret;
> > +
> >
> > ret = regulator_bulk_enable(ARRAY_SIZE(rt5665->supplies),
> >
> > rt5665->supplies);
> >
> > if (ret != 0) {
>
> This will attempt to disable the regulators if the initial enable fails
> which is a bug.
You are right. I will move this to rt5663_i2c_remove() in next version.
prev parent reply other threads:[~2023-08-01 15:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-23 7:07 [PATCH] ASoC: rt5665: add missed regulator_bulk_disable Zhang Shurong
2023-07-23 15:12 ` Mark Brown
2023-08-01 15:46 ` Zhang Shurong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_5E8D53EDF5D61E189A478942372A8C44CA06@qq.com \
--to=zhang_shurong@foxmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oder_chiou@realtek.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).