From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>
Subject: Re: [PATCH 1/8] ASoC: fsi: modify format area definition on flags
Date: Tue, 13 Jul 2010 10:22:35 +0900 (JST) [thread overview]
Message-ID: <w3pbpackwf9.wl%kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <20100712085419.GB21840@rakim.wolfsonmicro.main>
Dear Mark
Thank you for your checking patch.
At first, I will re-send v2 patches as "bug fix" and "add XXX".
> > +#define SH_FSI_FMT_MONO_DELAY (2 << 0)
> > +#define SH_FSI_FMT_PCM (3 << 0)
> > +#define SH_FSI_FMT_I2S (4 << 0)
> > +#define SH_FSI_FMT_TDM (5 << 0)
> > +#define SH_FSI_FMT_TDM_DELAY (6 << 0)
>
> Wouldn't it be clearer to just define these as straight numbers?
Sorry. Do you mean (1 << 0) is needed ?
(1 << 0) is not changed from old one
--------------------------------
#define SH_FSI_FMT_MONO (1 << 0) <===
-#define SH_FSI_FMT_MONO_DELAY (1 << 1)
-#define SH_FSI_FMT_PCM (1 << 2)
-#define SH_FSI_FMT_I2S (1 << 3)
-#define SH_FSI_FMT_TDM (1 << 4)
-#define SH_FSI_FMT_TDM_DELAY (1 << 5)
+#define SH_FSI_FMT_MONO_DELAY (2 << 0)
+#define SH_FSI_FMT_PCM (3 << 0)
+#define SH_FSI_FMT_I2S (4 << 0)
+#define SH_FSI_FMT_TDM (5 << 0)
+#define SH_FSI_FMT_TDM_DELAY (6 << 0)
--------------------------------
Best regards
--
Kuninori Morimoto
next prev parent reply other threads:[~2010-07-13 1:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-12 5:54 [PATCH 0/8] ASoC: fsi: fixup patches Kuninori Morimoto
2010-07-12 5:55 ` [PATCH 1/8] ASoC: fsi: modify format area definition on flags Kuninori Morimoto
2010-07-12 8:54 ` Mark Brown
2010-07-13 1:22 ` Kuninori Morimoto [this message]
2010-07-13 8:55 ` Mark Brown
2010-07-13 9:08 ` Kuninori Morimoto
2010-07-12 5:56 ` [PATCH 2/8] ASoC: fsi: fixup clock inversion operation Kuninori Morimoto, Kuninori Morimoto
2010-07-12 5:56 ` [PATCH 3/8] ASoC: fsi: remove un-used variable on fsi_dai_startup Kuninori Morimoto, Kuninori Morimoto
2010-07-12 5:56 ` [PATCH 4/8] ASoC: fsi: remove noisy CR_FMT macro Kuninori Morimoto, Kuninori Morimoto
2010-07-12 5:56 ` [PATCH 5/8] ASoC: fsi: modify wrong value setting order of TDM Kuninori Morimoto, Kuninori Morimoto
2010-07-12 9:00 ` Mark Brown
2010-07-12 5:56 ` [PATCH 6/8] ASoC: fsi: Change struct fsi_regs to fsi_core Kuninori Morimoto, Kuninori Morimoto
2010-07-12 5:56 ` [PATCH 7/8] ASoC: fsi: Add pr_err for noticing unsupported access Kuninori Morimoto, Kuninori Morimoto
2010-07-12 5:56 ` [PATCH 8/8] ASoC: fsi: Fixup for master mode Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=w3pbpackwf9.wl%kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).