alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Keith Chew <keith.chew@gmail.com>
To: alsa-devel@alsa-project.org
Subject: Re: PCM multi A/V Sync bug on SMP system
Date: Thu, 29 Apr 2010 08:12:33 +1200	[thread overview]
Message-ID: <y2l20f65d531004281312ja49b333eha47fd0cb9c5b0e01@mail.gmail.com> (raw)
In-Reply-To: <m2z20f65d531004271228gc2ab0716na68845e9b262a839@mail.gmail.com>

> I would like to help out in fixing this, but need a little bit of
> guidance from the experts here. Have I identified the problem
> correctly? Ie interaction between "multi" and "dmix" on a 5.1 channel
> card giving timing issues on an SMP system? If it is unlikely, I will
> investigate other areas.

Ok, I don't seem to be getting much help from this mailing list, so I
have dug deeper into the code, and found the problem. In
pcm_dmix_i386.c, we have:

				if (!strncmp(line, "processor", 9))
					smp++;

I have commented out the smp++, so that it thinks that I am on a uni
processor. Voila, so AV sync issues!

My question now is what are the implications of this change? Looking
at pcm_dmix_i386.h, it uses locks on an SMP system, but exclude them
if not SMP. Do we still need this lock, even if I am on a dual core,
ie 1 processor 2 cores?

I have CC'ed the author of the file, Jaroslav Kysela.

Regards
Keith

  reply	other threads:[~2010-04-28 20:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-25  5:07 PCM multi A/V Sync bug on SMP system Keith Chew
2010-04-27 19:28 ` Keith Chew
2010-04-28 20:12   ` Keith Chew [this message]
2010-04-30 11:09     ` Clemens Ladisch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=y2l20f65d531004281312ja49b333eha47fd0cb9c5b0e01@mail.gmail.com \
    --to=keith.chew@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).