AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "André Almeida" <andrealmeid@igalia.com>
To: Christopher Snowhill <chris@kode54.net>
Cc: kernel-dev@igalia.com, "Simon Ser" <contact@emersion.fr>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	joshua@froggi.es, ville.syrjala@linux.intel.com,
	"Daniel Stone" <daniel@fooishbar.org>,
	"Xaver Hugl" <xaver.hugl@gmail.com>,
	"Harry Wentland" <harry.wentland@amd.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	amd-gfx@lists.freedesktop.org, "Leo Li" <sunpeng.li@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"David Airlie" <airlied@gmail.com>,
	"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
	"Xinhui Pan" <Xinhui.Pan@amd.com>,
	dmitry.baryshkov@linaro.org
Subject: Re: [PATCH RESEND v9 1/2] drm/atomic: Let drivers decide which planes to async flip
Date: Mon, 4 Nov 2024 17:52:43 -0300	[thread overview]
Message-ID: <00a99b3e-3fad-42fb-8dc8-4f45d158c4c1@igalia.com> (raw)
In-Reply-To: <D5CC3U00B7CG.IGKCIES8PC2J@kode54.net>

Hi Christopher,

Em 03/11/2024 03:36, Christopher Snowhill escreveu:
> On Fri Nov 1, 2024 at 11:23 AM PDT, André Almeida wrote:
>> Currently, DRM atomic uAPI allows only primary planes to be flipped
>> asynchronously. However, each driver might be able to perform async
>> flips in other different plane types. To enable drivers to set their own
>> restrictions on which type of plane they can or cannot flip, use the
>> existing atomic_async_check() from struct drm_plane_helper_funcs to
>> enhance this flexibility, thus allowing different plane types to be able
>> to do async flips as well.
>>
>> In order to prevent regressions and such, we keep the current policy: we
>> skip the driver check for the primary plane, because it is always
>> allowed to do async flips on it.
>>
>> Signed-off-by: André Almeida <andrealmeid@igalia.com>
> 
> Should I do a R-b too? 

If you can review the code, it's always really appreciated.

> The changes looked sound enough for me to feel
> like testing it as well. Tested Borderlands Game of the Year Enhanced on
> my RX 7700 XT at maximum settings at 1080p165, and the tearing support in
> labwc allowed it to reach over 700fps. No problems from the hardware
> cursor.

Thanks for testing and reporting!

> 
> Tested-by: Christopher Snowhill <chris@kode54.net>
> 

  reply	other threads:[~2024-11-04 20:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-01 18:23 [PATCH RESEND v9 0/2] drm/atomic: Ease async flip restrictions André Almeida
2024-11-01 18:23 ` [PATCH RESEND v9 1/2] drm/atomic: Let drivers decide which planes to async flip André Almeida
2024-11-03  4:10   ` Dmitry Baryshkov
2024-11-03  6:36   ` Christopher Snowhill
2024-11-04 20:52     ` André Almeida [this message]
2024-11-05 10:15       ` Christopher Snowhill
2024-11-05 10:51         ` Dmitry Baryshkov
2024-11-06  5:04           ` Christopher Snowhill
2024-11-01 18:23 ` [PATCH RESEND v9 2/2] drm/amdgpu: Enable async flip on overlay planes André Almeida
2024-11-11 21:10   ` Harry Wentland
2024-11-12 16:44     ` André Almeida

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=00a99b3e-3fad-42fb-8dc8-4f45d158c4c1@igalia.com \
    --to=andrealmeid@igalia.com \
    --cc=Rodrigo.Siqueira@amd.com \
    --cc=Xinhui.Pan@amd.com \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=chris@kode54.net \
    --cc=christian.koenig@amd.com \
    --cc=contact@emersion.fr \
    --cc=daniel@fooishbar.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=harry.wentland@amd.com \
    --cc=joshua@froggi.es \
    --cc=kernel-dev@igalia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=sunpeng.li@amd.com \
    --cc=tzimmermann@suse.de \
    --cc=ville.syrjala@linux.intel.com \
    --cc=xaver.hugl@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox