From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 8/8] drm/amdkfd: Use kfd fd to mmap mmio Date: Fri, 24 May 2019 10:47:39 +0200 Message-ID: <0119ba18-c025-f331-d26e-2d12923f5e53@gmail.com> References: <1558651263-3478-1-git-send-email-Oak.Zeng@amd.com> <1558651263-3478-8-git-send-email-Oak.Zeng@amd.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1558651263-3478-8-git-send-email-Oak.Zeng-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Zeng, Oak" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" Cc: "Kuehling, Felix" , "Keely, Sean" , "Koenig, Christian" QW0gMjQuMDUuMTkgdW0gMDA6NDEgc2NocmllYiBaZW5nLCBPYWs6Cj4gVFRNIGRvZXNuJ3Qgc3Vw cG9ydCBDUFUgbWFwcGluZyBvZiBzZyB0eXBlIGJvICh1bmRlciB3aGljaAo+IG1taW8gYm8gaXMg Y3JlYXRlZCkuIFN3aXRjaCBtbWFwaW5nIG9mIG1taW8gcGFnZSB0byBrZmQKPiBkZXZpY2UgZmls ZS4KPgo+IENoYW5nZS1JZDogSTFhMWEyNGYyYWMwNjYyYmUzNzgzZDQ2MGMxMzc3MzFhZGUwMDdi ODMKPiBTaWduZWQtb2ZmLWJ5OiBPYWsgWmVuZyA8T2FrLlplbmdAYW1kLmNvbT4KCkFja2VkLWJ5 OiBDaHJpc3RpYW4gS8O2bmlnIDxjaHJpc3RpYW4ua29lbmlnQGFtZC5jb20+Cgo+IC0tLQo+ICAg ZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRrZmQva2ZkX2NoYXJkZXYuYyB8IDQ2ICsrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrCj4gICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGtmZC9rZmRf cHJpdi5oICAgIHwgIDEgKwo+ICAgMiBmaWxlcyBjaGFuZ2VkLCA0NyBpbnNlcnRpb25zKCspCj4K PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRrZmQva2ZkX2NoYXJkZXYuYyBi L2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1ka2ZkL2tmZF9jaGFyZGV2LmMKPiBpbmRleCA0NTVhM2Ri Li42N2QyNjliIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1ka2ZkL2tmZF9j aGFyZGV2LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGtmZC9rZmRfY2hhcmRldi5j Cj4gQEAgLTEzMDksNiArMTMwOSwxNSBAQCBzdGF0aWMgaW50IGtmZF9pb2N0bF9hbGxvY19tZW1v cnlfb2ZfZ3B1KHN0cnVjdCBmaWxlICpmaWxlcCwKPiAgIAlhcmdzLT5oYW5kbGUgPSBNQUtFX0hB TkRMRShhcmdzLT5ncHVfaWQsIGlkcl9oYW5kbGUpOwo+ICAgCWFyZ3MtPm1tYXBfb2Zmc2V0ID0g b2Zmc2V0Owo+ICAgCj4gKwkvKiBNTUlPIGlzIG1hcHBlZCB0aHJvdWdoIGtmZCBkZXZpY2UKPiAr CSAqIEdlbmVyYXRlIGEga2ZkIG1tYXAgb2Zmc2V0Cj4gKwkgKi8KPiArCWlmIChmbGFncyAmIEtG RF9JT0NfQUxMT0NfTUVNX0ZMQUdTX01NSU9fUkVNQVApIHsKPiArCQlhcmdzLT5tbWFwX29mZnNl dCA9IEtGRF9NTUFQX1RZUEVfTU1JTyB8IEtGRF9NTUFQX0dQVV9JRChhcmdzLT5ncHVfaWQpOwo+ ICsJCWFyZ3MtPm1tYXBfb2Zmc2V0IDw8PSBQQUdFX1NISUZUOwo+ICsJCWFyZ3MtPm1tYXBfb2Zm c2V0IHw9IGFtZGdwdV9hbWRrZmRfZ2V0X21taW9fcmVtYXBfcGh5c19hZGRyKGRldi0+a2dkKTsK PiArCX0KPiArCj4gICAJcmV0dXJuIDA7Cj4gICAKPiAgIGVycl9mcmVlOgo+IEBAIC0xODgwLDYg KzE4ODksMzkgQEAgc3RhdGljIGxvbmcga2ZkX2lvY3RsKHN0cnVjdCBmaWxlICpmaWxlcCwgdW5z aWduZWQgaW50IGNtZCwgdW5zaWduZWQgbG9uZyBhcmcpCj4gICAJcmV0dXJuIHJldGNvZGU7Cj4g ICB9Cj4gICAKPiArc3RhdGljIGludCBrZmRfbW1pb19tbWFwKHN0cnVjdCBrZmRfZGV2ICpkZXYs IHN0cnVjdCBrZmRfcHJvY2VzcyAqcHJvY2VzcywKPiArCQkgICAgICBzdHJ1Y3Qgdm1fYXJlYV9z dHJ1Y3QgKnZtYSkKPiArewo+ICsJcGh5c19hZGRyX3QgYWRkcmVzczsKPiArCWludCByZXQ7Cj4g Kwo+ICsJaWYgKHZtYS0+dm1fZW5kIC0gdm1hLT52bV9zdGFydCAhPSBQQUdFX1NJWkUpCj4gKwkJ cmV0dXJuIC1FSU5WQUw7Cj4gKwo+ICsJYWRkcmVzcyA9IGFtZGdwdV9hbWRrZmRfZ2V0X21taW9f cmVtYXBfcGh5c19hZGRyKGRldi0+a2dkKTsKPiArCj4gKwl2bWEtPnZtX2ZsYWdzIHw9IFZNX0lP IHwgVk1fRE9OVENPUFkgfCBWTV9ET05URVhQQU5EIHwgVk1fTk9SRVNFUlZFIHwKPiArCQkJCVZN X0RPTlREVU1QIHwgVk1fUEZOTUFQOwo+ICsKPiArCXZtYS0+dm1fcGFnZV9wcm90ID0gcGdwcm90 X25vbmNhY2hlZCh2bWEtPnZtX3BhZ2VfcHJvdCk7Cj4gKwo+ICsJcHJfZGVidWcoIlByb2Nlc3Mg JWQgbWFwcGluZyBtbWlvIHBhZ2VcbiIKPiArCQkgIiAgICAgdGFyZ2V0IHVzZXIgYWRkcmVzcyA9 PSAweCUwOGxsWFxuIgo+ICsJCSAiICAgICBwaHlzaWNhbCBhZGRyZXNzICAgID09IDB4JTA4bGxY XG4iCj4gKwkJICIgICAgIHZtX2ZsYWdzICAgICAgICAgICAgPT0gMHglMDRsWFxuIgo+ICsJCSAi ICAgICBzaXplICAgICAgICAgICAgICAgID09IDB4JTA0bFhcbiIsCj4gKwkJIHByb2Nlc3MtPnBh c2lkLCAodW5zaWduZWQgbG9uZyBsb25nKSB2bWEtPnZtX3N0YXJ0LAo+ICsJCSBhZGRyZXNzLCB2 bWEtPnZtX2ZsYWdzLCBQQUdFX1NJWkUpOwo+ICsKPiArCXJldCA9IGlvX3JlbWFwX3Bmbl9yYW5n ZSh2bWEsCj4gKwkJCQl2bWEtPnZtX3N0YXJ0LAo+ICsJCQkJYWRkcmVzcyA+PiBQQUdFX1NISUZU LAo+ICsJCQkJUEFHRV9TSVpFLAo+ICsJCQkJdm1hLT52bV9wYWdlX3Byb3QpOwo+ICsJcmV0dXJu IHJldDsKPiArfQo+ICsKPiArCj4gICBzdGF0aWMgaW50IGtmZF9tbWFwKHN0cnVjdCBmaWxlICpm aWxwLCBzdHJ1Y3Qgdm1fYXJlYV9zdHJ1Y3QgKnZtYSkKPiAgIHsKPiAgIAlzdHJ1Y3Qga2ZkX3By b2Nlc3MgKnByb2Nlc3M7Cj4gQEAgLTE5MTAsNiArMTk1MiwxMCBAQCBzdGF0aWMgaW50IGtmZF9t bWFwKHN0cnVjdCBmaWxlICpmaWxwLCBzdHJ1Y3Qgdm1fYXJlYV9zdHJ1Y3QgKnZtYSkKPiAgIAkJ aWYgKCFkZXYpCj4gICAJCQlyZXR1cm4gLUVOT0RFVjsKPiAgIAkJcmV0dXJuIGtmZF9yZXNlcnZl ZF9tZW1fbW1hcChkZXYsIHByb2Nlc3MsIHZtYSk7Cj4gKwljYXNlIEtGRF9NTUFQX1RZUEVfTU1J TzoKPiArCQlpZiAoIWRldikKPiArCQkJcmV0dXJuIC1FTk9ERVY7Cj4gKwkJcmV0dXJuIGtmZF9t bWlvX21tYXAoZGV2LCBwcm9jZXNzLCB2bWEpOwo+ICAgCX0KPiAgIAo+ICAgCXJldHVybiAtRUZB VUxUOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGtmZC9rZmRfcHJpdi5o IGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRrZmQva2ZkX3ByaXYuaAo+IGluZGV4IDQwYTVjNjcu LmI2MWRjNTMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRrZmQva2ZkX3By aXYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1ka2ZkL2tmZF9wcml2LmgKPiBAQCAt NTksNiArNTksNyBAQAo+ICAgI2RlZmluZSBLRkRfTU1BUF9UWVBFX0RPT1JCRUxMCSgweDNVTEwg PDwgS0ZEX01NQVBfVFlQRV9TSElGVCkKPiAgICNkZWZpbmUgS0ZEX01NQVBfVFlQRV9FVkVOVFMJ KDB4MlVMTCA8PCBLRkRfTU1BUF9UWVBFX1NISUZUKQo+ICAgI2RlZmluZSBLRkRfTU1BUF9UWVBF X1JFU0VSVkVEX01FTQkoMHgxVUxMIDw8IEtGRF9NTUFQX1RZUEVfU0hJRlQpCj4gKyNkZWZpbmUg S0ZEX01NQVBfVFlQRV9NTUlPCSgweDBVTEwgPDwgS0ZEX01NQVBfVFlQRV9TSElGVCkKPiAgIAo+ ICAgI2RlZmluZSBLRkRfTU1BUF9HUFVfSURfU0hJRlQgKDQ2IC0gUEFHRV9TSElGVCkKPiAgICNk ZWZpbmUgS0ZEX01NQVBfR1BVX0lEX01BU0sgKCgoMVVMTCA8PCBLRkRfR1BVX0lEX0hBU0hfV0lE VEgpIC0gMSkgXAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KYW1kLWdmeCBtYWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4