Re: [PATCH 5/7] drm/amd/display: Use connector kdev as aux device parent

["Kazlauskas, Nicholas" <Nicholas.Kazlauskas@amd.com>]

On 5/16/19 11:18 AM, sunpeng.li@amd.com wrote:
> 
> From: Leo Li <sunpeng.li@amd.com>
> 
> Set the connector's kernel device as the parent for the aux kernel
> device. This allows udev rules to access connector attributes when
> creating symlinks to aux devices.
> 
> For example, the following udev rule:
> 
> SUBSYSTEM=="drm_dp_aux_dev", SUBSYSTEMS=="drm", ATTRS{edid}=="*",
>          SYMLINK+="drm_dp_aux/by-name/$id"
> 
> Will create the following symlinks using the connector's name:
> 
> $ ls /dev/drm_dp_aux/by-name/
> card0-DP-1  card0-DP-2  card0-DP-3
> 
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Lyude Paul <lyude@redhat.com>
> Cc: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Jerry (Fangzhi) Zuo <Jerry.Zuo@amd.com>
> Signed-off-by: Leo Li <sunpeng.li@amd.com>

Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>

No idea why it wasn't like this in the first place.

Nicholas Kazlauskas

> ---
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> index a6f44a4..083fb97 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> @@ -385,7 +385,7 @@ void amdgpu_dm_initialize_dp_connector(struct amdgpu_display_manager *dm,
>                                         struct amdgpu_dm_connector *aconnector)
>   {
>          aconnector->dm_dp_aux.aux.name = "dmdc";
> -       aconnector->dm_dp_aux.aux.dev = dm->adev->dev;
> +       aconnector->dm_dp_aux.aux.dev = aconnector->base.kdev;
>          aconnector->dm_dp_aux.aux.transfer = dm_dp_aux_transfer;
>          aconnector->dm_dp_aux.ddc_service = aconnector->dc_link->ddc;
> 
> --
> 2.7.4
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel