From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 3/3] drm/amdgpu: enable paging queue based on FW version Date: Tue, 20 Nov 2018 10:58:21 +0100 Message-ID: <0195565f-3dcb-341d-662e-9e2582938a99@gmail.com> References: <20181119201946.5354-1-Philip.Yang@amd.com> <20181119201946.5354-3-Philip.Yang@amd.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Yang, Philip" , "Deucher, Alexander" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" QW0gMTkuMTEuMTggdW0gMjI6MTYgc2NocmllYiBZYW5nLCBQaGlsaXA6Cj4gT24gMjAxOC0xMS0x OSAzOjU3IHAubS4sIERldWNoZXIsIEFsZXhhbmRlciB3cm90ZToKPj4+IC0tLS0tT3JpZ2luYWwg TWVzc2FnZS0tLS0tCj4+PiBGcm9tOiBhbWQtZ2Z4IDxhbWQtZ2Z4LWJvdW5jZXNAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnPiBPbiBCZWhhbGYgT2YKPj4+IFlhbmcsIFBoaWxpcAo+Pj4gU2VudDogTW9u ZGF5LCBOb3ZlbWJlciAxOSwgMjAxOCAzOjIwIFBNCj4+PiBUbzogYW1kLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKPj4+IENjOiBZYW5nLCBQaGlsaXAgPFBoaWxpcC5ZYW5nQGFtZC5jb20+Cj4+ PiBTdWJqZWN0OiBbUEFUQ0ggMy8zXSBkcm0vYW1kZ3B1OiBlbmFibGUgcGFnaW5nIHF1ZXVlIGJh c2VkIG9uIEZXCj4+PiB2ZXJzaW9uCj4+Pgo+Pj4gQmFzZWQgU0RNQSBmdyB2ZXJzaW9uIHRvIGVu YWJsZSBoYXNfcGFnZV9xdWV1ZSBzdXBwb3J0LiBIYXZlIHRvIG1vdmUKPj4+IHNkbWFfdjRfMF9p bml0X21pY3JvY29kZSBmcm9tIHN3X2luaXQgdG8gZWFybHlfaW5pdCwgdG8gbG9hZCBmaXJtd2Fy ZSBhbmQKPj4+IGluaXQgZndfdmVyc2lvbiBiZWZvcmUgc2V0X3JpbmcvYnVmZmVyL3ZtX3B0ZV9m dW5jcyB1c2UgaXQuCj4+Pgo+Pj4gQ2hhbmdlLUlkOiBJZmU1ZDQ2NTlkMjhiYzJhNzAxMmI0ODk0 N2IyN2U5Mjk3NDlkODdjMQo+Pj4gU2lnbmVkLW9mZi1ieTogUGhpbGlwIFlhbmcgPFBoaWxpcC5Z YW5nQGFtZC5jb20+Cj4+PiAtLS0KPj4+ICAgIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L3Nk bWFfdjRfMC5jIHwgNDYgKysrKysrKysrKysrKysrKystLS0tCj4+PiAtLS0tLQo+Pj4gICAgMSBm aWxlIGNoYW5nZWQsIDMwIGluc2VydGlvbnMoKyksIDE2IGRlbGV0aW9ucygtKQo+Pj4KPj4+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9zZG1hX3Y0XzAuYwo+Pj4gYi9k cml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9zZG1hX3Y0XzAuYwo+Pj4gaW5kZXggNGQ4NzNmZDMy NDJjLi4wYTNiNjhkZDQ5YTAgMTAwNjQ0Cj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2Ft ZGdwdS9zZG1hX3Y0XzAuYwo+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvc2Rt YV92NF8wLmMKPj4+IEBAIC0xNDQ3LDIzICsxNDQ3LDQ0IEBAIHN0YXRpYyB2b2lkCj4+PiBzZG1h X3Y0XzBfcmluZ19lbWl0X3JlZ193YWl0KHN0cnVjdCBhbWRncHVfcmluZyAqcmluZywgdWludDMy X3QgcmVnLAo+Pj4gICAgCXNkbWFfdjRfMF93YWl0X3JlZ19tZW0ocmluZywgMCwgMCwgcmVnLCAw LCB2YWwsIG1hc2ssIDEwKTsgIH0KPj4+Cj4+PiArc3RhdGljIGJvb2wgc2RtYV92NF8wX2Z3X3N1 cHBvcnRfcGFnaW5nX3F1ZXVlKHN0cnVjdCBhbWRncHVfZGV2aWNlCj4+PiArKmFkZXYpIHsKPj4+ ICsJdWludCBmd192ZXJzaW9uID0gYWRldi0+c2RtYS5pbnN0YW5jZVswXS5md192ZXJzaW9uOwo+ Pj4gKwo+Pj4gKwlzd2l0Y2ggKGFkZXYtPmFzaWNfdHlwZSkgewo+Pj4gKwljYXNlIENISVBfVkVH QTEwOgo+Pj4gKwkJcmV0dXJuIGZ3X3ZlcnNpb24gPj0gNDMwOwo+Pj4gKwljYXNlIENISVBfVkVH QTEyOgo+Pj4gKwkJcmV0dXJuIGZ3X3ZlcnNpb24gPj0gMzE7Cj4+PiArCWNhc2UgQ0hJUF9WRUdB MjA6Cj4+PiArCQlyZXR1cm4gZndfdmVyc2lvbiA+PSAxMTU7Cj4+PiArCWRlZmF1bHQ6Cj4+PiAr CQlyZXR1cm4gZmFsc2U7Cj4+PiArCX0KPj4+ICt9Cj4+PiArCj4+PiAgICBzdGF0aWMgaW50IHNk bWFfdjRfMF9lYXJseV9pbml0KHZvaWQgKmhhbmRsZSkgIHsKPj4+ICAgIAlzdHJ1Y3QgYW1kZ3B1 X2RldmljZSAqYWRldiA9IChzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqKWhhbmRsZTsKPj4+ICsJaW50 IHI7Cj4+Pgo+Pj4gLQlpZiAoYWRldi0+YXNpY190eXBlID09IENISVBfUkFWRU4pIHsKPj4+ICsJ aWYgKGFkZXYtPmFzaWNfdHlwZSA9PSBDSElQX1JBVkVOKQo+Pj4gICAgCQlhZGV2LT5zZG1hLm51 bV9pbnN0YW5jZXMgPSAxOwo+Pj4gLQkJYWRldi0+c2RtYS5oYXNfcGFnZV9xdWV1ZSA9IGZhbHNl Owo+Pj4gLQl9IGVsc2Ugewo+Pj4gKwllbHNlCj4+PiAgICAJCWFkZXYtPnNkbWEubnVtX2luc3Rh bmNlcyA9IDI7Cj4+PiAtCQkvKiBUT0RPOiBQYWdlIHF1ZXVlIGJyZWFrcyBkcml2ZXIgcmVsb2Fk IHVuZGVyIFNSSU9WICovCj4+PiAtCQlpZiAoKGFkZXYtPmFzaWNfdHlwZSA9PSBDSElQX1ZFR0Ex MCkgJiYKPj4+IGFtZGdwdV9zcmlvdl92ZigoYWRldikpKQo+Pj4gLQkJCWFkZXYtPnNkbWEuaGFz X3BhZ2VfcXVldWUgPSBmYWxzZTsKPj4+IC0JCWVsc2UgaWYgKGFkZXYtPmFzaWNfdHlwZSAhPSBD SElQX1ZFR0EyMCAmJgo+Pj4gLQkJCQlhZGV2LT5hc2ljX3R5cGUgIT0gQ0hJUF9WRUdBMTIpCj4+ PiAtCQkJYWRldi0+c2RtYS5oYXNfcGFnZV9xdWV1ZSA9IHRydWU7Cj4+PiArCj4+PiArCXIgPSBz ZG1hX3Y0XzBfaW5pdF9taWNyb2NvZGUoYWRldik7Cj4+PiArCWlmIChyKSB7Cj4+PiArCQlEUk1f RVJST1IoIkZhaWxlZCB0byBsb2FkIHNkbWEgZmlybXdhcmUhXG4iKTsKPj4+ICsJCXJldHVybiBy Owo+PiBJIHRoaW5rIHRoaXMgc2hvdWxkIGJlIG9rLiAgQXMgbG9uZyBhcyB5b3UndmUgdmVyaWZp ZWQgdGhhdCBzZGFtX3Y0XzBfaW5pdF9taWNyb2NvZGUoKSBkb2Vzbid0IGRlcGVuZCBvbiBhbnkg b3RoZXIgaW5pdCBmcm9tIGFub3RoZXIgbW9kdWxlIGxpa2UgcHNwLiAgSSB0b29rIGEgcXVpY2sg bG9vayBhdCB0aGUgY29kZSBhbmQgaXQgc2VlbXMgbGlrZSB3ZSBzaG91bGQgYmUgb2suCj4+IEFj a2VkLWJ5OiBBbGV4IERldWNoZXIgPGFsZXhhbmRlci5kZXVjaGVyQGFtZC5jb20+Cj4gc2RtYV92 NF8wX2luaXRfbWljcm9jb2RlKCkgcmVhZHMgZncgYmluYXJ5IGZpbGUgYW5kIHNldHVwIGZ3IHZl cnNpb24gZXRjCj4gZGF0YSBzdHJ1Y3R1cmUuIEl0IGRvZXNuJ3QgZGVwZW5kIG9uIG90aGVyIGlu aXQgc28gaXQgaXMgZmluZSB0byBtb3ZlIGl0Cj4gZnJvbSBzd19pbml0KCkgdG8gZWFybHlfaW5p dCgpLiBzZG1hX3Y0XzBfbG9hZF9taWNyb2NvZGUoKSB3aWxsIHN0YXJ0IGZ3Cj4gZnJvbSBzZG1h X3Y0XzBfc3RhcnQoKSB3aGljaCBkZXBlbmRzIG9uIHBzcCwgZ21jIGV0Yy4gVGhpcyBoYXBwZW5z IGFmdGVyCj4gZWFybHlfaW5pdCgpLT5zd19pbml0KCktPmh3X2luaXQoKS4KClllYWgsIHRoYXQg c291bmRzIGxpa2UgaXQgc2hvdWxkIHdvcmsuCgpQYXRjaGVzICMxIGFuZCAjMiBhcmUgUmV2aWV3 ZWQtYnk6IENocmlzdGlhbiBLw7ZuaWcgCjxjaHJpc3RpYW4ua29lbmlnQGFtZC5jb20+CgpQYXRj aCAjMyBpcyBBY2tlZC1ieTogQ2hyaXN0aWFuIEvDtm5pZyA8Y2hyaXN0aWFuLmtvZW5pZ0BhbWQu Y29tPgoKVGhhbmtzIGZvciB0YWtpbmcgY2FyZSBvZiB0aGF0LApDaHJpc3RpYW4uCgoKPgo+IFBo aWxpcAo+Pj4gICAgCX0KPj4+Cj4+PiArCS8qIFRPRE86IFBhZ2UgcXVldWUgYnJlYWtzIGRyaXZl ciByZWxvYWQgdW5kZXIgU1JJT1YgKi8KPj4+ICsJaWYgKChhZGV2LT5hc2ljX3R5cGUgPT0gQ0hJ UF9WRUdBMTApICYmCj4+PiBhbWRncHVfc3Jpb3ZfdmYoKGFkZXYpKSkKPj4+ICsJCWFkZXYtPnNk bWEuaGFzX3BhZ2VfcXVldWUgPSBmYWxzZTsKPj4+ICsJZWxzZSBpZiAoc2RtYV92NF8wX2Z3X3N1 cHBvcnRfcGFnaW5nX3F1ZXVlKGFkZXYpKQo+Pj4gKwkJYWRldi0+c2RtYS5oYXNfcGFnZV9xdWV1 ZSA9IHRydWU7Cj4+PiArCj4+PiAgICAJc2RtYV92NF8wX3NldF9yaW5nX2Z1bmNzKGFkZXYpOwo+ Pj4gICAgCXNkbWFfdjRfMF9zZXRfYnVmZmVyX2Z1bmNzKGFkZXYpOwo+Pj4gICAgCXNkbWFfdjRf MF9zZXRfdm1fcHRlX2Z1bmNzKGFkZXYpOwo+Pj4gQEAgLTE0NzIsNyArMTQ5Myw2IEBAIHN0YXRp YyBpbnQgc2RtYV92NF8wX2Vhcmx5X2luaXQodm9pZCAqaGFuZGxlKQo+Pj4gICAgCXJldHVybiAw Owo+Pj4gICAgfQo+Pj4KPj4+IC0KPj4+ICAgIHN0YXRpYyBpbnQgc2RtYV92NF8wX3N3X2luaXQo dm9pZCAqaGFuZGxlKSAgewo+Pj4gICAgCXN0cnVjdCBhbWRncHVfcmluZyAqcmluZzsKPj4+IEBA IC0xNDkxLDEyICsxNTExLDYgQEAgc3RhdGljIGludCBzZG1hX3Y0XzBfc3dfaW5pdCh2b2lkICpo YW5kbGUpCj4+PiAgICAJaWYgKHIpCj4+PiAgICAJCXJldHVybiByOwo+Pj4KPj4+IC0JciA9IHNk bWFfdjRfMF9pbml0X21pY3JvY29kZShhZGV2KTsKPj4+IC0JaWYgKHIpIHsKPj4+IC0JCURSTV9F UlJPUigiRmFpbGVkIHRvIGxvYWQgc2RtYSBmaXJtd2FyZSFcbiIpOwo+Pj4gLQkJcmV0dXJuIHI7 Cj4+PiAtCX0KPj4+IC0KPj4+ICAgIAlmb3IgKGkgPSAwOyBpIDwgYWRldi0+c2RtYS5udW1faW5z dGFuY2VzOyBpKyspIHsKPj4+ICAgIAkJcmluZyA9ICZhZGV2LT5zZG1hLmluc3RhbmNlW2ldLnJp bmc7Cj4+PiAgICAJCXJpbmctPnJpbmdfb2JqID0gTlVMTDsKPj4+IC0tCj4+PiAyLjE3LjEKPj4+ Cj4+PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+Pj4g YW1kLWdmeCBtYWlsaW5nIGxpc3QKPj4+IGFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4+ PiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngK PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGFtZC1n ZnggbWFpbGluZyBsaXN0Cj4gYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngKCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmFtZC1nZnggbWFpbGluZyBs aXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeAo=