AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <ckoenig.leichtzumerken-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Daniel Vetter <daniel-/w4YWyX8dFk@public.gmane.org>
Cc: linaro-mm-sig-cunTk1MwBs8s++Sfvej+rw@public.gmane.org,
	sumit.semwal-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] dma-buf: use parameter structure for dma_buf_attach
Date: Mon, 26 Mar 2018 12:47:01 +0200	[thread overview]
Message-ID: <0242b504-87cd-2c80-ad86-868622c3c681@gmail.com> (raw)
In-Reply-To: <20180326083638.GS14155-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>

Am 26.03.2018 um 10:36 schrieb Daniel Vetter:
> On Sun, Mar 25, 2018 at 01:34:51PM +0200, Christian König wrote:
[SNIP]
>> -	attach->dev = dev;
>> +	attach->dev = info->dev;
>>   	attach->dmabuf = dmabuf;
>> +	attach->priv = info->priv;
> The ->priv field is for the exporter, not the importer. See e.g.
> drm_gem_map_attach. You can't let the importer set this now too, so needs
> to be removed from the info struct.

Crap, in this case I need to add an importer_priv field because we now 
need to map from the attachment to it's importer object as well.

Thanks for noticing this.

Regards,
Christian.

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2018-03-26 10:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-25 11:34 [PATCH] dma-buf: use parameter structure for dma_buf_attach Christian König
2018-03-26  8:36 ` Daniel Vetter
     [not found]   ` <20180326083638.GS14155-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2018-03-26 10:47     ` Christian König [this message]
     [not found]       ` <0242b504-87cd-2c80-ad86-868622c3c681-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-03-26 15:16         ` Daniel Vetter
2018-03-26 10:47     ` Christian König
     [not found] ` <20180325113451.2425-1-christian.koenig-5C7GfCeVMHo@public.gmane.org>
2018-03-25 21:58   ` kbuild test robot
2018-03-27 20:01   ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0242b504-87cd-2c80-ad86-868622c3c681@gmail.com \
    --to=ckoenig.leichtzumerken-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=christian.koenig-5C7GfCeVMHo@public.gmane.org \
    --cc=daniel-/w4YWyX8dFk@public.gmane.org \
    --cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=linaro-mm-sig-cunTk1MwBs8s++Sfvej+rw@public.gmane.org \
    --cc=linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sumit.semwal-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox