public inbox for amd-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Matt Coffin <mcoffin13@gmail.com>
To: "Alex Deucher" <alexdeucher@gmail.com>,
	"Christian König" <ckoenig.leichtzumerken@gmail.com>
Cc: amd-gfx list <amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/amdgpu: revert "fix system hang issue during GPU reset"
Date: Thu, 13 Aug 2020 19:23:25 -0600	[thread overview]
Message-ID: <02ae46c5-4741-e042-e037-480482e8b1a1@gmail.com> (raw)
In-Reply-To: <CADnq5_OeVF-YZu=dcFWa-GYexJ744AQGxd6D3owihrZftjc4Ew@mail.gmail.com>

On 8/12/20 9:55 AM, Alex Deucher wrote:
> This also broke GPU overclocking.

The fix for the `pp_od_clk_voltage` interface was actually quite simple,
and the bug was limited to that function. The patch just messed up the
return value (which was supposed to be the # of bytes consumed). It was
just returning 0 on success, which caused the userspace client to keep
on trying to send the data.

I suck at email lists, and don't know how to link it here, but I
submitted a patch just now to repair it, if that's the only blocker on this.

Thanks for the work guys,
Matt
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

      parent reply	other threads:[~2020-08-14  1:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-12 15:53 [PATCH] drm/amdgpu: revert "fix system hang issue during GPU reset" Christian König
2020-08-12 15:55 ` Alex Deucher
2020-08-13 10:58   ` Christian König
2020-08-14  1:23   ` Matt Coffin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=02ae46c5-4741-e042-e037-480482e8b1a1@gmail.com \
    --to=mcoffin13@gmail.com \
    --cc=alexdeucher@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=ckoenig.leichtzumerken@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox