From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH] drm/amdgpu: fix a race in GPU reset with IB test Date: Wed, 29 May 2019 09:47:28 +0200 Message-ID: <0307cdf4-2231-5d29-9666-28cfa0794ee7@gmail.com> References: <20190528192955.599-1-alexander.deucher@amd.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190528192955.599-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Alex Deucher , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: Alex Deucher QW0gMjguMDUuMTkgdW0gMjE6Mjkgc2NocmllYiBBbGV4IERldWNoZXI6Cj4gU3BsaXQgbGF0ZV9p bml0IGludG8gdHdvIGZ1bmN0aW9ucywgb25lIChkb19sYXRlX2luaXQpIHdoaWNoCj4ganVzdCBk b2VzIHRoZSBodyBpbml0LCBhbmQgbGF0ZV9pbml0IHdoaWNoIGNhbGxzIGRvX2xhdGVfaW5pdAo+ IGFuZCBzY2hlZHVsZXMgdGhlIElCIHRlc3Qgd29yay4gIENhbGwgZG9fbGF0ZV9pbml0IGluCj4g dGhlIEdQVSByZXNldCBjb2RlIHRvIHJ1biB0aGUgaW5pdCBjb2RlLCBidXQgbm90IHNjaGVkdWxl Cj4gdGhlIElCIHRlc3QgY29kZS4gIFRoZSBJQiB0ZXN0IGNvZGUgaXMgY2FsbGVkIGRpcmVjdGx5 Cj4gaW4gdGhlIGdwdSByZXNldCBjb2RlIHNvIG5vIG5lZWQgdG8gcnVuIHRoZSBJQiB0ZXN0cwo+ IGluIGEgc2VwYXJhdGUgd29yayB0aHJlYWQuICBJZiB3ZSBkbywgd2UgZW5kIHVwIHJhY2luZy4K CkkgYWxyZWFkeSBoYWQgdGhlIHN1c3BpY2lvbiB0aGF0IHdlIGRvIHNvbWV0aGluZyB3cm9uZyBp biB0aGUgcmVzZXQgcGF0aCAKd2l0aCB0aGlzLgoKQnV0IEkgZG9uJ3QgcmVhbGx5IGxpa2UgdGhl IG5hbWluZy4gSG93IGFib3V0IHdlIGNhbGwgdGhlIGxhdGVfaW5pdF93b3JrIApkZWxheWVkX2lu aXRfd29yayBpbnN0ZWFkIGFuZCBleHBsaWNpdGx5IHNjaGVkdWxlIGl0IGZyb20gCmFtZGdwdV9k ZXZpY2VfaW5pdCgpID8KCkNocmlzdGlhbi4KCj4KPiBTaWduZWQtb2ZmLWJ5OiBBbGV4IERldWNo ZXIgPGFsZXhhbmRlci5kZXVjaGVyQGFtZC5jb20+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0v YW1kL2FtZGdwdS9hbWRncHVfZGV2aWNlLmMgfCA0MyArKysrKysrKysrKysrLS0tLS0tLS0tCj4g ICAxIGZpbGUgY2hhbmdlZCwgMjYgaW5zZXJ0aW9ucygrKSwgMTcgZGVsZXRpb25zKC0pCj4KPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2RldmljZS5jIGIv ZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2RldmljZS5jCj4gaW5kZXggN2E4YzIy MDFjZDA0Li42YjkwODQwMzA3ZGMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9h bWRncHUvYW1kZ3B1X2RldmljZS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUv YW1kZ3B1X2RldmljZS5jCj4gQEAgLTE4NjksMTkgKzE4NjksNyBAQCBzdGF0aWMgaW50IGFtZGdw dV9kZXZpY2Vfc2V0X3BnX3N0YXRlKHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2LCBlbnVtIGFt ZF9wb3dlcgo+ICAgCXJldHVybiAwOwo+ICAgfQo+ICAgCj4gLS8qKgo+IC0gKiBhbWRncHVfZGV2 aWNlX2lwX2xhdGVfaW5pdCAtIHJ1biBsYXRlIGluaXQgZm9yIGhhcmR3YXJlIElQcwo+IC0gKgo+ IC0gKiBAYWRldjogYW1kZ3B1X2RldmljZSBwb2ludGVyCj4gLSAqCj4gLSAqIExhdGUgaW5pdGlh bGl6YXRpb24gcGFzcyBmb3IgaGFyZHdhcmUgSVBzLiAgVGhlIGxpc3Qgb2YgYWxsIHRoZSBoYXJk d2FyZQo+IC0gKiBJUHMgdGhhdCBtYWtlIHVwIHRoZSBhc2ljIGlzIHdhbGtlZCBhbmQgdGhlIGxh dGVfaW5pdCBjYWxsYmFja3MgYXJlIHJ1bi4KPiAtICogbGF0ZV9pbml0IGNvdmVycyBhbnkgc3Bl Y2lhbCBpbml0aWFsaXphdGlvbiB0aGF0IGFuIElQIHJlcXVpcmVzCj4gLSAqIGFmdGVyIGFsbCBv ZiB0aGUgaGF2ZSBiZWVuIGluaXRpYWxpemVkIG9yIHNvbWV0aGluZyB0aGF0IG5lZWRzIHRvIGhh cHBlbgo+IC0gKiBsYXRlIGluIHRoZSBpbml0IHByb2Nlc3MuCj4gLSAqIFJldHVybnMgMCBvbiBz dWNjZXNzLCBuZWdhdGl2ZSBlcnJvciBjb2RlIG9uIGZhaWx1cmUuCj4gLSAqLwo+IC1zdGF0aWMg aW50IGFtZGdwdV9kZXZpY2VfaXBfbGF0ZV9pbml0KHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2 KQo+ICtzdGF0aWMgaW50IGFtZGdwdV9kZXZpY2VfZG9faXBfbGF0ZV9pbml0KHN0cnVjdCBhbWRn cHVfZGV2aWNlICphZGV2KQo+ICAgewo+ICAgCWludCBpID0gMCwgcjsKPiAgIAo+IEBAIC0xOTAy LDE0ICsxODkwLDM1IEBAIHN0YXRpYyBpbnQgYW1kZ3B1X2RldmljZV9pcF9sYXRlX2luaXQoc3Ry dWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYpCj4gICAJYW1kZ3B1X2RldmljZV9zZXRfY2dfc3RhdGUo YWRldiwgQU1EX0NHX1NUQVRFX0dBVEUpOwo+ICAgCWFtZGdwdV9kZXZpY2Vfc2V0X3BnX3N0YXRl KGFkZXYsIEFNRF9QR19TVEFURV9HQVRFKTsKPiAgIAo+IC0JcXVldWVfZGVsYXllZF93b3JrKHN5 c3RlbV93cSwgJmFkZXYtPmxhdGVfaW5pdF93b3JrLAo+IC0JCQkgICBtc2Vjc190b19qaWZmaWVz KEFNREdQVV9SRVNVTUVfTVMpKTsKPiAtCj4gICAJYW1kZ3B1X2RldmljZV9maWxsX3Jlc2V0X21h Z2ljKGFkZXYpOwo+ICAgCj4gICAJcmV0dXJuIDA7Cj4gICB9Cj4gICAKPiArLyoqCj4gKyAqIGFt ZGdwdV9kZXZpY2VfaXBfbGF0ZV9pbml0IC0gcnVuIGxhdGUgaW5pdCBmb3IgaGFyZHdhcmUgSVBz Cj4gKyAqCj4gKyAqIEBhZGV2OiBhbWRncHVfZGV2aWNlIHBvaW50ZXIKPiArICoKPiArICogTGF0 ZSBpbml0aWFsaXphdGlvbiBwYXNzIGZvciBoYXJkd2FyZSBJUHMuICBUaGUgbGlzdCBvZiBhbGwg dGhlIGhhcmR3YXJlCj4gKyAqIElQcyB0aGF0IG1ha2UgdXAgdGhlIGFzaWMgaXMgd2Fsa2VkIGFu ZCB0aGUgbGF0ZV9pbml0IGNhbGxiYWNrcyBhcmUgcnVuLgo+ICsgKiBsYXRlX2luaXQgY292ZXJz IGFueSBzcGVjaWFsIGluaXRpYWxpemF0aW9uIHRoYXQgYW4gSVAgcmVxdWlyZXMKPiArICogYWZ0 ZXIgYWxsIG9mIHRoZSBoYXZlIGJlZW4gaW5pdGlhbGl6ZWQgb3Igc29tZXRoaW5nIHRoYXQgbmVl ZHMgdG8gaGFwcGVuCj4gKyAqIGxhdGUgaW4gdGhlIGluaXQgcHJvY2Vzcy4KPiArICogUmV0dXJu cyAwIG9uIHN1Y2Nlc3MsIG5lZ2F0aXZlIGVycm9yIGNvZGUgb24gZmFpbHVyZS4KPiArICovCj4g K3N0YXRpYyBpbnQgYW1kZ3B1X2RldmljZV9pcF9sYXRlX2luaXQoc3RydWN0IGFtZGdwdV9kZXZp Y2UgKmFkZXYpCj4gK3sKPiArCWludCByOwo+ICsKPiArCXIgPSBhbWRncHVfZGV2aWNlX2RvX2lw X2xhdGVfaW5pdChhZGV2KTsKPiArCj4gKwlxdWV1ZV9kZWxheWVkX3dvcmsoc3lzdGVtX3dxLCAm YWRldi0+bGF0ZV9pbml0X3dvcmssCj4gKwkJCSAgIG1zZWNzX3RvX2ppZmZpZXMoQU1ER1BVX1JF U1VNRV9NUykpOwo+ICsKPiArCXJldHVybiByOwo+ICt9Cj4gKwo+ICAgLyoqCj4gICAgKiBhbWRn cHVfZGV2aWNlX2lwX2ZpbmkgLSBydW4gZmluaSBmb3IgaGFyZHdhcmUgSVBzCj4gICAgKgo+IEBA IC0zNTAyLDcgKzM1MTEsNyBAQCBzdGF0aWMgaW50IGFtZGdwdV9kb19hc2ljX3Jlc2V0KHN0cnVj dCBhbWRncHVfaGl2ZV9pbmZvICpoaXZlLAo+ICAgCQkJCWlmICh2cmFtX2xvc3QpCj4gICAJCQkJ CWFtZGdwdV9kZXZpY2VfZmlsbF9yZXNldF9tYWdpYyh0bXBfYWRldik7Cj4gICAKPiAtCQkJCXIg PSBhbWRncHVfZGV2aWNlX2lwX2xhdGVfaW5pdCh0bXBfYWRldik7Cj4gKwkJCQlyID0gYW1kZ3B1 X2RldmljZV9kb19pcF9sYXRlX2luaXQodG1wX2FkZXYpOwo+ICAgCQkJCWlmIChyKQo+ICAgCQkJ CQlnb3RvIG91dDsKPiAgIAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KYW1kLWdmeCBtYWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4