From: "Christian König" <christian.koenig@amd.com>
To: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: kernel-dev@igalia.com,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>
Subject: Re: [RFC v2 1/5] drm/ttm: Add getter for some pool properties
Date: Tue, 7 Oct 2025 16:03:03 +0200 [thread overview]
Message-ID: <07ed348b-e8a7-4831-88d2-b53fcd07d5c5@amd.com> (raw)
In-Reply-To: <c3cb4df5-d6db-4cff-ba4c-c51f6503181c@igalia.com>
On 07.10.25 16:00, Tvrtko Ursulin wrote:
>>
>> Please not in the header. Neither drivers nor other TTM modules should mess with such properties.
>>
>> That is all internal to the pool.
>
> Hmm IMHO it is not that bad. Especially that ttm_pool.c and ttm_tt.c need to have access to them. Alternatiev is a new header for internal helpers which sounds a bit too much. But if you insist I can create it.
Wait a second why is ttm_tt.c still needing this? For the DMA32 eviction?
Regards,
Christian.
>
> Regards,
>
> Tvrtko
>
next prev parent reply other threads:[~2025-10-07 14:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-03 13:58 [RFC v2 0/5] Improving the worst case TTM large allocation latency Tvrtko Ursulin
2025-10-03 13:58 ` [RFC v2 1/5] drm/ttm: Add getter for some pool properties Tvrtko Ursulin
2025-10-06 8:38 ` Christian König
2025-10-07 14:00 ` Tvrtko Ursulin
2025-10-07 14:03 ` Christian König [this message]
2025-10-07 14:27 ` Tvrtko Ursulin
2025-10-07 15:04 ` Christian König
2025-10-08 7:34 ` Tvrtko Ursulin
2025-10-08 10:01 ` Christian König
2025-10-03 13:58 ` [RFC v2 2/5] drm/ttm: Replace multiple booleans with flags in pool init Tvrtko Ursulin
2025-10-03 13:58 ` [RFC v2 3/5] drm/ttm: Replace multiple booleans with flags in device init Tvrtko Ursulin
2025-10-03 13:58 ` [RFC v2 4/5] drm/ttm: Allow drivers to specify maximum beneficial TTM pool size Tvrtko Ursulin
2025-10-06 9:49 ` Christian König
2025-10-07 13:57 ` Tvrtko Ursulin
2025-10-07 15:36 ` Christian König
2025-10-03 13:58 ` [RFC v2 5/5] drm/amdgpu: Configure max beneficial TTM pool allocation order Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07ed348b-e8a7-4831-88d2-b53fcd07d5c5@amd.com \
--to=christian.koenig@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-dev@igalia.com \
--cc=thomas.hellstrom@linux.intel.com \
--cc=tvrtko.ursulin@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox