From: Felix Kuehling <felix.kuehling@amd.com>
To: Jonathan Kim <jonathan.kim@amd.com>, amd-gfx@lists.freedesktop.org
Cc: JinHuiEric.Huang@amd.com
Subject: Re: [PATCH] drm/amdkfd: fix double assign skip process context clear
Date: Thu, 10 Aug 2023 16:04:41 -0400 [thread overview]
Message-ID: <08f4806a-64df-da4c-aada-734919eec559@amd.com> (raw)
In-Reply-To: <20230810190317.3819769-1-jonathan.kim@amd.com>
On 2023-08-10 15:03, Jonathan Kim wrote:
> Remove redundant assignment when skipping process ctx clear.
>
> Signed-off-by: Jonathan Kim <jonathan.kim@amd.com>
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> index aa5091f18681..89c2bfcb36ce 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> @@ -227,7 +227,6 @@ static int add_queue_mes(struct device_queue_manager *dqm, struct queue *q,
> queue_input.tba_addr = qpd->tba_addr;
> queue_input.tma_addr = qpd->tma_addr;
> queue_input.trap_en = !kfd_dbg_has_cwsr_workaround(q->device);
> - queue_input.skip_process_ctx_clear = qpd->pqm->process->debug_trap_enabled;
> queue_input.skip_process_ctx_clear = qpd->pqm->process->debug_trap_enabled ||
> kfd_dbg_has_ttmps_always_setup(q->device);
>
prev parent reply other threads:[~2023-08-10 20:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 19:03 [PATCH] drm/amdkfd: fix double assign skip process context clear Jonathan Kim
2023-08-10 20:04 ` Felix Kuehling [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08f4806a-64df-da4c-aada-734919eec559@amd.com \
--to=felix.kuehling@amd.com \
--cc=JinHuiEric.Huang@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=jonathan.kim@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox