From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 79B19C3DA7D for ; Tue, 3 Jan 2023 09:40:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F074110E3B7; Tue, 3 Jan 2023 09:40:51 +0000 (UTC) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2070.outbound.protection.outlook.com [40.107.95.70]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7B46510E3B7 for ; Tue, 3 Jan 2023 09:40:50 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J96HN76r0OGYVIbqG/4W0k2m2T9Pl6W/c6Dy+r/4rrIaHnUiLETDfK/buFKPqc3a3BsKC0UfK/ziC8wWiPhCEeATidNtuRuzewFS5zD8T9HWmVqumLDTppZwa3tYua91pGI3OC3Sa/35CJMQvA+ezOKs49/X0dxERC0PZBjIItBUCt0g7W9t+Bx8rYzIqR0XEEm8KT3TwEkaguHlcMpgNPisTj8CJOqT50c/Fg9bdNMMkLFkJiKWicB5WcLW2xbKl84n1hPfTPDubXWdxdcdyoJ3JSXN0xT9EbS4ISbgbA9pqGfAhOueLdW/pDgaTnY77D5fkU903vzNxMl/W/h0Kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qsO4xZJjJV5rK4t6KFJu64K0S+RcAGHKrEqH/OVhtrQ=; b=MdSHjUOWOCBtAoVYBWNFSd5XQOemFiuiwHUZ89inpBHOQOnwnKAVGDtbs0+F+glAVakeVKhdrdtyDSDEoZ/5OixJnGUguBxuuTSmMGxpY1SrBGUtWZ/uIIlHu/N8Sbi3vEunxzbPJu+zQayz0oQ37/d1ZOEnWANlQEdEhaR05YQ0tlPsmJyM3EcBgLfVZH2lksPi1wvrRqRZAEi18ANL/XUIXmhh7pDafYBpC82yfpBlCXI+M4Qi+2TdCZHT4dXjlXQ6QgUf75Rz3gjZ+HV0vVSNp6xLSWewg3uyTNGBqIN+bxyvnCYkkc6B1LF2Mugs7yRzXixXTKXkHSruMxLwPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qsO4xZJjJV5rK4t6KFJu64K0S+RcAGHKrEqH/OVhtrQ=; b=VBSgaQiwKsWKg0MelCqqDnhqxTIwzOg3h0j5uhEVJghN27HgLJmTeLDjtUDyfy6iMxl2Ba9JMvhwENOT4tg1WrbYf2RUzlBD823z+XTjDsunZhg9c98GrgdNnq3OAA1YmSK6YZ+l4RPNzfqHkBF3ijs3m7bK7x6sKK4waa/tlJM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from MW4PR12MB5667.namprd12.prod.outlook.com (2603:10b6:303:18a::10) by LV2PR12MB5775.namprd12.prod.outlook.com (2603:10b6:408:179::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Tue, 3 Jan 2023 09:40:48 +0000 Received: from MW4PR12MB5667.namprd12.prod.outlook.com ([fe80::ae3c:5792:8b56:6367]) by MW4PR12MB5667.namprd12.prod.outlook.com ([fe80::ae3c:5792:8b56:6367%5]) with mapi id 15.20.5944.019; Tue, 3 Jan 2023 09:40:48 +0000 Message-ID: <091e247d-9416-6f03-87f6-470adf798eeb@amd.com> Date: Tue, 3 Jan 2023 10:40:37 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [RFC 5/7] drm/amdgpu: Create context for usermode queue Content-Language: en-US To: Alex Deucher References: <20221223193655.1972-1-shashank.sharma@amd.com> <20221223193655.1972-6-shashank.sharma@amd.com> From: Shashank Sharma In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0179.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::16) To MW4PR12MB5667.namprd12.prod.outlook.com (2603:10b6:303:18a::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW4PR12MB5667:EE_|LV2PR12MB5775:EE_ X-MS-Office365-Filtering-Correlation-Id: d25f923b-5fad-4f8c-e1e7-08daed6e97f3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wLvRwlFHPKm1QjzdEk2OQwj6gDc6JzdaW6eHOaXjwR1evHhU5AAzonRCylmOQ/0EMfM2mKKT4i43raEASAPIMrE75SA+VnKq/aU0PZqU5jvEm+IGmOvzGCCEHntn5EFMivbUyMv8O1ZLiGkq/YfvdHqIdEmByOFMraQPnUTwI1CSYXvKvg4zkqxZnU05a2x/yowbjRZDDUn3WidScXJfFDfdf97BYWm3QaIvRvFbkI7LrMZmaSIibUiDKuKLaJW+w/ShKqOeXYwTMHEXfCCH6j4qQxB3fSRUktxODcoa3Hgy7kSMHfynEmWyUzh62M4zPmWW21k+oiDm8G91utDid8wLrScLrNR8VhvkGzLG7n3lpoRn/AL3/Ot8E4RTP376FCfbhvLuYxHfh65tDbliG7DEhOy0/I53BnLfaghFz4b5dGUvVeKOTHgprlXg22SaJnSIGh3gpKepKWU+pdHZU+0tNcKBpr3nd9mEEBU0kB2/suOhOIou3pHT0+/Ti56nFpt6Yqr/eVM0VfkBo6VdE2JnZLgA2ULaqrFsv1Or5hgpmz/Z52pJi1s7gFqXMrUUynM4L//JVvhaRcdYpptf69oNzrEDv6z/6R0c5aOpSdE+6Ko32mLU5gKpyqxeAcDIquKl/2sKB923AgkbtHc0ZmKBS/kMSa53hma3i+pFZZcI20KFkGyBHw5AJzJmW6OO5dmpKzs4kuYNhlo60l14nEGAfquLHgzn+gO9cz+g/e81iNR8aR0fYjHMQN2HWnOFLuv4AhUs9aOtSLvFuGZRtAP7ExHXUc0oQr/kLlra3mz3kZZ5zRFu9X+x6C3K6qrD X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW4PR12MB5667.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(346002)(366004)(396003)(136003)(376002)(39860400002)(451199015)(6512007)(186003)(53546011)(26005)(6486002)(6916009)(54906003)(31686004)(478600001)(316002)(6506007)(4326008)(66946007)(6666004)(8676002)(66556008)(2616005)(66476007)(8936002)(5660300002)(44832011)(83380400001)(41300700001)(2906002)(38100700002)(36756003)(31696002)(86362001)(22166006)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Rk8vdXh1bVdERjlJbHJtQm45MmZTWGg5QmxwcWtlTUxBYWx1c2UrZjdkaVlp?= =?utf-8?B?aFhJTlNvaWhNOG9PUG41b3o0Z1R4dTRFY0xtbVBKM3RycEx0Y2xVRFZNNTda?= =?utf-8?B?bndTNGZ6QjJtWDhGNlh2RVkzZkZDSm9Ud3U2a0hSM3JZRWhFRWdhWjc1YklT?= =?utf-8?B?dEgrci9HN3RZbXBSL09WRnNzdWYxcXV0azNBZy9tbkE0bXN2NitpZi9LVlJn?= =?utf-8?B?djlxaWpXWWJyNElQbG1ucUF2QmNPVjRKWVFrYWFSSkU2Rnp6VXR4aElDVUFH?= =?utf-8?B?Q2NiSGpRMytnOGlRenFPUUk4Uk5SbEgwdHc0SlM1NUtHRmJ0Y0RkcW9iQ3dC?= =?utf-8?B?R21HeXlsTHpzRHYvb1lxSm9hTngzRWtyWk05S1VPbUo0RzVnZ2NQT0hvRXNT?= =?utf-8?B?Wkw3MGorZ3dyRFloaFk5anc5cmE1c0ZhQjdGSEZkWFhxV3hvZnF6OTNZWlM2?= =?utf-8?B?UWtCMnRJbUdyVGNZYVkyQm9VbDQ0YVEzKzYrblRrMHRCNHh5dHNaOEROOGdR?= =?utf-8?B?ZWVBd3VZTmJRUUhza3FhY2hFR010L1dCcWI0YTNmTkhVVHBBY3l6T3ZkNSsv?= =?utf-8?B?K21JT25GYjNTYzZrM0lkbHQyS0JHUStHTStzVTNxalhTRzR5c21IU1JkYWZN?= =?utf-8?B?dEV1TEUxam92aFJlRHZhYlBreDYvbHVsQ1lzczBYTmRad25tekxTamFZcGho?= =?utf-8?B?Ry93blFvcy9XcnlEVEYyVnF4S1RRY0F3eHc2VjE2Zmc2bmRNRXM4VWZvN0ZG?= =?utf-8?B?VnNOZFA0VUFlTlRGRE5YSnFZOXpmVW1KQjJDckwvV210Njh1eWNOU3ZtVjI3?= =?utf-8?B?MnFESVQzVndhaVV0cW9YL0VmMG50VEVXOHNoZUJNZUtWbXlpQmpPWWhUdE5y?= =?utf-8?B?Q0RaRHFVNENrMkMvQTFvZ3JpSGx4K0tYUjlTd21qd3VnMTlCMUp3b25Hdmp3?= =?utf-8?B?dWp1L2poMTNCQlhEUkxoOXVLTDU3YkErTkxrTHQ2QVNXa080NkFGc2hweUY1?= =?utf-8?B?RElBTkdnUXVrT0lBMk53R0Z1dUJrcnhxYUxjc1ZPZUtVdWU4dU1MUC9WUjVF?= =?utf-8?B?M2c5ejR0RFdYclA5SGV6bVB4WXFKZG9FZittaDg1endEMVFsRmJ1bnE5ZnZG?= =?utf-8?B?OUdrTEk2Tk9Hc0ZSZVE5TEwwaWxEelpGUDN5cnVUdk41dUpqN2VhaG5qVXYz?= =?utf-8?B?MFRwWXZCY1NKY21mU0s2Y3RBMnpqejlRY2dHMnZtYXdMY1BaTDR0RzJDNWNP?= =?utf-8?B?cHdZRTh0cVhEV00rdGswSDViU1UrSzRPZlR0RUJNdHFiQktyNGFieGZMSHda?= =?utf-8?B?dWwzQmNlSnd0SnhXK0NQOXduZWRsM3hGMUNOYVBPdmtUKzNTcGVhdS9Mdys0?= =?utf-8?B?N01RUDhDV0dEWjlaeEZCV1Z0eTlIOTA2NVNNanliVWloak1sdzF5aHhvWjND?= =?utf-8?B?MXJoOGNqT0xNdnpORmtmK0pCSXh1Q3RZcTU3a21hK2pNcE5tM2MzNVVsV0VN?= =?utf-8?B?cndIUk9rVjFUMHFEa2pPa25TSlplMXNGeFZZZEN6MkZadW5JU0hHYTl1b2lj?= =?utf-8?B?K2xDZ1VLRlloZHZkK0l6VHZBcFMrOUZXSGZRcVo1MjN6dWtkazhqRFNsYjRQ?= =?utf-8?B?emlieWJRcWxtOTVoSDlySTFxR1R2MmdDWEYvbm5NOTcwRkVCY1lYdjZkK3dT?= =?utf-8?B?c2ozSHBZeTQ4UERBYnliMHI0Wi84OE40Tnk0TTdVZXJxTWJDRWtFME8vY00x?= =?utf-8?B?c0FtQ1JLVXBRWlV5OVlDbXhRMHFPQ2JBZUwxNDNTaFpzd3U2S2hOczNabkFN?= =?utf-8?B?YjBUVEwvdEVMTHJQaUVoTGtzM3c5cTRiKzAvbE1FUmFtZ24veTM2d3FzSm9w?= =?utf-8?B?R1VlSzYvaDgyT3BEdG9FTklIR25UWUluc2MrZ1VWZnJxZmNNK01IaWxZZmFn?= =?utf-8?B?Mng5a25yekV0KzZNM1VIWVJoUmdkTjB3SXVDQUhNSllzUjg4L3ZNa2xKOFFV?= =?utf-8?B?WXdscGo1UnRoTzZiL05BV2tEQXczcFpQMVdVaUZ5bjViSWxhbzVHN1BWN0Vl?= =?utf-8?B?NjZLNDFHMkV0YUNPU3FhOFlXczlEZVVLSzlRMElpMjdBODVlWk5yeE4vMHBM?= =?utf-8?Q?trx3XHbCpw06GbSurwMPemfdQ?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: d25f923b-5fad-4f8c-e1e7-08daed6e97f3 X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB5667.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2023 09:40:48.0850 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gWTaw1Ciho9bPmmEgWQK9jlmSc7SVqFmrjOEH0K5mCpsTDglV6o4zXmDKi+Hs97C3h1373ZhZ4l6ENxlXzEPjw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5775 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alex Deucher , arvind.yadav@amd.com, Christian Koenig , amd-gfx@lists.freedesktop.org, arunpravin.paneerselvam@amd.com Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On 29/12/2022 18:54, Alex Deucher wrote: > On Fri, Dec 23, 2022 at 2:37 PM Shashank Sharma wrote: >> The FW expects us to allocate atleast one page as process >> context space, and one for gang context space. This patch adds some >> object for the same. > This should be handled in the IP specific code for the MQD creation. > Each IP may have different requirements for MQD related metadata. > > Alex Noted, so 3 IP specific functions so far, .init_mqd(), .map() and .create_ctx_space(). - Shashank > >> Cc: Alex Deucher >> Cc: Christian Koenig >> >> Signed-off-by: Shashank Sharma >> --- >> drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 57 +++++++++++++++++++ >> .../drm/amd/include/amdgpu_usermode_queue.h | 8 +++ >> 2 files changed, 65 insertions(+) >> >> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c >> index b566ce4cb7f0..2a854a5e2f70 100644 >> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c >> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c >> @@ -69,6 +69,56 @@ amdgpu_userqueue_get_doorbell(struct amdgpu_device *adev, >> return 0; >> } >> >> +static int >> +amdgpu_userqueue_create_context(struct amdgpu_device *adev, struct amdgpu_usermode_queue *queue) >> +{ >> + int r; >> + struct amdgpu_userq_ctx *pctx = &queue->proc_ctx; >> + struct amdgpu_userq_ctx *gctx = &queue->gang_ctx; >> + /* >> + * The FW expects atleast one page space allocated for >> + * process context related work, and one for gang context. >> + */ >> + r = amdgpu_bo_create_kernel(adev, PAGE_SIZE, PAGE_SIZE, >> + AMDGPU_GEM_DOMAIN_VRAM, >> + &pctx->obj, >> + &pctx->gpu_addr, >> + &pctx->cpu_ptr); >> + if (r) { >> + DRM_ERROR("Failed to allocate proc bo for userqueue (%d)", r); >> + return r; >> + } >> + >> + r = amdgpu_bo_create_kernel(adev, PAGE_SIZE, PAGE_SIZE, >> + AMDGPU_GEM_DOMAIN_VRAM, >> + &gctx->obj, >> + &gctx->gpu_addr, >> + &gctx->cpu_ptr); >> + if (r) { >> + DRM_ERROR("Failed to allocate proc bo for userqueue (%d)", r); >> + amdgpu_bo_free_kernel(&pctx->obj, >> + &pctx->gpu_addr, >> + &pctx->cpu_ptr); >> + return r; >> + } >> + >> + return 0; >> +} >> + >> +static void >> +amdgpu_userqueue_free_context(struct amdgpu_device *adev, struct amdgpu_usermode_queue *queue) >> +{ >> + struct amdgpu_userq_ctx *pctx = &queue->proc_ctx; >> + struct amdgpu_userq_ctx *gctx = &queue->gang_ctx; >> + >> + amdgpu_bo_free_kernel(&pctx->obj, >> + &pctx->gpu_addr, >> + &pctx->cpu_ptr); >> + amdgpu_bo_free_kernel(&pctx->obj, >> + &gctx->gpu_addr, >> + &gctx->cpu_ptr); >> +} >> + >> static void >> amdgpu_userqueue_setup_mqd(struct amdgpu_device *adev, struct amdgpu_usermode_queue *queue) >> { >> @@ -282,6 +332,12 @@ int amdgpu_userqueue_create(struct amdgpu_device *adev, struct drm_file *filp, >> goto free_mqd; >> } >> >> + r = amdgpu_userqueue_create_context(adev, queue); >> + if (r < 0) { >> + DRM_ERROR("Failed to create context for queue\n"); >> + goto free_mqd; >> + } >> + >> ctx->userq = queue; >> args->out.q_id = queue->queue_id; >> args->out.flags = 0; >> @@ -306,6 +362,7 @@ void amdgpu_userqueue_destroy(struct amdgpu_device *adev, struct drm_file *filp, >> struct amdgpu_usermode_queue *queue = ctx->userq; >> >> mutex_lock(&adev->userq.userq_mutex); >> + amdgpu_userqueue_free_context(adev, queue); >> amdgpu_userqueue_destroy_mqd(queue); >> amdgpu_userqueue_remove_index(adev, queue); >> ctx->userq = NULL; >> diff --git a/drivers/gpu/drm/amd/include/amdgpu_usermode_queue.h b/drivers/gpu/drm/amd/include/amdgpu_usermode_queue.h >> index c1fe39ffaf72..8bf3c0be6937 100644 >> --- a/drivers/gpu/drm/amd/include/amdgpu_usermode_queue.h >> +++ b/drivers/gpu/drm/amd/include/amdgpu_usermode_queue.h >> @@ -26,6 +26,12 @@ >> >> #define AMDGPU_MAX_USERQ 512 >> >> +struct amdgpu_userq_ctx { >> + struct amdgpu_bo *obj; >> + uint64_t gpu_addr; >> + void *cpu_ptr; >> +}; >> + >> struct amdgpu_usermode_queue { >> int queue_id; >> int queue_type; >> @@ -44,6 +50,8 @@ struct amdgpu_usermode_queue { >> >> struct amdgpu_bo *mqd_obj; >> struct amdgpu_vm *vm; >> + struct amdgpu_userq_ctx proc_ctx; >> + struct amdgpu_userq_ctx gang_ctx; >> struct list_head list; >> }; >> >> -- >> 2.34.1 >>