From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Lin, Amber" Subject: Re: Kernel crash at reloading amdgpu Date: Thu, 9 May 2019 14:20:02 +0000 Message-ID: <0963a798-caaf-4356-08aa-447d22e84dc6@amd.com> References: <235b28d2-5fe9-d62d-cef2-014c7ecfcb4e@amd.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2053042946==" Return-path: In-Reply-To: Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Deucher, Alexander" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" --===============2053042946== Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_0963a798caaf435608aa447d22e84dc6amdcom_" --_000_0963a798caaf435608aa447d22e84dc6amdcom_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable Thank you Alex! It does fix the crash. (GPU post failed following that but = at least it exits gracefully.) Regards, Amber On 2019-05-08 10:48 p.m., Deucher, Alexander wrote: The attached patch should fix it. Alex ________________________________ From: amd-gfx on behalf of Lin, Amber Sent: Wednesday, May 8, 2019 4:56 PM To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Subject: Kernel crash at reloading amdgpu [CAUTION: External Email] Hi, When I do "rmmod amdgpu; modprobe amdgpu", kernel crashed. This is vega20. What happens is in amdgpu_device_init(): /* check if we need to reset the asic * E.g., driver was not cleanly unloaded previously, etc. */ if (!amdgpu_sriov_vf(adev) && amdgpu_asic_need_reset_on_init(adev)) { r =3D amdgpu_asic_reset(adev); if (r) { dev_err(adev->dev, "asic reset on init failed\n"); goto failed; } } amdgpu_asic_need_reset_on_init()/soc15_need_reset_on_init() returns true and it goes to amdgpu_asic_reset()/soc15_asic_mode1_reset(), where it calls psp_gpu_reset(): int psp_gpu_reset(struct amdgpu_device *adev) { if (adev->firmware.load_type !=3D AMDGPU_FW_LOAD_PSP) return 0; return psp_mode1_reset(&adev->psp); } Here, however, psp_mode1_reset is NOT assigned as psp_v11_0_mode1_reset() until amdgpu_device_ip_init(), which is after amdgpu_asic_reset. This null function pointer causes the kernel crash and I have to reboot my system. Does anyone have an idea how to fix this properly? BTW this is the log: [ 157.686303] PGD 0 P4D 0 [ 157.688837] Oops: 0000 [#1] SMP PTI [ 157.692331] CPU: 0 PID: 1902 Comm: kworker/0:2 Tainted: G W 5.0.0-rc1-kfd+ #6 [ 157.700760] Hardware name: ASUS All Series/X99-E WS, BIOS 1302 01/05/201= 6 [ 157.707543] Workqueue: events work_for_cpu_fn [ 157.711976] RIP: 0010:psp_gpu_reset+0x18/0x30 [amdgpu] [ 157.717106] Code: ff ff ff 5b c3 b8 ea ff ff ff c3 0f 1f 80 00 00 00 00 0f 1f 44 00 00 83 bf c8 22 01 00 02 74 03 31 c0 c3 48 8b 87 c0 23 01 00 <48> 8b 40 50 48 85 c0 74 ed 48 81 c7 88 23 01 00 e9 03 3b 8d d6 0f [ 157.735852] RSP: 0018:ffffaa2544243ce0 EFLAGS: 00010246 [ 157.741077] RAX: 0000000000000000 RBX: ffff97e946f60000 RCX: 0000000000000000 [ 157.748202] RDX: 0000000000000027 RSI: ffffffff976655a0 RDI: ffff97e946f60000 [ 157.755326] RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000002 [ 157.762459] R10: ffffaa2544243ba0 R11: 38a79ac3ec19edd5 R12: ffff97e946f75088 [ 157.769608] R13: 000000000000000a R14: ffff97e946f75128 R15: 0000000000000001 [ 157.776741] FS: 0000000000000000(0000) GS:ffff97e94f800000(0000) knlGS:0000000000000000 [ 157.784827] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 157.790564] CR2: 0000000000000050 CR3: 00000008083e6003 CR4: 00000000001606f0 [ 157.797696] Call Trace: [ 157.800184] soc15_asic_reset+0x81/0x1f0 [amdgpu] [ 157.804936] amdgpu_device_init+0xcf1/0x1800 [amdgpu] [ 157.809993] ? rcu_read_lock_sched_held+0x74/0x80 [ 157.814734] amdgpu_driver_load_kms+0x65/0x270 [amdgpu] Thanks. Regards, Amber _______________________________________________ amd-gfx mailing list amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx --_000_0963a798caaf435608aa447d22e84dc6amdcom_ Content-Type: text/html; charset="Windows-1252" Content-ID: <0DD4168CFDA1084BBF9D0592D6ACF36F-asWib9pRmPqcE4WynfumptQqCkab/8FMAL8bYrjMMd8@public.gmane.org> Content-Transfer-Encoding: quoted-printable Thank you Alex! It does fix the crash. (GPU post failed following that but = at least it exits gracefully.)

Regards,
Amber

On 2019-05-08 10:48 p.m., Deucher, Alexander= wrote:
The attached patch should fix it.

Alex

From: amd-gfx <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org> on behalf of Lin, Amber <= a class=3D"moz-txt-link-rfc2396E" href=3D"mailto:Amber.Lin-5C7GfCeVMHo@public.gmane.org"> <Amber.Lin-5C7GfCeVMHo@public.gmane.org>
Sent: Wednesday, May 8, 2019 4:56 PM
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Kernel crash at reloading amdgpu
 
[CAUTION: External Email]

Hi,

When I do "rmmod amdgpu; modprobe amdgpu", kernel crashed. This i= s
vega20. What happens is in amdgpu_device_init():


         /* check if we need to res= et the asic
          *  E.g., driver= was not cleanly unloaded previously, etc.
          */
         if (!amdgpu_sriov_vf(adev)= &&
amdgpu_asic_need_reset_on_init(adev)) {
            &nb= sp;    r =3D amdgpu_asic_reset(adev);
            &nb= sp;    if (r) {
            &nb= sp;            dev_e= rr(adev->dev, "asic reset on init failed\n");
            &nb= sp;            goto = failed;
            &nb= sp;    }
         }

amdgpu_asic_need_reset_on_init()/soc15_need_reset_on_init() returns true and it goes to amdgpu_asic_reset()/soc15_asic_mode1_reset(), where it
calls psp_gpu_reset():

         int psp_gpu_reset(struct a= mdgpu_device *adev)
         {
             if= (adev->firmware.load_type !=3D AMDGPU_FW_LOAD_PSP)
            &nb= sp;        return 0;

             re= turn psp_mode1_reset(&adev->psp);
         }

Here, however, psp_mode1_reset is NOT assigned as
psp_v11_0_mode1_reset() until amdgpu_device_ip_init(), which is after
amdgpu_asic_reset. This null function pointer causes the kernel crash
and I have to reboot my system.

Does anyone have an idea how to fix this properly?

BTW this is the log:

[  157.686303] PGD 0 P4D 0
[  157.688837] Oops: 0000 [#1] SMP PTI
[  157.692331] CPU: 0 PID: 1902 Comm: kworker/0:2 Tainted: G W
5.0.0-rc1-kfd+ #6
[  157.700760] Hardware name: ASUS All Series/X99-E WS, BIOS 1302 01/0= 5/2016
[  157.707543] Workqueue: events work_for_cpu_fn
[  157.711976] RIP: 0010:psp_gpu_reset+0x18/0x30 [amdgpu]
[  157.717106] Code: ff ff ff 5b c3 b8 ea ff ff ff c3 0f 1f 80 00 00 0= 0
00 0f 1f 44 00 00 83 bf c8 22 01 00 02 74 03 31 c0 c3 48 8b 87 c0 23 01
00 <48> 8b 40 50 48 85 c0 74 ed 48 81 c7 88 23 01 00 e9 03 3b 8d d6 0= f
[  157.735852] RSP: 0018:ffffaa2544243ce0 EFLAGS: 00010246
[  157.741077] RAX: 0000000000000000 RBX: ffff97e946f60000 RCX:
0000000000000000
[  157.748202] RDX: 0000000000000027 RSI: ffffffff976655a0 RDI:
ffff97e946f60000
[  157.755326] RBP: 0000000000000000 R08: 0000000000000000 R09:
0000000000000002
[  157.762459] R10: ffffaa2544243ba0 R11: 38a79ac3ec19edd5 R12:
ffff97e946f75088
[  157.769608] R13: 000000000000000a R14: ffff97e946f75128 R15:
0000000000000001
[  157.776741] FS:  0000000000000000(0000) GS:ffff97e94f800000(00= 00)
knlGS:0000000000000000
[  157.784827] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033<= br> [  157.790564] CR2: 0000000000000050 CR3: 00000008083e6003 CR4:
00000000001606f0
[  157.797696] Call Trace:
[  157.800184]  soc15_asic_reset+0x81/0x1f0 [amdgpu]
[  157.804936]  amdgpu_device_init+0xcf1/0x1800 [amdgpu]
[  157.809993]  ? rcu_read_lock_sched_held+0x74/0x80
[  157.814734]  amdgpu_driver_load_kms+0x65/0x270 [amdgpu]
Thanks.

Regards,
Amber
_______________________________________________
amd-gfx mailing list
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx=

--_000_0963a798caaf435608aa447d22e84dc6amdcom_-- --===============2053042946== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBt YWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4 --===============2053042946==--