Re: [PATCH v2 3/8] amd/amdkfd: Use dma_fence_check_and_signal()

["Christian König" <christian.koenig@amd.com>]

On 12/1/25 11:50, Philipp Stanner wrote:
> amdkfd is one of the few users which relies on the return code of
> dma_fence_signal(), which, so far, informs the caller whether the fence
> had already been signaled.
> 
> As there are barely any users, dma_fence signaling functions shall get
> the return value void. To do so, the few users must be ported to a
> function which preserves the old behavior.
> 
> Replace the call to dma_fence_signal() with one to
> dma_fence_check_and_signal().
> 
> Suggested-by: Christian König <christian.koenig@amd.com>
> Signed-off-by: Philipp Stanner <phasta@kernel.org>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>  drivers/gpu/drm/amd/amdkfd/kfd_process.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> index ddfe30c13e9d..4dc46ac6a65e 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> @@ -1983,10 +1983,10 @@ kfd_process_gpuid_from_node(struct kfd_process *p, struct kfd_node *node,
>  	return -EINVAL;
>  }
>  
> -static int signal_eviction_fence(struct kfd_process *p)
> +static bool signal_eviction_fence(struct kfd_process *p)
>  {
>  	struct dma_fence *ef;
> -	int ret;
> +	bool ret;
>  
>  	rcu_read_lock();
>  	ef = dma_fence_get_rcu_safe(&p->ef);
> @@ -1994,7 +1994,7 @@ static int signal_eviction_fence(struct kfd_process *p)
>  	if (!ef)
>  		return -EINVAL;
>  
> -	ret = dma_fence_signal(ef);
> +	ret = dma_fence_check_and_signal(ef);
>  	dma_fence_put(ef);
>  
>  	return ret;