From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH] drm/amd/amdgpu: Bail out of BO node creation if not enough VRAM (v2) Date: Wed, 12 Jun 2019 10:00:24 +0200 Message-ID: <0acbd9ae-65bc-52f6-df7e-b7f0c169ea6c@gmail.com> References: <20190611165444.17841-1-tom.stdenis@amd.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190611165444.17841-1-tom.stdenis-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "StDenis, Tom" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" QW0gMTEuMDYuMTkgdW0gMTg6NTQgc2NocmllYiBTdERlbmlzLCBUb206Cj4gKHYyKTogUmV0dXJu IDAgYW5kIHNldCBtZW0tPm1tX25vZGUgdG8gTlVMTC4KPgo+IFNpZ25lZC1vZmYtYnk6IFRvbSBT dCBEZW5pcyA8dG9tLnN0ZGVuaXNAYW1kLmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9h bWQvYW1kZ3B1L2FtZGdwdV92cmFtX21nci5jIHwgMTggKysrKysrKysrKysrKy0tLS0tCj4gICAx IGZpbGUgY2hhbmdlZCwgMTMgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKPgo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdnJhbV9tZ3IuYyBiL2Ry aXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV92cmFtX21nci5jCj4gaW5kZXggOGFlYTJm MjFiMjAyLi5jMjczMGU1YzEwODEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9h bWRncHUvYW1kZ3B1X3ZyYW1fbWdyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdw dS9hbWRncHVfdnJhbV9tZ3IuYwo+IEBAIC0yNzYsNyArMjc2LDcgQEAgc3RhdGljIGludCBhbWRn cHVfdnJhbV9tZ3JfbmV3KHN0cnVjdCB0dG1fbWVtX3R5cGVfbWFuYWdlciAqbWFuLAo+ICAgCXN0 cnVjdCBkcm1fbW1fbm9kZSAqbm9kZXM7Cj4gICAJZW51bSBkcm1fbW1faW5zZXJ0X21vZGUgbW9k ZTsKPiAgIAl1bnNpZ25lZCBsb25nIGxwZm4sIG51bV9ub2RlcywgcGFnZXNfcGVyX25vZGUsIHBh Z2VzX2xlZnQ7Cj4gLQl1aW50NjRfdCB1c2FnZSA9IDAsIHZpc191c2FnZSA9IDA7Cj4gKwl1aW50 NjRfdCB2aXNfdXNhZ2UgPSAwOwo+ICAgCXVuc2lnbmVkIGk7Cj4gICAJaW50IHI7Cj4gICAKPiBA QCAtMjg0LDYgKzI4NCwxNCBAQCBzdGF0aWMgaW50IGFtZGdwdV92cmFtX21ncl9uZXcoc3RydWN0 IHR0bV9tZW1fdHlwZV9tYW5hZ2VyICptYW4sCj4gICAJaWYgKCFscGZuKQo+ICAgCQlscGZuID0g bWFuLT5zaXplOwo+ICAgCj4gKwkvKiBiYWlsIG91dCBxdWlja2x5IGlmIHRoZXJlJ3MgbGlrZWx5 IG5vdCBlbm91Z2ggVlJBTSBmb3IgdGhpcyBCTyAqLwo+ICsJYXRvbWljNjRfYWRkKG1lbS0+bnVt X3BhZ2VzIDw8IFBBR0VfU0hJRlQsICZtZ3ItPnVzYWdlKTsKPiArCWlmIChhdG9taWM2NF9yZWFk KCZtZ3ItPnVzYWdlKSA+IGFkZXYtPmdtYy5tY192cmFtX3NpemUpIHsKCllvdSBzaG91bGQgdXNl IGF0b21pYzY0X2FkZF9yZXR1cm4gaGVyZSBpbnN0ZWFkIG9mIHR3byBvcGVyYXRpb25zLiAKT3Ro ZXJ3aXNlIHVzaW5nIGFuIGF0b21pYyBkb2Vzbid0IG1ha2UgdG8gbXVjaCBzZW5zZS4KCkNocmlz dGlhbi4KCj4gKwkJYXRvbWljNjRfc3ViKG1lbS0+bnVtX3BhZ2VzIDw8IFBBR0VfU0hJRlQsICZt Z3ItPnVzYWdlKTsKPiArCQltZW0tPm1tX25vZGUgPSBOVUxMOwo+ICsJCXJldHVybiAwOwo+ICsJ fQo+ICsKPiAgIAlpZiAocGxhY2UtPmZsYWdzICYgVFRNX1BMX0ZMQUdfQ09OVElHVU9VUykgewo+ ICAgCQlwYWdlc19wZXJfbm9kZSA9IH4wdWw7Cj4gICAJCW51bV9ub2RlcyA9IDE7Cj4gQEAgLTMw MCw4ICszMDgsMTAgQEAgc3RhdGljIGludCBhbWRncHVfdnJhbV9tZ3JfbmV3KHN0cnVjdCB0dG1f bWVtX3R5cGVfbWFuYWdlciAqbWFuLAo+ICAgCj4gICAJbm9kZXMgPSBrdm1hbGxvY19hcnJheSgo dWludDMyX3QpbnVtX25vZGVzLCBzaXplb2YoKm5vZGVzKSwKPiAgIAkJCSAgICAgICBHRlBfS0VS TkVMIHwgX19HRlBfWkVSTyk7Cj4gLQlpZiAoIW5vZGVzKQo+ICsJaWYgKCFub2Rlcykgewo+ICsJ CWF0b21pYzY0X3N1YihtZW0tPm51bV9wYWdlcyA8PCBQQUdFX1NISUZULCAmbWdyLT51c2FnZSk7 Cj4gICAJCXJldHVybiAtRU5PTUVNOwo+ICsJfQo+ICAgCj4gICAJbW9kZSA9IERSTV9NTV9JTlNF UlRfQkVTVDsKPiAgIAlpZiAocGxhY2UtPmZsYWdzICYgVFRNX1BMX0ZMQUdfVE9QRE9XTikKPiBA QCAtMzIxLDcgKzMzMSw2IEBAIHN0YXRpYyBpbnQgYW1kZ3B1X3ZyYW1fbWdyX25ldyhzdHJ1Y3Qg dHRtX21lbV90eXBlX21hbmFnZXIgKm1hbiwKPiAgIAkJaWYgKHVubGlrZWx5KHIpKQo+ICAgCQkJ YnJlYWs7Cj4gICAKPiAtCQl1c2FnZSArPSBub2Rlc1tpXS5zaXplIDw8IFBBR0VfU0hJRlQ7Cj4g ICAJCXZpc191c2FnZSArPSBhbWRncHVfdnJhbV9tZ3JfdmlzX3NpemUoYWRldiwgJm5vZGVzW2ld KTsKPiAgIAkJYW1kZ3B1X3ZyYW1fbWdyX3ZpcnRfc3RhcnQobWVtLCAmbm9kZXNbaV0pOwo+ICAg CQlwYWdlc19sZWZ0IC09IHBhZ2VzOwo+IEBAIC0zNDEsMTQgKzM1MCwxMiBAQCBzdGF0aWMgaW50 IGFtZGdwdV92cmFtX21ncl9uZXcoc3RydWN0IHR0bV9tZW1fdHlwZV9tYW5hZ2VyICptYW4sCj4g ICAJCWlmICh1bmxpa2VseShyKSkKPiAgIAkJCWdvdG8gZXJyb3I7Cj4gICAKPiAtCQl1c2FnZSAr PSBub2Rlc1tpXS5zaXplIDw8IFBBR0VfU0hJRlQ7Cj4gICAJCXZpc191c2FnZSArPSBhbWRncHVf dnJhbV9tZ3JfdmlzX3NpemUoYWRldiwgJm5vZGVzW2ldKTsKPiAgIAkJYW1kZ3B1X3ZyYW1fbWdy X3ZpcnRfc3RhcnQobWVtLCAmbm9kZXNbaV0pOwo+ICAgCQlwYWdlc19sZWZ0IC09IHBhZ2VzOwo+ ICAgCX0KPiAgIAlzcGluX3VubG9jaygmbWdyLT5sb2NrKTsKPiAgIAo+IC0JYXRvbWljNjRfYWRk KHVzYWdlLCAmbWdyLT51c2FnZSk7Cj4gICAJYXRvbWljNjRfYWRkKHZpc191c2FnZSwgJm1nci0+ dmlzX3VzYWdlKTsKPiAgIAo+ICAgCW1lbS0+bW1fbm9kZSA9IG5vZGVzOwo+IEBAIC0zNTksNiAr MzY2LDcgQEAgc3RhdGljIGludCBhbWRncHVfdnJhbV9tZ3JfbmV3KHN0cnVjdCB0dG1fbWVtX3R5 cGVfbWFuYWdlciAqbWFuLAo+ICAgCXdoaWxlIChpLS0pCj4gICAJCWRybV9tbV9yZW1vdmVfbm9k ZSgmbm9kZXNbaV0pOwo+ICAgCXNwaW5fdW5sb2NrKCZtZ3ItPmxvY2spOwo+ICsJYXRvbWljNjRf c3ViKG1lbS0+bnVtX3BhZ2VzIDw8IFBBR0VfU0hJRlQsICZtZ3ItPnVzYWdlKTsKPiAgIAo+ICAg CWt2ZnJlZShub2Rlcyk7Cj4gICAJcmV0dXJuIHIgPT0gLUVOT1NQQyA/IDAgOiByOwoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5n IGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4