From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: Eric Anholt <eric@anholt.net>,
"Koenig, Christian" <Christian.Koenig@amd.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/sched: Always trace the dependencies we wait on, to fix a race.
Date: Fri, 8 Feb 2019 09:43:04 +0100 [thread overview]
Message-ID: <0d7c09cf-caeb-c706-928e-2a668ae78e53@gmail.com> (raw)
In-Reply-To: <87tvhf2o0l.fsf@anholt.net>
[-- Attachment #1.1: Type: text/plain, Size: 1082 bytes --]
Am 08.02.19 um 00:10 schrieb Eric Anholt:
> "Koenig, Christian" <Christian.Koenig@amd.com> writes:
>
>> Am 07.12.18 um 20:16 schrieb Eric Anholt:
>>> The entity->dependency can go away completely once we've called
>>> drm_sched_entity_add_dependency_cb() (if the cb is called before we
>>> get around to tracing). The tracepoint is more useful if we trace
>>> every dependency instead of just ones that get callbacks installed,
>>> anyway, so just do that.
>>>
>>> Fixes any easy-to-produce OOPS when tracing the scheduler on V3D with
>>> "perf record -a -e gpu_scheduler:.\* glxgears" and DEBUG_SLAB enabled.
>>>
>>> Signed-off-by: Eric Anholt <eric@anholt.net>
>> Reviewed-by: Christian König <christian.koenig@amd.com>
>>
>> Going to pick that up for upstream and will add with a CC: stable.
> Looks like this got misplaced.
My fault, pushed to our internal branch now with a CC: stable tag on it.
Christian.
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[-- Attachment #1.2: Type: text/html, Size: 2338 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2019-02-08 8:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 19:16 [PATCH] drm/sched: Always trace the dependencies we wait on, to fix a race Eric Anholt
2018-12-07 19:46 ` Koenig, Christian
2019-02-07 23:10 ` Eric Anholt
2019-02-08 8:43 ` Christian König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d7c09cf-caeb-c706-928e-2a668ae78e53@gmail.com \
--to=ckoenig.leichtzumerken@gmail.com \
--cc=Christian.Koenig@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox