AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Harry Wentland <harry.wentland@amd.com>
To: Alex Hung <alex.hung@amd.com>,
	dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org
Cc: wayland-devel@lists.freedesktop.org, leo.liu@amd.com,
	ville.syrjala@linux.intel.com, pekka.paalanen@collabora.com,
	contact@emersion.fr, mwen@igalia.com, jadahl@redhat.com,
	sebastian.wick@redhat.com, shashank.sharma@amd.com,
	agoins@nvidia.com, joshua@froggi.es, mdaenzer@redhat.com,
	aleixpol@kde.org, xaver.hugl@gmail.com, victoria@system76.com,
	daniel@ffwll.ch, uma.shankar@intel.com, quic_naseer@quicinc.com,
	quic_cbraga@quicinc.com, quic_abhinavk@quicinc.com,
	marcan@marcan.st, Liviu.Dudau@arm.com, sashamcintosh@google.com,
	chaitanya.kumar.borah@intel.com, louis.chauvet@bootlin.com,
	mcanal@igalia.com, nfraprado@collabora.com,
	arthurgrillo@riseup.net
Subject: Re: [PATCH V12 49/49] drm/amd/display: Enable support for Gamma 2.2
Date: Thu, 13 Nov 2025 14:50:23 -0500	[thread overview]
Message-ID: <0fb38eee-d090-4a06-9dfa-3a1af3a6dec9@amd.com> (raw)
In-Reply-To: <20251030034349.2309829-50-alex.hung@amd.com>



On 2025-10-29 23:42, Alex Hung wrote:
> This patchset enables support for the Gamma 2.2.
> 
> With this patch the following IGT subtests pass:
> 
> kms_colorop --run plane-XR30-XR30-gamma_2_2
> 
> kms_colorop --run plane-XR30-XR30-gamma_2_2_inv-gamma_2_2
> 
> kms_colorop --run plane-XR30-XR30-gamma_2_2_inv-gamma_2_2-gamma_2_2_inv
> 
> Signed-off-by: Alex Hung <alex.hung@amd.com>

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
> v12:
>  - Add gamma 2.2
> 
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c  | 3 +++
>  .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_colorop.c    | 9 ++++++---
>  2 files changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c
> index c3ddf136dbc8..6992067fd7d2 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c
> @@ -890,6 +890,9 @@ amdgpu_colorop_tf_to_dc_tf(enum drm_colorop_curve_1d_type tf)
>  	case DRM_COLOROP_1D_CURVE_BT2020_INV_OETF:
>  	case DRM_COLOROP_1D_CURVE_BT2020_OETF:
>  		return TRANSFER_FUNCTION_BT709;
> +	case DRM_COLOROP_1D_CURVE_GAMMA22:
> +	case DRM_COLOROP_1D_CURVE_GAMMA22_INV:
> +		return TRANSFER_FUNCTION_GAMMA22;
>  	default:
>  		return TRANSFER_FUNCTION_LINEAR;
>  	}
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_colorop.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_colorop.c
> index f205f3c31f6a..64a4757d778b 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_colorop.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_colorop.c
> @@ -36,17 +36,20 @@
>  const u64 amdgpu_dm_supported_degam_tfs =
>  	BIT(DRM_COLOROP_1D_CURVE_SRGB_EOTF) |
>  	BIT(DRM_COLOROP_1D_CURVE_PQ_125_EOTF) |
> -	BIT(DRM_COLOROP_1D_CURVE_BT2020_INV_OETF);
> +	BIT(DRM_COLOROP_1D_CURVE_BT2020_INV_OETF) |
> +	BIT(DRM_COLOROP_1D_CURVE_GAMMA22_INV);
>  
>  const u64 amdgpu_dm_supported_shaper_tfs =
>  	BIT(DRM_COLOROP_1D_CURVE_SRGB_INV_EOTF) |
>  	BIT(DRM_COLOROP_1D_CURVE_PQ_125_INV_EOTF) |
> -	BIT(DRM_COLOROP_1D_CURVE_BT2020_OETF);
> +	BIT(DRM_COLOROP_1D_CURVE_BT2020_OETF) |
> +	BIT(DRM_COLOROP_1D_CURVE_GAMMA22);
>  
>  const u64 amdgpu_dm_supported_blnd_tfs =
>  	BIT(DRM_COLOROP_1D_CURVE_SRGB_EOTF) |
>  	BIT(DRM_COLOROP_1D_CURVE_PQ_125_EOTF) |
> -	BIT(DRM_COLOROP_1D_CURVE_BT2020_INV_OETF);
> +	BIT(DRM_COLOROP_1D_CURVE_BT2020_INV_OETF) |
> +	BIT(DRM_COLOROP_1D_CURVE_GAMMA22_INV);
>  
>  #define MAX_COLOR_PIPELINE_OPS 10
>  


      reply	other threads:[~2025-11-13 19:50 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-30  3:42 [PATCH V12 00/49] Color Pipeline API w/ VKMS Alex Hung
2025-10-30  3:42 ` [PATCH V12 01/49] drm: Add helper for conversion from signed-magnitude Alex Hung
2025-10-30  3:42 ` [PATCH V12 02/49] drm/vkms: Add kunit tests for VKMS LUT handling Alex Hung
2025-10-30 14:50   ` Louis Chauvet
2025-10-31  0:01     ` Alex Hung
2025-10-30  3:42 ` [PATCH V12 03/49] drm/doc/rfc: Describe why prescriptive color pipeline is needed Alex Hung
2025-10-30  3:42 ` [PATCH V12 04/49] drm/colorop: Introduce new drm_colorop mode object Alex Hung
2025-10-30  3:42 ` [PATCH V12 05/49] drm/colorop: Add TYPE property Alex Hung
2025-10-30  3:42 ` [PATCH V12 06/49] drm/colorop: Add 1D Curve subtype Alex Hung
2025-10-30  3:42 ` [PATCH V12 07/49] drm/colorop: Add BYPASS property Alex Hung
2025-10-30  3:42 ` [PATCH V12 08/49] drm/colorop: Add NEXT property Alex Hung
2025-10-30  3:42 ` [PATCH V12 09/49] drm/colorop: Add atomic state print for drm_colorop Alex Hung
2025-10-30  3:42 ` [PATCH V12 10/49] drm/plane: Add COLOR PIPELINE property Alex Hung
2025-10-30  3:42 ` [PATCH V12 11/49] drm/colorop: Introduce DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE Alex Hung
2025-10-30  3:42 ` [PATCH V12 12/49] Documentation/gpu: document drm_colorop Alex Hung
2025-10-30  3:42 ` [PATCH V12 13/49] drm/colorop: Add destroy functions for color pipeline Alex Hung
2025-10-30  3:42 ` [PATCH V12 14/49] drm/vkms: Add enumerated 1D curve colorop Alex Hung
2025-10-30 14:50   ` Louis Chauvet
2025-10-31  0:04     ` Alex Hung
2025-10-31 10:15       ` Louis Chauvet
2025-10-31 22:28         ` Alex Hung
2025-10-30  3:42 ` [PATCH V12 15/49] drm/vkms: Add kunit tests for linear and sRGB LUTs Alex Hung
2025-10-30  3:42 ` [PATCH V12 16/49] drm/colorop: Add 3x4 CTM type Alex Hung
2025-10-30  3:42 ` [PATCH V12 17/49] drm/vkms: Use s32 for internal color pipeline precision Alex Hung
2025-10-30  3:42 ` [PATCH V12 18/49] drm/vkms: add 3x4 matrix in color pipeline Alex Hung
2025-10-30  3:42 ` [PATCH V12 19/49] drm/tests: Add a few tests around drm_fixed.h Alex Hung
2025-10-30  3:42 ` [PATCH V12 20/49] drm/vkms: Add tests for CTM handling Alex Hung
2025-10-30  3:42 ` [PATCH V12 21/49] drm/colorop: pass plane_color_pipeline client cap to atomic check Alex Hung
2025-10-30  3:42 ` [PATCH V12 22/49] drm/colorop: define a new macro for_each_new_colorop_in_state Alex Hung
2025-10-30  3:42 ` [PATCH V12 23/49] drm/amd/display: Ignore deprecated props when plane_color_pipeline set Alex Hung
2025-10-30  3:42 ` [PATCH V12 24/49] drm/amd/display: Add bypass COLOR PIPELINE Alex Hung
2025-10-30  3:42 ` [PATCH V12 25/49] drm/amd/display: Skip color pipeline initialization for cursor plane Alex Hung
2025-10-30  3:42 ` [PATCH V12 26/49] drm/amd/display: Add support for sRGB EOTF in DEGAM block Alex Hung
2025-10-30  3:42 ` [PATCH V12 27/49] drm/amd/display: Add support for sRGB Inverse EOTF in SHAPER block Alex Hung
2025-10-30  3:42 ` [PATCH V12 28/49] drm/amd/display: Add support for sRGB EOTF in BLND block Alex Hung
2025-10-30  3:42 ` [PATCH V12 29/49] drm/colorop: Add PQ 125 EOTF and its inverse Alex Hung
2025-10-30  3:42 ` [PATCH V12 30/49] drm/amd/display: Enable support for PQ 125 EOTF and Inverse Alex Hung
2025-10-30  3:42 ` [PATCH V12 31/49] drm/colorop: add BT2020/BT709 OETF and Inverse OETF Alex Hung
2025-10-30  3:42 ` [PATCH V12 32/49] drm/amd/display: Add support for BT.709 and BT.2020 TFs Alex Hung
2025-10-30  3:42 ` [PATCH V12 33/49] drm: Add Enhanced LUT precision structure Alex Hung
2025-10-30  3:42 ` [PATCH V12 34/49] drm: Add helper to extract lut from struct drm_color_lut32 Alex Hung
2025-10-30  3:42 ` [PATCH V12 35/49] drm/colorop: Add 1D Curve Custom LUT type Alex Hung
2025-10-30  3:42 ` [PATCH V12 36/49] drm/amd/display: add shaper and blend colorops for 1D Curve Custom LUT Alex Hung
2025-10-30  3:42 ` [PATCH V12 37/49] drm/amd/display: add 3x4 matrix colorop Alex Hung
2025-10-30  3:42 ` [PATCH V12 38/49] drm/colorop: Add multiplier type Alex Hung
2025-10-30  3:42 ` [PATCH V12 39/49] drm/amd/display: add multiplier colorop Alex Hung
2025-10-30  3:42 ` [PATCH V12 40/49] drm/amd/display: Swap matrix and multiplier Alex Hung
2025-10-30  3:42 ` [PATCH V12 41/49] drm/colorop: Define LUT_1D interpolation Alex Hung
2025-10-30  3:42 ` [PATCH V12 42/49] drm/colorop: allow non-bypass colorops Alex Hung
2025-10-30  3:42 ` [PATCH V12 43/49] drm/colorop: Add 3D LUT support to color pipeline Alex Hung
2025-10-30  3:42 ` [PATCH V12 44/49] drm/amd/display: add 3D LUT colorop Alex Hung
2025-10-30  3:42 ` [PATCH V12 45/49] drm/amd/display: Add AMD color pipeline doc Alex Hung
2025-10-30  3:42 ` [PATCH V12 46/49] drm/amd/display: Ensure 3D LUT for color pipeline Alex Hung
2025-11-13 19:40   ` Harry Wentland
2025-10-30  3:42 ` [PATCH V12 47/49] drm/amd/display: Disable CRTC degamma when color pipeline is enabled Alex Hung
2025-11-13 19:46   ` Harry Wentland
2025-10-30  3:42 ` [PATCH V12 48/49] drm/colorop: Add DRM_COLOROP_1D_CURVE_GAMMA22 to 1D Curve Alex Hung
2025-11-13 19:47   ` Harry Wentland
2025-10-30  3:42 ` [PATCH V12 49/49] drm/amd/display: Enable support for Gamma 2.2 Alex Hung
2025-11-13 19:50   ` Harry Wentland [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0fb38eee-d090-4a06-9dfa-3a1af3a6dec9@amd.com \
    --to=harry.wentland@amd.com \
    --cc=Liviu.Dudau@arm.com \
    --cc=agoins@nvidia.com \
    --cc=aleixpol@kde.org \
    --cc=alex.hung@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=arthurgrillo@riseup.net \
    --cc=chaitanya.kumar.borah@intel.com \
    --cc=contact@emersion.fr \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jadahl@redhat.com \
    --cc=joshua@froggi.es \
    --cc=leo.liu@amd.com \
    --cc=louis.chauvet@bootlin.com \
    --cc=marcan@marcan.st \
    --cc=mcanal@igalia.com \
    --cc=mdaenzer@redhat.com \
    --cc=mwen@igalia.com \
    --cc=nfraprado@collabora.com \
    --cc=pekka.paalanen@collabora.com \
    --cc=quic_abhinavk@quicinc.com \
    --cc=quic_cbraga@quicinc.com \
    --cc=quic_naseer@quicinc.com \
    --cc=sashamcintosh@google.com \
    --cc=sebastian.wick@redhat.com \
    --cc=shashank.sharma@amd.com \
    --cc=uma.shankar@intel.com \
    --cc=victoria@system76.com \
    --cc=ville.syrjala@linux.intel.com \
    --cc=wayland-devel@lists.freedesktop.org \
    --cc=xaver.hugl@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox