Re: [PATCH] drm/amdgpu/display: fix build when CONFIG_DRM_AMD_DC_DCN is not set

["Kazlauskas, Nicholas" <nicholas.kazlauskas@amd.com>]

On 2021-10-28 10:46 a.m., Alex Deucher wrote:
> ping
> 
> On Wed, Oct 27, 2021 at 6:40 PM Alex Deucher <alexander.deucher@amd.com> wrote:
>>
>> Need to guard some things with CONFIG_DRM_AMD_DC_DCN.
>>
>> Fixes: 707021dc0e16f6 ("drm/amd/display: Enable dpia in dmub only for DCN31 B0")
>> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>

Though this whole function could be guarded by DCN, DMUB doesn't exist 
on DCE.

Regards,
Nicholas Kazlauskas

>> ---
>>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> index 3f36dbb2c663..6dd6262f2769 100644
>> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> @@ -1108,7 +1108,9 @@ static int dm_dmub_hw_init(struct amdgpu_device *adev)
>>          case CHIP_YELLOW_CARP:
>>                  if (dc->ctx->asic_id.hw_internal_rev != YELLOW_CARP_A0) {
>>                          hw_params.dpia_supported = true;
>> +#if defined(CONFIG_DRM_AMD_DC_DCN)
>>                          hw_params.disable_dpia = dc->debug.dpia_debug.bits.disable_dpia;
>> +#endif
>>                  }
>>                  break;
>>          default:
>> --
>> 2.31.1
>>