From: Markus Elfring <Markus.Elfring@web.de>
To: "Haoxiang Li" <lihaoxiang@isrc.iscas.ac.cn>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"David Airlie" <airlied@gmail.com>,
"Felix Kühling" <felix.kuehling@amd.com>,
"Oak Zeng" <ozeng@amd.com>, "Simona Vetter" <simona@ffwll.ch>
Cc: stable@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] drm/amdkfd: fix a memory leak in device_queue_manager_init()
Date: Fri, 9 Jan 2026 17:23:54 +0100 [thread overview]
Message-ID: <12cd71cb-4139-413e-918c-6245d5d4f10a@web.de> (raw)
In-Reply-To: <20260108071822.297364-1-lihaoxiang@isrc.iscas.ac.cn>
…
> Move deallocate_hiq_sdma_mqd() up to ensure proper function
> visibility at the point of use.
…
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> @@ -2919,6 +2919,14 @@ static int allocate_hiq_sdma_mqd(struct device_queue_manager *dqm)
> return retval;
> }
>
> +static void deallocate_hiq_sdma_mqd(struct kfd_node *dev,
> + struct kfd_mem_obj *mqd)
> +{
> + WARN(!mqd, "No hiq sdma mqd trunk to free");
Can this macro call be omitted here?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.19-rc4#n1242
> +
> + amdgpu_amdkfd_free_gtt_mem(dev->adev, &mqd->gtt_mem);
> +}
…
Regards,
Markus
prev parent reply other threads:[~2026-01-10 17:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 7:18 [PATCH v3] drm/amdkfd: fix a memory leak in device_queue_manager_init() Haoxiang Li
2026-01-09 16:23 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12cd71cb-4139-413e-918c-6245d5d4f10a@web.de \
--to=markus.elfring@web.de \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=felix.kuehling@amd.com \
--cc=lihaoxiang@isrc.iscas.ac.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=ozeng@amd.com \
--cc=simona@ffwll.ch \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox