AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Nicolai Hähnle" <nhaehnle-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: [PATCH 0/5] drm/ttm, amdgpu: fix crashes due to shadow page table evictions
Date: Thu, 15 Dec 2016 18:10:10 +0100	[thread overview]
Message-ID: <1481821815-9971-1-git-send-email-nhaehnle@gmail.com> (raw)

Fix a bunch of related crashes in amdgpu that occur when shadow page tables
are kicked out of the GART.

One of the issues was that during command submission, we rely on a
device-global evictions counter to skip some of the work of page-table
validation. The driver was never informed of evictions from GART, so this
series adds an evict parameter to ttm_bo_driver::move_notify.

There's still the evict parameter on ttm_bo_driver::move which is used by
radeon and nouveau for the call to ttm_bo_move_accel_cleanup. The 'evict'
parameter there should probably be more accurately called 'wait', but unless
that wait can always be avoided, the evict parameter on ttm_bo_driver::move
needs to stay.

Please review!
Nicolai
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c    | 20 ++++++++++++++------
 drivers/gpu/drm/amd/amdgpu/amdgpu_object.c |  5 +++++
 drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 12 +++++++++++-
 drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c    |  4 ----
 drivers/gpu/drm/nouveau/nouveau_bo.c       |  3 ++-
 drivers/gpu/drm/qxl/qxl_ttm.c              |  1 +
 drivers/gpu/drm/radeon/radeon_object.c     |  1 +
 drivers/gpu/drm/radeon/radeon_object.h     |  1 +
 drivers/gpu/drm/ttm/ttm_bo.c               |  8 ++++----
 drivers/gpu/drm/virtio/virtgpu_ttm.c       |  1 +
 drivers/gpu/drm/vmwgfx/vmwgfx_buffer.c     |  1 +
 include/drm/ttm/ttm_bo_driver.h            | 10 ++++++++--
 12 files changed, 49 insertions(+), 18 deletions(-)

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

             reply	other threads:[~2016-12-15 17:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-15 17:10 Nicolai Hähnle [this message]
     [not found] ` <1481821815-9971-1-git-send-email-nhaehnle-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-12-15 17:10   ` [PATCH 1/5] drm/ttm: add evict parameter to ttm_bo_driver::move_notify Nicolai Hähnle
     [not found]     ` <1481821815-9971-2-git-send-email-nhaehnle-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-12-16  2:49       ` zhoucm1
     [not found]         ` <5853564E.5020005-5C7GfCeVMHo@public.gmane.org>
2016-12-21 15:12           ` Nicolai Hähnle
     [not found]             ` <8f68adf1-52bc-b2ef-2fa7-79a8f9695164-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-01-03 11:42               ` Christian König
2016-12-15 17:10   ` [PATCH 2/5] drm/amd/amdgpu: move eviction counting to amdgpu_bo_move_notify Nicolai Hähnle
     [not found]     ` <1481821815-9971-3-git-send-email-nhaehnle-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-12-16  2:50       ` zhoucm1
2016-12-15 17:10   ` [PATCH 3/5] drm/amd/amdgpu: add amdgpu_bo_gpu_accessible helper function Nicolai Hähnle
     [not found]     ` <1481821815-9971-4-git-send-email-nhaehnle-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-12-16  2:48       ` zhoucm1
2016-12-15 17:10   ` [PATCH 4/5] drm/amd/amdgpu: add check that shadow page directory is GPU-accessible Nicolai Hähnle
     [not found]     ` <1481821815-9971-5-git-send-email-nhaehnle-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-12-16  2:49       ` zhoucm1
2016-12-15 17:10   ` [PATCH 5/5] drm/amd/amdgpu: add check that shadow page tables are GPU-accessible Nicolai Hähnle
     [not found]     ` <1481821815-9971-6-git-send-email-nhaehnle-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-12-15 17:59       ` [PATCH v2] " Nicolai Hähnle
     [not found]         ` <1481824743-11139-1-git-send-email-nhaehnle-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-12-16  2:48           ` zhoucm1
2016-12-16  2:07       ` [PATCH 5/5] " zhoucm1

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1481821815-9971-1-git-send-email-nhaehnle@gmail.com \
    --to=nhaehnle-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox