From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lucas Stach Subject: Re: [PATCH 1/3] drm/v3d: Take a lock across GPU scheduler job creation and queuing. Date: Wed, 06 Jun 2018 10:46:37 +0200 Message-ID: <1528274797.26063.6.camel@pengutronix.de> References: <20180605190302.18279-1-eric@anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180605190302.18279-1-eric@anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Eric Anholt , dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org List-Id: amd-gfx.lists.freedesktop.org QW0gRGllbnN0YWcsIGRlbiAwNS4wNi4yMDE4LCAxMjowMyAtMDcwMCBzY2hyaWViIEVyaWMgQW5o b2x0Ogo+IEJldHdlZW4gY3JlYXRpb24gYW5kIHF1ZXVlaW5nIG9mIGEgam9iLCB5b3UgbmVlZCB0 byBwcmV2ZW50IGFueSBvdGhlcgo+IGpvYiBmcm9tIGJlaW5nIGNyZWF0ZWQgYW5kIHF1ZXVlZC7C oMKgT3RoZXJ3aXNlIHRoZSBzY2hlZHVsZXIncyBmZW5jZXMKPiBtYXkgYmUgc2lnbmFsZWQgb3V0 IG9mIHNlcW5vIG9yZGVyLgo+IAo+ID4gU2lnbmVkLW9mZi1ieTogRXJpYyBBbmhvbHQgPGVyaWNA YW5ob2x0Lm5ldD4KPiBGaXhlczogNTc2OTJjOTRkY2JlICgiZHJtL3YzZDogSW50cm9kdWNlIGEg bmV3IERSTSBkcml2ZXIgZm9yIEJyb2FkY29tIFYzRCBWMy54KyIpCj4gLS0tCj4gCj4gY2Npbmcg YW1kLWdmeCBkdWUgdG8gaW50ZXJhY3Rpb24gb2YgdGhpcyBzZXJpZXMgd2l0aCB0aGUgc2NoZWR1 bGVyLgo+IAo+IMKgZHJpdmVycy9ncHUvZHJtL3YzZC92M2RfZHJ2LmggfMKgwqA1ICsrKysrCj4g wqBkcml2ZXJzL2dwdS9kcm0vdjNkL3YzZF9nZW0uYyB8IDExICsrKysrKysrKy0tCj4gwqAyIGZp bGVzIGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS92M2QvdjNkX2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL3Yz ZC92M2RfZHJ2LmgKPiBpbmRleCBhMDQzYWMzYWFlOTguLjI2MDA1YWJkOWM1ZCAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vdjNkL3YzZF9kcnYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS92M2QvdjNkX2Rydi5oCj4gQEAgLTg1LDYgKzg1LDExIEBAIHN0cnVjdCB2M2RfZGV2IHsKPiA+ IMKgCcKgKi8KPiA+IMKgCXN0cnVjdCBtdXRleCByZXNldF9sb2NrOwo+IMKgCj4gPiArCS8qIExv Y2sgdGFrZW4gd2hlbiBjcmVhdGluZyBhbmQgcHVzaGluZyB0aGUgR1BVIHNjaGVkdWxlcgo+ID4g KwnCoCogam9icywgdG8ga2VlcCB0aGUgc2NoZWQtZmVuY2Ugc2Vxbm9zIGluIG9yZGVyLgo+ID4g KwnCoCovCj4gPiArCXN0cnVjdCBtdXRleCBzY2hlZF9sb2NrOwo+ICsKPiA+IMKgCXN0cnVjdCB7 Cj4gPiDCoAkJdTMyIG51bV9hbGxvY2F0ZWQ7Cj4gPiDCoAkJdTMyIHBhZ2VzX2FsbG9jYXRlZDsK PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3YzZC92M2RfZ2VtLmMgYi9kcml2ZXJzL2dw dS9kcm0vdjNkL3YzZF9nZW0uYwo+IGluZGV4IGI1MTNmOTE4OWNhZi4uOWVhODNiZGI5YTMwIDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS92M2QvdjNkX2dlbS5jCj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL3YzZC92M2RfZ2VtLmMKPiBAQCAtNTUwLDEzICs1NTAsMTYgQEAgdjNkX3N1Ym1p dF9jbF9pb2N0bChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB2b2lkICpkYXRhLAo+ID4gwqAJaWYg KHJldCkKPiA+IMKgCQlnb3RvIGZhaWw7Cj4gwqAKPiA+ICsJbXV0ZXhfbG9jaygmdjNkLT5zY2hl ZF9sb2NrKTsKPiA+IMKgCWlmIChleGVjLT5iaW4uc3RhcnQgIT0gZXhlYy0+YmluLmVuZCkgewo+ ID4gwqAJCXJldCA9IGRybV9zY2hlZF9qb2JfaW5pdCgmZXhlYy0+YmluLmJhc2UsCj4gPiDCoAkJ CQkJwqAmdjNkLT5xdWV1ZVtWM0RfQklOXS5zY2hlZCwKPiA+IMKgCQkJCQnCoCZ2M2RfcHJpdi0+ c2NoZWRfZW50aXR5W1YzRF9CSU5dLAo+ID4gwqAJCQkJCcKgdjNkX3ByaXYpOwo+ID4gLQkJaWYg KHJldCkKPiA+ICsJCWlmIChyZXQpIHsKPiA+ICsJCQltdXRleF91bmxvY2soJnYzZC0+c2NoZWRf bG9jayk7Cj4gwqAJCQlnb3RvIGZhaWxfdW5yZXNlcnZlOwoKSSBkb24ndCBzZWUgYW55IHBhdGgg d2hlcmUgeW91IHdvdWxkIGdvIHRvIGZhaWxfdW5yZXNlcnZlIHdpdGggdGhlCm11dGV4IG5vdCB5 ZXQgbG9ja2VkLCBzbyB5b3UgY291bGQganVzdCBmb2xkIHRoZSBtdXRleF91bmxvY2sgaW50byB0 aGlzCmVycm9yIHBhdGggZm9yIGEgYml0IGxlc3MgY29kZSBkdXBsaWNhdGlvbi4KCk90aGVyd2lz ZSB0aGlzIGxvb2tzIGZpbmUuCgpSZWdhcmRzLApMdWNhcwoKPiArCQl9Cj4gwqAKPiA+IMKgCQll eGVjLT5iaW5fZG9uZV9mZW5jZSA9Cj4gPiDCoAkJCWRtYV9mZW5jZV9nZXQoJmV4ZWMtPmJpbi5i YXNlLnNfZmVuY2UtPmZpbmlzaGVkKTsKPiBAQCAtNTcwLDEyICs1NzMsMTUgQEAgdjNkX3N1Ym1p dF9jbF9pb2N0bChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB2b2lkICpkYXRhLAo+ID4gwqAJCQkJ wqAmdjNkLT5xdWV1ZVtWM0RfUkVOREVSXS5zY2hlZCwKPiA+IMKgCQkJCcKgJnYzZF9wcml2LT5z Y2hlZF9lbnRpdHlbVjNEX1JFTkRFUl0sCj4gPiDCoAkJCQnCoHYzZF9wcml2KTsKPiA+IC0JaWYg KHJldCkKPiA+ICsJaWYgKHJldCkgewo+ID4gKwkJbXV0ZXhfdW5sb2NrKCZ2M2QtPnNjaGVkX2xv Y2spOwo+ID4gwqAJCWdvdG8gZmFpbF91bnJlc2VydmU7Cj4gPiArCX0KPiDCoAo+ID4gwqAJa3Jl Zl9nZXQoJmV4ZWMtPnJlZmNvdW50KTsgLyogcHV0IGJ5IHNjaGVkdWxlciBqb2IgY29tcGxldGlv biAqLwo+ID4gwqAJZHJtX3NjaGVkX2VudGl0eV9wdXNoX2pvYigmZXhlYy0+cmVuZGVyLmJhc2Us Cj4gPiDCoAkJCQnCoMKgJnYzZF9wcml2LT5zY2hlZF9lbnRpdHlbVjNEX1JFTkRFUl0pOwo+ID4g KwltdXRleF91bmxvY2soJnYzZC0+c2NoZWRfbG9jayk7Cj4gwqAKPiA+IMKgCXYzZF9hdHRhY2hf b2JqZWN0X2ZlbmNlcyhleGVjKTsKPiDCoAo+IEBAIC02MTUsNiArNjIxLDcgQEAgdjNkX2dlbV9p bml0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gPiDCoAlzcGluX2xvY2tfaW5pdCgmdjNkLT5q b2JfbG9jayk7Cj4gPiDCoAltdXRleF9pbml0KCZ2M2QtPmJvX2xvY2spOwo+ID4gwqAJbXV0ZXhf aW5pdCgmdjNkLT5yZXNldF9sb2NrKTsKPiA+ICsJbXV0ZXhfaW5pdCgmdjNkLT5zY2hlZF9sb2Nr KTsKPiDCoAo+ID4gwqAJLyogTm90ZTogV2UgZG9uJ3QgYWxsb2NhdGUgYWRkcmVzcyAwLsKgwqBW YXJpb3VzIGJpdHMgb2YgSFcKPiA+IMKgCcKgKiB0cmVhdCAwIGFzIHNwZWNpYWwsIHN1Y2ggYXMg dGhlIG9jY2x1c2lvbiBxdWVyeSBjb3VudGVycwpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWwK