From mboxrd@z Thu Jan 1 00:00:00 1970 From: "S, Shirish" Subject: [PATCH] drm/amdgpu: refactor smu8_send_msg_to_smc and WARN_ON time out Date: Mon, 12 Nov 2018 09:43:15 +0000 Message-ID: <1542015780-2137-1-git-send-email-shirish.s@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Zhu, Rex" , "Deucher, Alexander" Cc: Daniel Kurtz , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , "S, Shirish" RnJvbTogRGFuaWVsIEt1cnR6IDxkamt1cnR6QGNocm9taXVtLm9yZz4KClRoaXMgcGF0Y2ggcmVm YWN0b3JzIHNtdThfc2VuZF9tc2dfdG9fc21jX3dpdGhfcGFyYW1ldGVyKCkgdG8gaW5jbHVkZQpz bXU4X3NlbmRfbXNnX3RvX3NtY19hc3luYygpIHNvIHRoYXQgYWxsIHRoZSBtZXNzYWdlcyBzZW50 IHRvIFNNVSBjYW4gYmUKcHJvZmlsZWQgYW5kIGFwcHJvcHJpYXRlbHkgcmVwb3J0ZWQgaWYgdGhl eSBmYWlsLgoKU2lnbmVkLW9mZi1ieTogRGFuaWVsIEt1cnR6IDxkamt1cnR6QGNocm9taXVtLm9y Zz4KU2lnbmVkLW9mZi1ieTogU2hpcmlzaCBTIDxzaGlyaXNoLnNAYW1kLmNvbT4KLS0tCiBkcml2 ZXJzL2dwdS9kcm0vYW1kL3Bvd2VycGxheS9zbXVtZ3Ivc211OF9zbXVtZ3IuYyB8IDQ1ICsrKysr KysrKystLS0tLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAyMSBpbnNlcnRpb25zKCspLCAyNCBk ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL3Bvd2VycGxheS9z bXVtZ3Ivc211OF9zbXVtZ3IuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvcG93ZXJwbGF5L3NtdW1n ci9zbXU4X3NtdW1nci5jCmluZGV4IDA5Yjg0NGUuLmJmOTdhYmMgMTAwNjQ0Ci0tLSBhL2RyaXZl cnMvZ3B1L2RybS9hbWQvcG93ZXJwbGF5L3NtdW1nci9zbXU4X3NtdW1nci5jCisrKyBiL2RyaXZl cnMvZ3B1L2RybS9hbWQvcG93ZXJwbGF5L3NtdW1nci9zbXU4X3NtdW1nci5jCkBAIC0yNCw2ICsy NCw3IEBACiAjaW5jbHVkZSA8bGludXgvZGVsYXkuaD4KICNpbmNsdWRlIDxsaW51eC9nZnAuaD4K ICNpbmNsdWRlIDxsaW51eC9rZXJuZWwuaD4KKyNpbmNsdWRlIDxsaW51eC9rdGltZS5oPgogI2lu Y2x1ZGUgPGxpbnV4L3NsYWIuaD4KICNpbmNsdWRlIDxsaW51eC90eXBlcy5oPgogCkBAIC02MSw5 ICs2MiwxMyBAQCBzdGF0aWMgdWludDMyX3Qgc211OF9nZXRfYXJndW1lbnQoc3RydWN0IHBwX2h3 bWdyICpod21ncikKIAkJCQkJbW1TTVVfTVAxX1NSQk0yUF9BUkdfMCk7CiB9CiAKLXN0YXRpYyBp bnQgc211OF9zZW5kX21zZ190b19zbWNfYXN5bmMoc3RydWN0IHBwX2h3bWdyICpod21nciwgdWlu dDE2X3QgbXNnKQorLyogU2VuZCBhIG1lc3NhZ2UgdG8gdGhlIFNNQywgYW5kIHdhaXQgZm9yIGl0 cyByZXNwb25zZS4qLworc3RhdGljIGludCBzbXU4X3NlbmRfbXNnX3RvX3NtY193aXRoX3BhcmFt ZXRlcihzdHJ1Y3QgcHBfaHdtZ3IgKmh3bWdyLAorCQkJCQkgICAgdWludDE2X3QgbXNnLCB1aW50 MzJfdCBwYXJhbWV0ZXIpCiB7CiAJaW50IHJlc3VsdCA9IDA7CisJa3RpbWVfdCB0X3N0YXJ0Owor CXM2NCBlbGFwc2VkX3VzOwogCiAJaWYgKGh3bWdyID09IE5VTEwgfHwgaHdtZ3ItPmRldmljZSA9 PSBOVUxMKQogCQlyZXR1cm4gLUVJTlZBTDsKQEAgLTc0LDI4ICs3OSwzMSBAQCBzdGF0aWMgaW50 IHNtdThfc2VuZF9tc2dfdG9fc21jX2FzeW5jKHN0cnVjdCBwcF9od21nciAqaHdtZ3IsIHVpbnQx Nl90IG1zZykKIAkJLyogUmVhZCB0aGUgbGFzdCBtZXNzYWdlIHRvIFNNVSwgdG8gcmVwb3J0IGFj dHVhbCBjYXVzZSAqLwogCQl1aW50MzJfdCB2YWwgPSBjZ3NfcmVhZF9yZWdpc3Rlcihod21nci0+ ZGV2aWNlLAogCQkJCQkJIG1tU01VX01QMV9TUkJNMlBfTVNHXzApOwotCQlwcl9lcnIoInNtdThf c2VuZF9tc2dfdG9fc21jX2FzeW5jICgweCUwNHgpIGZhaWxlZFxuIiwgbXNnKTsKLQkJcHJfZXJy KCJTTVUgc3RpbGwgc2VydmljaW5nIG1zZyAoMHglMDR4KVxuIiwgdmFsKTsKKwkJcHJfZXJyKCIl cygweCUwNHgpIGFib3J0ZWQ7IFNNVSBzdGlsbCBzZXJ2aWNpbmcgbXNnICgweCUwNHgpXG4iLAor CQkJbXNnLCB2YWwpOwogCQlyZXR1cm4gcmVzdWx0OwogCX0KKwl0X3N0YXJ0ID0ga3RpbWVfZ2V0 KCk7CisKKwljZ3Nfd3JpdGVfcmVnaXN0ZXIoaHdtZ3ItPmRldmljZSwgbW1TTVVfTVAxX1NSQk0y UF9BUkdfMCwgcGFyYW1ldGVyKTsKIAogCWNnc193cml0ZV9yZWdpc3Rlcihod21nci0+ZGV2aWNl LCBtbVNNVV9NUDFfU1JCTTJQX1JFU1BfMCwgMCk7CiAJY2dzX3dyaXRlX3JlZ2lzdGVyKGh3bWdy LT5kZXZpY2UsIG1tU01VX01QMV9TUkJNMlBfTVNHXzAsIG1zZyk7CiAKLQlyZXR1cm4gMDsKKwly ZXN1bHQgPSBQSE1fV0FJVF9GSUVMRF9VTkVRVUFMKGh3bWdyLAorCQkJCQlTTVVfTVAxX1NSQk0y UF9SRVNQXzAsIENPTlRFTlQsIDApOworCisJZWxhcHNlZF91cyA9IGt0aW1lX3VzX2RlbHRhKGt0 aW1lX2dldCgpLCB0X3N0YXJ0KTsKKworCVdBUk4ocmVzdWx0LCAiJXMoMHglMDR4LCAlI3gpIHRp bWVkIG91dCBhZnRlciAlbGxkIHVzXG4iLAorCQkJX19mdW5jX18sIG1zZywgcGFyYW1ldGVyLCBl bGFwc2VkX3VzKTsKKworCXJldHVybiByZXN1bHQ7CiB9CiAKLS8qIFNlbmQgYSBtZXNzYWdlIHRv IHRoZSBTTUMsIGFuZCB3YWl0IGZvciBpdHMgcmVzcG9uc2UuKi8KIHN0YXRpYyBpbnQgc211OF9z ZW5kX21zZ190b19zbWMoc3RydWN0IHBwX2h3bWdyICpod21nciwgdWludDE2X3QgbXNnKQogewot CWludCByZXN1bHQgPSAwOwotCi0JcmVzdWx0ID0gc211OF9zZW5kX21zZ190b19zbWNfYXN5bmMo aHdtZ3IsIG1zZyk7Ci0JaWYgKHJlc3VsdCAhPSAwKQotCQlyZXR1cm4gcmVzdWx0OwotCi0JcmV0 dXJuIFBITV9XQUlUX0ZJRUxEX1VORVFVQUwoaHdtZ3IsCi0JCQkJCVNNVV9NUDFfU1JCTTJQX1JF U1BfMCwgQ09OVEVOVCwgMCk7CisJcmV0dXJuIHNtdThfc2VuZF9tc2dfdG9fc21jX3dpdGhfcGFy YW1ldGVyKGh3bWdyLCBtc2csIDApOwogfQogCiBzdGF0aWMgaW50IHNtdThfc2V0X3NtY19zcmFt X2FkZHJlc3Moc3RydWN0IHBwX2h3bWdyICpod21nciwKQEAgLTEzNSwxNyArMTQzLDYgQEAgc3Rh dGljIGludCBzbXU4X3dyaXRlX3NtY19zcmFtX2R3b3JkKHN0cnVjdCBwcF9od21nciAqaHdtZ3Is CiAJcmV0dXJuIHJlc3VsdDsKIH0KIAotc3RhdGljIGludCBzbXU4X3NlbmRfbXNnX3RvX3NtY193 aXRoX3BhcmFtZXRlcihzdHJ1Y3QgcHBfaHdtZ3IgKmh3bWdyLAotCQkJCQkgIHVpbnQxNl90IG1z ZywgdWludDMyX3QgcGFyYW1ldGVyKQotewotCWlmIChod21nciA9PSBOVUxMIHx8IGh3bWdyLT5k ZXZpY2UgPT0gTlVMTCkKLQkJcmV0dXJuIC1FSU5WQUw7Ci0KLQljZ3Nfd3JpdGVfcmVnaXN0ZXIo aHdtZ3ItPmRldmljZSwgbW1TTVVfTVAxX1NSQk0yUF9BUkdfMCwgcGFyYW1ldGVyKTsKLQotCXJl dHVybiBzbXU4X3NlbmRfbXNnX3RvX3NtYyhod21nciwgbXNnKTsKLX0KLQogc3RhdGljIGludCBz bXU4X2NoZWNrX2Z3X2xvYWRfZmluaXNoKHN0cnVjdCBwcF9od21nciAqaHdtZ3IsCiAJCQkJICAg dWludDMyX3QgZmlybXdhcmUpCiB7Ci0tIAoyLjcuNAoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9hbWQtZ2Z4Cg==