From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Gustavo A. R. Silva" Subject: Re: [PATCH] drm/amdkfd: Fix missing break in switch statement Date: Mon, 22 Jul 2019 14:19:53 -0500 Message-ID: <181c1bc9-4cf9-057f-a6e6-e6d62ddbc347@embeddedor.com> References: <20190721214935.GA910@embeddedor> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Alex Deucher Cc: Philip Cox , Oded Gabbay , Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= , "David (ChunMing) Zhou" , David Airlie , Daniel Vetter , Kees Cook , amd-gfx list , Maling list - DRI developers , LKML List-Id: amd-gfx.lists.freedesktop.org On 7/22/19 2:10 PM, Alex Deucher wrote: > On Sun, Jul 21, 2019 at 6:12 PM Gustavo A. R. Silva > wrote: >> >> Add missing break statement in order to prevent the code from falling >> through to case CHIP_NAVI10. >> >> This bug was found thanks to the ongoing efforts to enable >> -Wimplicit-fallthrough. >> >> Fixes: 14328aa58ce5 ("drm/amdkfd: Add navi10 support to amdkfd. (v3)") >> Cc: stable@vger.kernel.org >> Signed-off-by: Gustavo A. R. Silva > > Applied. Thanks! > By the way, Alex, I'm planning to add these fixes to my tree. I want to send a pull-request to Linus for v5.3-rc2 this afternoon. We want to have the -Wimplicit-fallthrough option globally enabled in v5.3, and these are some of the last fall-through warnings remaining in the kernel. Can I have your Ack or Signed-off-by for all these drm patches? Thanks! -- Gustavo