From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kazlauskas, Nicholas" Subject: Re: [PATCH 3/3] drm/amd/display: update bw_calcs to take pipe sync into account (v2) Date: Thu, 22 Aug 2019 16:35:37 +0000 Message-ID: <192d802d-352a-60dd-488e-81bd2c5b7fee@amd.com> References: <20190822153645.3296-1-alexander.deucher@amd.com> <20190822153645.3296-4-alexander.deucher@amd.com> <6c011b85-27c8-4ff5-12b5-4d034878c916@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US Content-ID: <166A04634A35804D8095DB9E01D66E9E-asWib9pRmPqcE4WynfumptQqCkab/8FMAL8bYrjMMd8@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Alex Deucher Cc: "Deucher, Alexander" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" T24gOC8yMi8xOSAxMjozMSBQTSwgQWxleCBEZXVjaGVyIHdyb3RlOg0KPiBPbiBUaHUsIEF1ZyAy MiwgMjAxOSBhdCAxMjoyNSBQTSBLYXpsYXVza2FzLCBOaWNob2xhcw0KPiA8TmljaG9sYXMuS2F6 bGF1c2thc0BhbWQuY29tPiB3cm90ZToNCj4+DQo+PiBPbiA4LzIyLzE5IDExOjM2IEFNLCBBbGV4 IERldWNoZXIgd3JvdGU6DQo+Pj4gUHJvcGVybHkgc2V0IGFsbF9kaXNwbGF5c19pbl9zeW5jIHNv IHRoYXQgd2hlbiB0aGUgZGF0YSBpcw0KPj4+IHByb3BhZ2F0ZWQgdG8gcG93ZXJwbGF5LCBpdCdz IHNldCBwcm9wZXJseSBhbmQgd2UgY2FuIGVuYWJsZQ0KPj4+IG1jbGsgc3dpdGNoaW5nIHdoZW4g YWxsIG1vbml0b3JzIGFyZSBpbiBzeW5jLg0KPj4+DQo+Pj4gdjI6IGZpeCBsb2dpYywgY2xlYW4g dXANCj4+Pg0KPj4+IFNpZ25lZC1vZmYtYnk6IEFsZXggRGV1Y2hlciA8YWxleGFuZGVyLmRldWNo ZXJAYW1kLmNvbT4NCj4+PiAtLS0NCj4+PiAgICAuLi4vZ3B1L2RybS9hbWQvZGlzcGxheS9kYy9j YWxjcy9kY2VfY2FsY3MuYyAgfCA0OSArKysrKysrKysrKysrKysrKystDQo+Pj4gICAgMSBmaWxl IGNoYW5nZWQsIDQ3IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pDQo+Pj4NCj4+PiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L2RjL2NhbGNzL2RjZV9jYWxjcy5j IGIvZHJpdmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L2RjL2NhbGNzL2RjZV9jYWxjcy5jDQo+Pj4g aW5kZXggOWYxMmUyMWY4YjliLi44ZDkwNDY0N2ZiMGYgMTAwNjQ0DQo+Pj4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL2FtZC9kaXNwbGF5L2RjL2NhbGNzL2RjZV9jYWxjcy5jDQo+Pj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L2RjL2NhbGNzL2RjZV9jYWxjcy5jDQo+Pj4gQEAgLTI1 LDYgKzI1LDcgQEANCj4+Pg0KPj4+ICAgICNpbmNsdWRlIDxsaW51eC9zbGFiLmg+DQo+Pj4NCj4+ PiArI2luY2x1ZGUgInJlc291cmNlLmgiDQo+Pj4gICAgI2luY2x1ZGUgImRtX3NlcnZpY2VzLmgi DQo+Pj4gICAgI2luY2x1ZGUgImRjZV9jYWxjcy5oIg0KPj4+ICAgICNpbmNsdWRlICJkYy5oIg0K Pj4+IEBAIC0yOTc3LDYgKzI5NzgsNTAgQEAgc3RhdGljIHZvaWQgcG9wdWxhdGVfaW5pdGlhbF9k YXRhKA0KPj4+ICAgICAgICBkYXRhLT5udW1iZXJfb2ZfZGlzcGxheXMgPSBudW1fZGlzcGxheXM7 DQo+Pj4gICAgfQ0KPj4+DQo+Pj4gK3N0YXRpYyBib29sIGFsbF9kaXNwbGF5c19pbl9zeW5jKGNv bnN0IHN0cnVjdCBwaXBlX2N0eCBwaXBlW10sDQo+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGludCBwaXBlX2NvdW50LA0KPj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICB1aW50MzJfdCBudW1iZXJfb2ZfZGlzcGxheXMpDQo+Pj4gK3sNCj4+PiArICAgICBjb25zdCBz dHJ1Y3QgcGlwZV9jdHggKnVuc3luY2VkX3BpcGVzW01BWF9QSVBFU10gPSB7IE5VTEwgfTsNCj4+ PiArICAgICBpbnQgZ3JvdXBfc2l6ZSA9IDE7DQo+Pj4gKyAgICAgaW50IGksIGo7DQo+Pj4gKw0K Pj4+ICsgICAgIGZvciAoaSA9IDA7IGkgPCBwaXBlX2NvdW50OyBpKyspIHsNCj4+PiArICAgICAg ICAgICAgIGlmICghcGlwZVtpXS5zdHJlYW0pDQo+Pg0KPj4gVGhpcyBiaXQgZGlmZmVycyBmcm9t IHByb2dyYW1fdGltaW5nX3N5bmMsIGJ1dCBzaW5jZSB0aGlzIGlzIGZvciBkY2UgYW5kDQo+PiB3 ZSBkb24ndCBkbyBwaXBlIHNwbGl0IG9yIE1QTyBJIHRoaW5rIGl0J3MgcHJvYmFibHkgZmluZSB0 aGF0IHlvdSdyZSBub3QNCj4+IGNoZWNraW5nIHRvcF9waXBlIGhlcmUuDQo+Pg0KPj4gV291bGRu J3QgaHVydCB0byBoYXZlIHRoYXQgbG9naWMgaGVyZSB0aG91Z2guDQo+Pg0KPiANCj4gSSBoYWQg Y2hlY2tlZCBmb3IgdG9wX3BpcGUgaGVyZSBvcmlnaW5hbGx5LCBidXQgaXQgd2FzIGFsd2F5cyBO VUxMIHNvDQo+IHVuc3luY2VkX3BpcGVzIG5ldmVyIGdvdCBwb3B1bGF0ZWQuICBNYXliZSB0aGF0 IGlzIG5vdCBwb3B1bGF0ZWQNCj4gcHJvcGVybHkgYXQgdGhpcyBwb2ludD8NCg0KVGhlIHByZXNl bmNlIG9mIGEgdG9wX3BpcGUgb24gYSBwaXBlIGluZGljYXRlcyB0aGF0IHRoZSBwaXBlIGlzIHBh cnQgb2YgDQphIGJsZW5kaW5nIGNoYWluLiBBIE5VTEwgdG9wX3BpcGUgdmFsdWUgaW5kaWNhdGVz IHRoYXQgdGhlIGN1cnJlbnQgcGlwZSANCmlzIHRoZSB0b3Agb2YgdGhlIGNoYWluLg0KDQpJdCBz aG91bGQgYmUgTlVMTCBmb3IgYWxsIHBpcGVzIG9uIERDRSBBU0lDcy4NCg0KTmljaG9sYXMgS2F6 bGF1c2thcw0KDQo+IA0KPj4+ICsgICAgICAgICAgICAgICAgICAgICBjb250aW51ZTsNCj4+PiAr DQo+Pj4gKyAgICAgICAgICAgICB1bnN5bmNlZF9waXBlc1tpXSA9ICZwaXBlW2ldOw0KPj4+ICsg ICAgIH0NCj4+PiArDQo+Pj4gKyAgICAgZm9yIChpID0gMDsgaSA8IHBpcGVfY291bnQ7IGkrKykg ew0KPj4+ICsgICAgICAgICAgICAgY29uc3Qgc3RydWN0IHBpcGVfY3R4ICpwaXBlX3NldFtNQVhf UElQRVNdOw0KPj4+ICsNCj4+PiArICAgICAgICAgICAgIGlmICghdW5zeW5jZWRfcGlwZXNbaV0p DQo+Pj4gKyAgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOw0KPj4+ICsNCj4+PiArICAgICAg ICAgICAgIHBpcGVfc2V0WzBdID0gdW5zeW5jZWRfcGlwZXNbaV07DQo+Pj4gKyAgICAgICAgICAg ICB1bnN5bmNlZF9waXBlc1tpXSA9IE5VTEw7DQo+Pj4gKw0KPj4+ICsgICAgICAgICAgICAgLyog QWRkIHRnIHRvIHRoZSBzZXQsIHNlYXJjaCByZXN0IG9mIHRoZSB0ZydzIGZvciBvbmVzIHdpdGgN Cj4+PiArICAgICAgICAgICAgICAqIHNhbWUgdGltaW5nLCBhZGQgYWxsIHRncyB3aXRoIHNhbWUg dGltaW5nIHRvIHRoZSBncm91cA0KPj4+ICsgICAgICAgICAgICAgICovDQo+Pj4gKyAgICAgICAg ICAgICBmb3IgKGogPSBpICsgMTsgaiA8IHBpcGVfY291bnQ7IGorKykgew0KPj4+ICsgICAgICAg ICAgICAgICAgICAgICBpZiAoIXVuc3luY2VkX3BpcGVzW2pdKQ0KPj4+ICsgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGNvbnRpbnVlOw0KPj4+ICsNCj4+PiArICAgICAgICAgICAgICAgICAg ICAgaWYgKHJlc291cmNlX2FyZV9zdHJlYW1zX3RpbWluZ19zeW5jaHJvbml6YWJsZSgNCj4+PiAr ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc3luY2VkX3BpcGVzW2pdLT5z dHJlYW0sDQo+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwaXBlX3Nl dFswXS0+c3RyZWFtKSkgew0KPj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBpcGVf c2V0W2dyb3VwX3NpemVdID0gdW5zeW5jZWRfcGlwZXNbal07DQo+Pj4gKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgdW5zeW5jZWRfcGlwZXNbal0gPSBOVUxMOw0KPj4+ICsgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGdyb3VwX3NpemUrKzsNCj4+PiArICAgICAgICAgICAgICAgICAg ICAgfQ0KPj4+ICsgICAgICAgICAgICAgfQ0KPj4+ICsgICAgIH0NCj4+PiArDQo+Pj4gKyAgICAg cmV0dXJuIChncm91cF9zaXplID09IG51bWJlcl9vZl9kaXNwbGF5cykgPyB0cnVlIDogZmFsc2U7 DQo+Pg0KPj4gSSB0aGluayB0aGlzIGxvZ2ljIGlzIGZ1bmN0aW9uYWwgYnV0IGl0IGxvb2tzIGlu Y29ycmVjdCBhdCBmaXJzdCBnbGFuY2UNCj4+IGJlY2F1c2UgZ3JvdXBfc2l6ZSBkb2Vzbid0IGdl dCByZXNldC4gV2hhdCBlbmRzIHVwIGhhcHBlbmluZyBpcyB0aGUNCj4+IGZpcnN0IHBpcGUgb2Yg ZWFjaCBncm91cCBkb2Vzbid0IGdldCBhZGRlZCB0byBncm91cF9zaXplLg0KPj4NCj4+IEkgZmVl bCB0aGF0IHRoaXMgd291bGQgYmUgbW9yZSBjbGVhciBhczoNCj4+DQo+PiBzdGF0aWMgYm9vbCBh bGxfZGlzcGxheXNfaW5fc3luYyhjb25zdCBzdHJ1Y3QgcGlwZV9jdHggcGlwZVtdLCBpbnQNCj4+ IHBpcGVfY291bnQpDQo+PiB7DQo+PiAgICAgICAgICBjb25zdCBzdHJ1Y3QgcGlwZV9jdHggKmFj dGl2ZV9waXBlc1tNQVhfUElQRVNdOw0KPj4gICAgICAgICAgaW50IGksIG51bV9hY3RpdmVfcGlw ZXMgPSAwOw0KPj4NCj4+ICAgICAgICAgIGZvciAoaSA9IDA7IGkgPCBwaXBlX2NvdW50OyBpKysp IHsNCj4+ICAgICAgICAgICAgICAgICAgaWYgKCFwaXBlW2ldLnN0cmVhbSB8fCBwaXBlW2ldLnRv cF9waXBlKQ0KPj4gICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOw0KPj4NCj4+ICAg ICAgICAgICAgICAgICAgYWN0aXZlX3BpcGVzW251bV9hY3RpdmVfcGlwZXMrK10gPSAmcGlwZVtp XTsNCj4+ICAgICAgICAgIH0NCj4+DQo+PiAgICAgICAgICBpZiAoIW51bV9hY3RpdmVfcGlwZXMp DQo+PiAgICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsNCj4+DQo+PiAgICAgICAgICBmb3Ig KGkgPSAxOyBpIDwgbnVtX2FjdGl2ZV9waXBlczsgKytpKQ0KPj4gICAgICAgICAgICAgICAgICBp ZiAoIXJlc291cmNlX2FyZV9zdHJlYW1zX3RpbWluZ19zeW5jaHJvbml6YWJsZSgNCj4+ICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgYWN0aXZlX3BpcGVzWzBdLT5zdHJlYW0sIGFjdGl2ZV9w aXBlc1tpXS0+c3RyZWFtKSkNCj4+ICAgICAgICAgICAgICAgICAgICAgICAgICByZXR1cm4gZmFs c2U7DQo+Pg0KPj4gICAgICAgICAgcmV0dXJuIHRydWU7DQo+PiB9DQo+IA0KPiBZZXMsIHRoYXQn cyBtdWNoIGNsZWFuZXIuICBUaGFua3MhDQo+IA0KPiBBbGV4DQo+IA0KPj4NCj4+IEJ1dCBJIGhh dmVuJ3QgdGVzdGVkIHRoaXMuDQo+Pg0KPj4gTmljaG9sYXMgS2F6bGF1c2thcw0KPj4NCj4+DQo+ Pj4gK30NCj4+PiArDQo+Pj4gICAgLyoqDQo+Pj4gICAgICogUmV0dXJuOg0KPj4+ICAgICAqICB0 cnVlIC0gIERpc3BsYXkocykgY29uZmlndXJhdGlvbiBzdXBwb3J0ZWQuDQo+Pj4gQEAgLTI5OTgs OCArMzA0Myw4IEBAIGJvb2wgYndfY2FsY3Moc3RydWN0IGRjX2NvbnRleHQgKmN0eCwNCj4+Pg0K Pj4+ICAgICAgICBwb3B1bGF0ZV9pbml0aWFsX2RhdGEocGlwZSwgcGlwZV9jb3VudCwgZGF0YSk7 DQo+Pj4NCj4+PiAtICAgICAvKlRPRE86IHRoaXMgc2hvdWxkIGJlIHRha2VuIG91dCBjYWxjcyBv dXRwdXQgYW5kIGFzc2lnbmVkIGR1cmluZyB0aW1pbmcgc3luYyBmb3IgcHBsaWIgdXNlKi8NCj4+ PiAtICAgICBjYWxjc19vdXRwdXQtPmFsbF9kaXNwbGF5c19pbl9zeW5jID0gZmFsc2U7DQo+Pj4g KyAgICAgY2FsY3Nfb3V0cHV0LT5hbGxfZGlzcGxheXNfaW5fc3luYyA9IGFsbF9kaXNwbGF5c19p bl9zeW5jKHBpcGUsIHBpcGVfY291bnQsDQo+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRhdGEtPm51bWJlcl9vZl9kaXNw bGF5cyk7DQo+Pj4NCj4+PiAgICAgICAgaWYgKGRhdGEtPm51bWJlcl9vZl9kaXNwbGF5cyAhPSAw KSB7DQo+Pj4gICAgICAgICAgICAgICAgdWludDhfdCB5Y2xrX2x2bCwgc2Nsa19sdmw7DQo+Pj4N Cj4+DQoNCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmFt ZC1nZnggbWFpbGluZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeA==