AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Harry Wentland <harry.wentland@amd.com>
To: Anson Jacob <Anson.Jacob@amd.com>, amd-gfx@lists.freedesktop.org
Cc: Sunpeng.Li@amd.com, Bhawanpreet.Lakha@amd.com,
	Rodrigo.Siqueira@amd.com, Aurabindo.Pillai@amd.com,
	Qingqing.Zhuo@amd.com,
	"Christian König" <christian.koenig@amd.com>,
	"Hersen Wu" <hersenxs.wu@amd.com>
Subject: Re: [PATCH] drm/amd/display: dc_assert_fp_enabled assert only if FPU is not enabled
Date: Thu, 9 Sep 2021 13:53:06 -0400	[thread overview]
Message-ID: <1c5569cb-2abe-eed2-da50-5eb456e8a26a@amd.com> (raw)
In-Reply-To: <20210909165532.1351652-1-Anson.Jacob@amd.com>

On 2021-09-09 12:55 p.m., Anson Jacob wrote:
> Assert only when FPU is not enabled.
> 
> Fixes: e549f77c1965 ("drm/amd/display: Add DC_FP helper to check FPU state")
> Signed-off-by: Anson Jacob <Anson.Jacob@amd.com>
> Cc: Christian König <christian.koenig@amd.com>
> Cc: Hersen Wu <hersenxs.wu@amd.com>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/dc_fpu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/dc_fpu.c b/drivers/gpu/drm/amd/display/amdgpu_dm/dc_fpu.c
> index c9f47d167472..b1bf80da3a55 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/dc_fpu.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/dc_fpu.c
> @@ -62,7 +62,7 @@ inline void dc_assert_fp_enabled(void)
>  	depth = *pcpu;
>  	put_cpu_ptr(&fpu_recursion_depth);
>  
> -	ASSERT(depth > 1);
> +	ASSERT(depth >= 1);
>  }
>  
>  /**
> 


      reply	other threads:[~2021-09-09 17:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-09 16:55 [PATCH] drm/amd/display: dc_assert_fp_enabled assert only if FPU is not enabled Anson Jacob
2021-09-09 17:53 ` Harry Wentland [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1c5569cb-2abe-eed2-da50-5eb456e8a26a@amd.com \
    --to=harry.wentland@amd.com \
    --cc=Anson.Jacob@amd.com \
    --cc=Aurabindo.Pillai@amd.com \
    --cc=Bhawanpreet.Lakha@amd.com \
    --cc=Qingqing.Zhuo@amd.com \
    --cc=Rodrigo.Siqueira@amd.com \
    --cc=Sunpeng.Li@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=hersenxs.wu@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox