From: Felix Kuehling <felix.kuehling@amd.com>
To: amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdkfd: Only apply TLB flush optimization on ALdebaran
Date: Wed, 30 Jun 2021 18:44:30 -0400 [thread overview]
Message-ID: <1d701acc-eeeb-da70-5211-10aed38d1157@amd.com> (raw)
In-Reply-To: <20210630220331.62246-1-jinhuieric.huang@amd.com>
On 2021-06-30 6:03 p.m., Eric Huang wrote:
> It is based on reverting two patches back.
> drm/amdkfd: Make TLB flush conditional on mapping
> drm/amdgpu: Add table_freed parameter to amdgpu_vm_bo_update
>
> Signed-off-by: Eric Huang <jinhuieric.huang@amd.com>
I'd prefer to put HW-specific workarounds in
amdgpu_amdkfd_gpuvm_map_memory_to_gpu.
Regards,
Felix
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> index cfaa5f88e630..f859ee7e8c13 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> @@ -1659,6 +1659,12 @@ static int kfd_ioctl_map_memory_to_gpu(struct file *filep,
> goto sync_memory_failed;
> }
>
> + /* Only apply no TLB flush on Aldebaran to
> + * workaround regressions on other Asics
> + */
> + if (dev->device_info->asic_family != CHIP_ALDEBARAN)
> + table_freed = true;
> +
> /* Flush TLBs after waiting for the page table updates to complete */
> if (table_freed) {
> for (i = 0; i < args->n_devices; i++) {
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2021-06-30 22:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 22:03 [PATCH] drm/amdkfd: Only apply TLB flush optimization on ALdebaran Eric Huang
2021-06-30 22:44 ` Felix Kuehling [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d701acc-eeeb-da70-5211-10aed38d1157@amd.com \
--to=felix.kuehling@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox