Re: [PATCH] drm/amd/pm: Use str_enabled_disabled in amdgpu_pm sysfs

["Lazar, Lijo" <lijo.lazar@amd.com>]

On 25-Mar-26 3:28 PM, Asad Kamal wrote:
> Coccinelle flags hand-rolled "enabled"/"disabled" strings; use the shared
> str_enabled_disabled() helper from string_choices.h for npm_status and
> thermal throttling logging sysfs text.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202603251434.zIN2QYWn-lkp@intel.com/
> 
> Signed-off-by: Asad Kamal <asad.kamal@amd.com>

Reviewed-by: Lijo Lazar <lijo.lazar@amd.com>

Thanks,
Lijo

> ---
>   drivers/gpu/drm/amd/pm/amdgpu_pm.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> index 6565cc3e35f2..a4d8e667eafb 100644
> --- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> +++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> @@ -33,6 +33,7 @@
>   #include <linux/hwmon-sysfs.h>
>   #include <linux/nospec.h>
>   #include <linux/pm_runtime.h>
> +#include <linux/string_choices.h>
>   #include <asm/processor.h>
>   
>   #define MAX_NUM_OF_FEATURES_PER_SUBSET		8
> @@ -1592,7 +1593,7 @@ static ssize_t amdgpu_get_thermal_throttling_logging(struct device *dev,
>   
>   	return sysfs_emit(buf, "%s: thermal throttling logging %s, with interval %d seconds\n",
>   			  adev_to_drm(adev)->unique,
> -			  atomic_read(&adev->throttling_logging_enabled) ? "enabled" : "disabled",
> +			  str_enabled_disabled(atomic_read(&adev->throttling_logging_enabled)),
>   			  adev->throttling_logging_rs.interval / HZ + 1);
>   }
>   
> @@ -2235,7 +2236,7 @@ static ssize_t amdgpu_show_npm_status(struct device *dev,
>   	if (r)
>   		return r;
>   
> -	return sysfs_emit(buf, "%s\n", npower ? "enabled" : "disabled");
> +	return sysfs_emit(buf, "%s\n", str_enabled_disabled(npower));
>   }
>   
>   /**