From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E741C5321D for ; Mon, 26 Aug 2024 15:15:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D4BC810E230; Mon, 26 Aug 2024 15:15:34 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="o6Ni0qGZ"; dkim-atps=neutral Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2054.outbound.protection.outlook.com [40.107.236.54]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0930B10E0A7 for ; Mon, 26 Aug 2024 15:15:33 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Q7h5f3C/b9l/j7snjSdxVCXcZEfPXm1grTvst8/PgzNZpAYF1e5DqaylwglNy1zcHfeGYOVQcaZa8rPq+VoJ+QhA+r2WeRMDpffPtHXYVDgW+ldBjk16iVLMhYsVu+OPK8SrtHw6iNOt8ArmMhjDyUqx9j2xMeW0A9hU6c9pz284TJOmHASR7bVlQDJ/md/0hmMR/2URSQlMTTu/zCqa44eY5J9CidzaDMHJgIWS0rDFVcTOVxiUlBIdCzYqKw0v+JDN8xBcNslsQWp/B8ECDBtHyPEB3zNpvgCh8YgjMXEc9mdeRbjgpK2vHDkt7ZrIhdF0bEpjun42Qv4gRyMnBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xSVSuoU1A3zTHXNtQhmDb/GBpFWWpNqvtB9141ERnhM=; b=YxK3gOECPdlFDck2UQhZKoOvLZvdvxybFMyuEwmTHRHa0i+xk0SL7JhAYGOfAbFdt/0lk1DpkIOQ9B5rK37U6TfDJqWkwum2rcNsUJKYd7P46M7kdxJWY/Fwoc+wOxLuzMv+Gb6oW8IK1C4la9z7LSqsgAWYqZz3jw2vQyGL5xjfRyVhg3hFI9ODZGc/JSXw4mq3EnbKz3SFaxIf2EWUDU0Mgs8FZSL2MEN7cca/RWjlWesjODPogdsZfYf6/dufIZinmf8d+aKUgT5jLY/vkODOVQn2aNQNlyY9qmLtex8Hggh1kVGRGVLjSSAtRHy7P79rz5v0BlY01Ezu/5nClQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xSVSuoU1A3zTHXNtQhmDb/GBpFWWpNqvtB9141ERnhM=; b=o6Ni0qGZi/hjQEe7E0vzyzRVp8h5uzLfd23rIwbfVl6cMz/ydq+jzWUxqC9guiQ96arNae+QUWZ0QFf+WuJlwlfv5/wnTLPLX8qHQ5Komcr/R0h+WvF7JqGZMA6uXPEYJAP6jaBuNw/zFt0WWiFvfvYrJcRiP3HG8E1wDQqueBg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM4PR12MB6566.namprd12.prod.outlook.com (2603:10b6:8:8d::16) by DS0PR12MB8573.namprd12.prod.outlook.com (2603:10b6:8:162::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7897.23; Mon, 26 Aug 2024 15:15:30 +0000 Received: from DM4PR12MB6566.namprd12.prod.outlook.com ([fe80::31b:5d31:8ba6:abd7]) by DM4PR12MB6566.namprd12.prod.outlook.com ([fe80::31b:5d31:8ba6:abd7%6]) with mapi id 15.20.7897.021; Mon, 26 Aug 2024 15:15:30 +0000 Content-Type: multipart/alternative; boundary="------------3DlyGbBb6pIJxLXmc2iccFAK" Message-ID: <1f29420a-0780-43cb-9df3-2607be05df35@amd.com> Date: Mon, 26 Aug 2024 10:15:27 -0500 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/amdgpu/: Add missing kdoc entry in amdgpu_vm_handle_fault function To: amd-gfx@lists.freedesktop.org References: <20240826132611.3331242-1-srinivasan.shanmugam@amd.com> Content-Language: en-CA From: "Chen, Xiaogang" In-Reply-To: <20240826132611.3331242-1-srinivasan.shanmugam@amd.com> X-ClientProxiedBy: BY3PR05CA0060.namprd05.prod.outlook.com (2603:10b6:a03:39b::35) To DM4PR12MB6566.namprd12.prod.outlook.com (2603:10b6:8:8d::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR12MB6566:EE_|DS0PR12MB8573:EE_ X-MS-Office365-Filtering-Correlation-Id: 54b6552f-e04d-4b7e-23c1-08dcc5e1ec00 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?TGRnaTJvZkhrdXl4NzhINFJrUUplL1hIUk9pQkpzUlFmb0w3OWlJZHIvU09M?= =?utf-8?B?YldNYW8yb2hxRHNLTFpwMTdEQ1FBbjhvRGx5RXk0bkcrOTNCeTAvMHlXY1E5?= =?utf-8?B?dzJBRTdCcUUrS0piYTZ3eXYvZlJ0bGs3aDFpTllYcnpFeVNpZHYvY1ZybGxX?= =?utf-8?B?RllHRlo2bWlQai9WdEFBSlRGQUYzaFM4VXlHNG5MRm1Kek84VWJoMFMrODhC?= =?utf-8?B?UTRlbEZqS2JEbHBVZTZGZ3g0T0JRWEthVzFXNUdaSTV5dGZMQmJmZThmakVl?= =?utf-8?B?MnlRTjBhN0FzL29kd0VLaHhIbzhlbmo2LzVvYWJtcG9RaW8rYkxEY08zR0xH?= =?utf-8?B?c2tyZ3VFOXZlelVWZXZ2Um9LRlI0UndTOWswV0ZJcVFGMmY4MEJiZFAzbDVk?= =?utf-8?B?V2hiTW9kano1RHBhdlUwejJ1M1BuZnFqeERxMjBIMVZtTzh6djdyL0hrOUxU?= =?utf-8?B?WW5YYjVvTWw1emNJcTRHVEY4WkYvTUY1RWtFT0ZXaG1FRUtsSk4xRUxOUlhF?= =?utf-8?B?SEVpZGFqWkRnYVJqL2NvMm9sVDVadGUxcCsyOWlCOXpOZzdkTVM4bnY5MUoy?= =?utf-8?B?K0ZvZ0dCQm1nZTkxZm0rcXZKdDlLQkZmYnZBSTRZcTB2NXo1QlQ1eTJ4b0tu?= =?utf-8?B?eHdXTDNPV1d5TGQ5UXA1bzM3aFM0OGZPNysrSXhRcmR0NWNmYjNkUEdJQzlR?= =?utf-8?B?VWkwOGo3L1JpQmlpNzN5VXB0ODd4TDB0RlovWHc3MUdUd0dDeDJBYVVFUExx?= =?utf-8?B?OXlialZhVmZ5NVlFNVhwcmx3TDluMnpqSENML3E1SGxoNUQycnArM1pVL0FR?= =?utf-8?B?bjQzcDA0Qmw3dG1NT2hvc1laQzBXTzNHSHdHTTgzVU9EOWhMSGR2Ukt6UFRs?= =?utf-8?B?UkVzYzkrcm9aT2JsVzYwMlRJdTd4N1RSdG9HTFZaakk0SDQwMVNaVDd5cVlD?= =?utf-8?B?YmVhYjVLOFNwcEQwUnVpQlRhNXlpOUhINU5QdjBQcVFjM0JqZzNwWCtJa1Vj?= =?utf-8?B?Q3VjQS9QU2VTY1REakdSenppRUhnNFhMdXIxci8wVnhiUUxPcnhUNzAyT0Fx?= =?utf-8?B?b3RaN0lFdzdROEpTWXhnNUFjbmZtWHlHcHVhOHh4RGE3ZXpJdzFLOWswYVFx?= =?utf-8?B?QUcvT2s3KzNWdTNVeUZkeEJaWXM5RnZ3UkFRdVFlZjBTUnhqdkh3OUY5cmEw?= =?utf-8?B?T3hCemI5RzhWekZ6S1V4OGs4endrNlh3MXYzelBBOXF0RDkzODBhZmdBZU9R?= =?utf-8?B?T256UVNWY09qUHV6TkV0RmtMRDA4WDlPMGxzOGJVN1htZUczQ1phZGswQTd0?= =?utf-8?B?eFlWa2kza0dFV1RYb21BUjc0Ry9SOU5vNkViMm8xN1FFdVBqa1BmZlRWSkFX?= =?utf-8?B?UEQvajA2NFcwUW9IQ3Z2eFFCS3VHU1ppUnh5S0NSWEFGVktvcmg1eVFnZ2Nl?= =?utf-8?B?VkxTemNLT2l6YW1RYWxPVDVvNUlSbUFsQVFrMHpaWnRZWitRMlVLTzF0RHp4?= =?utf-8?B?VkpDQXpmU1RnK3plUlc2WVZQZmg2Z2pRUE9GeGdRN3ZDMjM0YzB3YnBndGww?= =?utf-8?B?Und6UUZSenNRZUpyZjIySEJiVThpZkl5RlRnWkJ1UWFOcWxlMU5CTDNpV2s1?= =?utf-8?B?d3l4OW5iUDU0a1poQk5Md3RJd3JyWHROV2dRQ0Vid3phUkpXYzAwWG5CUHlj?= =?utf-8?B?aElvVmY5dThOTStPcUtIb1F0Z2RyMnJRUlVjaEIxYWpULzdFSWZyQW5ZU0RM?= =?utf-8?B?STltMVlDN2ZHWk9SUmgvZFRMK1hJRlgva2IwZ29WenBlb0hlZjJFdHc3dEdI?= =?utf-8?Q?NMXnqqAklDzOJdZDbyFggbAhXGh/P3wIbA9nQ=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB6566.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RFhTbk9JWlNWQTh4MDdnSFJ2UjlTcEQ4TmZxZjhSRmJ4NCsyZTJvR1RuejJk?= =?utf-8?B?aHo1eWFDVmwrN2dUQlg5SWVUSG4yVk4yYUhrR3E1QlNHVnZXcjh5amRJYnpB?= =?utf-8?B?UzJ0aFJMVm5oeklRVm1hTDRNaU9jQW1veVRoSVNockNNTW15eTZZck1ULytB?= =?utf-8?B?M2FidlllME9ZVUF4QVRIbnZsVEg5ODlkcCtudzJROFIxTmFKam9iOCtnOWVB?= =?utf-8?B?YmIxU2dhWGRaN29JWmlYMjZEaThuaFA4MmN3blRmbTVtNERxVzZqeUtmMVdZ?= =?utf-8?B?WFRhZC91MHZEbHEzR1I4QXpIdzJtK281aEVZZkUxZFg1TmxOY1RoMTJFVEJt?= =?utf-8?B?cVdSMTFiMnRSS2FFc053WFd5QlNXZDFhWkdhYURxaUZiM2tTQkNaR2JlUytM?= =?utf-8?B?YmMzM1gxVHo4SXA4OWdiMm9JUDdyMmpkWDZOZGxUUkQzemswWVBPcENGdzhI?= =?utf-8?B?L1drbFk4RlpEUEpYK2FEbks4Y1BWWmN2OUZzaUcxditmN0RRUHVQWm1aYWRv?= =?utf-8?B?T2pHRHhMS1paamhIM2NvdlpJc055M3F6MGYyRk1rT25iYzVrdm9ZeGFNMGZ1?= =?utf-8?B?MXJJT0wyYk9KOC83WEVZbTdlVkE0SWpPOVpjZ0FwTjF6OWZER1lPL2NPOUQz?= =?utf-8?B?WVJuK0ZURWwxVDdlZ29JT2xpY21xaTlJOFBqNE93N1RSSWRqK0JQMzlaWFZ1?= =?utf-8?B?dkpKQ2pycUM4RTk0UGVuTzJXcnJLbnZEYVZOQlZsTFNRVnJzR091Z0hSQmgy?= =?utf-8?B?QjN5SDdkNXpYbG5EeFRiRUVhaEVDY3RCTUxqZDRKYUJJODl5UVhlYUtVUEZv?= =?utf-8?B?dEl0YWc2WnFvd0VNdkgzTmkwdEJtMUdRWlpCMktPRGRVTy9zR3JEVzh1YzhT?= =?utf-8?B?M1pjblNFOW14a0xRdWxUdnhobFJEbDVkMm4vbVE5MkZ1ZG01Rmc5TVFPdVU1?= =?utf-8?B?QkRjcFBFM1Zmb0Nnd2pYZVFBZ3BFMWtaUnRIQ1pPNndoRWp6QU1XMjJWdmYy?= =?utf-8?B?Y1hYRDJWVzljZUlYczE4QjE2ZjVmcGtPcGVmdUdpc0FuRjg1eDZ3M2d2NFRu?= =?utf-8?B?Y1g4MXJyY2hDWGpxWERBL0pLWWNpSDBpNWdUektGOGZGci9MZzZPOWlhMTlQ?= =?utf-8?B?ZFJJeDVOQm4yejh0Vjl1TWhaTTRycGdzUVU1VEx3SHZtd0w5ZnBMQnFZaG5M?= =?utf-8?B?c3pacEVrMVZIMDN1ekVCVkRkS2x5MjlmNmpJVWNFYjZyKzRMdjdPNmt2dXR1?= =?utf-8?B?UEs3Nmt4UnVucWt5WTh4c1FhTHhjNlZSK25Dd1llVmZrazl1eWVXS2V1ZElJ?= =?utf-8?B?MUpJQVYvREYvNGZtNUhzdUVaU0U0MEhLOUxpVHFFcWV1aEhteWtwMnJZZTB5?= =?utf-8?B?a25xYlhsWjlrSkhwaDRzZnVuUHl5K0NxSndscHA3Q3BWM1NBVGtVMWoybkhS?= =?utf-8?B?VE0xN01OTkQyZjg3UkVhbUJ0YmdZMUt4MkhoRHN4KzRTcW5UTm0zOUJZcXVM?= =?utf-8?B?K2xlelBtK3BTcDV5NkdWcUlwaVBmODhDeTV6dVhabDhBQy9nTTg2UXNyenpw?= =?utf-8?B?WlRpbzNJbk5kQkdqZmJOQ0NJY3pTMjBqZWE5cDNIeERJanNuZ2dnaVpwS2Fm?= =?utf-8?B?NzFXRExpQ3lLVm56a1lMK3ZuNXVEQ0xEc2tnekZ6UHlzcG94bXo2NlNkeU1P?= =?utf-8?B?bUZ6eUU4V2UxeFVUenhnOUQ5bXAvMmpJU3hSNjJNVG9hRVZDcjJYOGxranVQ?= =?utf-8?B?M1VhMEV3L0tCMHlLUlJtVjQzL1VGRE8yOGN1TGhuUUYrOHljY1M0S2RGSjQw?= =?utf-8?B?TFkrV3dYRExETWxDc2QxZktsUm1JUmxuei8wK24xUjZzckVJNHdaSlpsR3pT?= =?utf-8?B?QmNjdnpRSWZDS1RpUHY4Q245QTNTakovbk8yR1MvZjdZSDVLMkZsbXZsTmVJ?= =?utf-8?B?M0FOZjBOeHFVWW1MSXNzOTlEZmtSY1Q3UVFEbTgzYXYwVXdJTWxGZ1IxN1p2?= =?utf-8?B?MmQ5L05JYU9IeVdBTTE3Q25GTmdISjlMV1k5U1BtSHIyVmlUTEszN2lsVHdU?= =?utf-8?B?Y3RiMCs3NEhwMFU0UGtObXkraGo1Q0xIMlk5OTUzS2UxMzlYallwaU9ER29r?= =?utf-8?Q?ISPw=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 54b6552f-e04d-4b7e-23c1-08dcc5e1ec00 X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6566.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2024 15:15:30.0944 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tTMmaRq7J0H6U1h1OpkQaJFQIz9ZJxZLhUX6wZR8kcprf+OSw+yxIAXhVVApJbQP X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8573 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" --------------3DlyGbBb6pIJxLXmc2iccFAK Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit It was generated from my patch "drm/amdkfd: Change kfd/svm page fault drain handling". kernel test robot also reported same. Please add: If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes:https://lore.kernel.org/oe-kbuild-all/202408251419.vgZHg3GV-lkp@intel.com/ Regards Xiaogang On 8/26/2024 8:26 AM, Srinivasan Shanmugam wrote: > Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. > > > This commit adds a description for the 'ts' parameter in the > amdgpu_vm_handle_fault function's comment block. > > Fixes the below with gcc W=1: > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:2781: warning: Function parameter or struct member 'ts' not described in 'amdgpu_vm_handle_fault' > > Cc: Christian König > Cc: Alex Deucher > Signed-off-by: Srinivasan Shanmugam > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c > index ad2e469548c9..0fa165e8fb40 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c > @@ -2766,6 +2766,7 @@ int amdgpu_vm_ioctl(struct drm_device *dev, void *data, struct drm_file *filp) > * amdgpu_vm_handle_fault - graceful handling of VM faults. > * @adev: amdgpu device pointer > * @pasid: PASID of the VM > + * @ts: Timestamp of the fault > * @vmid: VMID, only used for GFX 9.4.3. > * @node_id: Node_id received in IH cookie. Only applicable for > * GFX 9.4.3. > -- > 2.34.1 > --------------3DlyGbBb6pIJxLXmc2iccFAK Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

It was generated from my patch "drm/amdkfd: Change kfd/svm page fault drain handling". kernel test robot <lkp@intel.com> also reported same. Please add:

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408251419.vgZHg3GV-lkp@intel.com/


Regards

Xiaogang

On 8/26/2024 8:26 AM, Srinivasan Shanmugam wrote:
Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.


This commit adds a description for the 'ts' parameter in the
amdgpu_vm_handle_fault function's comment block.

Fixes the below with gcc W=1:
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:2781: warning: Function parameter or struct member 'ts' not described in 'amdgpu_vm_handle_fault'

Cc: Christian König <christian.koenig@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
index ad2e469548c9..0fa165e8fb40 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
@@ -2766,6 +2766,7 @@ int amdgpu_vm_ioctl(struct drm_device *dev, void *data, struct drm_file *filp)
  * amdgpu_vm_handle_fault - graceful handling of VM faults.
  * @adev: amdgpu device pointer
  * @pasid: PASID of the VM
+ * @ts: Timestamp of the fault
  * @vmid: VMID, only used for GFX 9.4.3.
  * @node_id: Node_id received in IH cookie. Only applicable for
  *           GFX 9.4.3.
--
2.34.1
--------------3DlyGbBb6pIJxLXmc2iccFAK--