From: Dave Airlie <airlied-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: [PATCH 8/8] dal: assign correct enum for edp revision
Date: Tue, 13 Dec 2016 16:41:12 +1000 [thread overview]
Message-ID: <20161213064112.20004-9-airlied@gmail.com> (raw)
In-Reply-To: <20161213064112.20004-1-airlied-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
From: Dave Airlie <airlied@redhat.com>
There are 2 edp enum revisions, no idea why, drop one, and just
assign 1.1 to the default value.
Signed-off-by: Dave Airlie <airlied@redhat.com>
---
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 +-
drivers/gpu/drm/amd/display/include/dpcd_defs.h | 16 ----------------
2 files changed, 1 insertion(+), 17 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
index d3625c2..a4b6a6a 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
@@ -2129,7 +2129,7 @@ static void retrieve_link_cap(struct core_link *link)
link->dpcd_caps.panel_mode_edp =
edp_config_cap.bits.ALT_SCRAMBLER_RESET;
- link->edp_revision = DPCD_EDP_REVISION_EDP_UNKNOWN;
+ link->edp_revision = EDP_REVISION_11;
link->public.test_pattern_enabled = false;
link->public.compliance_test_state.raw = 0;
diff --git a/drivers/gpu/drm/amd/display/include/dpcd_defs.h b/drivers/gpu/drm/amd/display/include/dpcd_defs.h
index f0376f4..ba99e6b 100644
--- a/drivers/gpu/drm/amd/display/include/dpcd_defs.h
+++ b/drivers/gpu/drm/amd/display/include/dpcd_defs.h
@@ -144,22 +144,6 @@ enum dpcd_psr_sink_states {
PSR_SINK_STATE_SINK_INTERNAL_ERROR = 7,
};
-/* This enum defines the Panel's eDP revision at DPCD 700h
- * 00h = eDP v1.1 or lower
- * 01h = eDP v1.2
- * 02h = eDP v1.3 (PSR support starts here)
- * 03h = eDP v1.4
- * If unknown revision, treat as eDP v1.1, meaning least functionality set.
- * This enum has values matched to eDP spec, thus values should not change.
- */
-enum dpcd_edp_revision {
- DPCD_EDP_REVISION_EDP_V1_1 = 0,
- DPCD_EDP_REVISION_EDP_V1_2 = 1,
- DPCD_EDP_REVISION_EDP_V1_3 = 2,
- DPCD_EDP_REVISION_EDP_V1_4 = 3,
- DPCD_EDP_REVISION_EDP_UNKNOWN = DPCD_EDP_REVISION_EDP_V1_1,
-};
-
union dpcd_rev {
struct {
uint8_t MINOR:4;
--
2.9.3
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2016-12-13 6:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-13 6:41 some minor dal cleanups and example of future patches Dave Airlie
[not found] ` <20161213064112.20004-1-airlied-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-12-13 6:41 ` [PATCH 1/8] dc: remove dc hub - this seems unused Dave Airlie
2016-12-13 6:41 ` [PATCH 2/8] dal: remove some unused wrappers Dave Airlie
[not found] ` <20161213064112.20004-3-airlied-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-12-14 16:26 ` Harry Wentland
[not found] ` <f30d9730-8d3d-4b9d-ced2-4a1bb93138d2-5C7GfCeVMHo@public.gmane.org>
2016-12-14 16:36 ` Alex Deucher
2016-12-14 21:04 ` Dave Airlie
2016-12-19 12:46 ` Emil Velikov
[not found] ` <CACvgo53HxQq4HhizR-+VY4W7cGb5O3XXmLUNhEGbipeo8ODjWA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-12-19 12:53 ` StDenis, Tom
[not found] ` <CY4PR12MB1768D6FCEC097FCDE97E314EF7910-rpdhrqHFk06yjjPBNVDk/QdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2016-12-21 14:50 ` Emil Velikov
[not found] ` <CACvgo5220YNkWfW0xWr9Sn6a-tN8Ja02CZu65H2UWTQh+d_EZQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-12-21 15:04 ` Sagalovitch, Serguei
[not found] ` <SN1PR12MB07034F6B1DB5696FC2DA9729FE930-z7L1TMIYDg6P/i5UxMCIqAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2016-12-24 13:29 ` Emil Velikov
2016-12-19 15:27 ` Harry Wentland
2016-12-13 6:41 ` [PATCH 3/8] dal: drop register logger and pid/tgid getters Dave Airlie
[not found] ` <20161213064112.20004-4-airlied-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-12-13 10:07 ` Christian König
2016-12-13 6:41 ` [PATCH 4/8] dal: drop get platform info Dave Airlie
2016-12-13 6:41 ` [PATCH 5/8] dal: drop setmode complete notifier Dave Airlie
2016-12-13 6:41 ` [PATCH 6/8] drm/dp-helper: add missing defines needed by AMD display core Dave Airlie
2016-12-13 6:41 ` [PATCH 7/8] dal: port to using drm dpcd defines Dave Airlie
2016-12-13 6:41 ` Dave Airlie [this message]
2016-12-13 6:57 ` some minor dal cleanups and example of future patches Dave Airlie
2016-12-13 7:48 ` Edward O'Callaghan
2016-12-15 20:44 ` Harry Wentland
[not found] ` <b3875cd1-74e2-1902-abe7-e674a352855d-5C7GfCeVMHo@public.gmane.org>
2016-12-16 0:56 ` Michel Dänzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161213064112.20004-9-airlied@gmail.com \
--to=airlied-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox