From: Nils Holland <nholland-iI9p2NPcQ/rYtjvyW6yDsg@public.gmane.org>
To: kbuild test robot <fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: "Alex Deucher" <alexander.deucher-5C7GfCeVMHo@public.gmane.org>,
"Michel Dänzer" <michel.daenzer-5C7GfCeVMHo@public.gmane.org>,
kbuild-all-JC7UmRfGjtg@public.gmane.org,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
"Christian König" <christian.koenig-5C7GfCeVMHo@public.gmane.org>
Subject: Re: [radeon-alex:drm-next-4.11-wip 131/131] drivers/gpu/drm/amd/amdgpu/amdgpu_object.c:380:48: error: expected ')' before ';' token
Date: Tue, 24 Jan 2017 01:30:40 +0100 [thread overview]
Message-ID: <20170124003039.GA17304@tisys.org> (raw)
In-Reply-To: <201701240656.PoIVchhM%fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
On Tue, Jan 24, 2017 at 06:37:58AM +0800, kbuild test robot wrote:
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c: In function 'amdgpu_bo_create_restricted':
> >> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c:377:2: warning: #warning Please enable CONFIG_MTRR and CONFIG_X86_PAT for better performance thanks to write-combining [-Wcpp]
> #warning Please enable CONFIG_MTRR and CONFIG_X86_PAT for better performance \
> ^~~~~~~
> >> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c:380:48: error: expected ')' before ';' token
> if (bo->flags & AMDGPU_GEM_CREATE_CPU_GTT_USWC;)
> ^
>
> vim +380 drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>
> 371 #elif defined(CONFIG_X86) && !defined(CONFIG_X86_PAT)
> 372 /* Don't try to enable write-combining when it can't work, or things
> 373 * may be slow
> 374 * See https://bugs.freedesktop.org/show_bug.cgi?id=88758
> 375 */
> 376
> > 377 #warning Please enable CONFIG_MTRR and CONFIG_X86_PAT for better performance \
> 378 thanks to write-combining
> 379
> > 380 if (bo->flags & AMDGPU_GEM_CREATE_CPU_GTT_USWC;)
> 381 DRM_INFO_ONCE("Please enable CONFIG_MTRR and CONFIG_X86_PAT for "
> 382 "better performance thanks to write-combining\n");
> 383 bo->flags &= ~AMDGPU_GEM_CREATE_CPU_GTT_USWC;
Whoops, the robot is certainly right, there's a ; that doesn't belong
in line 380. Shame on me! :-(
Michel, now that you've already commited this patch, what do I do?
Should I submit another patch that just fixes this one issue, or
should I re-submit the whole patch, in fixed state, as a v2?
Sorry for the hassle! :-/
Greetings
Nils
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next parent reply other threads:[~2017-01-24 0:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201701240656.PoIVchhM%fengguang.wu@intel.com>
[not found] ` <201701240656.PoIVchhM%fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-01-24 0:30 ` Nils Holland [this message]
[not found] ` <20170124003039.GA17304-iI9p2NPcQ/rYtjvyW6yDsg@public.gmane.org>
2017-01-24 14:41 ` [radeon-alex:drm-next-4.11-wip 131/131] drivers/gpu/drm/amd/amdgpu/amdgpu_object.c:380:48: error: expected ')' before ';' token Deucher, Alexander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170124003039.GA17304@tisys.org \
--to=nholland-ii9p2npcq/rytjvyw6ydsg@public.gmane.org \
--cc=alexander.deucher-5C7GfCeVMHo@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=christian.koenig-5C7GfCeVMHo@public.gmane.org \
--cc=fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=kbuild-all-JC7UmRfGjtg@public.gmane.org \
--cc=michel.daenzer-5C7GfCeVMHo@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox