From: Harry Wentland <harry.wentland-5C7GfCeVMHo@public.gmane.org>
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: Harry Wentland <harry.wentland-5C7GfCeVMHo@public.gmane.org>
Subject: [PATCH 06/24] drm/amd/display: Call update_stream_signal directly from amdgpu_dm
Date: Thu, 18 Jan 2018 16:03:35 -0500 [thread overview]
Message-ID: <20180118210353.18842-7-harry.wentland@amd.com> (raw)
In-Reply-To: <20180118210353.18842-1-harry.wentland-5C7GfCeVMHo@public.gmane.org>
There's no good place in DC to cover all place where stream signal should
be updated. update_stream_signal depends on timing which comes from DM.
Signed-off-by: Harry Wentland <harry.wentland@amd.com>
Reviewed-by: Tony Cheng <Tony.Cheng@amd.com>
Acked-by: Harry Wentland <harry.wentland@amd.com>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 10 +++-------
drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 2 +-
drivers/gpu/drm/amd/display/dc/dc_stream.h | 2 ++
3 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index ebcad3078d14..c01ec8aacfb2 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -2452,6 +2452,7 @@ create_stream_for_sink(struct amdgpu_dm_connector *aconnector,
dm_state ? (dm_state->scaling != RMX_OFF) : false);
}
+ drm_mode_set_crtcinfo(&mode, 0);
fill_stream_properties_from_drm_display_mode(stream,
&mode, &aconnector->base);
update_stream_scaling_settings(&mode, dm_state, stream);
@@ -2461,6 +2462,8 @@ create_stream_for_sink(struct amdgpu_dm_connector *aconnector,
drm_connector,
aconnector->dc_sink);
+ update_stream_signal(stream);
+
return stream;
}
@@ -2865,13 +2868,6 @@ int amdgpu_dm_connector_mode_valid(struct drm_connector *connector,
goto fail;
}
- drm_mode_set_crtcinfo(mode, 0);
- fill_stream_properties_from_drm_display_mode(stream, mode, connector);
-
- stream->src.width = mode->hdisplay;
- stream->src.height = mode->vdisplay;
- stream->dst = stream->src;
-
dc_result = dc_validate_stream(adev->dm.dc, stream);
if (dc_result == DC_OK)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
index 3cbdd8cacd37..c3b198836d1d 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
@@ -33,7 +33,7 @@
/*******************************************************************************
* Private functions
******************************************************************************/
-static void update_stream_signal(struct dc_stream_state *stream)
+void update_stream_signal(struct dc_stream_state *stream)
{
struct dc_sink *dc_sink = stream->sink;
diff --git a/drivers/gpu/drm/amd/display/dc/dc_stream.h b/drivers/gpu/drm/amd/display/dc/dc_stream.h
index 7df75f8ae2b1..275215096f51 100644
--- a/drivers/gpu/drm/amd/display/dc/dc_stream.h
+++ b/drivers/gpu/drm/amd/display/dc/dc_stream.h
@@ -239,6 +239,8 @@ enum surface_update_type dc_check_update_surfaces_for_stream(
*/
struct dc_stream_state *dc_create_stream_for_sink(struct dc_sink *dc_sink);
+void update_stream_signal(struct dc_stream_state *stream);
+
void dc_stream_retain(struct dc_stream_state *dc_stream);
void dc_stream_release(struct dc_stream_state *dc_stream);
--
2.14.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2018-01-18 21:03 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-18 21:03 [PATCH 00/24] DC Patches Jan 18, 2018 Harry Wentland
[not found] ` <20180118210353.18842-1-harry.wentland-5C7GfCeVMHo@public.gmane.org>
2018-01-18 21:03 ` [PATCH 01/24] drm/amd/display: dc: Remove unused display_mode_vba.c Harry Wentland
[not found] ` <20180118210353.18842-2-harry.wentland-5C7GfCeVMHo@public.gmane.org>
2018-01-22 20:26 ` Andrey Grodzovsky
2018-01-22 21:27 ` [PATCH v2] " Harry Wentland
[not found] ` <20180122212733.18899-1-harry.wentland-5C7GfCeVMHo@public.gmane.org>
2018-01-22 21:29 ` Deucher, Alexander
2018-01-18 21:03 ` [PATCH 02/24] drm/amd/display: Update the register GRPH_SWAP_CNTL if surface pixel format changed Harry Wentland
2018-01-18 21:03 ` [PATCH 03/24] drm/amd/display: Remove unused param in DML Harry Wentland
2018-01-18 21:03 ` [PATCH 04/24] drm/amd/display: Move output_tf to stream_state/update Harry Wentland
2018-01-18 21:03 ` [PATCH 05/24] drm/amd/display: Early return on crc get Harry Wentland
2018-01-18 21:03 ` Harry Wentland [this message]
2018-01-18 21:03 ` [PATCH 07/24] drm/amd/display: Demote error print to debug print when ATOM impl missing Harry Wentland
2018-01-18 21:03 ` [PATCH 08/24] drm/amd/display: Synchronize update plane addr for freesync Harry Wentland
2018-01-18 21:03 ` [PATCH 09/24] drm/amd/display: Add timing generator count to resource pool Harry Wentland
2018-01-18 21:03 ` [PATCH 10/24] drm/amd/display: fix backlight not off at resume from S4 Harry Wentland
2018-01-18 21:03 ` [PATCH 11/24] drm/amd/display: Define dpp1_set_cursor_position in header Harry Wentland
2018-01-18 21:03 ` [PATCH 12/24] drm/amd/display: disable az_clock_gating for endpoint register access only Harry Wentland
2018-01-18 21:03 ` [PATCH 13/24] drm/amd/display: revert to hacking bounding box for pipe split Harry Wentland
2018-01-18 21:03 ` [PATCH 14/24] drm/amd/display: dpms off mute az audio endpoint only Harry Wentland
2018-01-18 21:03 ` [PATCH 15/24] drm/amd/display: Fix deadlock when flushing irq Harry Wentland
[not found] ` <20180118210353.18842-16-harry.wentland-5C7GfCeVMHo@public.gmane.org>
2018-01-19 18:33 ` Andrey Grodzovsky
[not found] ` <2996fec0-814d-ec58-788b-883df20d2651-5C7GfCeVMHo@public.gmane.org>
2018-01-22 14:38 ` Lipski, Mikita
[not found] ` <BN6PR1201MB0100D9415FC07D00CBE859CCE4EF0-6iU6OBHu2P8MZuswy4CCPGrFom/aUZj6nBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2018-01-22 14:57 ` Andrey Grodzovsky
[not found] ` <a5d20d38-760e-a4ef-5f79-8774e70f3a4c-5C7GfCeVMHo@public.gmane.org>
2018-01-22 15:53 ` Harry Wentland
[not found] ` <fd132165-4c3e-09e4-ec1c-d583263a2917-5C7GfCeVMHo@public.gmane.org>
2018-01-22 16:01 ` Andrey Grodzovsky
[not found] ` <98d53b0d-855f-1702-3c10-2b11ec416cc3-5C7GfCeVMHo@public.gmane.org>
2018-01-22 17:23 ` Deucher, Alexander
2018-01-18 21:03 ` [PATCH 16/24] drm/amd/display: dal 3.1.29 Harry Wentland
2018-01-18 21:03 ` [PATCH 17/24] drm/amd/display: Force full update on pixel_format_change Harry Wentland
2018-01-18 21:03 ` [PATCH 18/24] drm/amd/display: Add debug flag for p010_mpo_support Harry Wentland
2018-01-18 21:03 ` [PATCH 19/24] drm/amd/display: eDP sequence BL off first then DP blank Harry Wentland
2018-01-18 21:03 ` [PATCH 20/24] drm/amd/display: Fix unused variable compilation error Harry Wentland
2018-01-18 21:03 ` [PATCH 21/24] drm/amd/display: Add temporary delay on disconnect patch Harry Wentland
2018-01-18 21:03 ` [PATCH 22/24] drm/amd/display: Remove unnecessary register programming Harry Wentland
2018-01-18 21:03 ` [PATCH 23/24] drm/amd/display: Add temporary delay on disconnect patch Harry Wentland
2018-01-18 21:03 ` [PATCH 24/24] drm/amd/display: Fix warning about misaligned code Harry Wentland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180118210353.18842-7-harry.wentland@amd.com \
--to=harry.wentland-5c7gfcevmho@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox