From: Alex Deucher <alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: Alex Deucher <alexander.deucher-5C7GfCeVMHo@public.gmane.org>
Subject: [PATCH 4/4] drm/amdgpu/gmc9: don't keep stolen memory on vega20
Date: Thu, 30 Aug 2018 09:53:39 -0500 [thread overview]
Message-ID: <20180830145339.5162-4-alexander.deucher@amd.com> (raw)
In-Reply-To: <20180830145339.5162-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
Vega20 does not appear to be affected by the same issue
as vega10. Enable the full stolen memory handling on
vega20. Reserve the appropriate size at init time to avoid
display artifacts and then free it at the end of init once
the new FB is up and running.
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
Can someone test this on Vega20? I don't have one.
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
index 3180113f49ae..f467638eb49d 100644
--- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
@@ -705,14 +705,13 @@ static bool gmc_v9_0_keep_stolen_memory(struct amdgpu_device *adev)
* Also check code in gmc_v9_0_get_vbios_fb_size and gmc_v9_0_late_init
*/
switch (adev->asic_type) {
+ case CHIP_VEGA10:
+ return true;
case CHIP_RAVEN:
- return false;
case CHIP_VEGA12:
- return false;
- case CHIP_VEGA10:
case CHIP_VEGA20:
default:
- return true;
+ return false;
}
}
--
2.13.6
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2018-08-30 14:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-30 14:53 [PATCH 1/4] drm/amdgpu/gmc9: rework stolen vga memory handling Alex Deucher
[not found] ` <20180830145339.5162-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
2018-08-30 14:53 ` [PATCH 2/4] drm/amdgpu/gmc9: don't keep stolen memory on Raven Alex Deucher
[not found] ` <20180830145339.5162-2-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
2018-08-31 2:03 ` Zhang, Jerry (Junwei)
2018-08-30 14:53 ` [PATCH 3/4] drm/amdgpu/gmc9: don't keep stolen memory on vega12 Alex Deucher
2018-08-30 14:53 ` Alex Deucher [this message]
2018-08-31 2:03 ` [PATCH 1/4] drm/amdgpu/gmc9: rework stolen vga memory handling Zhang, Jerry (Junwei)
2018-08-31 8:20 ` Christian König
[not found] ` <9e88efe2-029e-1b98-2362-8ff5cc400ad1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-09-02 14:56 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180830145339.5162-4-alexander.deucher@amd.com \
--to=alexdeucher-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=alexander.deucher-5C7GfCeVMHo@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox