public inbox for amd-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: linux-fbdev@vger.kernel.org,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	David Airlie <airlied@linux.ie>,
	amd-gfx@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	linux-tegra@vger.kernel.org,
	Thierry Reding <thierry.reding@gmail.com>,
	dri-devel@lists.freedesktop.org, Daniel Vetter <daniel@ffwll.ch>,
	Alex Deucher <alexander.deucher@amd.com>,
	Maxime Ripard <maxime.ripard@bootlin.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 00/12] remove_conflicting_framebuffers() cleanup
Date: Sat, 1 Sep 2018 15:45:31 +0200	[thread overview]
Message-ID: <20180901134531.GA23402@qmqm.qmqm.pl> (raw)
In-Reply-To: <153570646209.15613.3061584574975657074@skylake-alporthouse-com>

On Fri, Aug 31, 2018 at 10:07:42AM +0100, Chris Wilson wrote:
[...]
> Ahah, someone is looking at remove_conflicting_framebuffers(). May I
> interest you in a use-after-free?

> [  378.423513] stack segment: 0000 [#1] PREEMPT SMP PTI
> [  378.423530] CPU: 1 PID: 4338 Comm: pm_rpm Tainted: G     U            4.19.0-rc1-CI-CI_DRM_4746+ #1
> [  378.423548] Hardware name: To Be Filled By O.E.M. To Be Filled By O.E.M./J4205-ITX, BIOS P1.10 09/29/2016
> [  378.423570] RIP: 0010:do_remove_conflicting_framebuffers+0x56/0x170
> [  378.423587] Code: 49 8b 45 00 48 85 c0 74 50 f6 40 0a 08 74 4a 4d 85 e4 48 8b a8 78 04 00 00 74 1f 48 85 ed 74 1a 41 8b 0c 24 31 db 85 c9 74 10 <8b> 55 00 85 d2 75 42 83 c3 01 41 39 1c 24 77 f0 48 85 ed 74 1a 45
> [  378.423620] RSP: 0018:ffffc900001dfa88 EFLAGS: 00010202
> [  378.423632] RAX: ffff880274470008 RBX: 0000000000000000 RCX: 0000000000000001
> [  378.423646] RDX: 0000000000000001 RSI: ffffffffa025c634 RDI: ffff88025cc3b428
> [  378.423660] RBP: 6b6b6b6b6b6b6b6b R08: 000000001edaddfa R09: ffffffffa025c634
> [  378.423673] R10: ffffc900001dfae8 R11: ffffffff820de938 R12: ffff88025cc3b428
> [  378.423687] R13: ffffffff8234ca20 R14: ffffffff8234cb20 R15: 0000000000000001
> [  378.423701] FS:  00007fcf03d0a980(0000) GS:ffff880277e80000(0000) knlGS:0000000000000000
> [  378.423717] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [  378.423729] CR2: 00007fffece1fdb8 CR3: 00000001fe32e000 CR4: 00000000003406e0
> [  378.423742] Call Trace:
> [  378.423756]  remove_conflicting_framebuffers+0x28/0x40
> [  378.423856]  i915_driver_load+0x7f5/0x10c0 [i915]
[...]

Looks like registered_fb[] entry is pointing to (partially?) freed or
corrupted fb_info, but I can't see how this could be an effect of
remove_conflicting_framebuffers().

Best Regards,
Michał Mirosław

  reply	other threads:[~2018-09-01 13:45 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-24 17:53 [PATCH 00/13] remove_conflicting_framebuffers() cleanup Michał Mirosław
     [not found] ` <cover.1511544782.git.mirq-linux-CoA6ZxLDdyEEUmgCuDUIdw@public.gmane.org>
2017-11-24 17:53   ` [PATCH 03/13] drm/amdgpu: use simpler remove_conflicting_pci_framebuffers() Michał Mirosław
2017-11-27 15:27     ` Alex Deucher
2017-11-24 17:53   ` [PATCH 07/13] drm/radeon: " Michał Mirosław
2017-11-24 17:53 ` [PATCH 02/13] fbdev: add remove_conflicting_pci_framebuffers() Michał Mirosław
     [not found]   ` <1738dbed0239bffc886f126fd3091daa39cd14c9.1511544782.git.mirq-linux-CoA6ZxLDdyEEUmgCuDUIdw@public.gmane.org>
2017-11-27 10:27     ` Daniel Vetter
2017-11-27 20:52       ` Sudip Mukherjee
2017-11-28 10:22         ` Daniel Vetter
2017-11-28 11:32           ` Greg KH
2017-11-28 12:30             ` Sudip Mukherjee
2017-11-28 13:06               ` Greg KH
2017-11-29  9:56               ` Daniel Vetter
2017-11-30 23:49                 ` Sudip Mukherjee
2017-12-01  7:19                   ` Daniel Vetter
2017-12-01 14:10                     ` Sudip Mukherjee
2017-12-01 14:40                   ` Emil Velikov
2017-12-11 21:57                     ` Sudip Mukherjee
2017-11-27 10:30 ` [PATCH 00/13] remove_conflicting_framebuffers() cleanup Daniel Vetter
     [not found]   ` <20171127103044.faakzch7ehlkc3or-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2017-11-27 10:33     ` Thierry Reding
2018-01-03 15:04     ` Bartlomiej Zolnierkiewicz
2018-08-30 21:00 ` [PATCH v2 00/12] " Michał Mirosław
2018-08-30 21:00   ` [PATCH v2 01/12] fbdev: show fbdev number for debugging Michał Mirosław
2018-08-30 21:00   ` [PATCH v2 02/12] fbdev: allow apertures == NULL in remove_conflicting_framebuffers() Michał Mirosław
2018-08-31  8:56     ` Daniel Vetter
     [not found]       ` <20180831085656.GR21634-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2018-08-31  9:01         ` Daniel Vetter
2018-08-30 21:00   ` [PATCH v2 04/12] drm/amdgpu: use simpler remove_conflicting_pci_framebuffers() Michał Mirosław
2018-08-30 21:00   ` [PATCH v2 03/12] fbdev: add remove_conflicting_pci_framebuffers() Michał Mirosław
2018-08-30 21:00   ` [PATCH v2 06/12] drm/cirrus: use simpler remove_conflicting_pci_framebuffers() Michał Mirosław
2018-08-30 21:00   ` [PATCH v2 05/12] drm/bochs: " Michał Mirosław
2018-08-30 21:00   ` [PATCH v2 08/12] drm/radeon: " Michał Mirosław
2018-08-30 21:00   ` [PATCH v2 07/12] drm/mgag200: " Michał Mirosław
2018-08-30 21:00   ` [PATCH v2 09/12] drm/virtio: " Michał Mirosław
2018-08-30 21:00   ` [PATCH v2 10/12] drm/vc4: use simpler remove_conflicting_framebuffers(NULL) Michał Mirosław
2018-08-30 21:00   ` [PATCH v2 11/12] drm/sun4i: " Michał Mirosław
2018-08-30 21:00   ` [PATCH v2 12/12] drm/tegra: kick out simplefb Michał Mirosław
2018-08-31  9:04   ` [PATCH v2 00/12] remove_conflicting_framebuffers() cleanup Daniel Vetter
     [not found]     ` <20180831090439.GT21634-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2018-08-31  9:07       ` Chris Wilson
2018-09-01 13:45         ` Michał Mirosław [this message]
2018-09-01 14:08   ` [PATCH v3 00/13] " Michał Mirosław
2018-09-01 14:08     ` [PATCH v3 02/13] fbdev: allow apertures == NULL in remove_conflicting_framebuffers() Michał Mirosław
2018-09-01 14:08     ` [PATCH v3 01/13] fbdev: show fbdev number for debugging Michał Mirosław
2018-09-01 14:08     ` [PATCH v3 04/13] fbdev: add remove_conflicting_pci_framebuffers() Michał Mirosław
2018-09-03 16:16       ` Daniel Vetter
2018-09-04 15:40       ` kbuild test robot
2018-09-01 14:08     ` [PATCH v3 03/13] fbdev: add kerneldoc do remove_conflicting_framebuffers() Michał Mirosław
     [not found]       ` <283fef19815b991700b56119d8d5874a2a8da44e.1535810304.git.mirq-linux-CoA6ZxLDdyEEUmgCuDUIdw@public.gmane.org>
2018-09-05 11:02         ` Paul Menzel
2018-09-01 14:08     ` [PATCH v3 06/13] drm/bochs: use simpler remove_conflicting_pci_framebuffers() Michał Mirosław
2018-09-01 14:08     ` [PATCH v3 05/13] drm/amdgpu: " Michał Mirosław
2018-09-01 14:08     ` [PATCH v3 07/13] drm/cirrus: " Michał Mirosław
2018-09-01 14:08     ` [PATCH v3 09/13] drm/radeon: " Michał Mirosław
2018-09-01 14:08     ` [PATCH v3 08/13] drm/mgag200: " Michał Mirosław
2018-09-01 14:08     ` [PATCH v3 10/13] drm/virtio: " Michał Mirosław
2018-09-01 14:08     ` [PATCH v3 11/13] drm/vc4: use simpler remove_conflicting_framebuffers(NULL) Michał Mirosław
2018-09-01 14:08     ` [PATCH v3 13/13] drm/tegra: kick out simplefb Michał Mirosław
2018-09-01 14:08     ` [PATCH v3 12/13] drm/sun4i: use simpler remove_conflicting_framebuffers(NULL) Michał Mirosław
     [not found]     ` <cover.1535810304.git.mirq-linux-CoA6ZxLDdyEEUmgCuDUIdw@public.gmane.org>
2018-09-03  7:43       ` [PATCH v3 00/13] remove_conflicting_framebuffers() cleanup Daniel Vetter
     [not found]         ` <20180903074315.GB21634-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2018-09-03 11:31           ` Bartlomiej Zolnierkiewicz
2018-09-03 16:26             ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180901134531.GA23402@qmqm.qmqm.pl \
    --to=mirq-linux@rere.qmqm.pl \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=b.zolnierkie@samsung.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=maxime.ripard@bootlin.com \
    --cc=thierry.reding@gmail.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox