From mboxrd@z Thu Jan 1 00:00:00 1970 From: Huang Rui Subject: Re: [PATCH 01/11] drm/amdgpu: try allocating VRAM as power of two Date: Tue, 11 Sep 2018 17:50:29 +0800 Message-ID: <20180911095027.GA5590@hr-amur2> References: <20180909180339.1910-1-christian.koenig@amd.com> <20180909180339.1910-2-christian.koenig@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180909180339.1910-2-christian.koenig-5C7GfCeVMHo@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org T24gU3VuLCBTZXAgMDksIDIwMTggYXQgMDg6MDM6MjlQTSArMDIwMCwgQ2hyaXN0aWFuIEvDtm5p ZyB3cm90ZToKPiBUcnkgdG8gYWxsb2NhdGUgVlJBTSBpbiBwb3dlciBvZiB0d28gc2l6ZXMgYW5k IG9ubHkgZmFsbGJhY2sgdG8gdnJhbQo+IHNwbGl0IHNpemVzIGlmIHRoYXQgZmFpbHMuCj4gCj4g U2lnbmVkLW9mZi1ieTogQ2hyaXN0aWFuIEvDtm5pZyA8Y2hyaXN0aWFuLmtvZW5pZ0BhbWQuY29t Pgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdnJhbV9tZ3IuYyB8 IDUyICsrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDQwIGlu c2VydGlvbnMoKyksIDEyIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdnJhbV9tZ3IuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQv YW1kZ3B1L2FtZGdwdV92cmFtX21nci5jCj4gaW5kZXggOWNmYThhOWFkYTkyLi4zZjlkNWQwMGM5 YjMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3ZyYW1f bWdyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdnJhbV9tZ3Iu Ywo+IEBAIC0xMjQsNiArMTI0LDI4IEBAIHU2NCBhbWRncHVfdnJhbV9tZ3JfYm9fdmlzaWJsZV9z aXplKHN0cnVjdCBhbWRncHVfYm8gKmJvKQo+ICAJcmV0dXJuIHVzYWdlOwo+ICB9Cj4gIAo+ICsv KioKPiArICogYW1kZ3B1X3ZyYW1fbWdyX3ZpcnRfc3RhcnQgLSB1cGRhdGUgdmlydHVhbCBzdGFy dCBhZGRyZXNzCj4gKyAqCj4gKyAqIEBtZW06IHR0bV9tZW1fcmVnIHRvIHVwZGF0ZQo+ICsgKiBA bm9kZToganVzdCBhbGxvY2F0ZWQgbm9kZQo+ICsgKgo+ICsgKiBDYWxjdWxhdGUgYSB2aXJ0dWFs IEJPIHN0YXJ0IGFkZHJlc3MgdG8gZWFzaWx5IGNoZWNrIGlmIGV2ZXJ5dGhpbmcgaXMgQ1BVCj4g KyAqIGFjY2Vzc2libGUuCj4gKyAqLwo+ICtzdGF0aWMgdm9pZCBhbWRncHVfdnJhbV9tZ3Jfdmly dF9zdGFydChzdHJ1Y3QgdHRtX21lbV9yZWcgKm1lbSwKPiArCQkJCSAgICAgICBzdHJ1Y3QgZHJt X21tX25vZGUgKm5vZGUpCj4gK3sKPiArCXVuc2lnbmVkIGxvbmcgc3RhcnQ7Cj4gKwo+ICsJc3Rh cnQgPSBub2RlLT5zdGFydCArIG5vZGUtPnNpemU7Cj4gKwlpZiAoc3RhcnQgPiBtZW0tPm51bV9w YWdlcykKPiArCQlzdGFydCAtPSBtZW0tPm51bV9wYWdlczsKPiArCWVsc2UKPiArCQlzdGFydCA9 IDA7Cj4gKwltZW0tPnN0YXJ0ID0gbWF4KG1lbS0+c3RhcnQsIHN0YXJ0KTsKPiArfQo+ICsKCkhv dyBhYm91dCBtb3ZlIHRoaXMgZnVuY3Rpb24gaW50byB0dG0gKHR0bV9ib19tYW5hZ2VyLmMpIHRo ZW4gZXhwb3J0IHRoZQpzeW1ib2wsIGl0IGxvb2tzIG1vcmUgbGlrZSBhIHR0bSBoZWxwZXIgZnVu Y3Rpb24uCgpUaGFua3MsClJheQoKPiAgLyoqCj4gICAqIGFtZGdwdV92cmFtX21ncl9uZXcgLSBh bGxvY2F0ZSBuZXcgcmFuZ2VzCj4gICAqCj4gQEAgLTE3NiwxMCArMTk4LDI1IEBAIHN0YXRpYyBp bnQgYW1kZ3B1X3ZyYW1fbWdyX25ldyhzdHJ1Y3QgdHRtX21lbV90eXBlX21hbmFnZXIgKm1hbiwK PiAgCXBhZ2VzX2xlZnQgPSBtZW0tPm51bV9wYWdlczsKPiAgCj4gIAlzcGluX2xvY2soJm1nci0+ bG9jayk7Cj4gLQlmb3IgKGkgPSAwOyBpIDwgbnVtX25vZGVzOyArK2kpIHsKPiArCWZvciAoaSA9 IDA7IHBhZ2VzX2xlZnQgPj0gcGFnZXNfcGVyX25vZGU7ICsraSkgewo+ICsJCXVuc2lnbmVkIGxv bmcgcGFnZXMgPSByb3VuZGRvd25fcG93X29mX3R3byhwYWdlc19sZWZ0KTsKPiArCj4gKwkJciA9 IGRybV9tbV9pbnNlcnRfbm9kZV9pbl9yYW5nZShtbSwgJm5vZGVzW2ldLCBwYWdlcywKPiArCQkJ CQkJcGFnZXNfcGVyX25vZGUsIDAsCj4gKwkJCQkJCXBsYWNlLT5mcGZuLCBscGZuLAo+ICsJCQkJ CQltb2RlKTsKPiArCQlpZiAodW5saWtlbHkocikpCj4gKwkJCWJyZWFrOwo+ICsKPiArCQl1c2Fn ZSArPSBub2Rlc1tpXS5zaXplIDw8IFBBR0VfU0hJRlQ7Cj4gKwkJdmlzX3VzYWdlICs9IGFtZGdw dV92cmFtX21ncl92aXNfc2l6ZShhZGV2LCAmbm9kZXNbaV0pOwo+ICsJCWFtZGdwdV92cmFtX21n cl92aXJ0X3N0YXJ0KG1lbSwgJm5vZGVzW2ldKTsKPiArCQlwYWdlc19sZWZ0IC09IHBhZ2VzOwo+ ICsJfQo+ICsKPiArCWZvciAoOyBwYWdlc19sZWZ0OyArK2kpIHsKPiAgCQl1bnNpZ25lZCBsb25n IHBhZ2VzID0gbWluKHBhZ2VzX2xlZnQsIHBhZ2VzX3Blcl9ub2RlKTsKPiAgCQl1aW50MzJfdCBh bGlnbm1lbnQgPSBtZW0tPnBhZ2VfYWxpZ25tZW50Owo+IC0JCXVuc2lnbmVkIGxvbmcgc3RhcnQ7 Cj4gIAo+ICAJCWlmIChwYWdlcyA9PSBwYWdlc19wZXJfbm9kZSkKPiAgCQkJYWxpZ25tZW50ID0g cGFnZXNfcGVyX25vZGU7Cj4gQEAgLTE5MywxNiArMjMwLDcgQEAgc3RhdGljIGludCBhbWRncHVf dnJhbV9tZ3JfbmV3KHN0cnVjdCB0dG1fbWVtX3R5cGVfbWFuYWdlciAqbWFuLAo+ICAKPiAgCQl1 c2FnZSArPSBub2Rlc1tpXS5zaXplIDw8IFBBR0VfU0hJRlQ7Cj4gIAkJdmlzX3VzYWdlICs9IGFt ZGdwdV92cmFtX21ncl92aXNfc2l6ZShhZGV2LCAmbm9kZXNbaV0pOwo+IC0KPiAtCQkvKiBDYWxj dWxhdGUgYSB2aXJ0dWFsIEJPIHN0YXJ0IGFkZHJlc3MgdG8gZWFzaWx5IGNoZWNrIGlmCj4gLQkJ ICogZXZlcnl0aGluZyBpcyBDUFUgYWNjZXNzaWJsZS4KPiAtCQkgKi8KPiAtCQlzdGFydCA9IG5v ZGVzW2ldLnN0YXJ0ICsgbm9kZXNbaV0uc2l6ZTsKPiAtCQlpZiAoc3RhcnQgPiBtZW0tPm51bV9w YWdlcykKPiAtCQkJc3RhcnQgLT0gbWVtLT5udW1fcGFnZXM7Cj4gLQkJZWxzZQo+IC0JCQlzdGFy dCA9IDA7Cj4gLQkJbWVtLT5zdGFydCA9IG1heChtZW0tPnN0YXJ0LCBzdGFydCk7Cj4gKwkJYW1k Z3B1X3ZyYW1fbWdyX3ZpcnRfc3RhcnQobWVtLCAmbm9kZXNbaV0pOwo+ICAJCXBhZ2VzX2xlZnQg LT0gcGFnZXM7Cj4gIAl9Cj4gIAlzcGluX3VubG9jaygmbWdyLT5sb2NrKTsKPiAtLSAKPiAyLjE0 LjEKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ IGFtZC1nZnggbWFpbGluZyBsaXN0Cj4gYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWls aW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg==