From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/9] drm: Add variable refresh rate properties to DRM connector Date: Tue, 11 Sep 2018 19:22:43 +0300 Message-ID: <20180911162243.GN5565@intel.com> References: <20180911161333.5334-1-nicholas.kazlauskas@amd.com> <20180911161333.5334-2-nicholas.kazlauskas@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180911161333.5334-2-nicholas.kazlauskas@amd.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Nicholas Kazlauskas Cc: nicolai.haehnle@amd.com, michel@daenzer.net, amd-gfx@lists.freedesktop.org, Christian.Koenig@amd.com, manasi.d.navare@intel.com, dri-devel@lists.freedesktop.org, Alexander.Deucher@amd.com, Marek.Olsak@amd.com List-Id: amd-gfx.lists.freedesktop.org T24gVHVlLCBTZXAgMTEsIDIwMTggYXQgMTI6MTM6MjVQTSAtMDQwMCwgTmljaG9sYXMgS2F6bGF1 c2thcyB3cm90ZToKPiBNb2Rlcm4gbW9uaXRvciBoYXJkd2FyZSBpcyBjYXBhYmxlIG9mIHN1cHBv cnRpbmcgdmFyaWFibGUgcmVmcmVzaCByYXRlcwo+IGFuZCBhZGFwdGl2ZSBzeW5jIHRlY2hub2xv Z2llcy4gVGhlIHByb3BlcnRpZXMgZm9yIHF1ZXJ5aW5nIGFuZAo+IGNvbnRyb2xsaW5nIHRoZXNl IGZlYXR1cmVzIHNob3VsZCBiZSBleHBvc2VkIG9uIHRoZSBEUk0gY29ubmVjdG9yLgo+IAo+IFRo aXMgcGF0Y2ggaW50cm9kdWNlcyB0d28gbmV3IHByb3BlcnRpZXMgZm9yIHZhcmlhYmxlIHJlZnJl c2ggcmF0ZQo+IHN1cHBvcnQ6Cj4gCj4gLSB2YXJpYWJsZV9yZWZyZXNoX2NhcGFibGUKPiAtIHZh cmlhYmxlX3JlZnJlc2hfZW5hYmxlZAo+IAo+IFRoZXNlIGFyZSBvcHRpb25hbCBwcm9wZXJ0aWVz IHRoYXQgY2FuIGJlIGFkZGVkIHRvIGEgRFJNIGNvbm5lY3Rvcgo+IGR5bmFtaWNhbGx5IGJ5IHVz aW5nIGRybV9jb25uZWN0b3JfYXR0YWNoX3ZhcmlhYmxlX3JlZnJlc2hfcHJvcGVydGllcy4KPiAK PiBEUk0gZHJpdmVycyBzaG91bGQgc2V0IHZhcmlhYmxlX3JlZnJlc2hfY2FwYWJsZSBhcyBhcHBs aWNhYmxlIGZvcgo+IHRoZWlyIGhhcmR3YXJlLiBUaGUgcHJvcGVydHkgdmFyaWFibGVfcmVmcmVz aF9lbmFibGVkIGFzIGEgdXNlcnNwYWNlCj4gY29udHJvbGxlZCBvcHRpb24uCj4gCj4gQ2hhbmdl LUlkOiBJNWY2MGY4YjU3NTM0ZTFkM2RhY2RhNGM2NGM2YzkxMDZiNDJmNDQzOQo+IFNpZ25lZC1v ZmYtYnk6IE5pY2hvbGFzIEthemxhdXNrYXMgPG5pY2hvbGFzLmthemxhdXNrYXNAYW1kLmNvbT4K PiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWMuYyAgICB8ICA5ICsrKysrKysrKwo+ ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2Nvbm5lY3Rvci5jIHwgMzUgKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrCj4gIGluY2x1ZGUvZHJtL2RybV9jb25uZWN0b3IuaCAgICAgfCAyNyAr KysrKysrKysrKysrKysrKysrKysrKysrCj4gIDMgZmlsZXMgY2hhbmdlZCwgNzEgaW5zZXJ0aW9u cygrKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pYy5jIGIvZHJp dmVycy9ncHUvZHJtL2RybV9hdG9taWMuYwo+IGluZGV4IGQwNDc4YWJjMDFiZC4uMmY4OWFiMGZh Yzg3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljLmMKPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pYy5jCj4gQEAgLTE0MDMsNiArMTQwMywxMSBAQCBzdGF0 aWMgaW50IGRybV9hdG9taWNfY29ubmVjdG9yX3NldF9wcm9wZXJ0eShzdHJ1Y3QgZHJtX2Nvbm5l Y3RvciAqY29ubmVjdG9yLAo+ICAJCXN0YXRlLT5jb250ZW50X3R5cGUgPSB2YWw7Cj4gIAl9IGVs c2UgaWYgKHByb3BlcnR5ID09IGNvbm5lY3Rvci0+c2NhbGluZ19tb2RlX3Byb3BlcnR5KSB7Cj4g IAkJc3RhdGUtPnNjYWxpbmdfbW9kZSA9IHZhbDsKPiArCX0gZWxzZSBpZiAocHJvcGVydHkgPT0g Y29ubmVjdG9yLT52YXJpYWJsZV9yZWZyZXNoX2NhcGFibGVfcHJvcGVydHkpIHsKPiArCQlEUk1f REVCVUdfS01TKCJvbmx5IGRyaXZlcnMgY2FuIHNldCB2YXJpYWJsZV9yZWZyZXNoX2NhcGFibGVc biIpOwo+ICsJCXJldHVybiAtRUlOVkFMOwoKV2h5IGlzIHRoYXQgbmVlZGVkPyBXaHkgbm90IGp1 c3QgYXZvaWQgZXhwb3NpbmcgdGhlIHZycl9lbmFibGVkIHByb3AKd2hlbiBpdCdzIG5vdCBzdXBw b3J0ZWQ/Cgo+ICsJfSBlbHNlIGlmIChwcm9wZXJ0eSA9PSBjb25uZWN0b3ItPnZhcmlhYmxlX3Jl ZnJlc2hfZW5hYmxlZF9wcm9wZXJ0eSkgewo+ICsJCXN0YXRlLT52YXJpYWJsZV9yZWZyZXNoX2Vu YWJsZWQgPSB2YWw7CgpTbyBvbmUgdGhpbmcgSSBhbHJlYWR5IGFza2VkIGxvbmcgYWdvIGlzIHdo ZXRoZXIgdGhlcmUgd291bGQgYSBwb2ludCBpbgpleHBvc2luZyBzb21lIGtpbmQgb2YgbWluL21h eCByZWZyZXNoIHJhdGUgcmFuZ2UgY29udHJvbC4gTmV2ZXIgcmVhbGx5CmdvdCBhbiBhbnN3ZXIu IFdhcyBzb21laHRpbmcgbGlrZSB0aGF0IGNvbnNpZGVyZWQgYW5kIHJlamVjdGVkPwoKPiAgCX0g ZWxzZSBpZiAocHJvcGVydHkgPT0gY29ubmVjdG9yLT5jb250ZW50X3Byb3RlY3Rpb25fcHJvcGVy dHkpIHsKPiAgCQlpZiAodmFsID09IERSTV9NT0RFX0NPTlRFTlRfUFJPVEVDVElPTl9FTkFCTEVE KSB7Cj4gIAkJCURSTV9ERUJVR19LTVMoIm9ubHkgZHJpdmVycyBjYW4gc2V0IENQIEVuYWJsZWRc biIpOwo+IEBAIC0xNTA4LDYgKzE1MTMsMTAgQEAgZHJtX2F0b21pY19jb25uZWN0b3JfZ2V0X3By b3BlcnR5KHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsCj4gIAkJKnZhbCA9IHN0YXRl LT5jb250ZW50X3R5cGU7Cj4gIAl9IGVsc2UgaWYgKHByb3BlcnR5ID09IGNvbm5lY3Rvci0+c2Nh bGluZ19tb2RlX3Byb3BlcnR5KSB7Cj4gIAkJKnZhbCA9IHN0YXRlLT5zY2FsaW5nX21vZGU7Cj4g Kwl9IGVsc2UgaWYgKHByb3BlcnR5ID09IGNvbm5lY3Rvci0+dmFyaWFibGVfcmVmcmVzaF9jYXBh YmxlX3Byb3BlcnR5KSB7Cj4gKwkJKnZhbCA9IHN0YXRlLT52YXJpYWJsZV9yZWZyZXNoX2NhcGFi bGU7Cj4gKwl9IGVsc2UgaWYgKHByb3BlcnR5ID09IGNvbm5lY3Rvci0+dmFyaWFibGVfcmVmcmVz aF9lbmFibGVkX3Byb3BlcnR5KSB7Cj4gKwkJKnZhbCA9IHN0YXRlLT52YXJpYWJsZV9yZWZyZXNo X2VuYWJsZWQ7Cj4gIAl9IGVsc2UgaWYgKHByb3BlcnR5ID09IGNvbm5lY3Rvci0+Y29udGVudF9w cm90ZWN0aW9uX3Byb3BlcnR5KSB7Cj4gIAkJKnZhbCA9IHN0YXRlLT5jb250ZW50X3Byb3RlY3Rp b247Cj4gIAl9IGVsc2UgaWYgKHByb3BlcnR5ID09IGNvbmZpZy0+d3JpdGViYWNrX2ZiX2lkX3By b3BlcnR5KSB7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fY29ubmVjdG9yLmMg Yi9kcml2ZXJzL2dwdS9kcm0vZHJtX2Nvbm5lY3Rvci5jCj4gaW5kZXggNjAxMWQ3NjlkNTBiLi4z N2ZiMzNmYTc3YjkgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9jb25uZWN0b3Iu Ywo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fY29ubmVjdG9yLmMKPiBAQCAtMTI1MCw2ICsx MjUwLDQxIEBAIGludCBkcm1fbW9kZV9jcmVhdGVfc2NhbGluZ19tb2RlX3Byb3BlcnR5KHN0cnVj dCBkcm1fZGV2aWNlICpkZXYpCj4gIH0KPiAgRVhQT1JUX1NZTUJPTChkcm1fbW9kZV9jcmVhdGVf c2NhbGluZ19tb2RlX3Byb3BlcnR5KTsKPiAgCj4gKy8qKgo+ICsgKiBkcm1fY29ubmVjdG9yX2F0 dGFjaF92YXJpYWJsZV9yZWZyZXNoX3Byb3BlcnRpZXMgLSBjcmVhdGVzIGFuZCBhdHRhY2hlcwo+ ICsgKiBwcm9wZXJ0aWVzIGZvciBjb25uZWN0b3JzIHRoYXQgc3VwcG9ydCBhZGFwdGl2ZSByZWZy ZXNoCj4gKyAqIEBjb25uZWN0b3I6IGNvbm5lY3RvciB0byBjcmVhdGUgYWRhcHRpdmUgcmVmcmVz aCBwcm9wZXJ0aWVzIG9uCj4gKyAqLwo+ICtpbnQgZHJtX2Nvbm5lY3Rvcl9hdHRhY2hfdmFyaWFi bGVfcmVmcmVzaF9wcm9wZXJ0aWVzKAo+ICsJc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3Rv cikKPiArewo+ICsJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGNvbm5lY3Rvci0+ZGV2Owo+ICsJ c3RydWN0IGRybV9wcm9wZXJ0eSAqcHJvcDsKPiArCj4gKwlpZiAoIWNvbm5lY3Rvci0+dmFyaWFi bGVfcmVmcmVzaF9jYXBhYmxlX3Byb3BlcnR5KSB7Cj4gKwkJcHJvcCA9IGRybV9wcm9wZXJ0eV9j cmVhdGVfYm9vbChkZXYsIDAsCj4gKwkJCSJ2YXJpYWJsZV9yZWZyZXNoX2NhcGFibGUiKTsKPiAr CQlpZiAoIXByb3ApCj4gKwkJCXJldHVybiAtRU5PTUVNOwo+ICsKPiArCQljb25uZWN0b3ItPnZh cmlhYmxlX3JlZnJlc2hfY2FwYWJsZV9wcm9wZXJ0eSA9IHByb3A7Cj4gKwkJZHJtX29iamVjdF9h dHRhY2hfcHJvcGVydHkoJmNvbm5lY3Rvci0+YmFzZSwgcHJvcCwgMCk7Cj4gKwl9Cj4gKwo+ICsJ aWYgKCFjb25uZWN0b3ItPnZhcmlhYmxlX3JlZnJlc2hfZW5hYmxlZF9wcm9wZXJ0eSkgewo+ICsJ CXByb3AgPSBkcm1fcHJvcGVydHlfY3JlYXRlX2Jvb2woZGV2LCAwLAo+ICsJCQkidmFyaWFibGVf cmVmcmVzaF9lbmFibGVkIik7Cj4gKwkJaWYgKCFwcm9wKQo+ICsJCQlyZXR1cm4gLUVOT01FTTsK PiArCj4gKwkJY29ubmVjdG9yLT52YXJpYWJsZV9yZWZyZXNoX2VuYWJsZWRfcHJvcGVydHkgPSBw cm9wOwo+ICsJCWRybV9vYmplY3RfYXR0YWNoX3Byb3BlcnR5KCZjb25uZWN0b3ItPmJhc2UsIHBy b3AsIDApOwo+ICsJfQo+ICsKPiArCXJldHVybiAwOwo+ICt9Cj4gK0VYUE9SVF9TWU1CT0woZHJt X2Nvbm5lY3Rvcl9hdHRhY2hfdmFyaWFibGVfcmVmcmVzaF9wcm9wZXJ0aWVzKTsKPiArCj4gIC8q Kgo+ICAgKiBkcm1fY29ubmVjdG9yX2F0dGFjaF9zY2FsaW5nX21vZGVfcHJvcGVydHkgLSBhdHRh Y2ggYXRvbWljIHNjYWxpbmcgbW9kZSBwcm9wZXJ0eQo+ICAgKiBAY29ubmVjdG9yOiBjb25uZWN0 b3IgdG8gYXR0YWNoIHNjYWxpbmcgbW9kZSBwcm9wZXJ0eSBvbi4KPiBkaWZmIC0tZ2l0IGEvaW5j bHVkZS9kcm0vZHJtX2Nvbm5lY3Rvci5oIGIvaW5jbHVkZS9kcm0vZHJtX2Nvbm5lY3Rvci5oCj4g aW5kZXggOTdlYTQxZGM2NzhmLi4xMDVhMTI3ZTkxOTEgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9k cm0vZHJtX2Nvbm5lY3Rvci5oCj4gKysrIGIvaW5jbHVkZS9kcm0vZHJtX2Nvbm5lY3Rvci5oCj4g QEAgLTQ0OCw2ICs0NDgsMTggQEAgc3RydWN0IGRybV9jb25uZWN0b3Jfc3RhdGUgewo+ICAJICov Cj4gIAl1bnNpZ25lZCBpbnQgY29udGVudF9wcm90ZWN0aW9uOwo+ICAKPiArCS8qKgo+ICsJICog QHZhcmlhYmxlX3JlZnJlc2hfZW5hYmxlZDogQ29ubmVjdG9yIHByb3BlcnR5IHVzZWQgdG8gY2hl Y2sKPiArCSAqIGlmIHZhcmlhYmxlIHJlZnJlc2ggaXMgc3VwcG9ydGVkIG9uIHRoZSBkZXZpY2Uu Cj4gKwkgKi8KPiArCWJvb2wgdmFyaWFibGVfcmVmcmVzaF9jYXBhYmxlOwo+ICsKPiArCS8qKgo+ ICsJICogQHZhcmlhYmxlX3JlZnJlc2hfZW5hYmxlZDogQ29ubmVjdG9yIHByb3BlcnR5IHVzZWQg dG8gY2hlY2sKPiArCSAqIGlmIHZhcmlhYmxlIHJlZnJlc2ggaXMgZW5hYmxlZC4KPiArCSAqLwo+ ICsJYm9vbCB2YXJpYWJsZV9yZWZyZXNoX2VuYWJsZWQ7Cj4gKwo+ICAJLyoqCj4gIAkgKiBAd3Jp dGViYWNrX2pvYjogV3JpdGViYWNrIGpvYiBmb3Igd3JpdGViYWNrIGNvbm5lY3RvcnMKPiAgCSAq Cj4gQEAgLTkwOSw2ICs5MjEsMTkgQEAgc3RydWN0IGRybV9jb25uZWN0b3Igewo+ICAJICovCj4g IAlzdHJ1Y3QgZHJtX3Byb3BlcnR5ICpzY2FsaW5nX21vZGVfcHJvcGVydHk7Cj4gIAo+ICsJLyoq Cj4gKwkgKiBAdmFyaWFibGVfcmVmcmVzaF9jYXBhYmxlX3Byb3BlcnR5OiBPcHRpb25hbCBwcm9w ZXJ0eSBmb3IKPiArCSAqIHF1ZXJ5aW5nIGhhcmR3YXJlIHN1cHBvcnQgZm9yIHZhcmlhYmxlIHJl ZnJlc2guCj4gKwkgKi8KPiArCXN0cnVjdCBkcm1fcHJvcGVydHkgKnZhcmlhYmxlX3JlZnJlc2hf Y2FwYWJsZV9wcm9wZXJ0eTsKPiArCj4gKwkvKioKPiArCSAqIEB2YXJpYWJsZV9yZWZyZXNoX2Vu YWJsZWRfcHJvcGVydHk6IE9wdGlvbmFsIHByb3BlcnR5IGZvcgo+ICsJICogZW5hYmxpbmcgb3Ig ZGlzYWJsaW5nIHN1cHBvcnQgZm9yIHZhcmlhYmxlIHJlZnJlc2gKPiArCSAqIG9uIHRoZSBjb25u ZWN0b3IuCj4gKwkgKi8KPiArCXN0cnVjdCBkcm1fcHJvcGVydHkgKnZhcmlhYmxlX3JlZnJlc2hf ZW5hYmxlZF9wcm9wZXJ0eTsKPiArCj4gIAkvKioKPiAgCSAqIEBjb250ZW50X3Byb3RlY3Rpb25f cHJvcGVydHk6IERSTSBFTlVNIHByb3BlcnR5IGZvciBjb250ZW50Cj4gIAkgKiBwcm90ZWN0aW9u LiBTZWUgZHJtX2Nvbm5lY3Rvcl9hdHRhY2hfY29udGVudF9wcm90ZWN0aW9uX3Byb3BlcnR5KCku Cj4gQEAgLTExODIsNiArMTIwNyw4IEBAIGludCBkcm1fbW9kZV9jcmVhdGVfc2NhbGluZ19tb2Rl X3Byb3BlcnR5KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpOwo+ICBpbnQgZHJtX2Nvbm5lY3Rvcl9h dHRhY2hfY29udGVudF90eXBlX3Byb3BlcnR5KHN0cnVjdCBkcm1fY29ubmVjdG9yICpkZXYpOwo+ ICBpbnQgZHJtX2Nvbm5lY3Rvcl9hdHRhY2hfc2NhbGluZ19tb2RlX3Byb3BlcnR5KHN0cnVjdCBk cm1fY29ubmVjdG9yICpjb25uZWN0b3IsCj4gIAkJCQkJICAgICAgIHUzMiBzY2FsaW5nX21vZGVf bWFzayk7Cj4gK2ludCBkcm1fY29ubmVjdG9yX2F0dGFjaF92YXJpYWJsZV9yZWZyZXNoX3Byb3Bl cnRpZXMoCj4gKwlzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yKTsKPiAgaW50IGRybV9j b25uZWN0b3JfYXR0YWNoX2NvbnRlbnRfcHJvdGVjdGlvbl9wcm9wZXJ0eSgKPiAgCQlzdHJ1Y3Qg ZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yKTsKPiAgaW50IGRybV9tb2RlX2NyZWF0ZV9hc3BlY3Rf cmF0aW9fcHJvcGVydHkoc3RydWN0IGRybV9kZXZpY2UgKmRldik7Cj4gLS0gCj4gMi4xNy4xCgot LSAKVmlsbGUgU3lyasOkbMOkCkludGVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2RyaS1kZXZlbAo=