From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manasi Navare Subject: Re: [PATCH 1/9] drm: Add variable refresh rate properties to DRM connector Date: Tue, 11 Sep 2018 10:18:09 -0700 Message-ID: <20180911171809.GB26205@intel.com> References: <20180911161333.5334-1-nicholas.kazlauskas@amd.com> <20180911161333.5334-2-nicholas.kazlauskas@amd.com> <20180911162243.GN5565@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180911162243.GN5565@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: nicolai.haehnle@amd.com, michel@daenzer.net, amd-gfx@lists.freedesktop.org, Christian.Koenig@amd.com, Marek.Olsak@amd.com, dri-devel@lists.freedesktop.org, Alexander.Deucher@amd.com, Nicholas Kazlauskas List-Id: amd-gfx.lists.freedesktop.org T24gVHVlLCBTZXAgMTEsIDIwMTggYXQgMDc6MjI6NDNQTSArMDMwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIFR1ZSwgU2VwIDExLCAyMDE4IGF0IDEyOjEzOjI1UE0gLTA0MDAsIE5pY2hv bGFzIEthemxhdXNrYXMgd3JvdGU6Cj4gPiBNb2Rlcm4gbW9uaXRvciBoYXJkd2FyZSBpcyBjYXBh YmxlIG9mIHN1cHBvcnRpbmcgdmFyaWFibGUgcmVmcmVzaCByYXRlcwo+ID4gYW5kIGFkYXB0aXZl IHN5bmMgdGVjaG5vbG9naWVzLiBUaGUgcHJvcGVydGllcyBmb3IgcXVlcnlpbmcgYW5kCj4gPiBj b250cm9sbGluZyB0aGVzZSBmZWF0dXJlcyBzaG91bGQgYmUgZXhwb3NlZCBvbiB0aGUgRFJNIGNv bm5lY3Rvci4KPiA+IAo+ID4gVGhpcyBwYXRjaCBpbnRyb2R1Y2VzIHR3byBuZXcgcHJvcGVydGll cyBmb3IgdmFyaWFibGUgcmVmcmVzaCByYXRlCj4gPiBzdXBwb3J0Ogo+ID4gCj4gPiAtIHZhcmlh YmxlX3JlZnJlc2hfY2FwYWJsZQo+ID4gLSB2YXJpYWJsZV9yZWZyZXNoX2VuYWJsZWQKPiA+IAo+ ID4gVGhlc2UgYXJlIG9wdGlvbmFsIHByb3BlcnRpZXMgdGhhdCBjYW4gYmUgYWRkZWQgdG8gYSBE Uk0gY29ubmVjdG9yCj4gPiBkeW5hbWljYWxseSBieSB1c2luZyBkcm1fY29ubmVjdG9yX2F0dGFj aF92YXJpYWJsZV9yZWZyZXNoX3Byb3BlcnRpZXMuCj4gPiAKPiA+IERSTSBkcml2ZXJzIHNob3Vs ZCBzZXQgdmFyaWFibGVfcmVmcmVzaF9jYXBhYmxlIGFzIGFwcGxpY2FibGUgZm9yCj4gPiB0aGVp ciBoYXJkd2FyZS4gVGhlIHByb3BlcnR5IHZhcmlhYmxlX3JlZnJlc2hfZW5hYmxlZCBhcyBhIHVz ZXJzcGFjZQo+ID4gY29udHJvbGxlZCBvcHRpb24uCj4gPiAKPiA+IENoYW5nZS1JZDogSTVmNjBm OGI1NzUzNGUxZDNkYWNkYTRjNjRjNmM5MTA2YjQyZjQ0MzkKPiA+IFNpZ25lZC1vZmYtYnk6IE5p Y2hvbGFzIEthemxhdXNrYXMgPG5pY2hvbGFzLmthemxhdXNrYXNAYW1kLmNvbT4KPiA+IC0tLQo+ ID4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljLmMgICAgfCAgOSArKysrKysrKysKPiA+ICBk cml2ZXJzL2dwdS9kcm0vZHJtX2Nvbm5lY3Rvci5jIHwgMzUgKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrCj4gPiAgaW5jbHVkZS9kcm0vZHJtX2Nvbm5lY3Rvci5oICAgICB8IDI3ICsr KysrKysrKysrKysrKysrKysrKysrKysKPiA+ICAzIGZpbGVzIGNoYW5nZWQsIDcxIGluc2VydGlv bnMoKykKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljLmMg Yi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pYy5jCj4gPiBpbmRleCBkMDQ3OGFiYzAxYmQuLjJm ODlhYjBmYWM4NyAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljLmMK PiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljLmMKPiA+IEBAIC0xNDAzLDYgKzE0 MDMsMTEgQEAgc3RhdGljIGludCBkcm1fYXRvbWljX2Nvbm5lY3Rvcl9zZXRfcHJvcGVydHkoc3Ry dWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciwKPiA+ICAJCXN0YXRlLT5jb250ZW50X3R5cGUg PSB2YWw7Cj4gPiAgCX0gZWxzZSBpZiAocHJvcGVydHkgPT0gY29ubmVjdG9yLT5zY2FsaW5nX21v ZGVfcHJvcGVydHkpIHsKPiA+ICAJCXN0YXRlLT5zY2FsaW5nX21vZGUgPSB2YWw7Cj4gPiArCX0g ZWxzZSBpZiAocHJvcGVydHkgPT0gY29ubmVjdG9yLT52YXJpYWJsZV9yZWZyZXNoX2NhcGFibGVf cHJvcGVydHkpIHsKPiA+ICsJCURSTV9ERUJVR19LTVMoIm9ubHkgZHJpdmVycyBjYW4gc2V0IHZh cmlhYmxlX3JlZnJlc2hfY2FwYWJsZVxuIik7Cj4gPiArCQlyZXR1cm4gLUVJTlZBTDsKPiAKPiBX aHkgaXMgdGhhdCBuZWVkZWQ/IFdoeSBub3QganVzdCBhdm9pZCBleHBvc2luZyB0aGUgdnJyX2Vu YWJsZWQgcHJvcAo+IHdoZW4gaXQncyBub3Qgc3VwcG9ydGVkPwo+IAo+ID4gKwl9IGVsc2UgaWYg KHByb3BlcnR5ID09IGNvbm5lY3Rvci0+dmFyaWFibGVfcmVmcmVzaF9lbmFibGVkX3Byb3BlcnR5 KSB7Cj4gPiArCQlzdGF0ZS0+dmFyaWFibGVfcmVmcmVzaF9lbmFibGVkID0gdmFsOwo+IAo+IFNv IG9uZSB0aGluZyBJIGFscmVhZHkgYXNrZWQgbG9uZyBhZ28gaXMgd2hldGhlciB0aGVyZSB3b3Vs ZCBhIHBvaW50IGluCj4gZXhwb3Npbmcgc29tZSBraW5kIG9mIG1pbi9tYXggcmVmcmVzaCByYXRl IHJhbmdlIGNvbnRyb2wuIE5ldmVyIHJlYWxseQo+IGdvdCBhbiBhbnN3ZXIuIFdhcyBzb21laHRp bmcgbGlrZSB0aGF0IGNvbnNpZGVyZWQgYW5kIHJlamVjdGVkPwo+CgpZZXMgSSB0aGluayB3ZSB3 aWxsIG5lZWQgdGhlIG1pbi9tYXggcmVmcmVzaCByYXRlIHRvIGJlIGV4cG9zZWQgZnJvbSB0aGUg ZHJpdmVyLgpTaW5jZSB0aGUgZHJpdmVyIHdpbGwgcGFyc2UgdGhlIGVkaWQgYW5kIG1vbml0b3Ig cmFuZ2UgZGVzY3JpcHRvciBpbmZvcm1hdGlvbgphbmQgd2lsbCBrbm93IHRoZSBtaW4vbWF4IHZh cmlhYmxlIHJlZnJlc2ggdmFsdWVzIGFuZCBpdCBuZWVkcwp0byBleHBvc2UgdGhhdCB0byB0aGUg dXNlcnNwYWNlIGFsb25nIHdpdGggdGhlIHZhcmlhYmxlX3JlZnJlc2hfY2FwYWJsZSBwcm9wZXJ0 eS4KCk1hbmFzaQogCj4gPiAgCX0gZWxzZSBpZiAocHJvcGVydHkgPT0gY29ubmVjdG9yLT5jb250 ZW50X3Byb3RlY3Rpb25fcHJvcGVydHkpIHsKPiA+ICAJCWlmICh2YWwgPT0gRFJNX01PREVfQ09O VEVOVF9QUk9URUNUSU9OX0VOQUJMRUQpIHsKPiA+ICAJCQlEUk1fREVCVUdfS01TKCJvbmx5IGRy aXZlcnMgY2FuIHNldCBDUCBFbmFibGVkXG4iKTsKPiA+IEBAIC0xNTA4LDYgKzE1MTMsMTAgQEAg ZHJtX2F0b21pY19jb25uZWN0b3JfZ2V0X3Byb3BlcnR5KHN0cnVjdCBkcm1fY29ubmVjdG9yICpj b25uZWN0b3IsCj4gPiAgCQkqdmFsID0gc3RhdGUtPmNvbnRlbnRfdHlwZTsKPiA+ICAJfSBlbHNl IGlmIChwcm9wZXJ0eSA9PSBjb25uZWN0b3ItPnNjYWxpbmdfbW9kZV9wcm9wZXJ0eSkgewo+ID4g IAkJKnZhbCA9IHN0YXRlLT5zY2FsaW5nX21vZGU7Cj4gPiArCX0gZWxzZSBpZiAocHJvcGVydHkg PT0gY29ubmVjdG9yLT52YXJpYWJsZV9yZWZyZXNoX2NhcGFibGVfcHJvcGVydHkpIHsKPiA+ICsJ CSp2YWwgPSBzdGF0ZS0+dmFyaWFibGVfcmVmcmVzaF9jYXBhYmxlOwo+ID4gKwl9IGVsc2UgaWYg KHByb3BlcnR5ID09IGNvbm5lY3Rvci0+dmFyaWFibGVfcmVmcmVzaF9lbmFibGVkX3Byb3BlcnR5 KSB7Cj4gPiArCQkqdmFsID0gc3RhdGUtPnZhcmlhYmxlX3JlZnJlc2hfZW5hYmxlZDsKPiA+ICAJ fSBlbHNlIGlmIChwcm9wZXJ0eSA9PSBjb25uZWN0b3ItPmNvbnRlbnRfcHJvdGVjdGlvbl9wcm9w ZXJ0eSkgewo+ID4gIAkJKnZhbCA9IHN0YXRlLT5jb250ZW50X3Byb3RlY3Rpb247Cj4gPiAgCX0g ZWxzZSBpZiAocHJvcGVydHkgPT0gY29uZmlnLT53cml0ZWJhY2tfZmJfaWRfcHJvcGVydHkpIHsK PiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2Nvbm5lY3Rvci5jIGIvZHJpdmVy cy9ncHUvZHJtL2RybV9jb25uZWN0b3IuYwo+ID4gaW5kZXggNjAxMWQ3NjlkNTBiLi4zN2ZiMzNm YTc3YjkgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2Nvbm5lY3Rvci5jCj4g PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2Nvbm5lY3Rvci5jCj4gPiBAQCAtMTI1MCw2ICsx MjUwLDQxIEBAIGludCBkcm1fbW9kZV9jcmVhdGVfc2NhbGluZ19tb2RlX3Byb3BlcnR5KHN0cnVj dCBkcm1fZGV2aWNlICpkZXYpCj4gPiAgfQo+ID4gIEVYUE9SVF9TWU1CT0woZHJtX21vZGVfY3Jl YXRlX3NjYWxpbmdfbW9kZV9wcm9wZXJ0eSk7Cj4gPiAgCj4gPiArLyoqCj4gPiArICogZHJtX2Nv bm5lY3Rvcl9hdHRhY2hfdmFyaWFibGVfcmVmcmVzaF9wcm9wZXJ0aWVzIC0gY3JlYXRlcyBhbmQg YXR0YWNoZXMKPiA+ICsgKiBwcm9wZXJ0aWVzIGZvciBjb25uZWN0b3JzIHRoYXQgc3VwcG9ydCBh ZGFwdGl2ZSByZWZyZXNoCj4gPiArICogQGNvbm5lY3RvcjogY29ubmVjdG9yIHRvIGNyZWF0ZSBh ZGFwdGl2ZSByZWZyZXNoIHByb3BlcnRpZXMgb24KPiA+ICsgKi8KPiA+ICtpbnQgZHJtX2Nvbm5l Y3Rvcl9hdHRhY2hfdmFyaWFibGVfcmVmcmVzaF9wcm9wZXJ0aWVzKAo+ID4gKwlzdHJ1Y3QgZHJt X2Nvbm5lY3RvciAqY29ubmVjdG9yKQo+ID4gK3sKPiA+ICsJc3RydWN0IGRybV9kZXZpY2UgKmRl diA9IGNvbm5lY3Rvci0+ZGV2Owo+ID4gKwlzdHJ1Y3QgZHJtX3Byb3BlcnR5ICpwcm9wOwo+ID4g Kwo+ID4gKwlpZiAoIWNvbm5lY3Rvci0+dmFyaWFibGVfcmVmcmVzaF9jYXBhYmxlX3Byb3BlcnR5 KSB7Cj4gPiArCQlwcm9wID0gZHJtX3Byb3BlcnR5X2NyZWF0ZV9ib29sKGRldiwgMCwKPiA+ICsJ CQkidmFyaWFibGVfcmVmcmVzaF9jYXBhYmxlIik7Cj4gPiArCQlpZiAoIXByb3ApCj4gPiArCQkJ cmV0dXJuIC1FTk9NRU07Cj4gPiArCj4gPiArCQljb25uZWN0b3ItPnZhcmlhYmxlX3JlZnJlc2hf Y2FwYWJsZV9wcm9wZXJ0eSA9IHByb3A7Cj4gPiArCQlkcm1fb2JqZWN0X2F0dGFjaF9wcm9wZXJ0 eSgmY29ubmVjdG9yLT5iYXNlLCBwcm9wLCAwKTsKPiA+ICsJfQo+ID4gKwo+ID4gKwlpZiAoIWNv bm5lY3Rvci0+dmFyaWFibGVfcmVmcmVzaF9lbmFibGVkX3Byb3BlcnR5KSB7Cj4gPiArCQlwcm9w ID0gZHJtX3Byb3BlcnR5X2NyZWF0ZV9ib29sKGRldiwgMCwKPiA+ICsJCQkidmFyaWFibGVfcmVm cmVzaF9lbmFibGVkIik7Cj4gPiArCQlpZiAoIXByb3ApCj4gPiArCQkJcmV0dXJuIC1FTk9NRU07 Cj4gPiArCj4gPiArCQljb25uZWN0b3ItPnZhcmlhYmxlX3JlZnJlc2hfZW5hYmxlZF9wcm9wZXJ0 eSA9IHByb3A7Cj4gPiArCQlkcm1fb2JqZWN0X2F0dGFjaF9wcm9wZXJ0eSgmY29ubmVjdG9yLT5i YXNlLCBwcm9wLCAwKTsKPiA+ICsJfQo+ID4gKwo+ID4gKwlyZXR1cm4gMDsKPiA+ICt9Cj4gPiAr RVhQT1JUX1NZTUJPTChkcm1fY29ubmVjdG9yX2F0dGFjaF92YXJpYWJsZV9yZWZyZXNoX3Byb3Bl cnRpZXMpOwo+ID4gKwo+ID4gIC8qKgo+ID4gICAqIGRybV9jb25uZWN0b3JfYXR0YWNoX3NjYWxp bmdfbW9kZV9wcm9wZXJ0eSAtIGF0dGFjaCBhdG9taWMgc2NhbGluZyBtb2RlIHByb3BlcnR5Cj4g PiAgICogQGNvbm5lY3RvcjogY29ubmVjdG9yIHRvIGF0dGFjaCBzY2FsaW5nIG1vZGUgcHJvcGVy dHkgb24uCj4gPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9kcm0vZHJtX2Nvbm5lY3Rvci5oIGIvaW5j bHVkZS9kcm0vZHJtX2Nvbm5lY3Rvci5oCj4gPiBpbmRleCA5N2VhNDFkYzY3OGYuLjEwNWExMjdl OTE5MSAxMDA2NDQKPiA+IC0tLSBhL2luY2x1ZGUvZHJtL2RybV9jb25uZWN0b3IuaAo+ID4gKysr IGIvaW5jbHVkZS9kcm0vZHJtX2Nvbm5lY3Rvci5oCj4gPiBAQCAtNDQ4LDYgKzQ0OCwxOCBAQCBz dHJ1Y3QgZHJtX2Nvbm5lY3Rvcl9zdGF0ZSB7Cj4gPiAgCSAqLwo+ID4gIAl1bnNpZ25lZCBpbnQg Y29udGVudF9wcm90ZWN0aW9uOwo+ID4gIAo+ID4gKwkvKioKPiA+ICsJICogQHZhcmlhYmxlX3Jl ZnJlc2hfZW5hYmxlZDogQ29ubmVjdG9yIHByb3BlcnR5IHVzZWQgdG8gY2hlY2sKPiA+ICsJICog aWYgdmFyaWFibGUgcmVmcmVzaCBpcyBzdXBwb3J0ZWQgb24gdGhlIGRldmljZS4KPiA+ICsJICov Cj4gPiArCWJvb2wgdmFyaWFibGVfcmVmcmVzaF9jYXBhYmxlOwo+ID4gKwo+ID4gKwkvKioKPiA+ ICsJICogQHZhcmlhYmxlX3JlZnJlc2hfZW5hYmxlZDogQ29ubmVjdG9yIHByb3BlcnR5IHVzZWQg dG8gY2hlY2sKPiA+ICsJICogaWYgdmFyaWFibGUgcmVmcmVzaCBpcyBlbmFibGVkLgo+ID4gKwkg Ki8KPiA+ICsJYm9vbCB2YXJpYWJsZV9yZWZyZXNoX2VuYWJsZWQ7Cj4gPiArCj4gPiAgCS8qKgo+ ID4gIAkgKiBAd3JpdGViYWNrX2pvYjogV3JpdGViYWNrIGpvYiBmb3Igd3JpdGViYWNrIGNvbm5l Y3RvcnMKPiA+ICAJICoKPiA+IEBAIC05MDksNiArOTIxLDE5IEBAIHN0cnVjdCBkcm1fY29ubmVj dG9yIHsKPiA+ICAJICovCj4gPiAgCXN0cnVjdCBkcm1fcHJvcGVydHkgKnNjYWxpbmdfbW9kZV9w cm9wZXJ0eTsKPiA+ICAKPiA+ICsJLyoqCj4gPiArCSAqIEB2YXJpYWJsZV9yZWZyZXNoX2NhcGFi bGVfcHJvcGVydHk6IE9wdGlvbmFsIHByb3BlcnR5IGZvcgo+ID4gKwkgKiBxdWVyeWluZyBoYXJk d2FyZSBzdXBwb3J0IGZvciB2YXJpYWJsZSByZWZyZXNoLgo+ID4gKwkgKi8KPiA+ICsJc3RydWN0 IGRybV9wcm9wZXJ0eSAqdmFyaWFibGVfcmVmcmVzaF9jYXBhYmxlX3Byb3BlcnR5Owo+ID4gKwo+ ID4gKwkvKioKPiA+ICsJICogQHZhcmlhYmxlX3JlZnJlc2hfZW5hYmxlZF9wcm9wZXJ0eTogT3B0 aW9uYWwgcHJvcGVydHkgZm9yCj4gPiArCSAqIGVuYWJsaW5nIG9yIGRpc2FibGluZyBzdXBwb3J0 IGZvciB2YXJpYWJsZSByZWZyZXNoCj4gPiArCSAqIG9uIHRoZSBjb25uZWN0b3IuCj4gPiArCSAq Lwo+ID4gKwlzdHJ1Y3QgZHJtX3Byb3BlcnR5ICp2YXJpYWJsZV9yZWZyZXNoX2VuYWJsZWRfcHJv cGVydHk7Cj4gPiArCj4gPiAgCS8qKgo+ID4gIAkgKiBAY29udGVudF9wcm90ZWN0aW9uX3Byb3Bl cnR5OiBEUk0gRU5VTSBwcm9wZXJ0eSBmb3IgY29udGVudAo+ID4gIAkgKiBwcm90ZWN0aW9uLiBT ZWUgZHJtX2Nvbm5lY3Rvcl9hdHRhY2hfY29udGVudF9wcm90ZWN0aW9uX3Byb3BlcnR5KCkuCj4g PiBAQCAtMTE4Miw2ICsxMjA3LDggQEAgaW50IGRybV9tb2RlX2NyZWF0ZV9zY2FsaW5nX21vZGVf cHJvcGVydHkoc3RydWN0IGRybV9kZXZpY2UgKmRldik7Cj4gPiAgaW50IGRybV9jb25uZWN0b3Jf YXR0YWNoX2NvbnRlbnRfdHlwZV9wcm9wZXJ0eShzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqZGV2KTsK PiA+ICBpbnQgZHJtX2Nvbm5lY3Rvcl9hdHRhY2hfc2NhbGluZ19tb2RlX3Byb3BlcnR5KHN0cnVj dCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsCj4gPiAgCQkJCQkgICAgICAgdTMyIHNjYWxpbmdf bW9kZV9tYXNrKTsKPiA+ICtpbnQgZHJtX2Nvbm5lY3Rvcl9hdHRhY2hfdmFyaWFibGVfcmVmcmVz aF9wcm9wZXJ0aWVzKAo+ID4gKwlzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yKTsKPiA+ ICBpbnQgZHJtX2Nvbm5lY3Rvcl9hdHRhY2hfY29udGVudF9wcm90ZWN0aW9uX3Byb3BlcnR5KAo+ ID4gIAkJc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3Rvcik7Cj4gPiAgaW50IGRybV9tb2Rl X2NyZWF0ZV9hc3BlY3RfcmF0aW9fcHJvcGVydHkoc3RydWN0IGRybV9kZXZpY2UgKmRldik7Cj4g PiAtLSAKPiA+IDIuMTcuMQo+IAo+IC0tIAo+IFZpbGxlIFN5cmrDpGzDpAo+IEludGVsCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWls aW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=