From: Huang Rui <ray.huang-5C7GfCeVMHo@public.gmane.org>
To: David Francis <David.Francis-5C7GfCeVMHo@public.gmane.org>
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH 2/3] drm/amd: Add PSP DMCU support
Date: Thu, 13 Sep 2018 15:18:30 +0800 [thread overview]
Message-ID: <20180913071829.GC3371@hr-amur2> (raw)
In-Reply-To: <20180911191513.25864-3-David.Francis-5C7GfCeVMHo@public.gmane.org>
On Tue, Sep 11, 2018 at 03:15:12PM -0400, David Francis wrote:
> DMCU (Display Microcontroller Unit) is a GPU chip involved in
> eDP features like Adaptive Backlight Modulation and Panel Self
> Refresh.
>
> PSP is already equipped to handle DMCU firmware loading, all
> that is needed is to translate between the new DMCU ucode ID and
> the equivalent psp_gfx_fw_type.
>
> Signed-off-by: David Francis <David.Francis@amd.com>
Reviewed-by: Huang Rui <ray.huang@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/psp_v10_0.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v10_0.c b/drivers/gpu/drm/amd/amdgpu/psp_v10_0.c
> index 02be34e72ed9..240dc8c85867 100644
> --- a/drivers/gpu/drm/amd/amdgpu/psp_v10_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/psp_v10_0.c
> @@ -91,6 +91,12 @@ psp_v10_0_get_fw_type(struct amdgpu_firmware_info *ucode, enum psp_gfx_fw_type *
> case AMDGPU_UCODE_ID_VCN:
> *type = GFX_FW_TYPE_VCN;
> break;
> + case AMDGPU_UCODE_ID_DMCU_ERAM:
> + *type = GFX_FW_TYPE_DMCU_ERAM;
> + break;
> + case AMDGPU_UCODE_ID_DMCU_INTV:
> + *type = GFX_FW_TYPE_DMCU_ISR;
> + break;
> case AMDGPU_UCODE_ID_MAXIMUM:
> default:
> return -EINVAL;
> --
> 2.17.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2018-09-13 7:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 19:15 [PATCH 0/3] Add DMCU fw loading on raven David Francis
[not found] ` <20180911191513.25864-1-David.Francis-5C7GfCeVMHo@public.gmane.org>
2018-09-11 19:15 ` [PATCH 1/3] drm/amd: Add ucode DMCU support David Francis
[not found] ` <20180911191513.25864-2-David.Francis-5C7GfCeVMHo@public.gmane.org>
2018-09-13 7:16 ` Huang Rui
2018-09-11 19:15 ` [PATCH 2/3] drm/amd: Add PSP " David Francis
[not found] ` <20180911191513.25864-3-David.Francis-5C7GfCeVMHo@public.gmane.org>
2018-09-13 7:18 ` Huang Rui [this message]
2018-09-11 19:15 ` [PATCH 3/3] drm/amd: Add DM " David Francis
[not found] ` <20180911191513.25864-4-David.Francis-5C7GfCeVMHo@public.gmane.org>
2018-09-13 7:38 ` Huang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180913071829.GC3371@hr-amur2 \
--to=ray.huang-5c7gfcevmho@public.gmane.org \
--cc=David.Francis-5C7GfCeVMHo@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox