From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2 1/3] drm: Add variable refresh rate properties to connector Date: Mon, 24 Sep 2018 21:32:11 +0300 Message-ID: <20180924183211.GW5565@intel.com> References: <20180924181537.12092-1-nicholas.kazlauskas@amd.com> <20180924181537.12092-2-nicholas.kazlauskas@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180924181537.12092-2-nicholas.kazlauskas@amd.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Nicholas Kazlauskas Cc: nicolai.haehnle@amd.com, michel@daenzer.net, amd-gfx@lists.freedesktop.org, Christian.Koenig@amd.com, manasi.d.navare@intel.com, dri-devel@lists.freedesktop.org, Alexander.Deucher@amd.com, Marek.Olsak@amd.com List-Id: amd-gfx.lists.freedesktop.org T24gTW9uLCBTZXAgMjQsIDIwMTggYXQgMDI6MTU6MzVQTSAtMDQwMCwgTmljaG9sYXMgS2F6bGF1 c2thcyB3cm90ZToKPiBNb2Rlcm4gZGlzcGxheSBoYXJkd2FyZSBpcyBjYXBhYmxlIG9mIHN1cHBv cnRpbmcgdmFyaWFibGUgcmVmcmVzaCByYXRlcwo+IGFuZCBhZGFwdGl2ZSBzeW5jIHRlY2hub2xv Z2llcy4gVGhlIHByb3BlcnRpZXMgZm9yIHF1ZXJ5aW5nIGFuZAo+IGNvbnRyb2xsaW5nIHRoZXNl IGZlYXR1cmVzIHNob3VsZCBiZSBleHBvc2VkIG9uIHRoZSBEUk0gY29ubmVjdG9yLgo+IAo+IFRo aXMgcGF0Y2ggaW50cm9kdWNlcyB0d28gbmV3IHByb3BlcnRpZXMgZm9yIHZhcmlhYmxlIHJlZnJl c2ggcmF0ZQo+IHN1cHBvcnQ6Cj4gCj4gLSB2YXJpYWJsZV9yZWZyZXNoX2NhcGFibGUKPiAtIHZh cmlhYmxlX3JlZnJlc2hfZW5hYmxlZAo+IAo+IFRoZXNlIGFyZSBvcHRpb25hbCBwcm9wZXJ0aWVz IHRoYXQgY2FuIGJlIGFkZGVkIHRvIGEgRFJNIGNvbm5lY3Rvcgo+IGR5bmFtaWNhbGx5IGJ5IHVz aW5nIGRybV9jb25uZWN0b3JfYXR0YWNoX3ZhcmlhYmxlX3JlZnJlc2hfcHJvcGVydGllcy4KPiAK PiBEUk0gZHJpdmVycyBzaG91bGQgc2V0IHZhcmlhYmxlX3JlZnJlc2hfY2FwYWJsZSBhcyBhcHBs aWNhYmxlIGZvcgo+IHRoZWlyIGhhcmR3YXJlLiBUaGUgcHJvcGVydHkgdmFyaWFibGVfcmVmcmVz aF9lbmFibGVkIGlzIGEgdXNlcnNwYWNlCj4gY29udHJvbGxlZCBvcHRpb24uCj4gCj4gU2lnbmVk LW9mZi1ieTogTmljaG9sYXMgS2F6bGF1c2thcyA8bmljaG9sYXMua2F6bGF1c2thc0BhbWQuY29t Pgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY191YXBpLmMgfCAgNiArKysrKysK PiAgZHJpdmVycy9ncHUvZHJtL2RybV9jb25uZWN0b3IuYyAgIHwgMzUgKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKwo+ICBpbmNsdWRlL2RybS9kcm1fY29ubmVjdG9yLmggICAgICAgfCAy NyArKysrKysrKysrKysrKysrKysrKysrKysKPiAgMyBmaWxlcyBjaGFuZ2VkLCA2OCBpbnNlcnRp b25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX3VhcGku YyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX3VhcGkuYwo+IGluZGV4IGQ1YjdmMzE1MDk4 Yy4uMGJiMjdhMjRhNTVjIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWlj X3VhcGkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX3VhcGkuYwo+IEBAIC03 MjMsNiArNzIzLDggQEAgc3RhdGljIGludCBkcm1fYXRvbWljX2Nvbm5lY3Rvcl9zZXRfcHJvcGVy dHkoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciwKPiAgCQlzdGF0ZS0+Y29udGVudF90 eXBlID0gdmFsOwo+ICAJfSBlbHNlIGlmIChwcm9wZXJ0eSA9PSBjb25uZWN0b3ItPnNjYWxpbmdf bW9kZV9wcm9wZXJ0eSkgewo+ICAJCXN0YXRlLT5zY2FsaW5nX21vZGUgPSB2YWw7Cj4gKwl9IGVs c2UgaWYgKHByb3BlcnR5ID09IGNvbm5lY3Rvci0+dmFyaWFibGVfcmVmcmVzaF9lbmFibGVkX3By b3BlcnR5KSB7Cj4gKwkJc3RhdGUtPnZhcmlhYmxlX3JlZnJlc2hfZW5hYmxlZCA9IHZhbDsKPiAg CX0gZWxzZSBpZiAocHJvcGVydHkgPT0gY29ubmVjdG9yLT5jb250ZW50X3Byb3RlY3Rpb25fcHJv cGVydHkpIHsKPiAgCQlpZiAodmFsID09IERSTV9NT0RFX0NPTlRFTlRfUFJPVEVDVElPTl9FTkFC TEVEKSB7Cj4gIAkJCURSTV9ERUJVR19LTVMoIm9ubHkgZHJpdmVycyBjYW4gc2V0IENQIEVuYWJs ZWRcbiIpOwo+IEBAIC03OTcsNiArNzk5LDEwIEBAIGRybV9hdG9taWNfY29ubmVjdG9yX2dldF9w cm9wZXJ0eShzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+ICAJCSp2YWwgPSBzdGF0 ZS0+Y29udGVudF90eXBlOwo+ICAJfSBlbHNlIGlmIChwcm9wZXJ0eSA9PSBjb25uZWN0b3ItPnNj YWxpbmdfbW9kZV9wcm9wZXJ0eSkgewo+ICAJCSp2YWwgPSBzdGF0ZS0+c2NhbGluZ19tb2RlOwo+ ICsJfSBlbHNlIGlmIChwcm9wZXJ0eSA9PSBjb25uZWN0b3ItPnZhcmlhYmxlX3JlZnJlc2hfY2Fw YWJsZV9wcm9wZXJ0eSkgewo+ICsJCSp2YWwgPSBzdGF0ZS0+dmFyaWFibGVfcmVmcmVzaF9jYXBh YmxlOwoKSW1tdXRhYmxlIHByb3BzIGRvbid0IHRha2UgdGhpcyBwYXRoLiBTZWUKX19kcm1fb2Jq ZWN0X3Byb3BlcnR5X2dldF92YWx1ZSgpLgoKPiArCX0gZWxzZSBpZiAocHJvcGVydHkgPT0gY29u bmVjdG9yLT52YXJpYWJsZV9yZWZyZXNoX2VuYWJsZWRfcHJvcGVydHkpIHsKPiArCQkqdmFsID0g c3RhdGUtPnZhcmlhYmxlX3JlZnJlc2hfZW5hYmxlZDsKPiAgCX0gZWxzZSBpZiAocHJvcGVydHkg PT0gY29ubmVjdG9yLT5jb250ZW50X3Byb3RlY3Rpb25fcHJvcGVydHkpIHsKPiAgCQkqdmFsID0g c3RhdGUtPmNvbnRlbnRfcHJvdGVjdGlvbjsKPiAgCX0gZWxzZSBpZiAocHJvcGVydHkgPT0gY29u ZmlnLT53cml0ZWJhY2tfZmJfaWRfcHJvcGVydHkpIHsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2RybV9jb25uZWN0b3IuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fY29ubmVjdG9yLmMK PiBpbmRleCAxZTQwZTVkZWNiZTkuLmZjMTczMjYzOWJkMyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vZHJtX2Nvbm5lY3Rvci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9jb25u ZWN0b3IuYwo+IEBAIC0xMjU0LDYgKzEyNTQsNDEgQEAgaW50IGRybV9tb2RlX2NyZWF0ZV9zY2Fs aW5nX21vZGVfcHJvcGVydHkoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAgfQo+ICBFWFBPUlRf U1lNQk9MKGRybV9tb2RlX2NyZWF0ZV9zY2FsaW5nX21vZGVfcHJvcGVydHkpOwo+ICAKPiArLyoq Cj4gKyAqIGRybV9jb25uZWN0b3JfYXR0YWNoX3ZhcmlhYmxlX3JlZnJlc2hfcHJvcGVydGllcyAt IGNyZWF0ZXMgYW5kIGF0dGFjaGVzCj4gKyAqIHByb3BlcnRpZXMgZm9yIGNvbm5lY3RvcnMgdGhh dCBzdXBwb3J0IGFkYXB0aXZlIHJlZnJlc2gKPiArICogQGNvbm5lY3RvcjogY29ubmVjdG9yIHRv IGNyZWF0ZSBhZGFwdGl2ZSByZWZyZXNoIHByb3BlcnRpZXMgb24KPiArICovCj4gK2ludCBkcm1f Y29ubmVjdG9yX2F0dGFjaF92YXJpYWJsZV9yZWZyZXNoX3Byb3BlcnRpZXMoCj4gKwlzdHJ1Y3Qg ZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yKQo+ICt7Cj4gKwlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2 ID0gY29ubmVjdG9yLT5kZXY7Cj4gKwlzdHJ1Y3QgZHJtX3Byb3BlcnR5ICpwcm9wOwo+ICsKPiAr CWlmICghY29ubmVjdG9yLT52YXJpYWJsZV9yZWZyZXNoX2NhcGFibGVfcHJvcGVydHkpIHsKPiAr CQlwcm9wID0gZHJtX3Byb3BlcnR5X2NyZWF0ZV9ib29sKGRldiwgRFJNX01PREVfUFJPUF9JTU1V VEFCTEUsCj4gKwkJCSJ2YXJpYWJsZV9yZWZyZXNoX2NhcGFibGUiKTsKPiArCQlpZiAoIXByb3Ap Cj4gKwkJCXJldHVybiAtRU5PTUVNOwo+ICsKPiArCQljb25uZWN0b3ItPnZhcmlhYmxlX3JlZnJl c2hfY2FwYWJsZV9wcm9wZXJ0eSA9IHByb3A7Cj4gKwkJZHJtX29iamVjdF9hdHRhY2hfcHJvcGVy dHkoJmNvbm5lY3Rvci0+YmFzZSwgcHJvcCwgMCk7Cj4gKwl9Cj4gKwo+ICsJaWYgKCFjb25uZWN0 b3ItPnZhcmlhYmxlX3JlZnJlc2hfZW5hYmxlZF9wcm9wZXJ0eSkgewo+ICsJCXByb3AgPSBkcm1f cHJvcGVydHlfY3JlYXRlX2Jvb2woZGV2LCAwLAo+ICsJCQkidmFyaWFibGVfcmVmcmVzaF9lbmFi bGVkIik7Cj4gKwkJaWYgKCFwcm9wKQo+ICsJCQlyZXR1cm4gLUVOT01FTTsKPiArCj4gKwkJY29u bmVjdG9yLT52YXJpYWJsZV9yZWZyZXNoX2VuYWJsZWRfcHJvcGVydHkgPSBwcm9wOwo+ICsJCWRy bV9vYmplY3RfYXR0YWNoX3Byb3BlcnR5KCZjb25uZWN0b3ItPmJhc2UsIHByb3AsIDApOwo+ICsJ fQo+ICsKPiArCXJldHVybiAwOwo+ICt9Cj4gK0VYUE9SVF9TWU1CT0woZHJtX2Nvbm5lY3Rvcl9h dHRhY2hfdmFyaWFibGVfcmVmcmVzaF9wcm9wZXJ0aWVzKTsKPiArCj4gIC8qKgo+ICAgKiBkcm1f Y29ubmVjdG9yX2F0dGFjaF9zY2FsaW5nX21vZGVfcHJvcGVydHkgLSBhdHRhY2ggYXRvbWljIHNj YWxpbmcgbW9kZSBwcm9wZXJ0eQo+ICAgKiBAY29ubmVjdG9yOiBjb25uZWN0b3IgdG8gYXR0YWNo IHNjYWxpbmcgbW9kZSBwcm9wZXJ0eSBvbi4KPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9kcm0vZHJt X2Nvbm5lY3Rvci5oIGIvaW5jbHVkZS9kcm0vZHJtX2Nvbm5lY3Rvci5oCj4gaW5kZXggOTFhODc3 ZmEwMGNiLi5lMmMyNjg0MmJkNTAgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9kcm0vZHJtX2Nvbm5l Y3Rvci5oCj4gKysrIGIvaW5jbHVkZS9kcm0vZHJtX2Nvbm5lY3Rvci5oCj4gQEAgLTQ0OSw2ICs0 NDksMTggQEAgc3RydWN0IGRybV9jb25uZWN0b3Jfc3RhdGUgewo+ICAJICovCj4gIAl1bnNpZ25l ZCBpbnQgY29udGVudF9wcm90ZWN0aW9uOwo+ICAKPiArCS8qKgo+ICsJICogQHZhcmlhYmxlX3Jl ZnJlc2hfZW5hYmxlZDogQ29ubmVjdG9yIHByb3BlcnR5IHVzZWQgdG8gY2hlY2sKPiArCSAqIGlm IHZhcmlhYmxlIHJlZnJlc2ggaXMgc3VwcG9ydGVkIG9uIHRoZSBkZXZpY2UuCj4gKwkgKi8KPiAr CWJvb2wgdmFyaWFibGVfcmVmcmVzaF9jYXBhYmxlOwo+ICsKPiArCS8qKgo+ICsJICogQHZhcmlh YmxlX3JlZnJlc2hfZW5hYmxlZDogQ29ubmVjdG9yIHByb3BlcnR5IHVzZWQgdG8gY2hlY2sKPiAr CSAqIGlmIHZhcmlhYmxlIHJlZnJlc2ggaXMgZW5hYmxlZC4KPiArCSAqLwo+ICsJYm9vbCB2YXJp YWJsZV9yZWZyZXNoX2VuYWJsZWQ7Cj4gKwo+ICAJLyoqCj4gIAkgKiBAd3JpdGViYWNrX2pvYjog V3JpdGViYWNrIGpvYiBmb3Igd3JpdGViYWNrIGNvbm5lY3RvcnMKPiAgCSAqCj4gQEAgLTkxMCw2 ICs5MjIsMTkgQEAgc3RydWN0IGRybV9jb25uZWN0b3Igewo+ICAJICovCj4gIAlzdHJ1Y3QgZHJt X3Byb3BlcnR5ICpzY2FsaW5nX21vZGVfcHJvcGVydHk7Cj4gIAo+ICsJLyoqCj4gKwkgKiBAdmFy aWFibGVfcmVmcmVzaF9jYXBhYmxlX3Byb3BlcnR5OiBPcHRpb25hbCBwcm9wZXJ0eSBmb3IKPiAr CSAqIHF1ZXJ5aW5nIGhhcmR3YXJlIHN1cHBvcnQgZm9yIHZhcmlhYmxlIHJlZnJlc2guCj4gKwkg Ki8KPiArCXN0cnVjdCBkcm1fcHJvcGVydHkgKnZhcmlhYmxlX3JlZnJlc2hfY2FwYWJsZV9wcm9w ZXJ0eTsKPiArCj4gKwkvKioKPiArCSAqIEB2YXJpYWJsZV9yZWZyZXNoX2VuYWJsZWRfcHJvcGVy dHk6IE9wdGlvbmFsIHByb3BlcnR5IGZvcgo+ICsJICogZW5hYmxpbmcgb3IgZGlzYWJsaW5nIHN1 cHBvcnQgZm9yIHZhcmlhYmxlIHJlZnJlc2gKPiArCSAqIG9uIHRoZSBjb25uZWN0b3IuCj4gKwkg Ki8KPiArCXN0cnVjdCBkcm1fcHJvcGVydHkgKnZhcmlhYmxlX3JlZnJlc2hfZW5hYmxlZF9wcm9w ZXJ0eTsKPiArCj4gIAkvKioKPiAgCSAqIEBjb250ZW50X3Byb3RlY3Rpb25fcHJvcGVydHk6IERS TSBFTlVNIHByb3BlcnR5IGZvciBjb250ZW50Cj4gIAkgKiBwcm90ZWN0aW9uLiBTZWUgZHJtX2Nv bm5lY3Rvcl9hdHRhY2hfY29udGVudF9wcm90ZWN0aW9uX3Byb3BlcnR5KCkuCj4gQEAgLTExODMs NiArMTIwOCw4IEBAIGludCBkcm1fbW9kZV9jcmVhdGVfc2NhbGluZ19tb2RlX3Byb3BlcnR5KHN0 cnVjdCBkcm1fZGV2aWNlICpkZXYpOwo+ICBpbnQgZHJtX2Nvbm5lY3Rvcl9hdHRhY2hfY29udGVu dF90eXBlX3Byb3BlcnR5KHN0cnVjdCBkcm1fY29ubmVjdG9yICpkZXYpOwo+ICBpbnQgZHJtX2Nv bm5lY3Rvcl9hdHRhY2hfc2NhbGluZ19tb2RlX3Byb3BlcnR5KHN0cnVjdCBkcm1fY29ubmVjdG9y ICpjb25uZWN0b3IsCj4gIAkJCQkJICAgICAgIHUzMiBzY2FsaW5nX21vZGVfbWFzayk7Cj4gK2lu dCBkcm1fY29ubmVjdG9yX2F0dGFjaF92YXJpYWJsZV9yZWZyZXNoX3Byb3BlcnRpZXMoCj4gKwlz dHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yKTsKPiAgaW50IGRybV9jb25uZWN0b3JfYXR0 YWNoX2NvbnRlbnRfcHJvdGVjdGlvbl9wcm9wZXJ0eSgKPiAgCQlzdHJ1Y3QgZHJtX2Nvbm5lY3Rv ciAqY29ubmVjdG9yKTsKPiAgaW50IGRybV9tb2RlX2NyZWF0ZV9hc3BlY3RfcmF0aW9fcHJvcGVy dHkoc3RydWN0IGRybV9kZXZpY2UgKmRldik7Cj4gLS0gCj4gMi4xOS4wCgotLSAKVmlsbGUgU3ly asOkbMOkCkludGVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl bAo=