From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2 2/3] drm: Add variable refresh property to DRM CRTC Date: Mon, 24 Sep 2018 21:38:26 +0300 Message-ID: <20180924183826.GX5565@intel.com> References: <20180924181537.12092-1-nicholas.kazlauskas@amd.com> <20180924181537.12092-3-nicholas.kazlauskas@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180924181537.12092-3-nicholas.kazlauskas@amd.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Nicholas Kazlauskas Cc: nicolai.haehnle@amd.com, michel@daenzer.net, amd-gfx@lists.freedesktop.org, Christian.Koenig@amd.com, manasi.d.navare@intel.com, dri-devel@lists.freedesktop.org, Alexander.Deucher@amd.com, Marek.Olsak@amd.com List-Id: amd-gfx.lists.freedesktop.org T24gTW9uLCBTZXAgMjQsIDIwMTggYXQgMDI6MTU6MzZQTSAtMDQwMCwgTmljaG9sYXMgS2F6bGF1 c2thcyB3cm90ZToKPiBWYXJpYWJsZSByZWZyZXNoIHJhdGUgYWxnb3JpdGhtcyBoYXZlIHR5cGlj YWxseSBiZWVuIGVuYWJsZWQgb25seQo+IHdoZW4gdGhlIGRpc3BsYXkgaXMgY292ZXJlZCBieSBh IHNpbmdsZSBzb3VyY2Ugb2YgY29udGVudC4KPiAKPiBUaGlzIHBhdGNoIGludHJvZHVjZXMgYSBu ZXcgZGVmYXVsdCBDUlRDIHByb3BlcnR5IHRoYXQgaGVscHMKPiBoaW50IHRvIHRoZSBkcml2ZXIg d2hlbiB0aGUgQ1JUQyBjb21wb3NpdGlvbiBpcyBzdWl0YWJsZSBmb3IgdmFyaWFibGUKPiByZWZy ZXNoIHJhdGUgYWxnb3JpdGhtcy4gVXNlcnNwYWNlIGNhbiBzZXQgdGhpcyBwcm9wZXJ0eSBkeW5h bWljYWxseQo+IGFzIHRoZSBjb21wb3NpdGlvbiBjaGFuZ2VzLgo+IAo+IFdoZXRoZXIgdGhlIHZh cmlhYmxlIHJlZnJlc2ggcmF0ZSBhbGdvcml0aG1zIGFyZSBhY3RpdmUgd2lsbCBzdGlsbAo+IGRl cGVuZCBvbiB0aGUgQ1JUQyBiZWluZyBzdWl0YWJsZSBhbmQgdGhlIGNvbm5lY3RvciBiZWluZyBj YXBhYmxlCj4gYW5kIGVuYWJsZWQgYnkgdGhlIHVzZXIgZm9yIHZhcmlhYmxlIHJlZnJlc2ggcmF0 ZSBzdXBwb3J0Lgo+IAo+IEl0IGlzIHdvcnRoIG5vdGluZyB0aGF0IHdoaWxlIHRoZSBwcm9wZXJ0 eSBpcyBhdG9taWMgaXQgaXNuJ3QgZmlsdGVyZWQKPiBmcm9tIGxlZ2FjeSB1c2Vyc3BhY2UgcXVl cmllcy4gVGhpcyBhbGxvd3MgZm9yIFhvcmcgdXNlcnNwYWNlIGRyaXZlcnMKPiB0byBpbXBsZW1l bnQgc3VwcG9ydCBpbiBub24tYXRvbWljIHNldHVwcy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBOaWNo b2xhcyBLYXpsYXVza2FzIDxuaWNob2xhcy5rYXpsYXVza2FzQGFtZC5jb20+Cj4gLS0tCj4gIGRy aXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jIHwgIDEgKwo+ICBkcml2ZXJzL2dwdS9k cm0vZHJtX2F0b21pY191YXBpLmMgICB8ICA2ICsrKysrKwo+ICBkcml2ZXJzL2dwdS9kcm0vZHJt X2NydGMuYyAgICAgICAgICB8ICAyICsrCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fbW9kZV9jb25m aWcuYyAgIHwgIDYgKysrKysrCj4gIGluY2x1ZGUvZHJtL2RybV9jcnRjLmggICAgICAgICAgICAg IHwgMTMgKysrKysrKysrKysrKwo+ICBpbmNsdWRlL2RybS9kcm1fbW9kZV9jb25maWcuaCAgICAg ICB8ICA4ICsrKysrKysrCj4gIDYgZmlsZXMgY2hhbmdlZCwgMzYgaW5zZXJ0aW9ucygrKQo+IAo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYyBiL2RyaXZl cnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jCj4gaW5kZXggM2NmMWFhMTMyNzc4Li5iNzY4 ZDM5N2E4MTEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVy LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwo+IEBAIC0zNDcz LDYgKzM0NzMsNyBAQCB2b2lkIF9fZHJtX2F0b21pY19oZWxwZXJfY3J0Y19kdXBsaWNhdGVfc3Rh dGUoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ICAJc3RhdGUtPnBsYW5lc19jaGFuZ2VkID0gZmFs c2U7Cj4gIAlzdGF0ZS0+Y29ubmVjdG9yc19jaGFuZ2VkID0gZmFsc2U7Cj4gIAlzdGF0ZS0+Y29s b3JfbWdtdF9jaGFuZ2VkID0gZmFsc2U7Cj4gKwlzdGF0ZS0+dmFyaWFibGVfcmVmcmVzaF9jaGFu Z2VkID0gZmFsc2U7CgpBbm90aGVyIGJvb2wganVzdCB0byBjaGVjayBpZiBvbmUgYm9vbCBjaGFu Z2VkIHNlZW1zIGEgYml0IGV4Y2Vzc2l2ZS4KSXMgdGhlcmUgYSByZWFzb24geW91IGNhbid0IGRp cmVjdGx5IGNoZWNrIGlmIHRoZSBvdGhlciBib29sIGNoYW5nZWQ/CgpBY3R1YWxseSBJIGRvbid0 IHVuZGVyc3RhbmQgd2h5IHRoaXMgcGVyLWNydGMgdGhpbmcgaXMgYmVpbmcgYWRkZWQgYXQKYWxs LiBZb3UgYWxyZWFkeSBoYXZlIHRoZSBwcm9wIG9uIHRoZSBjb25uZWN0b3IuIFdoeSBkbyB3ZSB3 YW50IHRvCm1ha2UgbGlmZSBtb3JlIGRpZmZpY3VsdCBieSByZXF1aXJpbmcgdGhlIHRoaW5nIHRv IGJlIHNldCBvbiBib3RoIHRoZQpjcnRjIGFuZCBjb25uZWN0b3I/Cgo+ICAJc3RhdGUtPnpwb3Nf Y2hhbmdlZCA9IGZhbHNlOwo+ICAJc3RhdGUtPmNvbW1pdCA9IE5VTEw7Cj4gIAlzdGF0ZS0+ZXZl bnQgPSBOVUxMOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY191YXBp LmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY191YXBpLmMKPiBpbmRleCAwYmIyN2EyNGE1 NWMuLjMyYTRjZjhhMDFjMyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21p Y191YXBpLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY191YXBpLmMKPiBAQCAt NDMzLDYgKzQzMywxMCBAQCBzdGF0aWMgaW50IGRybV9hdG9taWNfY3J0Y19zZXRfcHJvcGVydHko c3RydWN0IGRybV9jcnRjICpjcnRjLAo+ICAJCXJldCA9IGRybV9hdG9taWNfc2V0X21vZGVfcHJv cF9mb3JfY3J0YyhzdGF0ZSwgbW9kZSk7Cj4gIAkJZHJtX3Byb3BlcnR5X2Jsb2JfcHV0KG1vZGUp Owo+ICAJCXJldHVybiByZXQ7Cj4gKwl9IGVsc2UgaWYgKHByb3BlcnR5ID09IGNvbmZpZy0+cHJv cF92YXJpYWJsZV9yZWZyZXNoKSB7Cj4gKwkJaWYgKHN0YXRlLT52YXJpYWJsZV9yZWZyZXNoICE9 IHZhbCkKPiArCQkJc3RhdGUtPnZhcmlhYmxlX3JlZnJlc2hfY2hhbmdlZCA9IHRydWU7Cj4gKwkJ c3RhdGUtPnZhcmlhYmxlX3JlZnJlc2ggPSB2YWw7Cj4gIAl9IGVsc2UgaWYgKHByb3BlcnR5ID09 IGNvbmZpZy0+ZGVnYW1tYV9sdXRfcHJvcGVydHkpIHsKPiAgCQlyZXQgPSBkcm1fYXRvbWljX3Jl cGxhY2VfcHJvcGVydHlfYmxvYl9mcm9tX2lkKGRldiwKPiAgCQkJCQkmc3RhdGUtPmRlZ2FtbWFf bHV0LAo+IEBAIC00OTEsNiArNDk1LDggQEAgZHJtX2F0b21pY19jcnRjX2dldF9wcm9wZXJ0eShz dHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4gIAkJKnZhbCA9IHN0YXRlLT5hY3RpdmU7Cj4gIAllbHNl IGlmIChwcm9wZXJ0eSA9PSBjb25maWctPnByb3BfbW9kZV9pZCkKPiAgCQkqdmFsID0gKHN0YXRl LT5tb2RlX2Jsb2IpID8gc3RhdGUtPm1vZGVfYmxvYi0+YmFzZS5pZCA6IDA7Cj4gKwllbHNlIGlm IChwcm9wZXJ0eSA9PSBjb25maWctPnByb3BfdmFyaWFibGVfcmVmcmVzaCkKPiArCQkqdmFsID0g c3RhdGUtPnZhcmlhYmxlX3JlZnJlc2g7Cj4gIAllbHNlIGlmIChwcm9wZXJ0eSA9PSBjb25maWct PmRlZ2FtbWFfbHV0X3Byb3BlcnR5KQo+ICAJCSp2YWwgPSAoc3RhdGUtPmRlZ2FtbWFfbHV0KSA/ IHN0YXRlLT5kZWdhbW1hX2x1dC0+YmFzZS5pZCA6IDA7Cj4gIAllbHNlIGlmIChwcm9wZXJ0eSA9 PSBjb25maWctPmN0bV9wcm9wZXJ0eSkKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2Ry bV9jcnRjLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2NydGMuYwo+IGluZGV4IDVmNDg4YWE4MGJj ZC4uY2EzM2Q2ZmI5MGFjIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fY3J0Yy5j Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9jcnRjLmMKPiBAQCAtMzQwLDYgKzM0MCw4IEBA IGludCBkcm1fY3J0Y19pbml0X3dpdGhfcGxhbmVzKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHN0 cnVjdCBkcm1fY3J0YyAqY3J0YywKPiAgCQlkcm1fb2JqZWN0X2F0dGFjaF9wcm9wZXJ0eSgmY3J0 Yy0+YmFzZSwgY29uZmlnLT5wcm9wX21vZGVfaWQsIDApOwo+ICAJCWRybV9vYmplY3RfYXR0YWNo X3Byb3BlcnR5KCZjcnRjLT5iYXNlLAo+ICAJCQkJCSAgIGNvbmZpZy0+cHJvcF9vdXRfZmVuY2Vf cHRyLCAwKTsKPiArCQlkcm1fb2JqZWN0X2F0dGFjaF9wcm9wZXJ0eSgmY3J0Yy0+YmFzZSwKPiAr CQkJCQkgICBjb25maWctPnByb3BfdmFyaWFibGVfcmVmcmVzaCwgMCk7Cj4gIAl9Cj4gIAo+ICAJ cmV0dXJuIDA7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fbW9kZV9jb25maWcu YyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fbW9kZV9jb25maWcuYwo+IGluZGV4IGVlODA3ODhmMmM0 MC4uMTI4N2MxNjFkNjVkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fbW9kZV9j b25maWcuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fbW9kZV9jb25maWcuYwo+IEBAIC0z MTAsNiArMzEwLDEyIEBAIHN0YXRpYyBpbnQgZHJtX21vZGVfY3JlYXRlX3N0YW5kYXJkX3Byb3Bl cnRpZXMoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAgCQlyZXR1cm4gLUVOT01FTTsKPiAgCWRl di0+bW9kZV9jb25maWcucHJvcF9tb2RlX2lkID0gcHJvcDsKPiAgCj4gKwlwcm9wID0gZHJtX3By b3BlcnR5X2NyZWF0ZV9ib29sKGRldiwgMCwKPiArCQkJIlZBUklBQkxFX1JFRlJFU0giKTsKPiAr CWlmICghcHJvcCkKPiArCQlyZXR1cm4gLUVOT01FTTsKPiArCWRldi0+bW9kZV9jb25maWcucHJv cF92YXJpYWJsZV9yZWZyZXNoID0gcHJvcDsKPiArCj4gIAlwcm9wID0gZHJtX3Byb3BlcnR5X2Ny ZWF0ZShkZXYsCj4gIAkJCURSTV9NT0RFX1BST1BfQkxPQiwKPiAgCQkJIkRFR0FNTUFfTFVUIiwg MCk7Cj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvZHJtL2RybV9jcnRjLmggYi9pbmNsdWRlL2RybS9k cm1fY3J0Yy5oCj4gaW5kZXggYjIxNDM3YmM5NWJmLi4zMmI3N2YxOGNlNmQgMTAwNjQ0Cj4gLS0t IGEvaW5jbHVkZS9kcm0vZHJtX2NydGMuaAo+ICsrKyBiL2luY2x1ZGUvZHJtL2RybV9jcnRjLmgK PiBAQCAtMTY4LDYgKzE2OCwxMiBAQCBzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgewo+ICAJICogZHJp dmVycyB0byBzdGVlciB0aGUgYXRvbWljIGNvbW1pdCBjb250cm9sIGZsb3cuCj4gIAkgKi8KPiAg CWJvb2wgY29sb3JfbWdtdF9jaGFuZ2VkIDogMTsKPiArCS8qKgo+ICsJICogQHZhcmlhYmxlX3Jl ZnJlc2hfY2hhbmdlZDogVmFyaWFibGUgcmVmcmVzaCBzdXBwb3J0IGhhcyBjaGFuZ2VkCj4gKwkg KiBvbiB0aGUgQ1JUQy4gVXNlZCBieSB0aGUgYXRvbWljIGhlbHBlcnMgYW5kIGRyaXZlcnMgdG8g c3RlZXIgdGhlCj4gKwkgKiBhdG9taWMgY29tbWl0IGNvbnRyb2wgZmxvdy4KPiArCSAqLwo+ICsJ Ym9vbCB2YXJpYWJsZV9yZWZyZXNoX2NoYW5nZWQgOiAxOwo+ICAKPiAgCS8qKgo+ICAJICogQG5v X3ZibGFuazoKPiBAQCAtMjkwLDYgKzI5NiwxMyBAQCBzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgewo+ ICAJICovCj4gIAl1MzIgcGFnZWZsaXBfZmxhZ3M7Cj4gIAo+ICsJLyoqCj4gKwkgKiBAdmFyaWFi bGVfcmVmcmVzaDoKPiArCSAqCj4gKwkgKiBJbmRpY2F0ZXMgd2hldGhlciB0aGUgQ1JUQyBpcyBz dWl0YWJsZSBmb3IgdmFyaWFibGUgcmVmcmVzaCByYXRlLgo+ICsJICovCj4gKwlib29sIHZhcmlh YmxlX3JlZnJlc2g7Cj4gKwo+ICAJLyoqCj4gIAkgKiBAZXZlbnQ6Cj4gIAkgKgo+IGRpZmYgLS1n aXQgYS9pbmNsdWRlL2RybS9kcm1fbW9kZV9jb25maWcuaCBiL2luY2x1ZGUvZHJtL2RybV9tb2Rl X2NvbmZpZy5oCj4gaW5kZXggOTI4ZTQxNzJhMGJiLi4xMjkwMTkxY2Q5NmUgMTAwNjQ0Cj4gLS0t IGEvaW5jbHVkZS9kcm0vZHJtX21vZGVfY29uZmlnLmgKPiArKysgYi9pbmNsdWRlL2RybS9kcm1f bW9kZV9jb25maWcuaAo+IEBAIC02MzksNiArNjM5LDE0IEBAIHN0cnVjdCBkcm1fbW9kZV9jb25m aWcgewo+ICAJICogY29ubmVjdG9ycyBtdXN0IGJlIG9mIGFuZCBhY3RpdmUgbXVzdCBiZSBzZXQg dG8gZGlzYWJsZWQsIHRvby4KPiAgCSAqLwo+ICAJc3RydWN0IGRybV9wcm9wZXJ0eSAqcHJvcF9t b2RlX2lkOwo+ICsJLyoqCj4gKwkgKiBAcHJvcF92YXJpYWJsZV9yZWZyZXNoOiBEZWZhdWx0IGF0 b21pYyBDUlRDIHByb3BlcnR5IHRvIGluZGljYXRlCj4gKwkgKiB3aGV0aGVyIHRoZSBDUlRDIGlz IHN1aXRhYmxlIGZvciB2YXJpYWJsZSByZWZyZXNoIHJhdGUgc3VwcG9ydC4KPiArCSAqCj4gKwkg KiBUaGlzIGlzIG9ubHkgYW4gaW5kaWNhdGlvbiBvZiBzdXBwb3J0LCBub3Qgd2hldGhlciB2YXJp YWJsZQo+ICsJICogcmVmcmVzaCBpcyBhY3RpdmUgb24gdGhlIENSVEMuCj4gKwkgKi8KPiArCXN0 cnVjdCBkcm1fcHJvcGVydHkgKnByb3BfdmFyaWFibGVfcmVmcmVzaDsKPiAgCj4gIAkvKioKPiAg CSAqIEBkdmlfaV9zdWJjb25uZWN0b3JfcHJvcGVydHk6IE9wdGlvbmFsIERWSS1JIHByb3BlcnR5 IHRvCj4gLS0gCj4gMi4xOS4wCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxp c3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=