From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH v2 1/3] drm: Add variable refresh rate properties to
 connector
Date: Mon, 1 Oct 2018 09:05:52 +0200
Message-ID: <20181001070552.GH11082@phenom.ffwll.local>
References: <20180924181537.12092-1-nicholas.kazlauskas@amd.com>
 <20180924181537.12092-2-nicholas.kazlauskas@amd.com>
 <20180924183211.GW5565@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <20180924183211.GW5565@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Cc: manasi.d.navare@intel.com, nicolai.haehnle@amd.com, michel@daenzer.net, amd-gfx@lists.freedesktop.org, Christian.Koenig@amd.com, Marek.Olsak@amd.com, dri-devel@lists.freedesktop.org, Alexander.Deucher@amd.com, Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
List-Id: amd-gfx.lists.freedesktop.org

T24gTW9uLCBTZXAgMjQsIDIwMTggYXQgMDk6MzI6MTFQTSArMDMwMCwgVmlsbGUgU3lyasOkbMOk
IHdyb3RlOgo+IE9uIE1vbiwgU2VwIDI0LCAyMDE4IGF0IDAyOjE1OjM1UE0gLTA0MDAsIE5pY2hv
bGFzIEthemxhdXNrYXMgd3JvdGU6Cj4gPiBNb2Rlcm4gZGlzcGxheSBoYXJkd2FyZSBpcyBjYXBh
YmxlIG9mIHN1cHBvcnRpbmcgdmFyaWFibGUgcmVmcmVzaCByYXRlcwo+ID4gYW5kIGFkYXB0aXZl
IHN5bmMgdGVjaG5vbG9naWVzLiBUaGUgcHJvcGVydGllcyBmb3IgcXVlcnlpbmcgYW5kCj4gPiBj
b250cm9sbGluZyB0aGVzZSBmZWF0dXJlcyBzaG91bGQgYmUgZXhwb3NlZCBvbiB0aGUgRFJNIGNv
bm5lY3Rvci4KPiA+IAo+ID4gVGhpcyBwYXRjaCBpbnRyb2R1Y2VzIHR3byBuZXcgcHJvcGVydGll
cyBmb3IgdmFyaWFibGUgcmVmcmVzaCByYXRlCj4gPiBzdXBwb3J0Ogo+ID4gCj4gPiAtIHZhcmlh
YmxlX3JlZnJlc2hfY2FwYWJsZQo+ID4gLSB2YXJpYWJsZV9yZWZyZXNoX2VuYWJsZWQKPiA+IAo+
ID4gVGhlc2UgYXJlIG9wdGlvbmFsIHByb3BlcnRpZXMgdGhhdCBjYW4gYmUgYWRkZWQgdG8gYSBE
Uk0gY29ubmVjdG9yCj4gPiBkeW5hbWljYWxseSBieSB1c2luZyBkcm1fY29ubmVjdG9yX2F0dGFj
aF92YXJpYWJsZV9yZWZyZXNoX3Byb3BlcnRpZXMuCj4gPiAKPiA+IERSTSBkcml2ZXJzIHNob3Vs
ZCBzZXQgdmFyaWFibGVfcmVmcmVzaF9jYXBhYmxlIGFzIGFwcGxpY2FibGUgZm9yCj4gPiB0aGVp
ciBoYXJkd2FyZS4gVGhlIHByb3BlcnR5IHZhcmlhYmxlX3JlZnJlc2hfZW5hYmxlZCBpcyBhIHVz
ZXJzcGFjZQo+ID4gY29udHJvbGxlZCBvcHRpb24uCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IE5p
Y2hvbGFzIEthemxhdXNrYXMgPG5pY2hvbGFzLmthemxhdXNrYXNAYW1kLmNvbT4KPiA+IC0tLQo+
ID4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX3VhcGkuYyB8ICA2ICsrKysrKwo+ID4gIGRy
aXZlcnMvZ3B1L2RybS9kcm1fY29ubmVjdG9yLmMgICB8IDM1ICsrKysrKysrKysrKysrKysrKysr
KysrKysrKysrKysKPiA+ICBpbmNsdWRlL2RybS9kcm1fY29ubmVjdG9yLmggICAgICAgfCAyNyAr
KysrKysrKysrKysrKysrKysrKysrKysKPiA+ICAzIGZpbGVzIGNoYW5nZWQsIDY4IGluc2VydGlv
bnMoKykKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX3Vh
cGkuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX3VhcGkuYwo+ID4gaW5kZXggZDViN2Yz
MTUwOThjLi4wYmIyN2EyNGE1NWMgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJt
X2F0b21pY191YXBpLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX3VhcGku
Ywo+ID4gQEAgLTcyMyw2ICs3MjMsOCBAQCBzdGF0aWMgaW50IGRybV9hdG9taWNfY29ubmVjdG9y
X3NldF9wcm9wZXJ0eShzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+ID4gIAkJc3Rh
dGUtPmNvbnRlbnRfdHlwZSA9IHZhbDsKPiA+ICAJfSBlbHNlIGlmIChwcm9wZXJ0eSA9PSBjb25u
ZWN0b3ItPnNjYWxpbmdfbW9kZV9wcm9wZXJ0eSkgewo+ID4gIAkJc3RhdGUtPnNjYWxpbmdfbW9k
ZSA9IHZhbDsKPiA+ICsJfSBlbHNlIGlmIChwcm9wZXJ0eSA9PSBjb25uZWN0b3ItPnZhcmlhYmxl
X3JlZnJlc2hfZW5hYmxlZF9wcm9wZXJ0eSkgewo+ID4gKwkJc3RhdGUtPnZhcmlhYmxlX3JlZnJl
c2hfZW5hYmxlZCA9IHZhbDsKPiA+ICAJfSBlbHNlIGlmIChwcm9wZXJ0eSA9PSBjb25uZWN0b3It
PmNvbnRlbnRfcHJvdGVjdGlvbl9wcm9wZXJ0eSkgewo+ID4gIAkJaWYgKHZhbCA9PSBEUk1fTU9E
RV9DT05URU5UX1BST1RFQ1RJT05fRU5BQkxFRCkgewo+ID4gIAkJCURSTV9ERUJVR19LTVMoIm9u
bHkgZHJpdmVycyBjYW4gc2V0IENQIEVuYWJsZWRcbiIpOwo+ID4gQEAgLTc5Nyw2ICs3OTksMTAg
QEAgZHJtX2F0b21pY19jb25uZWN0b3JfZ2V0X3Byb3BlcnR5KHN0cnVjdCBkcm1fY29ubmVjdG9y
ICpjb25uZWN0b3IsCj4gPiAgCQkqdmFsID0gc3RhdGUtPmNvbnRlbnRfdHlwZTsKPiA+ICAJfSBl
bHNlIGlmIChwcm9wZXJ0eSA9PSBjb25uZWN0b3ItPnNjYWxpbmdfbW9kZV9wcm9wZXJ0eSkgewo+
ID4gIAkJKnZhbCA9IHN0YXRlLT5zY2FsaW5nX21vZGU7Cj4gPiArCX0gZWxzZSBpZiAocHJvcGVy
dHkgPT0gY29ubmVjdG9yLT52YXJpYWJsZV9yZWZyZXNoX2NhcGFibGVfcHJvcGVydHkpIHsKPiA+
ICsJCSp2YWwgPSBzdGF0ZS0+dmFyaWFibGVfcmVmcmVzaF9jYXBhYmxlOwo+IAo+IEltbXV0YWJs
ZSBwcm9wcyBkb24ndCB0YWtlIHRoaXMgcGF0aC4gU2VlCj4gX19kcm1fb2JqZWN0X3Byb3BlcnR5
X2dldF92YWx1ZSgpLgoKWWVhaCBJIHRoaW5rIGFuIGV4cGxpY2l0IHNldCBmdW5jdGlvbiAobGlr
ZSB3ZSBoYXZlIGZvciBlZGlkLCBsaW5rX3N0YXR1cywKLi4uKSB3b3VsZCBiZSBnb29kIGhlcmUu
IEdpdmVzIHVzIGF0IGxlYXN0IGEgbmVhdCB3YXkgdG8gYXR0YWNoIHNvbWUgbW9yZQprZXJuZWwt
ZG9jLgotRGFuaWVsCgo+IAo+ID4gKwl9IGVsc2UgaWYgKHByb3BlcnR5ID09IGNvbm5lY3Rvci0+
dmFyaWFibGVfcmVmcmVzaF9lbmFibGVkX3Byb3BlcnR5KSB7Cj4gPiArCQkqdmFsID0gc3RhdGUt
PnZhcmlhYmxlX3JlZnJlc2hfZW5hYmxlZDsKPiA+ICAJfSBlbHNlIGlmIChwcm9wZXJ0eSA9PSBj
b25uZWN0b3ItPmNvbnRlbnRfcHJvdGVjdGlvbl9wcm9wZXJ0eSkgewo+ID4gIAkJKnZhbCA9IHN0
YXRlLT5jb250ZW50X3Byb3RlY3Rpb247Cj4gPiAgCX0gZWxzZSBpZiAocHJvcGVydHkgPT0gY29u
ZmlnLT53cml0ZWJhY2tfZmJfaWRfcHJvcGVydHkpIHsKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJz
L2dwdS9kcm0vZHJtX2Nvbm5lY3Rvci5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9jb25uZWN0b3Iu
Ywo+ID4gaW5kZXggMWU0MGU1ZGVjYmU5Li5mYzE3MzI2MzliZDMgMTAwNjQ0Cj4gPiAtLS0gYS9k
cml2ZXJzL2dwdS9kcm0vZHJtX2Nvbm5lY3Rvci5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v
ZHJtX2Nvbm5lY3Rvci5jCj4gPiBAQCAtMTI1NCw2ICsxMjU0LDQxIEBAIGludCBkcm1fbW9kZV9j
cmVhdGVfc2NhbGluZ19tb2RlX3Byb3BlcnR5KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gPiAg
fQo+ID4gIEVYUE9SVF9TWU1CT0woZHJtX21vZGVfY3JlYXRlX3NjYWxpbmdfbW9kZV9wcm9wZXJ0
eSk7Cj4gPiAgCj4gPiArLyoqCj4gPiArICogZHJtX2Nvbm5lY3Rvcl9hdHRhY2hfdmFyaWFibGVf
cmVmcmVzaF9wcm9wZXJ0aWVzIC0gY3JlYXRlcyBhbmQgYXR0YWNoZXMKPiA+ICsgKiBwcm9wZXJ0
aWVzIGZvciBjb25uZWN0b3JzIHRoYXQgc3VwcG9ydCBhZGFwdGl2ZSByZWZyZXNoCj4gPiArICog
QGNvbm5lY3RvcjogY29ubmVjdG9yIHRvIGNyZWF0ZSBhZGFwdGl2ZSByZWZyZXNoIHByb3BlcnRp
ZXMgb24KPiA+ICsgKi8KPiA+ICtpbnQgZHJtX2Nvbm5lY3Rvcl9hdHRhY2hfdmFyaWFibGVfcmVm
cmVzaF9wcm9wZXJ0aWVzKAo+ID4gKwlzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yKQo+
ID4gK3sKPiA+ICsJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGNvbm5lY3Rvci0+ZGV2Owo+ID4g
KwlzdHJ1Y3QgZHJtX3Byb3BlcnR5ICpwcm9wOwo+ID4gKwo+ID4gKwlpZiAoIWNvbm5lY3Rvci0+
dmFyaWFibGVfcmVmcmVzaF9jYXBhYmxlX3Byb3BlcnR5KSB7Cj4gPiArCQlwcm9wID0gZHJtX3By
b3BlcnR5X2NyZWF0ZV9ib29sKGRldiwgRFJNX01PREVfUFJPUF9JTU1VVEFCTEUsCj4gPiArCQkJ
InZhcmlhYmxlX3JlZnJlc2hfY2FwYWJsZSIpOwo+ID4gKwkJaWYgKCFwcm9wKQo+ID4gKwkJCXJl
dHVybiAtRU5PTUVNOwo+ID4gKwo+ID4gKwkJY29ubmVjdG9yLT52YXJpYWJsZV9yZWZyZXNoX2Nh
cGFibGVfcHJvcGVydHkgPSBwcm9wOwo+ID4gKwkJZHJtX29iamVjdF9hdHRhY2hfcHJvcGVydHko
JmNvbm5lY3Rvci0+YmFzZSwgcHJvcCwgMCk7Cj4gPiArCX0KPiA+ICsKPiA+ICsJaWYgKCFjb25u
ZWN0b3ItPnZhcmlhYmxlX3JlZnJlc2hfZW5hYmxlZF9wcm9wZXJ0eSkgewo+ID4gKwkJcHJvcCA9
IGRybV9wcm9wZXJ0eV9jcmVhdGVfYm9vbChkZXYsIDAsCj4gPiArCQkJInZhcmlhYmxlX3JlZnJl
c2hfZW5hYmxlZCIpOwo+ID4gKwkJaWYgKCFwcm9wKQo+ID4gKwkJCXJldHVybiAtRU5PTUVNOwo+
ID4gKwo+ID4gKwkJY29ubmVjdG9yLT52YXJpYWJsZV9yZWZyZXNoX2VuYWJsZWRfcHJvcGVydHkg
PSBwcm9wOwo+ID4gKwkJZHJtX29iamVjdF9hdHRhY2hfcHJvcGVydHkoJmNvbm5lY3Rvci0+YmFz
ZSwgcHJvcCwgMCk7Cj4gPiArCX0KPiA+ICsKPiA+ICsJcmV0dXJuIDA7Cj4gPiArfQo+ID4gK0VY
UE9SVF9TWU1CT0woZHJtX2Nvbm5lY3Rvcl9hdHRhY2hfdmFyaWFibGVfcmVmcmVzaF9wcm9wZXJ0
aWVzKTsKPiA+ICsKPiA+ICAvKioKPiA+ICAgKiBkcm1fY29ubmVjdG9yX2F0dGFjaF9zY2FsaW5n
X21vZGVfcHJvcGVydHkgLSBhdHRhY2ggYXRvbWljIHNjYWxpbmcgbW9kZSBwcm9wZXJ0eQo+ID4g
ICAqIEBjb25uZWN0b3I6IGNvbm5lY3RvciB0byBhdHRhY2ggc2NhbGluZyBtb2RlIHByb3BlcnR5
IG9uLgo+ID4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvZHJtL2RybV9jb25uZWN0b3IuaCBiL2luY2x1
ZGUvZHJtL2RybV9jb25uZWN0b3IuaAo+ID4gaW5kZXggOTFhODc3ZmEwMGNiLi5lMmMyNjg0MmJk
NTAgMTAwNjQ0Cj4gPiAtLS0gYS9pbmNsdWRlL2RybS9kcm1fY29ubmVjdG9yLmgKPiA+ICsrKyBi
L2luY2x1ZGUvZHJtL2RybV9jb25uZWN0b3IuaAo+ID4gQEAgLTQ0OSw2ICs0NDksMTggQEAgc3Ry
dWN0IGRybV9jb25uZWN0b3Jfc3RhdGUgewo+ID4gIAkgKi8KPiA+ICAJdW5zaWduZWQgaW50IGNv
bnRlbnRfcHJvdGVjdGlvbjsKPiA+ICAKPiA+ICsJLyoqCj4gPiArCSAqIEB2YXJpYWJsZV9yZWZy
ZXNoX2VuYWJsZWQ6IENvbm5lY3RvciBwcm9wZXJ0eSB1c2VkIHRvIGNoZWNrCj4gPiArCSAqIGlm
IHZhcmlhYmxlIHJlZnJlc2ggaXMgc3VwcG9ydGVkIG9uIHRoZSBkZXZpY2UuCj4gPiArCSAqLwo+
ID4gKwlib29sIHZhcmlhYmxlX3JlZnJlc2hfY2FwYWJsZTsKPiA+ICsKPiA+ICsJLyoqCj4gPiAr
CSAqIEB2YXJpYWJsZV9yZWZyZXNoX2VuYWJsZWQ6IENvbm5lY3RvciBwcm9wZXJ0eSB1c2VkIHRv
IGNoZWNrCj4gPiArCSAqIGlmIHZhcmlhYmxlIHJlZnJlc2ggaXMgZW5hYmxlZC4KPiA+ICsJICov
Cj4gPiArCWJvb2wgdmFyaWFibGVfcmVmcmVzaF9lbmFibGVkOwo+ID4gKwo+ID4gIAkvKioKPiA+
ICAJICogQHdyaXRlYmFja19qb2I6IFdyaXRlYmFjayBqb2IgZm9yIHdyaXRlYmFjayBjb25uZWN0
b3JzCj4gPiAgCSAqCj4gPiBAQCAtOTEwLDYgKzkyMiwxOSBAQCBzdHJ1Y3QgZHJtX2Nvbm5lY3Rv
ciB7Cj4gPiAgCSAqLwo+ID4gIAlzdHJ1Y3QgZHJtX3Byb3BlcnR5ICpzY2FsaW5nX21vZGVfcHJv
cGVydHk7Cj4gPiAgCj4gPiArCS8qKgo+ID4gKwkgKiBAdmFyaWFibGVfcmVmcmVzaF9jYXBhYmxl
X3Byb3BlcnR5OiBPcHRpb25hbCBwcm9wZXJ0eSBmb3IKPiA+ICsJICogcXVlcnlpbmcgaGFyZHdh
cmUgc3VwcG9ydCBmb3IgdmFyaWFibGUgcmVmcmVzaC4KPiA+ICsJICovCj4gPiArCXN0cnVjdCBk
cm1fcHJvcGVydHkgKnZhcmlhYmxlX3JlZnJlc2hfY2FwYWJsZV9wcm9wZXJ0eTsKPiA+ICsKPiA+
ICsJLyoqCj4gPiArCSAqIEB2YXJpYWJsZV9yZWZyZXNoX2VuYWJsZWRfcHJvcGVydHk6IE9wdGlv
bmFsIHByb3BlcnR5IGZvcgo+ID4gKwkgKiBlbmFibGluZyBvciBkaXNhYmxpbmcgc3VwcG9ydCBm
b3IgdmFyaWFibGUgcmVmcmVzaAo+ID4gKwkgKiBvbiB0aGUgY29ubmVjdG9yLgo+ID4gKwkgKi8K
PiA+ICsJc3RydWN0IGRybV9wcm9wZXJ0eSAqdmFyaWFibGVfcmVmcmVzaF9lbmFibGVkX3Byb3Bl
cnR5Owo+ID4gKwo+ID4gIAkvKioKPiA+ICAJICogQGNvbnRlbnRfcHJvdGVjdGlvbl9wcm9wZXJ0
eTogRFJNIEVOVU0gcHJvcGVydHkgZm9yIGNvbnRlbnQKPiA+ICAJICogcHJvdGVjdGlvbi4gU2Vl
IGRybV9jb25uZWN0b3JfYXR0YWNoX2NvbnRlbnRfcHJvdGVjdGlvbl9wcm9wZXJ0eSgpLgo+ID4g
QEAgLTExODMsNiArMTIwOCw4IEBAIGludCBkcm1fbW9kZV9jcmVhdGVfc2NhbGluZ19tb2RlX3By
b3BlcnR5KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpOwo+ID4gIGludCBkcm1fY29ubmVjdG9yX2F0
dGFjaF9jb250ZW50X3R5cGVfcHJvcGVydHkoc3RydWN0IGRybV9jb25uZWN0b3IgKmRldik7Cj4g
PiAgaW50IGRybV9jb25uZWN0b3JfYXR0YWNoX3NjYWxpbmdfbW9kZV9wcm9wZXJ0eShzdHJ1Y3Qg
ZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+ID4gIAkJCQkJICAgICAgIHUzMiBzY2FsaW5nX21v
ZGVfbWFzayk7Cj4gPiAraW50IGRybV9jb25uZWN0b3JfYXR0YWNoX3ZhcmlhYmxlX3JlZnJlc2hf
cHJvcGVydGllcygKPiA+ICsJc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3Rvcik7Cj4gPiAg
aW50IGRybV9jb25uZWN0b3JfYXR0YWNoX2NvbnRlbnRfcHJvdGVjdGlvbl9wcm9wZXJ0eSgKPiA+
ICAJCXN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IpOwo+ID4gIGludCBkcm1fbW9kZV9j
cmVhdGVfYXNwZWN0X3JhdGlvX3Byb3BlcnR5KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpOwo+ID4g
LS0gCj4gPiAyLjE5LjAKPiAKPiAtLSAKPiBWaWxsZSBTeXJqw6Rsw6QKPiBJbnRlbAoKLS0gCkRh
bmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9i
bG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y
ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl
bAo=