From mboxrd@z Thu Jan 1 00:00:00 1970 From: Huang Rui Subject: Re: [PATCH 1/8] drm/amdgpu: fix incorrect use of amdgpu_irq_add_id in si_dma.c Date: Tue, 9 Oct 2018 16:37:19 +0800 Message-ID: <20181009083717.GA8763@hr-amur2> References: <20181008133521.3237-1-christian.koenig@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20181008133521.3237-1-christian.koenig-5C7GfCeVMHo@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org T24gTW9uLCBPY3QgMDgsIDIwMTggYXQgMDM6MzU6MTRQTSArMDIwMCwgQ2hyaXN0aWFuIEvDtm5p ZyB3cm90ZToKPiBBZGRpbmcgYSBzZWNvbmQgaXJxIHNvdXJjZSBiZWNhdXNlIG9mIGEgZGlmZmVy ZW50IHNyY19pZCBpcyBhY3R1YWxseSBhCj4gYnVnLgo+IAo+IFNpZ25lZC1vZmYtYnk6IENocmlz dGlhbiBLw7ZuaWcgPGNocmlzdGlhbi5rb2VuaWdAYW1kLmNvbT4KClJldmlld2VkLWJ5OiBIdWFu ZyBSdWkgPHJheS5odWFuZ0BhbWQuY29tPgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2FtZC9h bWRncHUvYW1kZ3B1X3NkbWEuaCB8ICA0IC0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRn cHUvc2lfZG1hLmMgICAgICB8IDI3ICsrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICAyIGZp bGVzIGNoYW5nZWQsIDggaW5zZXJ0aW9ucygrKSwgMjMgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9zZG1hLmggYi9kcml2ZXJz L2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfc2RtYS5oCj4gaW5kZXggZDE3NTAzZjBkZjhlLi41 MDAxMTNlYzY1Y2EgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1k Z3B1X3NkbWEuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9zZG1h LmgKPiBAQCAtNDYsMTAgKzQ2LDYgQEAgc3RydWN0IGFtZGdwdV9zZG1hX2luc3RhbmNlIHsKPiAg Cj4gIHN0cnVjdCBhbWRncHVfc2RtYSB7Cj4gIAlzdHJ1Y3QgYW1kZ3B1X3NkbWFfaW5zdGFuY2Ug aW5zdGFuY2VbQU1ER1BVX01BWF9TRE1BX0lOU1RBTkNFU107Cj4gLSNpZmRlZiBDT05GSUdfRFJN X0FNREdQVV9TSQo+IC0JLy9TSSBETUEgaGFzIGEgZGlmZmVyZW5jZSB0cmFwIGlycSBudW1iZXIg Zm9yIHRoZSBzZWNvbmQgZW5naW5lCj4gLQlzdHJ1Y3QgYW1kZ3B1X2lycV9zcmMJdHJhcF9pcnFf MTsKPiAtI2VuZGlmCj4gIAlzdHJ1Y3QgYW1kZ3B1X2lycV9zcmMJdHJhcF9pcnE7Cj4gIAlzdHJ1 Y3QgYW1kZ3B1X2lycV9zcmMJaWxsZWdhbF9pbnN0X2lycTsKPiAgCWludAkJCW51bV9pbnN0YW5j ZXM7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L3NpX2RtYS5jIGIv ZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvc2lfZG1hLmMKPiBpbmRleCBkNGNlYWY0NDBmMjYu LmFkYmFlYTZkYTBkNyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9z aV9kbWEuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L3NpX2RtYS5jCj4gQEAg LTUwMiwxMiArNTAyLDE0IEBAIHN0YXRpYyBpbnQgc2lfZG1hX3N3X2luaXQodm9pZCAqaGFuZGxl KQo+ICAJc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYgPSAoc3RydWN0IGFtZGdwdV9kZXZpY2Ug KiloYW5kbGU7Cj4gIAo+ICAJLyogRE1BMCB0cmFwIGV2ZW50ICovCj4gLQlyID0gYW1kZ3B1X2ly cV9hZGRfaWQoYWRldiwgQU1ER1BVX0lSUV9DTElFTlRJRF9MRUdBQ1ksIDIyNCwgJmFkZXYtPnNk bWEudHJhcF9pcnEpOwo+ICsJciA9IGFtZGdwdV9pcnFfYWRkX2lkKGFkZXYsIEFNREdQVV9JUlFf Q0xJRU5USURfTEVHQUNZLCAyMjQsCj4gKwkJCSAgICAgICZhZGV2LT5zZG1hLnRyYXBfaXJxKTsK PiAgCWlmIChyKQo+ICAJCXJldHVybiByOwo+ICAKPiAgCS8qIERNQTEgdHJhcCBldmVudCAqLwo+ IC0JciA9IGFtZGdwdV9pcnFfYWRkX2lkKGFkZXYsIEFNREdQVV9JUlFfQ0xJRU5USURfTEVHQUNZ LCAyNDQsICZhZGV2LT5zZG1hLnRyYXBfaXJxXzEpOwo+ICsJciA9IGFtZGdwdV9pcnFfYWRkX2lk KGFkZXYsIEFNREdQVV9JUlFfQ0xJRU5USURfTEVHQUNZLCAyNDQsCj4gKwkJCSAgICAgICZhZGV2 LT5zZG1hLnRyYXBfaXJxKTsKPiAgCWlmIChyKQo+ICAJCXJldHVybiByOwo+ICAKPiBAQCAtNjQ5 LDE3ICs2NTEsMTAgQEAgc3RhdGljIGludCBzaV9kbWFfcHJvY2Vzc190cmFwX2lycShzdHJ1Y3Qg YW1kZ3B1X2RldmljZSAqYWRldiwKPiAgCQkJCSAgICAgIHN0cnVjdCBhbWRncHVfaXJxX3NyYyAq c291cmNlLAo+ICAJCQkJICAgICAgc3RydWN0IGFtZGdwdV9pdl9lbnRyeSAqZW50cnkpCj4gIHsK PiAtCWFtZGdwdV9mZW5jZV9wcm9jZXNzKCZhZGV2LT5zZG1hLmluc3RhbmNlWzBdLnJpbmcpOwo+ IC0KPiAtCXJldHVybiAwOwo+IC19Cj4gLQo+IC1zdGF0aWMgaW50IHNpX2RtYV9wcm9jZXNzX3Ry YXBfaXJxXzEoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYsCj4gLQkJCQkgICAgICBzdHJ1Y3Qg YW1kZ3B1X2lycV9zcmMgKnNvdXJjZSwKPiAtCQkJCSAgICAgIHN0cnVjdCBhbWRncHVfaXZfZW50 cnkgKmVudHJ5KQo+IC17Cj4gLQlhbWRncHVfZmVuY2VfcHJvY2VzcygmYWRldi0+c2RtYS5pbnN0 YW5jZVsxXS5yaW5nKTsKPiAtCj4gKwlpZiAoZW50cnktPnNyY19pZCA9PSAyMjQpCj4gKwkJYW1k Z3B1X2ZlbmNlX3Byb2Nlc3MoJmFkZXYtPnNkbWEuaW5zdGFuY2VbMF0ucmluZyk7Cj4gKwllbHNl Cj4gKwkJYW1kZ3B1X2ZlbmNlX3Byb2Nlc3MoJmFkZXYtPnNkbWEuaW5zdGFuY2VbMV0ucmluZyk7 Cj4gIAlyZXR1cm4gMDsKPiAgfQo+ICAKPiBAQCAtNzg2LDExICs3ODEsNiBAQCBzdGF0aWMgY29u c3Qgc3RydWN0IGFtZGdwdV9pcnFfc3JjX2Z1bmNzIHNpX2RtYV90cmFwX2lycV9mdW5jcyA9IHsK PiAgCS5wcm9jZXNzID0gc2lfZG1hX3Byb2Nlc3NfdHJhcF9pcnEsCj4gIH07Cj4gIAo+IC1zdGF0 aWMgY29uc3Qgc3RydWN0IGFtZGdwdV9pcnFfc3JjX2Z1bmNzIHNpX2RtYV90cmFwX2lycV9mdW5j c18xID0gewo+IC0JLnNldCA9IHNpX2RtYV9zZXRfdHJhcF9pcnFfc3RhdGUsCj4gLQkucHJvY2Vz cyA9IHNpX2RtYV9wcm9jZXNzX3RyYXBfaXJxXzEsCj4gLX07Cj4gLQo+ICBzdGF0aWMgY29uc3Qg c3RydWN0IGFtZGdwdV9pcnFfc3JjX2Z1bmNzIHNpX2RtYV9pbGxlZ2FsX2luc3RfaXJxX2Z1bmNz ID0gewo+ICAJLnByb2Nlc3MgPSBzaV9kbWFfcHJvY2Vzc19pbGxlZ2FsX2luc3RfaXJxLAo+ICB9 Owo+IEBAIC03OTksNyArNzg5LDYgQEAgc3RhdGljIHZvaWQgc2lfZG1hX3NldF9pcnFfZnVuY3Mo c3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYpCj4gIHsKPiAgCWFkZXYtPnNkbWEudHJhcF9pcnEu bnVtX3R5cGVzID0gQU1ER1BVX1NETUFfSVJRX0xBU1Q7Cj4gIAlhZGV2LT5zZG1hLnRyYXBfaXJx LmZ1bmNzID0gJnNpX2RtYV90cmFwX2lycV9mdW5jczsKPiAtCWFkZXYtPnNkbWEudHJhcF9pcnFf MS5mdW5jcyA9ICZzaV9kbWFfdHJhcF9pcnFfZnVuY3NfMTsKPiAgCWFkZXYtPnNkbWEuaWxsZWdh bF9pbnN0X2lycS5mdW5jcyA9ICZzaV9kbWFfaWxsZWdhbF9pbnN0X2lycV9mdW5jczsKPiAgfQo+ ICAKPiAtLSAKPiAyLjE0LjEKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwo+IGFtZC1nZnggbWFpbGluZyBsaXN0Cj4gYW1kLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2FtZC1nZngKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KYW1kLWdmeCBtYWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg==