From mboxrd@z Thu Jan 1 00:00:00 1970 From: Huang Rui Subject: Re: [PATCH 4/8] drm/amdgpu: remove non gfx specific handling from sdma_v4_0_gfx_resume Date: Tue, 9 Oct 2018 17:34:31 +0800 Message-ID: <20181009093430.GD8763@hr-amur2> References: <20181008133521.3237-1-christian.koenig@amd.com> <20181008133521.3237-4-christian.koenig@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20181008133521.3237-4-christian.koenig-5C7GfCeVMHo@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org T24gTW9uLCBPY3QgMDgsIDIwMTggYXQgMDM6MzU6MTdQTSArMDIwMCwgQ2hyaXN0aWFuIEvDtm5p ZyB3cm90ZToKPiBOZWVkZWQgdG8gc3RhcnQgdXNpbmcgdGhlIHBhZ2luZyBxdWV1ZS4KPiAKPiBT aWduZWQtb2ZmLWJ5OiBDaHJpc3RpYW4gS8O2bmlnIDxjaHJpc3RpYW4ua29lbmlnQGFtZC5jb20+ CgpSZXZpZXdlZC1ieTogSHVhbmcgUnVpIDxyYXkuaHVhbmdAYW1kLmNvbT4KCj4gLS0tCj4gIGRy aXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L3NkbWFfdjRfMC5jIHwgMzYgKysrKysrKysrKysrKysr KysrKy0tLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMjAgaW5zZXJ0aW9ucygrKSwg MTYgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1k Z3B1L3NkbWFfdjRfMC5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvc2RtYV92NF8wLmMK PiBpbmRleCA1ZWNmNmM5MjUyYzQuLjExMjRiNDVkMTY2ZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vYW1kL2FtZGdwdS9zZG1hX3Y0XzAuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9h bWQvYW1kZ3B1L3NkbWFfdjRfMC5jCj4gQEAgLTY4NiwxMyArNjg2LDEwIEBAIHN0YXRpYyB2b2lk IHNkbWFfdjRfMF9nZnhfcmVzdW1lKHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2LCB1bnNpZ25l ZCBpbnQgaSkKPiAgCXUzMiB3Yl9vZmZzZXQ7Cj4gIAl1MzIgZG9vcmJlbGw7Cj4gIAl1MzIgZG9v cmJlbGxfb2Zmc2V0Owo+IC0JdTMyIHRlbXA7Cj4gIAl1NjQgd3B0cl9ncHVfYWRkcjsKPiAgCj4g IAl3Yl9vZmZzZXQgPSAocmluZy0+cnB0cl9vZmZzICogNCk7Cj4gIAo+IC0JV1JFRzMyKHNkbWFf djRfMF9nZXRfcmVnX29mZnNldChhZGV2LCBpLCBtbVNETUEwX1NFTV9XQUlUX0ZBSUxfVElNRVJf Q05UTCksIDApOwo+IC0KPiAgCS8qIFNldCByaW5nIGJ1ZmZlciBzaXplIGluIGR3b3JkcyAqLwo+ ICAJcmJfYnVmc3ogPSBvcmRlcl9iYXNlXzIocmluZy0+cmluZ19zaXplIC8gNCk7Cj4gIAlyYl9j bnRsID0gUlJFRzMyKHNkbWFfdjRfMF9nZXRfcmVnX29mZnNldChhZGV2LCBpLCBtbVNETUEwX0dG WF9SQl9DTlRMKSk7Cj4gQEAgLTc1MiwxOCArNzQ5LDYgQEAgc3RhdGljIHZvaWQgc2RtYV92NF8w X2dmeF9yZXN1bWUoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYsIHVuc2lnbmVkIGludCBpKQo+ ICAJLyogc2V0IG1pbm9yX3B0cl91cGRhdGUgdG8gMCBhZnRlciB3cHRyIHByb2dyYW1lZCAqLwo+ ICAJV1JFRzMyKHNkbWFfdjRfMF9nZXRfcmVnX29mZnNldChhZGV2LCBpLCBtbVNETUEwX0dGWF9N SU5PUl9QVFJfVVBEQVRFKSwgMCk7Cj4gIAo+IC0JLyogc2V0IHV0YyBsMSBlbmFibGUgZmxhZyBh bHdheXMgdG8gMSAqLwo+IC0JdGVtcCA9IFJSRUczMihzZG1hX3Y0XzBfZ2V0X3JlZ19vZmZzZXQo YWRldiwgaSwgbW1TRE1BMF9DTlRMKSk7Cj4gLQl0ZW1wID0gUkVHX1NFVF9GSUVMRCh0ZW1wLCBT RE1BMF9DTlRMLCBVVENfTDFfRU5BQkxFLCAxKTsKPiAtCVdSRUczMihzZG1hX3Y0XzBfZ2V0X3Jl Z19vZmZzZXQoYWRldiwgaSwgbW1TRE1BMF9DTlRMKSwgdGVtcCk7Cj4gLQo+IC0JaWYgKCFhbWRn cHVfc3Jpb3ZfdmYoYWRldikpIHsKPiAtCQkvKiB1bmhhbHQgZW5naW5lICovCj4gLQkJdGVtcCA9 IFJSRUczMihzZG1hX3Y0XzBfZ2V0X3JlZ19vZmZzZXQoYWRldiwgaSwgbW1TRE1BMF9GMzJfQ05U TCkpOwo+IC0JCXRlbXAgPSBSRUdfU0VUX0ZJRUxEKHRlbXAsIFNETUEwX0YzMl9DTlRMLCBIQUxU LCAwKTsKPiAtCQlXUkVHMzIoc2RtYV92NF8wX2dldF9yZWdfb2Zmc2V0KGFkZXYsIGksIG1tU0RN QTBfRjMyX0NOVEwpLCB0ZW1wKTsKPiAtCX0KPiAtCj4gIAkvKiBzZXR1cCB0aGUgd3B0ciBzaGFk b3cgcG9sbGluZyAqLwo+ICAJd3B0cl9ncHVfYWRkciA9IGFkZXYtPndiLmdwdV9hZGRyICsgKHJp bmctPndwdHJfb2ZmcyAqIDQpOwo+ICAJV1JFRzMyKHNkbWFfdjRfMF9nZXRfcmVnX29mZnNldChh ZGV2LCBpLCBtbVNETUEwX0dGWF9SQl9XUFRSX1BPTExfQUREUl9MTyksCj4gQEAgLTk0Miw5ICs5 MjcsMjggQEAgc3RhdGljIGludCBzZG1hX3Y0XzBfc3RhcnQoc3RydWN0IGFtZGdwdV9kZXZpY2Ug KmFkZXYpCj4gIAl9Cj4gIAo+ICAJLyogc3RhcnQgdGhlIGdmeCByaW5ncyBhbmQgcmxjIGNvbXB1 dGUgcXVldWVzICovCj4gLQlmb3IgKGkgPSAwOyBpIDwgYWRldi0+c2RtYS5udW1faW5zdGFuY2Vz OyBpKyspCj4gKwlmb3IgKGkgPSAwOyBpIDwgYWRldi0+c2RtYS5udW1faW5zdGFuY2VzOyBpKysp IHsKPiArCQl1aW50MzJfdCB0ZW1wOwo+ICsKPiArCQlXUkVHMzIoc2RtYV92NF8wX2dldF9yZWdf b2Zmc2V0KGFkZXYsIGksCj4gKwkJCQltbVNETUEwX1NFTV9XQUlUX0ZBSUxfVElNRVJfQ05UTCks IDApOwo+ICAJCXNkbWFfdjRfMF9nZnhfcmVzdW1lKGFkZXYsIGkpOwo+ICAKPiArCQkvKiBzZXQg dXRjIGwxIGVuYWJsZSBmbGFnIGFsd2F5cyB0byAxICovCj4gKwkJdGVtcCA9IFJSRUczMihzZG1h X3Y0XzBfZ2V0X3JlZ19vZmZzZXQoYWRldiwgaSwgbW1TRE1BMF9DTlRMKSk7Cj4gKwkJdGVtcCA9 IFJFR19TRVRfRklFTEQodGVtcCwgU0RNQTBfQ05UTCwgVVRDX0wxX0VOQUJMRSwgMSk7Cj4gKwkJ V1JFRzMyKHNkbWFfdjRfMF9nZXRfcmVnX29mZnNldChhZGV2LCBpLCBtbVNETUEwX0NOVEwpLCB0 ZW1wKTsKPiArCj4gKwkJaWYgKCFhbWRncHVfc3Jpb3ZfdmYoYWRldikpIHsKPiArCQkJLyogdW5o YWx0IGVuZ2luZSAqLwo+ICsJCQl0ZW1wID0gUlJFRzMyKHNkbWFfdjRfMF9nZXRfcmVnX29mZnNl dChhZGV2LCBpLAo+ICsJCQkJCW1tU0RNQTBfRjMyX0NOVEwpKTsKPiArCQkJdGVtcCA9IFJFR19T RVRfRklFTEQodGVtcCwgU0RNQTBfRjMyX0NOVEwsIEhBTFQsIDApOwo+ICsJCQlXUkVHMzIoc2Rt YV92NF8wX2dldF9yZWdfb2Zmc2V0KGFkZXYsIGksCj4gKwkJCQkJbW1TRE1BMF9GMzJfQ05UTCks IHRlbXApOwo+ICsJCX0KPiArCX0KPiArCj4gIAlpZiAoYW1kZ3B1X3NyaW92X3ZmKGFkZXYpKSB7 Cj4gIAkJc2RtYV92NF8wX2N0eF9zd2l0Y2hfZW5hYmxlKGFkZXYsIHRydWUpOwo+ICAJCXNkbWFf djRfMF9lbmFibGUoYWRldiwgdHJ1ZSk7Cj4gLS0gCj4gMi4xNC4xCj4gCj4gX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBhbWQtZ2Z4IG1haWxpbmcgbGlz dAo+IGFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmFtZC1nZnggbWFpbGluZyBsaXN0CmFtZC1nZnhAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vYW1kLWdmeAo=