From mboxrd@z Thu Jan 1 00:00:00 1970 From: Huang Rui Subject: Re: [PATCH 2/8] drm/amdgpu: fix sdma v4 startup under SRIOV Date: Tue, 16 Oct 2018 22:42:17 +0800 Message-ID: <20181016144048.GA10291@hr-amur2> References: <20181008133521.3237-2-christian.koenig@amd.com> <20181009091708.GB8763@hr-amur2> <5ae6a2fe-80d6-858e-dcd2-2d44ab0b76ce@gmail.com> <8d7c9d2e-6d4d-34d3-d8dc-102e253610f2@amd.com> <2512cfee-a603-75c4-bf10-9ae0b4b8c5c7@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <2512cfee-a603-75c4-bf10-9ae0b4b8c5c7-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Koenig, Christian" Cc: "Min, Frank" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , "Liu, Monk" , "Ma, Sigil" T24gVHVlLCBPY3QgMTYsIDIwMTggYXQgMDg6MzQ6MzdQTSArMDgwMCwgQ2hyaXN0aWFuIEvDtm5p ZyB3cm90ZToKPiBBbm90aGVyIGdlbnRsZSBwaW5nPyBSYXksIE1vbmsgY2FuIGFueWJvZHkgZ2l2 ZSBtZSBhbiByYiBmb3IgdGhpcyBwYXRjaD8KPiAKPiBJdCdzIHRoZSBsYXN0IG9uZSBpbiB0aGlz IHNlcmllcyBhbmQgSSB3YW50IHRvIGdldCBpdCBkb25lLgo+IAoKRmVlbCBmcmVlIHRvIGFkZAoK UmV2aWV3ZWQtYnk6IEh1YW5nIFJ1aSA8cmF5Lmh1YW5nQGFtZC5jb20+Cgo+IENocmlzdGlhbi4K PiAKPiBBbSAxMi4xMC4yMDE4IHVtIDE2OjI3IHNjaHJpZWIgS29lbmlnLCBDaHJpc3RpYW46Cj4g PiBHcmVhdCwgY2FuIEkgZ2V0IGFuIHJiIG9yIGFja2VkLWJ5IGZvciB0aGUgcGF0Y2ggaW4gdGhp cyBjYXNlPwo+ID4KPiA+IFRoYW5rcywKPiA+IENocmlzdGlhbi4KPiA+Cj4gPiBBbSAxMC4xMC4y MDE4IHVtIDA5OjUyIHNjaHJpZWIgTGl1LCBNb25rOgo+ID4+IFRoYW5rcyBTaWdpbAo+ID4+Cj4g Pj4gSGkgQ2hyaXN0aWFuCj4gPj4KPiA+PiBMb29rcyB3ZSBjYW4gZW5hYmxlL2Rpc2FibGUgY3R4 LXN3aXRjaCBmb3IgU0RNQSBhdCB3aWxsLCBubyBkZXBlbmRlbmN5IG9yIGNvbmZsaWN0IG9uIFNS SU9WCj4gPj4KPiA+PiAvTW9uawo+ID4+Cj4gPj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0K PiA+PiBGcm9tOiBNYSwgU2lnaWwKPiA+PiBTZW50OiBXZWRuZXNkYXksIE9jdG9iZXIgMTAsIDIw MTggMzoyNSBQTQo+ID4+IFRvOiBMaXUsIE1vbmsgPE1vbmsuTGl1QGFtZC5jb20+OyBLb2VuaWcs IENocmlzdGlhbiA8Q2hyaXN0aWFuLktvZW5pZ0BhbWQuY29tPjsgSHVhbmcsIFJheSA8UmF5Lkh1 YW5nQGFtZC5jb20+OyBNaW4sIEZyYW5rIDxGcmFuay5NaW5AYW1kLmNvbT4KPiA+PiBDYzogYW1k LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+PiBTdWJqZWN0OiBSRTogW1BBVENIIDIvOF0g ZHJtL2FtZGdwdTogZml4IHNkbWEgdjQgc3RhcnR1cCB1bmRlciBTUklPVgo+ID4+Cj4gPj4gSGkg TW9uaywKPiA+Pgo+ID4+IEFVVE9fQ1RYU1dfRU5BQkxFIGlzIG5vdCByZWxldmFudCB0byB3b3Js ZHN3aXRjaCBwcmVlbXB0aW9uLiBpdCBvbmx5IGFwcGxpZXMgZm9yIHJpbmcgYnVmZmVyIHByZWVt cHRpb24uIFNETUEgd2lsbCBkbyB3b3JsZHN3aXRjaCB3aGF0ZXZlciBBVVRPX0NUWFNXX0VOQUJM RSBpcyAxIG9yIDAuCj4gPj4KPiA+PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+ID4+IEZy b206IExpdSwgTW9uawo+ID4+IFNlbnQ6IFdlZG5lc2RheSwgT2N0b2JlciAxMCwgMjAxOCAyOjU0 IFBNCj4gPj4gVG86IEtvZW5pZywgQ2hyaXN0aWFuIDxDaHJpc3RpYW4uS29lbmlnQGFtZC5jb20+ OyBIdWFuZywgUmF5IDxSYXkuSHVhbmdAYW1kLmNvbT47IE1pbiwgRnJhbmsgPEZyYW5rLk1pbkBh bWQuY29tPjsgTWEsIFNpZ2lsIDxTaWdpbC5NYUBhbWQuY29tPgo+ID4+IENjOiBhbWQtZ2Z4QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4+IFN1YmplY3Q6IFJFOiBbUEFUQ0ggMi84XSBkcm0vYW1k Z3B1OiBmaXggc2RtYSB2NCBzdGFydHVwIHVuZGVyIFNSSU9WCj4gPj4KPiA+PiBPaCwgdGhhdCBt ZWFuIEkgcmVtZW1iZXIgaXQgcmV2ZXJzZWQgd2F5LCBhY2NvcmRpbmcgdG8gY29kZSBsb29rcyB3 ZSBuZWVkIHRvIGVuYWJsZSBjdHhfc3dpdGNoIHRvIHN1cHBvcnQgV09STEQgU1dJVENIIGZvciBT RE1BIGVuZ2luZQo+ID4+Cj4gPj4gQnV0IGJldHRlciBsZXQgU2lnaWwgY29uZmlybSBpdCAgLi4u Cj4gPj4KPiA+PiBIaSBATWEsIFNpZ2lsIGNhbiB5b3UgY29uZmlybSBpdCA/IHdoYXQncyB0aGUg cmVsYXRpb25zaGlwIGJldHdlZW4gY3R4X3N3aWNoIGFuZCB3b3JsZCBzd2ljaCBmb3IgU0RNQSBl bmdpbmVzID8KPiA+Pgo+ID4+IEN0eF9zd2l0Y2hfZW5hYmxlKCkgd2lsbCBzZXQgIlNETUEwLzFf Q05UTCdzIGZpZWxkOiBBVVRPX0NUWFNXX0VOQUJMRSIgdG8gMSwgY2FuIHlvdSB0ZWxsIHVzIHdo YXQncyBpdCBmb3IgYW5kIGhvdyBpdCBnbyB3aXRoIFNSSU9WIHdvcmxkIHN3aXRjaCA/Cj4gPj4K PiA+PiBUaGFua3MKPiA+Pgo+ID4+IC9Nb25rCj4gPj4KPiA+PiAtLS0tLU9yaWdpbmFsIE1lc3Nh Z2UtLS0tLQo+ID4+IEZyb206IEtvZW5pZywgQ2hyaXN0aWFuCj4gPj4gU2VudDogVHVlc2RheSwg T2N0b2JlciA5LCAyMDE4IDk6MDMgUE0KPiA+PiBUbzogTGl1LCBNb25rIDxNb25rLkxpdUBhbWQu Y29tPjsgSHVhbmcsIFJheSA8UmF5Lkh1YW5nQGFtZC5jb20+OyBNaW4sIEZyYW5rIDxGcmFuay5N aW5AYW1kLmNvbT47IE1hLCBTaWdpbCA8U2lnaWwuTWFAYW1kLmNvbT4KPiA+PiBDYzogYW1kLWdm eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+PiBTdWJqZWN0OiBSZTogW1BBVENIIDIvOF0gZHJt L2FtZGdwdTogZml4IHNkbWEgdjQgc3RhcnR1cCB1bmRlciBTUklPVgo+ID4+Cj4gPj4gSGkgTW9u aywKPiA+Pgo+ID4+IHdlbGwgdGhhdCBkb2Vzbid0IG1ha2UgbXVjaCBzZW5zZSB0byBtZSB3aGF0 IHlvdSBzYXkgaGVyZSBjYXVzZSBjb250ZXh0IHN3aXRjaGluZyBjZXJ0YWlubHkgaXMgYWxyZWFk eSBlbmFibGVkIHVuZGVyIFNSSU9WOgo+ID4+Cj4gPj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgIGlmIChhbWRncHVfc3Jpb3ZfdmYoYWRldikpIHsgLyogYmFyZS1tZXRhbCBzZXF1ZW5j ZQo+ID4+PiBkb2Vzbid0IG5lZWQgYmVsb3cgdG8gbGluZXMgKi8KPiA+Pj4gLcKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHNkbWFfdjRfMF9jdHhfc3dpdGNoX2Vu YWJsZShhZGV2LCB0cnVlKTsKPiA+Pj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgIHNkbWFfdjRfMF9lbmFibGUoYWRldiwgdHJ1ZSk7Cj4gPj4+IC3CoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgIH0KPiA+PiBUaGUgcHJvYmxlbSBpcyB0aGF0IGNvbnRleHQg c3dpdGNoaW5nIGFzIHdlbGwgYXMgdGhlIGdmeCByaW5nIGlzIGVuYWJsZWQgZm9yIGJvdGggU0RN QTAgYW5kIFNETUExIHdpdGhvdXQgaW5pdGlhbGl6aW5nIFNETUExLgo+ID4+Cj4gPj4gVGhhdCdz IG1vc3QgbGlrZWx5IGNhdXNpbmcgc29tZSB1bndhbnRlZCBjb25zZXF1ZW5jZXMuCj4gPj4KPiA+ PiBDaHJpc3RpYW4uCj4gPj4KPiA+PiBBbSAwOS4xMC4yMDE4IHVtIDEzOjQ1IHNjaHJpZWIgTGl1 LCBNb25rOgo+ID4+PiBDb250ZXh0IHN3aXRjaCBpcyBmb3IgcHJlZW1wdGlvbiBhY3Jvc3MgZGlm ZmVyZW50IHF1ZXVlcyAoZ2Z4LCBybGMwLzEsCj4gPj4+IHBhZ2UpIHVuZGVyIGJhcmUtbWV0YWwg ZW52aXJvbm1lbnQsIEZvciBTUklPViB3ZSBkaWRuJ3QgbmVlZCBpdCBhbmQgd2UgZGlkbid0IHRl c3QgaXQgeWV0LCBzbyB3ZSBqdXN0IGRpc2FibGUgaXQgdG8gbWFrZSBsaWZlIGVhc2llciwgYmVz aWRlcyBzaW5jZSBlYWNoIFZGIHNoYXJlIG9ubHkgNiBNUyBzbGljZSB0aGVyZSBpcyBpbiBmYWN0 IG5vIGJlbmVmaXQgdG8gZW5hYmxlIGl0IGZvciBTUklPViAuLi4KPiA+Pj4KPiA+Pj4gKyBATWEs IFNpZ2lsIHRvIGNvbmZpcm0KPiA+Pj4KPiA+Pj4gSGkgU2lnaWwKPiA+Pj4KPiA+Pj4gRG8geW91 IHRoaW5rIGNvbnRleHQgc3dpdGNoIGNvdWxkIGJlIGVuYWJsZWQgZm9yIFNSSU9WIFZGID8/IEkg d29ycnkgdGhhdCB0aGUgY29udGV4dCBzd2l0Y2ggaGF2ZSBpbnRlcm5hbCBjcnVzaCB3aXRoIHBy ZWVtcHRpb24gZm9yIHdvcmxkIHN3aXRjaCAsIHRoYW5rcyAhCj4gPj4+Cj4gPj4+IC9Nb25rCj4g Pj4+Cj4gPj4+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tCj4gPj4+IEZyb206IENocmlzdGlh biBLw7ZuaWcgPGNrb2VuaWcubGVpY2h0enVtZXJrZW5AZ21haWwuY29tPgo+ID4+PiBTZW50OiBU dWVzZGF5LCBPY3RvYmVyIDksIDIwMTggNjo1NyBQTQo+ID4+PiBUbzogSHVhbmcsIFJheSA8UmF5 Lkh1YW5nQGFtZC5jb20+OyBMaXUsIE1vbmsgPE1vbmsuTGl1QGFtZC5jb20+OyBNaW4sCj4gPj4+ IEZyYW5rIDxGcmFuay5NaW5AYW1kLmNvbT4KPiA+Pj4gQ2M6IGFtZC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCj4gPj4+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggMi84XSBkcm0vYW1kZ3B1OiBmaXgg c2RtYSB2NCBzdGFydHVwIHVuZGVyIFNSSU9WCj4gPj4+Cj4gPj4+IEFtIDA5LjEwLjIwMTggdW0g MTE6MTcgc2NocmllYiBIdWFuZyBSdWk6Cj4gPj4+PiBPbiBNb24sIE9jdCAwOCwgMjAxOCBhdCAw MzozNToxNVBNICswMjAwLCBDaHJpc3RpYW4gS8O2bmlnIHdyb3RlOgo+ID4+Pj4+IFtTTklQXQo+ ID4+Pj4+IC0JaWYgKGFkZXYtPmZpcm13YXJlLmxvYWRfdHlwZSAhPSBBTURHUFVfRldfTE9BRF9Q U1ApIHsKPiA+Pj4+PiAtCQlyID0gc2RtYV92NF8wX2xvYWRfbWljcm9jb2RlKGFkZXYpOwo+ID4+ Pj4+ICsJLyogc3RhcnQgdGhlIGdmeCByaW5ncyBhbmQgcmxjIGNvbXB1dGUgcXVldWVzICovCj4g Pj4+Pj4gKwlmb3IgKGkgPSAwOyBpIDwgYWRldi0+c2RtYS5udW1faW5zdGFuY2VzOyBpKyspCj4g Pj4+Pj4gKwkJc2RtYV92NF8wX2dmeF9yZXN1bWUoYWRldiwgaSk7Cj4gPj4+Pj4gKwo+ID4+Pj4+ ICsJaWYgKGFtZGdwdV9zcmlvdl92ZihhZGV2KSkgewo+ID4+Pj4+ICsJCXNkbWFfdjRfMF9jdHhf c3dpdGNoX2VuYWJsZShhZGV2LCB0cnVlKTsKPiA+Pj4+PiArCQlzZG1hX3Y0XzBfZW5hYmxlKGFk ZXYsIHRydWUpOwo+ID4+Pj4+ICsJfSBlbHNlIHsKPiA+Pj4+PiArCQlyID0gc2RtYV92NF8wX3Js Y19yZXN1bWUoYWRldik7Cj4gPj4+Pj4gICAgICAJCWlmIChyKQo+ID4+Pj4+ICAgICAgCQkJcmV0 dXJuIHI7Cj4gPj4+Pj4gICAgICAJfQo+ID4+Pj4gKyBNb25rLCBGcmFuaywKPiA+Pj4+Cj4gPj4+ PiBJIHByb2JhYmx5IGNhbm5vdCBqdWRnZSBoZXJlLCB1bmRlciBTUklPViwgSSBzYXcgeW91IGRp c2FibGUgY3R4Cj4gPj4+PiBzd2l0Y2ggYmVmb3JlLiBEbyB5b3UgaGF2ZSBhbnkgY29uY2VybiBp ZiB3ZSBlbmFibGVkIGl0IGhlcmUuCj4gPj4+IFRoZSBwcm9ibGVtIHdhcyB0aGF0IHRob3NlIGNh bGxzIHdoZXJlIG1peGVkIGludG8gc2RtYV92NF8wX2dmeF9yZXN1bWUoKSBmb3IgdGhlIGZpcnN0 IFNETUEgaW5zdGFuY2UuCj4gPj4+Cj4gPj4+IFdoYXQgd2FzIGhhcHBlbmluZyBpcyB0aGF0IFNE TUEwIHdhcyBpbml0aWFsaXplZCBhbmQgd2hpbGUgZG9pbmcgc28gZW5hYmxlZCBib3RoIFNETUEw IGFuZCBTRE1BMS4gU28gU0RNQTEgd2FzIHN0YXJ0aW5nIHVwIGJlZm9yZSB0aGUgcmluZyBidWZm ZXIgd2FzIGV2ZW4gc2V0Lgo+ID4+Pgo+ID4+PiBUaGF0IHRoaXMgZG9lc24ndCBjcmFzaGVkIHdh cyBwdXJlIGNvaW5jaWRlbnQgYW5kIGlzIG1vc3QgbGlrZWx5IGFsc28gdGhlIHJlYXNvbiB3aHkg d2UgcmFuIGludG8gcHJvYmxlbXMgd2hlbiByaW5nIGJ1ZmZlcnMgd2VyZW4ndCBpbml0aWFsaXpl ZC4KPiA+Pj4KPiA+Pj4gUmVnYXJkcywKPiA+Pj4gQ2hyaXN0aWFuLgo+ID4+Pgo+ID4+Pj4gT3Ro ZXJzLCBsb29rcyBnb29kIGZvciBtZS4gQ2hyaXN0aWFuLCBtYXkgd2Uga25vdyB3aGljaCBraW5k IG9mIGpvYnMKPiA+Pj4+IHdpbGwgdXNlIHNkbWEgcGFnZSBxdWV1ZShyaW5nKSwgeW91IGtub3cs IHdlIGp1c3Qgc2RtYSBnZnggcXVldWUocmluZykgYmVmb3JlPwo+ID4+Pj4KPiA+Pj4+IFRoYW5r cywKPiA+Pj4+IFJheQo+ID4+Pj4KPiA+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCj4gPiBhbWQtZ2Z4IG1haWxpbmcgbGlzdAo+ID4gYW1kLWdmeEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKPiA+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vYW1kLWdmeAo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Ft ZC1nZngK