From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bjorn Helgaas <helgaas-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH] pci: fix incorrect value returned from pcie_get_speed_cap
Date: Mon, 19 Nov 2018 18:47:04 -0600
Message-ID: <20181120004704.GA191199@google.com>
References: <alpine.LRH.2.02.1810301232310.23106@file01.intranet.prod.int.rdu2.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Content-Disposition: inline
In-Reply-To: <alpine.LRH.2.02.1810301232310.23106-Hpncn10jQN4oNljnaZt3ZvA+iT7yCHsGwRM8/txMwJMAicBL8TP8PQ@public.gmane.org>
List-Id: Discussion list for AMD gfx <amd-gfx.lists.freedesktop.org>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/amd-gfx>,
 <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/amd-gfx>
List-Post: <mailto:amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
List-Help: <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/amd-gfx>,
 <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=subscribe>
Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Sender: "amd-gfx" <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
To: Mikulas Patocka <mpatocka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Tal Gilboa <talgi-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>, linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Alex Deucher <alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Tariq Toukan <tariqt-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

T24gVHVlLCBPY3QgMzAsIDIwMTggYXQgMTI6MzY6MDhQTSAtMDQwMCwgTWlrdWxhcyBQYXRvY2th
IHdyb3RlOgo+IFRoZSBtYWNyb3MgUENJX0VYUF9MTktDQVBfU0xTXypHQiBhcmUgdmFsdWVzLCBu
b3QgYml0IG1hc2tzLiBXZSBtdXN0IG1hc2sKPiB0aGUgcmVnaXN0ZXIgYW5kIGNvbXBhcmUgaXQg
YWdhaW5zdCB0aGVtLgo+IAo+IFRoaXMgcGF0Y2ggZml4ZXMgZXJyb3JzICJhbWRncHU6IFtwb3dl
cnBsYXldIGZhaWxlZCB0byBzZW5kIG1lc3NhZ2UgMjYxCj4gcmV0IGlzIDAiIGVycm9ycyB3aGVu
IFBDSWUtdjMgY2FyZCBpcyBwbHVnZ2VkIGludG8gUENJZS12MSBzbG90LCBiZWNhdXNlCj4gdGhl
IHNsb3QgaXMgYmVpbmcgaW5jb3JyZWN0bHkgcmVwb3J0ZWQgYXMgUENJZS12MyBjYXBhYmxlLgo+
IAo+IFNpZ25lZC1vZmYtYnk6IE1pa3VsYXMgUGF0b2NrYSA8bXBhdG9ja2FAcmVkaGF0LmNvbT4K
PiBGaXhlczogNmNmNTdiZTBmNzhlICgiUENJOiBBZGQgcGNpZV9nZXRfc3BlZWRfY2FwKCkgdG8g
ZmluZCBtYXggc3VwcG9ydGVkIGxpbmsgc3BlZWQiKQo+IENjOiBzdGFibGVAdmdlci5rZXJuZWwu
b3JnCSMgdjQuMTcrCj4gCj4gLS0tCj4gIGRyaXZlcnMvcGNpL3BjaS5jIHwgICAgOCArKysrLS0t
LQo+ICAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+IAo+
IEluZGV4OiBsaW51eC00LjE5L2RyaXZlcnMvcGNpL3BjaS5jCj4gPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQo+IC0tLSBs
aW51eC00LjE5Lm9yaWcvZHJpdmVycy9wY2kvcGNpLmMJMjAxOC0xMC0zMCAxNjo1ODo1OC4wMDAw
MDAwMDAgKzAxMDAKPiArKysgbGludXgtNC4xOS9kcml2ZXJzL3BjaS9wY2kuYwkyMDE4LTEwLTMw
IDE2OjU4OjU4LjAwMDAwMDAwMCArMDEwMAo+IEBAIC01NDkyLDEzICs1NDkyLDEzIEBAIGVudW0g
cGNpX2J1c19zcGVlZCBwY2llX2dldF9zcGVlZF9jYXAoc3QKPiAgCj4gIAlwY2llX2NhcGFiaWxp
dHlfcmVhZF9kd29yZChkZXYsIFBDSV9FWFBfTE5LQ0FQLCAmbG5rY2FwKTsKPiAgCWlmIChsbmtj
YXApIHsKPiAtCQlpZiAobG5rY2FwICYgUENJX0VYUF9MTktDQVBfU0xTXzE2XzBHQikKPiArCQlp
ZiAoKGxua2NhcCAmIFBDSV9FWFBfTE5LQ0FQX1NMUykgPT0gUENJX0VYUF9MTktDQVBfU0xTXzE2
XzBHQikKPiAgCQkJcmV0dXJuIFBDSUVfU1BFRURfMTZfMEdUOwo+IC0JCWVsc2UgaWYgKGxua2Nh
cCAmIFBDSV9FWFBfTE5LQ0FQX1NMU184XzBHQikKPiArCQllbHNlIGlmICgobG5rY2FwICYgUENJ
X0VYUF9MTktDQVBfU0xTKSA9PSBQQ0lfRVhQX0xOS0NBUF9TTFNfOF8wR0IpCj4gIAkJCXJldHVy
biBQQ0lFX1NQRUVEXzhfMEdUOwo+IC0JCWVsc2UgaWYgKGxua2NhcCAmIFBDSV9FWFBfTE5LQ0FQ
X1NMU181XzBHQikKPiArCQllbHNlIGlmICgobG5rY2FwICYgUENJX0VYUF9MTktDQVBfU0xTKSA9
PVBDSV9FWFBfTE5LQ0FQX1NMU181XzBHQikKPiAgCQkJcmV0dXJuIFBDSUVfU1BFRURfNV8wR1Q7
Cj4gLQkJZWxzZSBpZiAobG5rY2FwICYgUENJX0VYUF9MTktDQVBfU0xTXzJfNUdCKQo+ICsJCWVs
c2UgaWYgKChsbmtjYXAgJiBQQ0lfRVhQX0xOS0NBUF9TTFMpID09IFBDSV9FWFBfTE5LQ0FQX1NM
U18yXzVHQikKPiAgCQkJcmV0dXJuIFBDSUVfU1BFRURfMl81R1Q7Cj4gIAl9Cj4gIAoKSSdkIGxp
a2UgdG8gYXBwbHkgdGhpcyBhcyBiZWxvdywgd2hlcmUgSSByZW1vdmVkIHRoZSA4XzBHQiBhbmQg
MTZfMEdCCmNhc2VzIGFzIHJlY29tbWVuZGVkIGJ5IHRoZSBzcGVjLiAgSSBjYW4ndCB0ZXN0IGl0
IG15c2VsZiwgYW5kIHRoZQpidWd6aWxsYXMgZG9uJ3QgY29udGFpbiBlbm91Z2ggaW5mb3JtYXRp
b24gZm9yIG1lIHRvIGNvbmZpcm0gdGhhdCB0aGUKcGF0Y2ggYmVsb3cgaXMgZW5vdWdoICh0aGUg
ImxzcGNpIC12diIgb3V0cHV0IG9mIHRoZSByb290IHBvcnQgYW5kIEdQVQppcyB3aGF0IEkgd291
bGQgbmVlZCkuCgpJJ20gY29uZnVzZWQgYWJvdXQgdGhlIGZhY3QgdGhhdCA2Y2Y1N2JlMGY3OGUg
YXBwZWFyZWQgaW4gdjQuMTcsIGJ1dAp2NC4xOCB3b3JrcyBmaW5lIGFjY29yZGluZyB0byBib3Ro
IGJ1Z3ppbGxhcy4KCkkgYWxzbyBkb24ndCBoYXZlIGEgZ29vZCBmZWVsIGZvciB3aGV0aGVyIHRo
aXMgaXMgdXJnZW50IGVub3VnaCB0byBiZQphIHY0LjIwIGZpeCBvciB3aGV0aGVyIGl0IGNhbiB3
YWl0IGZvciB2NC4yMS4gIEV2aWRlbmNlIGVpdGhlciB3YXkKd291bGQgaGVscC4KCldlIGFsc28g
bmVlZCBzaW1pbGFyIGZpeGVzIGluIHBjaV9zZXRfYnVzX3NwZWVkKCksIHBjaWVfc3BlZWRzKCkK
KGhmaTEpLCBjb2JhbHRfcGNpZV9zdGF0dXNfc2hvdygpLCBoYmFfaW9jdGxfY2FsbGJhY2soKSwK
cWxhMjR4eF9wY2lfaW5mb19zdHIoKSwgYW5kIG1heWJlIGEgY291cGxlIG90aGVyIHBsYWNlcy4K
CkJqb3JuCgoKY29tbWl0IDg3MWY3M2FiZjRiOGU2YWVlOGEyMDY3NzVmOTQ0ZWRlN2M3ZDcyNTAK
QXV0aG9yOiBNaWt1bGFzIFBhdG9ja2EgPG1wYXRvY2thQHJlZGhhdC5jb20+CkRhdGU6ICAgVHVl
IE9jdCAzMCAxMjozNjowOCAyMDE4IC0wNDAwCgogICAgUENJOiBGaXggaW5jb3JyZWN0IHZhbHVl
IHJldHVybmVkIGZyb20gcGNpZV9nZXRfc3BlZWRfY2FwKCkKICAgIAogICAgVGhlIG1hY3JvcyBQ
Q0lfRVhQX0xOS0NBUF9TTFNfKkdCIGFyZSB2YWx1ZXMsIG5vdCBiaXQgbWFza3MuICBXZSBtdXN0
IG1hc2sKICAgIHRoZSByZWdpc3RlciBhbmQgY29tcGFyZSBpdCBhZ2FpbnN0IHRoZW0uCiAgICAK
ICAgIFRoaXMgcGF0Y2ggZml4ZXMgZXJyb3JzICJhbWRncHU6IFtwb3dlcnBsYXldIGZhaWxlZCB0
byBzZW5kIG1lc3NhZ2UgMjYxIHJldAogICAgaXMgMCIgZXJyb3JzIHdoZW4gUENJZS12MyBjYXJk
IGlzIHBsdWdnZWQgaW50byBQQ0llLXYxIHNsb3QsIGJlY2F1c2UgdGhlCiAgICBzbG90IGlzIGJl
aW5nIGluY29ycmVjdGx5IHJlcG9ydGVkIGFzIFBDSWUtdjMgY2FwYWJsZS4KICAgIAogICAgRml4
ZXM6IDZjZjU3YmUwZjc4ZSAoIlBDSTogQWRkIHBjaWVfZ2V0X3NwZWVkX2NhcCgpIHRvIGZpbmQg
bWF4IHN1cHBvcnRlZCBsaW5rIHNwZWVkIikKICAgIExpbms6IGh0dHBzOi8vYnVncy5mcmVlZGVz
a3RvcC5vcmcvc2hvd19idWcuY2dpP2lkPTEwODcwNAogICAgTGluazogaHR0cHM6Ly9idWdzLmZy
ZWVkZXNrdG9wLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA4Nzc4CiAgICBTaWduZWQtb2ZmLWJ5OiBN
aWt1bGFzIFBhdG9ja2EgPG1wYXRvY2thQHJlZGhhdC5jb20+CiAgICBbYmhlbGdhYXM6IHVwZGF0
ZSBjb21tZW50LCByZW1vdmUgdXNlIG9mIFBDSV9FWFBfTE5LQ0FQX1NMU184XzBHQiBhbmQKICAg
IFBDSV9FWFBfTE5LQ0FQX1NMU18xNl8wR0Igc2luY2UgdGhvc2Ugc2hvdWxkIGJlIGNvdmVyZWQg
YnkgUENJX0VYUF9MTktDQVAyXQogICAgU2lnbmVkLW9mZi1ieTogQmpvcm4gSGVsZ2FhcyA8Ymhl
bGdhYXNAZ29vZ2xlLmNvbT4KICAgIEFja2VkLWJ5OiBBbGV4IERldWNoZXIgPGFsZXhhbmRlci5k
ZXVjaGVyQGFtZC5jb20+CiAgICBDYzogc3RhYmxlQHZnZXIua2VybmVsLm9yZyAgICAgICMgdjQu
MTcrCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9wY2kvcGNpLmMgYi9kcml2ZXJzL3BjaS9wY2kuYwpp
bmRleCBkMDY4ZjExZDA4YTcuLjg1NjNkMWQ5YjEwMiAxMDA2NDQKLS0tIGEvZHJpdmVycy9wY2kv
cGNpLmMKKysrIGIvZHJpdmVycy9wY2kvcGNpLmMKQEAgLTU1NTYsOSArNTU1NiwxMyBAQCBlbnVt
IHBjaV9idXNfc3BlZWQgcGNpZV9nZXRfc3BlZWRfY2FwKHN0cnVjdCBwY2lfZGV2ICpkZXYpCiAJ
dTMyIGxua2NhcDIsIGxua2NhcDsKIAogCS8qCi0JICogUENJZSByNC4wIHNlYyA3LjUuMy4xOCBy
ZWNvbW1lbmRzIHVzaW5nIHRoZSBTdXBwb3J0ZWQgTGluawotCSAqIFNwZWVkcyBWZWN0b3IgaW4g
TGluayBDYXBhYmlsaXRpZXMgMiB3aGVuIHN1cHBvcnRlZCwgZmFsbGluZwotCSAqIGJhY2sgdG8g
TWF4IExpbmsgU3BlZWQgaW4gTGluayBDYXBhYmlsaXRpZXMgb3RoZXJ3aXNlLgorCSAqIExpbmsg
Q2FwYWJpbGl0aWVzIDIgd2FzIGFkZGVkIGluIFBDSWUgcjMuMCwgc2VjIDcuOC4xOC4gIFRoZQor
CSAqIGltcGxlbWVudGF0aW9uIG5vdGUgdGhlcmUgcmVjb21tZW5kcyB1c2luZyB0aGUgU3VwcG9y
dGVkIExpbmsKKwkgKiBTcGVlZHMgVmVjdG9yIGluIExpbmsgQ2FwYWJpbGl0aWVzIDIgd2hlbiBz
dXBwb3J0ZWQuCisJICoKKwkgKiBXaXRob3V0IExpbmsgQ2FwYWJpbGl0aWVzIDIsIGkuZS4sIHBy
aW9yIHRvIFBDSWUgcjMuMCwgc29mdHdhcmUKKwkgKiBzaG91bGQgdXNlIHRoZSBTdXBwb3J0ZWQg
TGluayBTcGVlZHMgZmllbGQgaW4gTGluayBDYXBhYmlsaXRpZXMsCisJICogd2hlcmUgb25seSAy
LjUgR1QvcyBhbmQgNS4wIEdUL3Mgc3BlZWRzIHdlcmUgZGVmaW5lZC4KIAkgKi8KIAlwY2llX2Nh
cGFiaWxpdHlfcmVhZF9kd29yZChkZXYsIFBDSV9FWFBfTE5LQ0FQMiwgJmxua2NhcDIpOwogCWlm
IChsbmtjYXAyKSB7IC8qIFBDSWUgcjMuMC1jb21wbGlhbnQgKi8KQEAgLTU1NzUsMTMgKzU1Nzks
OSBAQCBlbnVtIHBjaV9idXNfc3BlZWQgcGNpZV9nZXRfc3BlZWRfY2FwKHN0cnVjdCBwY2lfZGV2
ICpkZXYpCiAKIAlwY2llX2NhcGFiaWxpdHlfcmVhZF9kd29yZChkZXYsIFBDSV9FWFBfTE5LQ0FQ
LCAmbG5rY2FwKTsKIAlpZiAobG5rY2FwKSB7Ci0JCWlmIChsbmtjYXAgJiBQQ0lfRVhQX0xOS0NB
UF9TTFNfMTZfMEdCKQotCQkJcmV0dXJuIFBDSUVfU1BFRURfMTZfMEdUOwotCQllbHNlIGlmIChs
bmtjYXAgJiBQQ0lfRVhQX0xOS0NBUF9TTFNfOF8wR0IpCi0JCQlyZXR1cm4gUENJRV9TUEVFRF84
XzBHVDsKLQkJZWxzZSBpZiAobG5rY2FwICYgUENJX0VYUF9MTktDQVBfU0xTXzVfMEdCKQorCQlp
ZiAoKGxua2NhcCAmIFBDSV9FWFBfTE5LQ0FQX1NMUykgPT0gUENJX0VYUF9MTktDQVBfU0xTXzVf
MEdCKQogCQkJcmV0dXJuIFBDSUVfU1BFRURfNV8wR1Q7Ci0JCWVsc2UgaWYgKGxua2NhcCAmIFBD
SV9FWFBfTE5LQ0FQX1NMU18yXzVHQikKKwkJZWxzZSBpZiAoKGxua2NhcCAmIFBDSV9FWFBfTE5L
Q0FQX1NMUykgPT0gUENJX0VYUF9MTktDQVBfU0xTXzJfNUdCKQogCQkJcmV0dXJuIFBDSUVfU1BF
RURfMl81R1Q7CiAJfQogCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fCmFtZC1nZnggbWFpbGluZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn
Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeAo=