From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Helgaas Subject: Re: [PATCH] pci: fix incorrect value returned from pcie_get_speed_cap Date: Mon, 26 Nov 2018 16:33:41 -0600 Message-ID: <20181126223340.GA212532@google.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Mikulas Patocka Cc: Tal Gilboa , linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Alex Deucher , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Tariq Toukan T24gVHVlLCBPY3QgMzAsIDIwMTggYXQgMTI6MzY6MDhQTSAtMDQwMCwgTWlrdWxhcyBQYXRvY2th IHdyb3RlOgo+IFRoZSBtYWNyb3MgUENJX0VYUF9MTktDQVBfU0xTXypHQiBhcmUgdmFsdWVzLCBu b3QgYml0IG1hc2tzLiBXZSBtdXN0IG1hc2sKPiB0aGUgcmVnaXN0ZXIgYW5kIGNvbXBhcmUgaXQg YWdhaW5zdCB0aGVtLgo+IAo+IFRoaXMgcGF0Y2ggZml4ZXMgZXJyb3JzICJhbWRncHU6IFtwb3dl cnBsYXldIGZhaWxlZCB0byBzZW5kIG1lc3NhZ2UgMjYxCj4gcmV0IGlzIDAiIGVycm9ycyB3aGVu IFBDSWUtdjMgY2FyZCBpcyBwbHVnZ2VkIGludG8gUENJZS12MSBzbG90LCBiZWNhdXNlCj4gdGhl IHNsb3QgaXMgYmVpbmcgaW5jb3JyZWN0bHkgcmVwb3J0ZWQgYXMgUENJZS12MyBjYXBhYmxlLgo+ IAo+IFNpZ25lZC1vZmYtYnk6IE1pa3VsYXMgUGF0b2NrYSA8bXBhdG9ja2FAcmVkaGF0LmNvbT4K CkFwcGxpZWQgdGhlIHBhdGNoIGJlbG93IHRvIGZvci1saW51cyBmb3IgdjQuMjAgYW5kIGJhY2tw b3J0IHRvIHY0LjE3KwpzdGFibGUga2VybmVscywgdGhhbmtzIQoKSSByZW1vdmVkIHRoZSAiaWYg KGxua2NhcCkiIHRlc3QgYmVjYXVzZSB0aGUgTE5LQ0FQIGNhc2UgaXMgbm90CnBhcmFsbGVsIHRv IHRoZSBMTktDQVAyIGNhc2UuICBMTktDQVAyIGlzIG9wdGlvbmFsIHNvIHdlIGhhdmUgdG8gdGVz dApmb3IgbG5rY2FwMiBiZWluZyBub24temVyby4gIEJ1dCBMTktDQVAgaXMgcmVxdWlyZWQgZm9y IGFsbCBkZXZpY2VzLgpJZiB0aGUgY29uZmlnIHJlYWQgb2YgaXQgZmFpbHMsIHdlIHNob3VsZCBn ZXQgZWl0aGVyIDAgb3IgfjAsIGFuZApuZWl0aGVyIG9uZSB3aWxsIHNhdGlzZnkgdGhlIDUuMCBv ciAyLjUgY2hlY2tzLgoKPiBGaXhlczogNmNmNTdiZTBmNzhlICgiUENJOiBBZGQgcGNpZV9nZXRf c3BlZWRfY2FwKCkgdG8gZmluZCBtYXggc3VwcG9ydGVkIGxpbmsgc3BlZWQiKQo+IENjOiBzdGFi bGVAdmdlci5rZXJuZWwub3JnCSMgdjQuMTcrCj4gCj4gLS0tCj4gIGRyaXZlcnMvcGNpL3BjaS5j IHwgICAgOCArKysrLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCA0IGRl bGV0aW9ucygtKQo+IAo+IEluZGV4OiBsaW51eC00LjE5L2RyaXZlcnMvcGNpL3BjaS5jCj4gPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQo+IC0tLSBsaW51eC00LjE5Lm9yaWcvZHJpdmVycy9wY2kvcGNpLmMJMjAxOC0xMC0z MCAxNjo1ODo1OC4wMDAwMDAwMDAgKzAxMDAKPiArKysgbGludXgtNC4xOS9kcml2ZXJzL3BjaS9w Y2kuYwkyMDE4LTEwLTMwIDE2OjU4OjU4LjAwMDAwMDAwMCArMDEwMAo+IEBAIC01NDkyLDEzICs1 NDkyLDEzIEBAIGVudW0gcGNpX2J1c19zcGVlZCBwY2llX2dldF9zcGVlZF9jYXAoc3QKPiAgCj4g IAlwY2llX2NhcGFiaWxpdHlfcmVhZF9kd29yZChkZXYsIFBDSV9FWFBfTE5LQ0FQLCAmbG5rY2Fw KTsKPiAgCWlmIChsbmtjYXApIHsKPiAtCQlpZiAobG5rY2FwICYgUENJX0VYUF9MTktDQVBfU0xT XzE2XzBHQikKPiArCQlpZiAoKGxua2NhcCAmIFBDSV9FWFBfTE5LQ0FQX1NMUykgPT0gUENJX0VY UF9MTktDQVBfU0xTXzE2XzBHQikKPiAgCQkJcmV0dXJuIFBDSUVfU1BFRURfMTZfMEdUOwo+IC0J CWVsc2UgaWYgKGxua2NhcCAmIFBDSV9FWFBfTE5LQ0FQX1NMU184XzBHQikKPiArCQllbHNlIGlm ICgobG5rY2FwICYgUENJX0VYUF9MTktDQVBfU0xTKSA9PSBQQ0lfRVhQX0xOS0NBUF9TTFNfOF8w R0IpCj4gIAkJCXJldHVybiBQQ0lFX1NQRUVEXzhfMEdUOwo+IC0JCWVsc2UgaWYgKGxua2NhcCAm IFBDSV9FWFBfTE5LQ0FQX1NMU181XzBHQikKPiArCQllbHNlIGlmICgobG5rY2FwICYgUENJX0VY UF9MTktDQVBfU0xTKSA9PVBDSV9FWFBfTE5LQ0FQX1NMU181XzBHQikKPiAgCQkJcmV0dXJuIFBD SUVfU1BFRURfNV8wR1Q7Cj4gLQkJZWxzZSBpZiAobG5rY2FwICYgUENJX0VYUF9MTktDQVBfU0xT XzJfNUdCKQo+ICsJCWVsc2UgaWYgKChsbmtjYXAgJiBQQ0lfRVhQX0xOS0NBUF9TTFMpID09IFBD SV9FWFBfTE5LQ0FQX1NMU18yXzVHQikKPiAgCQkJcmV0dXJuIFBDSUVfU1BFRURfMl81R1Q7Cj4g IAl9Cj4gIAoKY29tbWl0IDk0ZWEwMWE2ZDlhNgpBdXRob3I6IE1pa3VsYXMgUGF0b2NrYSA8bXBh dG9ja2FAcmVkaGF0LmNvbT4KRGF0ZTogICBNb24gTm92IDI2IDEwOjM3OjEzIDIwMTggLTA2MDAK CiAgICBQQ0k6IEZpeCBpbmNvcnJlY3QgdmFsdWUgcmV0dXJuZWQgZnJvbSBwY2llX2dldF9zcGVl ZF9jYXAoKQogICAgCiAgICBUaGUgbWFjcm9zIFBDSV9FWFBfTE5LQ0FQX1NMU18qR0IgYXJlIHZh bHVlcywgbm90IGJpdCBtYXNrcy4gIFdlIG11c3QgbWFzawogICAgdGhlIHJlZ2lzdGVyIGFuZCBj b21wYXJlIGl0IGFnYWluc3QgdGhlbS4KICAgIAogICAgVGhpcyBmaXhlcyBlcnJvcnMgbGlrZSB0 aGlzOgogICAgCiAgICAgIGFtZGdwdTogW3Bvd2VycGxheV0gZmFpbGVkIHRvIHNlbmQgbWVzc2Fn ZSAyNjEgcmV0IGlzIDAKICAgIAogICAgd2hlbiBQQ0llLXYzIGNhcmQgaXMgcGx1Z2dlZCBpbnRv IGEgUENJZS12MSBzbG90LCBiZWNhdXNlIHRoZSBzbG90IGlzIGJlaW5nCiAgICBpbmNvcnJlY3Rs eSByZXBvcnRlZCBhcyBQQ0llLXYzIGNhcGFibGUuCiAgICAKICAgIDZjZjU3YmUwZjc4ZSwgd2hp Y2ggYXBwZWFyZWQgaW4gdjQuMTcsIGFkZGVkIHBjaWVfZ2V0X3NwZWVkX2NhcCgpIHdpdGggdGhl CiAgICBpbmNvcnJlY3QgdGVzdCBvZiBQQ0lfRVhQX0xOS0NBUF9TTFMgYXMgYSBiaXRtYXNrLiAg NWQ5YTYzMzA0MDMyLCB3aGljaAogICAgYXBwZWFyZWQgaW4gdjQuMTksIGNoYW5nZWQgYW1kZ3B1 IHRvIHVzZSBwY2llX2dldF9zcGVlZF9jYXAoKSwgc28gdGhlCiAgICBhbWRncHUgYnVnIHJlcG9y dHMgYmVsb3cgYXJlIHJlZ3Jlc3Npb25zIGluIHY0LjE5LgogICAgCiAgICBGaXhlczogNmNmNTdi ZTBmNzhlICgiUENJOiBBZGQgcGNpZV9nZXRfc3BlZWRfY2FwKCkgdG8gZmluZCBtYXggc3VwcG9y dGVkIGxpbmsgc3BlZWQiKQogICAgRml4ZXM6IDVkOWE2MzMwNDAzMiAoImRybS9hbWRncHU6IHVz ZSBwY2llIGZ1bmN0aW9ucyBmb3IgbGluayB3aWR0aCBhbmQgc3BlZWQiKQogICAgTGluazogaHR0 cHM6Ly9idWdzLmZyZWVkZXNrdG9wLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA4NzA0CiAgICBMaW5r OiBodHRwczovL2J1Z3MuZnJlZWRlc2t0b3Aub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDg3NzgKICAg IFNpZ25lZC1vZmYtYnk6IE1pa3VsYXMgUGF0b2NrYSA8bXBhdG9ja2FAcmVkaGF0LmNvbT4KICAg IFtiaGVsZ2FhczogdXBkYXRlIGNvbW1lbnQsIHJlbW92ZSB1c2Ugb2YgUENJX0VYUF9MTktDQVBf U0xTXzhfMEdCIGFuZAogICAgUENJX0VYUF9MTktDQVBfU0xTXzE2XzBHQiBzaW5jZSB0aG9zZSBz aG91bGQgYmUgY292ZXJlZCBieSBQQ0lfRVhQX0xOS0NBUDIsCiAgICByZW1vdmUgdGVzdCBvZiBQ Q0lfRVhQX0xOS0NBUCBmb3IgemVybywgc2luY2UgdGhhdCByZWdpc3RlciBpcyByZXF1aXJlZF0K ICAgIFNpZ25lZC1vZmYtYnk6IEJqb3JuIEhlbGdhYXMgPGJoZWxnYWFzQGdvb2dsZS5jb20+CiAg ICBBY2tlZC1ieTogQWxleCBEZXVjaGVyIDxhbGV4YW5kZXIuZGV1Y2hlckBhbWQuY29tPgogICAg Q2M6IHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmcgICAgICAjIHY0LjE3KwoKZGlmZiAtLWdpdCBhL2Ry aXZlcnMvcGNpL3BjaS5jIGIvZHJpdmVycy9wY2kvcGNpLmMKaW5kZXggZDA2OGYxMWQwOGE3Li5j OWQ4ZTNjODM3ZGUgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvcGNpL3BjaS5jCisrKyBiL2RyaXZlcnMv cGNpL3BjaS5jCkBAIC01NTU2LDkgKzU1NTYsMTMgQEAgZW51bSBwY2lfYnVzX3NwZWVkIHBjaWVf Z2V0X3NwZWVkX2NhcChzdHJ1Y3QgcGNpX2RldiAqZGV2KQogCXUzMiBsbmtjYXAyLCBsbmtjYXA7 CiAKIAkvKgotCSAqIFBDSWUgcjQuMCBzZWMgNy41LjMuMTggcmVjb21tZW5kcyB1c2luZyB0aGUg U3VwcG9ydGVkIExpbmsKLQkgKiBTcGVlZHMgVmVjdG9yIGluIExpbmsgQ2FwYWJpbGl0aWVzIDIg d2hlbiBzdXBwb3J0ZWQsIGZhbGxpbmcKLQkgKiBiYWNrIHRvIE1heCBMaW5rIFNwZWVkIGluIExp bmsgQ2FwYWJpbGl0aWVzIG90aGVyd2lzZS4KKwkgKiBMaW5rIENhcGFiaWxpdGllcyAyIHdhcyBh ZGRlZCBpbiBQQ0llIHIzLjAsIHNlYyA3LjguMTguICBUaGUKKwkgKiBpbXBsZW1lbnRhdGlvbiBu b3RlIHRoZXJlIHJlY29tbWVuZHMgdXNpbmcgdGhlIFN1cHBvcnRlZCBMaW5rCisJICogU3BlZWRz IFZlY3RvciBpbiBMaW5rIENhcGFiaWxpdGllcyAyIHdoZW4gc3VwcG9ydGVkLgorCSAqCisJICog V2l0aG91dCBMaW5rIENhcGFiaWxpdGllcyAyLCBpLmUuLCBwcmlvciB0byBQQ0llIHIzLjAsIHNv ZnR3YXJlCisJICogc2hvdWxkIHVzZSB0aGUgU3VwcG9ydGVkIExpbmsgU3BlZWRzIGZpZWxkIGlu IExpbmsgQ2FwYWJpbGl0aWVzLAorCSAqIHdoZXJlIG9ubHkgMi41IEdUL3MgYW5kIDUuMCBHVC9z IHNwZWVkcyB3ZXJlIGRlZmluZWQuCiAJICovCiAJcGNpZV9jYXBhYmlsaXR5X3JlYWRfZHdvcmQo ZGV2LCBQQ0lfRVhQX0xOS0NBUDIsICZsbmtjYXAyKTsKIAlpZiAobG5rY2FwMikgeyAvKiBQQ0ll IHIzLjAtY29tcGxpYW50ICovCkBAIC01NTc0LDE2ICs1NTc4LDEwIEBAIGVudW0gcGNpX2J1c19z cGVlZCBwY2llX2dldF9zcGVlZF9jYXAoc3RydWN0IHBjaV9kZXYgKmRldikKIAl9CiAKIAlwY2ll X2NhcGFiaWxpdHlfcmVhZF9kd29yZChkZXYsIFBDSV9FWFBfTE5LQ0FQLCAmbG5rY2FwKTsKLQlp ZiAobG5rY2FwKSB7Ci0JCWlmIChsbmtjYXAgJiBQQ0lfRVhQX0xOS0NBUF9TTFNfMTZfMEdCKQot CQkJcmV0dXJuIFBDSUVfU1BFRURfMTZfMEdUOwotCQllbHNlIGlmIChsbmtjYXAgJiBQQ0lfRVhQ X0xOS0NBUF9TTFNfOF8wR0IpCi0JCQlyZXR1cm4gUENJRV9TUEVFRF84XzBHVDsKLQkJZWxzZSBp ZiAobG5rY2FwICYgUENJX0VYUF9MTktDQVBfU0xTXzVfMEdCKQotCQkJcmV0dXJuIFBDSUVfU1BF RURfNV8wR1Q7Ci0JCWVsc2UgaWYgKGxua2NhcCAmIFBDSV9FWFBfTE5LQ0FQX1NMU18yXzVHQikK LQkJCXJldHVybiBQQ0lFX1NQRUVEXzJfNUdUOwotCX0KKwlpZiAoKGxua2NhcCAmIFBDSV9FWFBf TE5LQ0FQX1NMUykgPT0gUENJX0VYUF9MTktDQVBfU0xTXzVfMEdCKQorCQlyZXR1cm4gUENJRV9T UEVFRF81XzBHVDsKKwllbHNlIGlmICgobG5rY2FwICYgUENJX0VYUF9MTktDQVBfU0xTKSA9PSBQ Q0lfRVhQX0xOS0NBUF9TTFNfMl81R0IpCisJCXJldHVybiBQQ0lFX1NQRUVEXzJfNUdUOwogCiAJ cmV0dXJuIFBDSV9TUEVFRF9VTktOT1dOOwogfQpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2FtZC1nZngK