From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Helgaas Subject: Re: [PATCH] pci: fix incorrect value returned from pcie_get_speed_cap Date: Mon, 26 Nov 2018 16:40:52 -0600 Message-ID: <20181126224051.GB212532@google.com> References: <20181120004704.GA191199@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20181120004704.GA191199-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Mikulas Patocka Cc: Tal Gilboa , linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Alex Deucher , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Tariq Toukan T24gTW9uLCBOb3YgMTksIDIwMTggYXQgMDY6NDc6MDRQTSAtMDYwMCwgQmpvcm4gSGVsZ2FhcyB3 cm90ZToKPiBPbiBUdWUsIE9jdCAzMCwgMjAxOCBhdCAxMjozNjowOFBNIC0wNDAwLCBNaWt1bGFz IFBhdG9ja2Egd3JvdGU6Cj4gPiBUaGUgbWFjcm9zIFBDSV9FWFBfTE5LQ0FQX1NMU18qR0IgYXJl IHZhbHVlcywgbm90IGJpdCBtYXNrcy4gV2UgbXVzdCBtYXNrCj4gPiB0aGUgcmVnaXN0ZXIgYW5k IGNvbXBhcmUgaXQgYWdhaW5zdCB0aGVtLgo+ID4gCj4gPiBUaGlzIHBhdGNoIGZpeGVzIGVycm9y cyAiYW1kZ3B1OiBbcG93ZXJwbGF5XSBmYWlsZWQgdG8gc2VuZCBtZXNzYWdlIDI2MQo+ID4gcmV0 IGlzIDAiIGVycm9ycyB3aGVuIFBDSWUtdjMgY2FyZCBpcyBwbHVnZ2VkIGludG8gUENJZS12MSBz bG90LCBiZWNhdXNlCj4gPiB0aGUgc2xvdCBpcyBiZWluZyBpbmNvcnJlY3RseSByZXBvcnRlZCBh cyBQQ0llLXYzIGNhcGFibGUuCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IE1pa3VsYXMgUGF0b2Nr YSA8bXBhdG9ja2FAcmVkaGF0LmNvbT4KPiA+IEZpeGVzOiA2Y2Y1N2JlMGY3OGUgKCJQQ0k6IEFk ZCBwY2llX2dldF9zcGVlZF9jYXAoKSB0byBmaW5kIG1heCBzdXBwb3J0ZWQgbGluayBzcGVlZCIp Cj4gPiBDYzogc3RhYmxlQHZnZXIua2VybmVsLm9yZwkjIHY0LjE3Kwo+ID4gCj4gPiAtLS0KPiA+ ICBkcml2ZXJzL3BjaS9wY2kuYyB8ICAgIDggKysrKy0tLS0KPiA+ICAxIGZpbGUgY2hhbmdlZCwg NCBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+ID4gCj4gPiBJbmRleDogbGludXgtNC4x OS9kcml2ZXJzL3BjaS9wY2kuYwo+ID4gPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQo+ID4gLS0tIGxpbnV4LTQuMTkub3Jp Zy9kcml2ZXJzL3BjaS9wY2kuYwkyMDE4LTEwLTMwIDE2OjU4OjU4LjAwMDAwMDAwMCArMDEwMAo+ ID4gKysrIGxpbnV4LTQuMTkvZHJpdmVycy9wY2kvcGNpLmMJMjAxOC0xMC0zMCAxNjo1ODo1OC4w MDAwMDAwMDAgKzAxMDAKPiA+IEBAIC01NDkyLDEzICs1NDkyLDEzIEBAIGVudW0gcGNpX2J1c19z cGVlZCBwY2llX2dldF9zcGVlZF9jYXAoc3QKPiA+ICAKPiA+ICAJcGNpZV9jYXBhYmlsaXR5X3Jl YWRfZHdvcmQoZGV2LCBQQ0lfRVhQX0xOS0NBUCwgJmxua2NhcCk7Cj4gPiAgCWlmIChsbmtjYXAp IHsKPiA+IC0JCWlmIChsbmtjYXAgJiBQQ0lfRVhQX0xOS0NBUF9TTFNfMTZfMEdCKQo+ID4gKwkJ aWYgKChsbmtjYXAgJiBQQ0lfRVhQX0xOS0NBUF9TTFMpID09IFBDSV9FWFBfTE5LQ0FQX1NMU18x Nl8wR0IpCj4gPiAgCQkJcmV0dXJuIFBDSUVfU1BFRURfMTZfMEdUOwo+ID4gLQkJZWxzZSBpZiAo bG5rY2FwICYgUENJX0VYUF9MTktDQVBfU0xTXzhfMEdCKQo+ID4gKwkJZWxzZSBpZiAoKGxua2Nh cCAmIFBDSV9FWFBfTE5LQ0FQX1NMUykgPT0gUENJX0VYUF9MTktDQVBfU0xTXzhfMEdCKQo+ID4g IAkJCXJldHVybiBQQ0lFX1NQRUVEXzhfMEdUOwo+ID4gLQkJZWxzZSBpZiAobG5rY2FwICYgUENJ X0VYUF9MTktDQVBfU0xTXzVfMEdCKQo+ID4gKwkJZWxzZSBpZiAoKGxua2NhcCAmIFBDSV9FWFBf TE5LQ0FQX1NMUykgPT1QQ0lfRVhQX0xOS0NBUF9TTFNfNV8wR0IpCj4gPiAgCQkJcmV0dXJuIFBD SUVfU1BFRURfNV8wR1Q7Cj4gPiAtCQllbHNlIGlmIChsbmtjYXAgJiBQQ0lfRVhQX0xOS0NBUF9T TFNfMl81R0IpCj4gPiArCQllbHNlIGlmICgobG5rY2FwICYgUENJX0VYUF9MTktDQVBfU0xTKSA9 PSBQQ0lfRVhQX0xOS0NBUF9TTFNfMl81R0IpCj4gPiAgCQkJcmV0dXJuIFBDSUVfU1BFRURfMl81 R1Q7Cj4gPiAgCX0KCj4gV2UgYWxzbyBuZWVkIHNpbWlsYXIgZml4ZXMgaW4gcGNpX3NldF9idXNf c3BlZWQoKSwgcGNpZV9zcGVlZHMoKQo+IChoZmkxKSwgY29iYWx0X3BjaWVfc3RhdHVzX3Nob3co KSwgaGJhX2lvY3RsX2NhbGxiYWNrKCksCj4gcWxhMjR4eF9wY2lfaW5mb19zdHIoKSwgYW5kIG1h eWJlIGEgY291cGxlIG90aGVyIHBsYWNlcy4KCkRvZXMgYW55Ym9keSB3YW50IHRvIHZvbHVudGVl ciB0byBmaXggdGhlIHBsYWNlcyBhYm92ZSBhcyB3ZWxsPyAgSQpmb3VuZCB0aGVtIGJ5IGdyZXBw aW5nIGZvciBQQ0lfRVhQX0xOS0NBUCwgYW5kIHRoZXkncmUgYWxsIGJyb2tlbiBpbgp3YXlzIHNp bWlsYXIgdG8gcGNpZV9nZXRfc3BlZWRfY2FwKCkuICBQb3NzaWJseSBzb21lIG9mIHRoZXNlIHBs YWNlcwpjb3VsZCB1c2UgcGNpZV9nZXRfc3BlZWRfY2FwKCkgZGlyZWN0bHkuCgpCam9ybgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1haWxp bmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngK