AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: Chris.Park-5C7GfCeVMHo@public.gmane.org
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: [bug report] drm/amd/display: Move link functions from dc to dc_link
Date: Thu, 30 May 2019 22:25:19 +0300	[thread overview]
Message-ID: <20190530192519.GA6076@mwanda> (raw)

Hello Chris Park,

This is a semi-automatic email about new static checker warnings.

The patch f5692f69f673: "drm/amd/display: Move link functions from dc 
to dc_link" from May 10, 2019, leads to the following Smatch 
complaint:

    drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link.c:2929 dc_link_set_preferred_link_settings()
    warn: variable dereferenced before check 'link_stream' (see line 2926)

drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link.c
  2911          for (i = 0; i < MAX_PIPES; i++) {
  2912                  pipe = &dc->current_state->res_ctx.pipe_ctx[i];
  2913                  if (pipe->stream && pipe->stream->link) {
  2914                          if (pipe->stream->link == link)
  2915                                  break;
  2916                  }
  2917          }
  2918  
  2919          /* Stream not found */
  2920          if (i == MAX_PIPES)
  2921                  return;
  2922  
  2923          link_stream = link->dc->current_state->res_ctx.pipe_ctx[i].stream;
  2924  
  2925		/* Cannot retrain link if backend is off */
  2926		if (link_stream->dpms_off)
                    ^^^^^^^^^^^^^^^^^^^^^
Can link_stream be NULL?

  2927			return;
  2928	
  2929		if (link_stream)
                    ^^^^^^^^^^^
We check here so maybe?

  2930			decide_link_settings(link_stream, &store_settings);
  2931	

regards,
dan carpenter
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

                 reply	other threads:[~2019-05-30 19:25 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190530192519.GA6076@mwanda \
    --to=dan.carpenter-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
    --cc=Chris.Park-5C7GfCeVMHo@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox