From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jason Gunthorpe <jgg@ziepe.ca>
Subject: Re: [PATCH v2 12/11] mm/hmm: Fix error flows in
 hmm_invalidate_range_start
Date: Fri, 7 Jun 2019 22:35:30 -0300
Message-ID: <20190608013530.GB7844@ziepe.ca>
References: <20190606184438.31646-1-jgg@ziepe.ca>
 <20190607160557.GA335@ziepe.ca>
 <439b5731-0b7e-b25b-ce1a-74b34e1f9bf5@nvidia.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <439b5731-0b7e-b25b-ce1a-74b34e1f9bf5@nvidia.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Ralph Campbell <rcampbell@nvidia.com>
Cc: Andrea Arcangeli <aarcange@redhat.com>, linux-rdma@vger.kernel.org, John Hubbard <jhubbard@nvidia.com>, Felix.Kuehling@amd.com, dri-devel@lists.freedesktop.org, linux-mm@kvack.org, Jerome Glisse <jglisse@redhat.com>, amd-gfx@lists.freedesktop.org
List-Id: amd-gfx.lists.freedesktop.org

T24gRnJpLCBKdW4gMDcsIDIwMTkgYXQgMDQ6NTI6NThQTSAtMDcwMCwgUmFscGggQ2FtcGJlbGwg
d3JvdGU6Cj4gPiBAQCAtMTQxLDYgKzE0MiwyMyBAQCBzdGF0aWMgdm9pZCBobW1fcmVsZWFzZShz
dHJ1Y3QgbW11X25vdGlmaWVyICptbiwgc3RydWN0IG1tX3N0cnVjdCAqbW0pCj4gPiAgIAlobW1f
cHV0KGhtbSk7Cj4gPiAgIH0KPiA+ICtzdGF0aWMgdm9pZCBub3RpZmllcnNfZGVjcmVtZW50KHN0
cnVjdCBobW0gKmhtbSkKPiA+ICt7Cj4gPiArCWxvY2tkZXBfYXNzZXJ0X2hlbGQoJmhtbS0+cmFu
Z2VzX2xvY2spOwo+ID4gKwo+ID4gKwlobW0tPm5vdGlmaWVycy0tOwo+ID4gKwlpZiAoIWhtbS0+
bm90aWZpZXJzKSB7Cj4gPiArCQlzdHJ1Y3QgaG1tX3JhbmdlICpyYW5nZTsKPiA+ICsKPiA+ICsJ
CWxpc3RfZm9yX2VhY2hfZW50cnkocmFuZ2UsICZobW0tPnJhbmdlcywgbGlzdCkgewo+ID4gKwkJ
CWlmIChyYW5nZS0+dmFsaWQpCj4gPiArCQkJCWNvbnRpbnVlOwo+ID4gKwkJCXJhbmdlLT52YWxp
ZCA9IHRydWU7Cj4gPiArCQl9Cj4gCj4gVGhpcyBqdXN0IGVmZmVjdGl2ZWx5IHNldHMgYWxsIHJh
bmdlcyB0byB2YWxpZC4KPiBJJ20gbm90IHN1cmUgdGhhdCBpcyBiZXN0LgoKVGhpcyBpcyBhIHRy
YWRlIG9mZiwgaXQgd291bGQgYmUgbXVjaCBtb3JlIGV4cGVuc2l2ZSB0byBoYXZlIGEgcHJlY2lz
ZQondmFsaWQgPSB0cnVlJyAtIGluc3RlYWQgdGhpcyBhbGdvcml0aG0gaXMgcHJlY2lzZSBhYm91
dCAndmFsaWQgPQpmYWxzZScgYW5kIGxhenkgYWJvdXQgJ3ZhbGlkID0gdHJ1ZScgd2hpY2ggaXMg
bXVjaCBsZXNzIGNvc3RseSB0bwpjYWxjdWxhdGUuCgo+IFNob3VsZG4ndCBobW1fcmFuZ2VfcmVn
aXN0ZXIoKSBzdGFydCB3aXRoIHJhbmdlLnZhbGlkID0gdHJ1ZSBhbmQKPiB0aGVuIGhtbV9pbnZh
bGlkYXRlX3JhbmdlX3N0YXJ0KCkgc2V0IGFmZmVjdGVkIHJhbmdlcyB0byBmYWxzZT8KCkl0IGtp
bmQgb2YgZG9lcywgZXhwZWN0IHdoZW4gaXQgZG9lc24ndCwgcmlnaHQ/IDopCgo+IFRoZW4gdGhp
cyBiZWNvbWVzIGp1c3Qgd2FrZV91cF9hbGwoKSBpZiAtLW5vdGlmaWVycyA9PSAwIGFuZAo+IGht
bV9yYW5nZV93YWl0X3VudGlsX3ZhbGlkKCkgc2hvdWxkIHdhaXQgZm9yIG5vdGlmaWVycyA9PSAw
LgoKQWxtb3N0Li4gYnV0IGl0IGlzIG1vcmUgdHJpY2t5IHRoYW4gdGhhdC4KClRoaXMgc2NoZW1l
IGlzIGEgY29sbGlzaW9uLXJldHJ5IGFsZ29yaXRobS4gVGhlIHBhZ2VmYXVsdCBzaWRlIHJ1bnMg
dG8KY29tcGxldGlvbiBpZiBubyBwYXJhbGxlbCBpbnZhbGlkYXRlIHN0YXJ0L2VuZCBoYXBwZW5z
LgoKSWYgYSBwYXJhbGxlbCBpbnZhbGlkYXRpb24gaGFwcGVucyB0aGVuIHRoZSBwYWdlZmF1bHQg
cmV0cmllcy4KClNlZWluZyBub3RpZmllcnMgPT0gMCBtZWFucyB0aGVyZSBpcyBhYnNvbHV0ZWx5
IG5vIGN1cnJlbnQgcGFyYWxsZWwKaW52YWxpZGF0aW9uLgoKU2VlaW5nIHJhbmdlLT52YWxpZCA9
PSB0cnVlICh1bmRlciB0aGUgZGV2aWNlIGxvY2spCm1lYW5zIHRoaXMgcmFuZ2UgZG9lc24ndCBp
bnRlcnNlY3Qgd2l0aCBhIHBhcmFsbGVsIGludmFsaWRhdGUuCgpTby4uIGhtbV9yYW5nZV93YWl0
X3VudGlsX3ZhbGlkKCkgY2hlY2tzIHRoZSBwZXItcmFuZ2UgdmFsaWQgYmVjYXVzZQppdCBkb2Vz
bid0IHdhbnQgdG8gc2xlZXAgaWYgKnRoaXMgcmFuZ2UqIGlzIG5vdCBpbnZvbHZlZCBpbiBhIHBh
cmFsbGVsCmludmFsaWRhdGlvbiAtIGJ1dCBvbmNlIGl0IGJlY29tZXMgaW52b2x2ZWQsIHRoZW4g
eWVzLCB2YWxpZCA9PSB0cnVlCmltcGxpZXMgbm90aWZpZXJzID09IDAuCgpJdCBpcyBlYXNpZXIv
c2FmZXIgdG8gdXNlIHVubG9ja2VkIHZhcmlhYmxlIHJlYWRzIGlmIHRoZXJlIGlzIG9ubHkgb25l
CnZhcmlhYmxlLCB0aHVzIHRoZSB3ZWlyZCBjb25zdHJ1Y3Rpb24uCgpJdCBpcyB1bmNsZWFyIHRv
IG1lIGlmIHRoaXMgbWljcm8gb3B0aW1pemF0aW9uIGlzIHJlYWxseQp3b3J0aHdoaWxlLiBJdCBp
cyB2ZXJ5IGV4cGVuc2l2ZSB0byBtYW5hZ2UgYWxsIHRoaXMgdHJhY2tpbmcsIGFuZCBubwpvdGhl
ciBtbXUgbm90aWZpZXIgaW1wbGVtZW50YXRpb24gcmVhbGx5IGRvZXMgc29tZXRoaW5nIGxpa2UK
dGhpcy4gRWxpbWluYXRpbmcgdGhlIHBlci1yYW5nZSB0cmFja2luZyBhbmQgdXNpbmcgdGhlIG5v
dGlmaWVyIGNvdW50CmFzIGEgZ2xvYmFsIGxvY2sgd291bGQgYmUgbXVjaCBzaW1wbGVyLi4uCgo+
IE90aGVyd2lzZSwgcmFuZ2UudmFsaWQgZG9lc24ndCByZWFsbHkgbWVhbiBpdCdzIHZhbGlkLgoK
UmlnaHQsIGl0IGRvZXNuJ3QgcmVhbGx5IG1lYW4gJ3ZhbGlkJwoKSXQgaXMgdHJhY2tpbmcgcG9z
c2libGUgY29sbGlkaW5nIGludmFsaWRhdGVzIHN1Y2ggdGhhdCB2YWxpZCA9PSB0cnVlCih1bmRl
ciB0aGUgZGV2aWNlIGxvY2spIG1lYW5zIHRoYXQgdGhlcmUgd2FzIG5vIGNvbGxpZGluZyBpbnZh
bGlkYXRlLgoKSSBzdGlsbCB0aGluayB0aGlzIGltcGxlbWVudGF0aW9uIGRvZXNuJ3QgcXVpdGUg
d29yaywgYXMgSSBkZXNjcmliZWQKaGVyZToKCmh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2xpbnV4
LW1tLzIwMTkwNTI3MTk1ODI5LkdCMTgwMTlAbWVsbGFub3guY29tLwoKQnV0IHRoZSBpZGVhIGlz
IGJhc2ljYWxseSBzb3VuZCBhbmQgbWF0Y2hlcyB3aGF0IG90aGVyIG1tdSBub3RpZmllcgp1c2Vy
cyBkbywganVzdCB1c2luZyBhIHNlcWNvdW50IGxpa2Ugc2NoZW1lLCBub3QgYSBib29sZWFuLgoK
SmFzb24KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp
LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz
Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs