From: Sam Ravnborg <sam@ravnborg.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: "David Airlie" <airlied@linux.ie>,
amd-gfx@lists.freedesktop.org,
"Maxime Ripard" <maxime.ripard@bootlin.com>,
dri-devel@lists.freedesktop.org,
"Alex Deucher" <alexander.deucher@amd.com>,
"Sean Paul" <sean@poorly.run>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH v1 01/10] drm: fix build errors with drm_print.h
Date: Tue, 11 Jun 2019 12:37:12 +0200 [thread overview]
Message-ID: <20190611103712.GA31140@ravnborg.org> (raw)
In-Reply-To: <20190611094224.GA21222@phenom.ffwll.local>
Hi Daniel.
> >
> > drm_print.h uses DRM_NAME - which is defined only in uapi/drm/drm.h.
> > The error is seen when you include drm_print.h and not much other drm
> > header files.
> > Tiday we rely on other drm header files to pull in drm.h.
> >
> > Notice - the error only manifest itself when the macros are used.
> > Including the drm_print.h will not do it.
>
> Uh, I think let's just inline DRM_NAME, that also cleans up the code. And
> drop the uapi include from drm internal headers, that feels bad. In
> general I think uapi headers should only be included by the .c files that
> actually implement ioctls and stuff like that.
>
> Can you pls do that patch for drm_print.h?
Yep - will do in a few days.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-06-11 10:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-09 22:07 [PATCH v1 0/10] drm/amd: drop use of drmP.h Sam Ravnborg
2019-06-09 22:07 ` [PATCH v1 01/10] drm: fix build errors with drm_print.h Sam Ravnborg
2019-06-11 8:39 ` Daniel Vetter
[not found] ` <20190611083911.GT21222-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2019-06-11 9:11 ` Sam Ravnborg
2019-06-11 9:42 ` Daniel Vetter
2019-06-11 10:37 ` Sam Ravnborg [this message]
2019-06-09 22:07 ` [PATCH v1 02/10] drm/amd: drop dependencies on drm_os_linux.h Sam Ravnborg
[not found] ` <20190609220757.10862-1-sam-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org>
2019-06-09 22:07 ` [PATCH v1 03/10] drm/amd: drop use of drmp.h in os_types.h Sam Ravnborg
2019-06-09 22:07 ` [PATCH v1 05/10] drm/amd: drop use of drmP.h in atom.h Sam Ravnborg
2019-06-09 22:07 ` [PATCH v1 06/10] drm/amd: drop use of drmP.h from all header files Sam Ravnborg
2019-06-09 22:07 ` [PATCH v1 07/10] drm/amd: drop use of drmP.h in powerplay/ Sam Ravnborg
2019-06-09 22:07 ` [PATCH v1 08/10] drm/amd: drop use of drmP.h in display/ Sam Ravnborg
2019-06-09 22:07 ` [PATCH v1 10/10] drm/amd: drop use of drmP.h in remaining files Sam Ravnborg
2019-06-09 22:07 ` [PATCH v1 04/10] drm/amd: drop use of drmP.h in amdgpu.h Sam Ravnborg
2019-06-09 22:07 ` [PATCH v1 09/10] drm/amd: drop use of drmP.h in amdgpu/amdgpu* Sam Ravnborg
2019-06-10 19:21 ` [PATCH v1 0/10] drm/amd: drop use of drmP.h Alex Deucher
[not found] ` <CADnq5_PtU+-FrTcOF9hkFYbqsSjAKmJkWReu-91pQH6mWoHtgw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-06-10 22:02 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190611103712.GA31140@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=maxime.ripard@bootlin.com \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox